Make tests usable with path with spaces
This is somewhat subtle:
The #RUN line in a littlecheck file will be run by a posix shell,
which means the substitutions will also be mangled by it.
Now, we *have* shell-quoted them, but unfortunately what we need is to
quote them for inside a pre-existing layer of quotes, e.g.
# RUN: fish -C 'set -g fish %fish'
here, %fish can't be replaced with `'path with spaces/fish'`, because
that ends up as
# RUN: fish -C 'set -g fish 'path with spaces/fish''
which is just broken.
So instead, we pass it as a variable to that fish:
# RUN: fish=%fish fish...
In addition, we need to not mangle the arguments in our test_driver.
For that, because we insist on posix shell, which has only one array,
and we source a file, we *need* to stop having that file use
arguments.
Which is okay - test_env.sh could previously be used to start a test,
and now it no longer can because that is test_*driver*.sh's job.
For the interactive tests, it's slightly different:
pexpect.spawn(foo) is sensitive to shell metacharacters like space.
So we shell-quote it.
But if you pass any args to pexpect.spawn, it no longer uses a shell,
and so we cannot shell-quote it.
There could be a better way to fix this?
2024-12-27 19:54:43 +00:00
|
|
|
#RUN: fish=%fish %fish %s
|
2019-06-25 20:01:53 +00:00
|
|
|
begin
|
2024-12-27 19:02:11 +00:00
|
|
|
set -l dir (dirname (status -f))
|
2019-06-25 20:01:53 +00:00
|
|
|
set -gx XDG_CONFIG_HOME $dir/broken-config/
|
|
|
|
|
set -gx HOME $dir/broken-config/
|
|
|
|
|
$fish -l -c 'echo but still going'
|
|
|
|
|
# CHECK: broken
|
|
|
|
|
# CHECK: but still going
|
|
|
|
|
# CHECKERR: fish: Unknown command: syntax-error
|
|
|
|
|
# CHECKERR: ~//fish/config.fish (line {{\d+}}):
|
|
|
|
|
# CHECKERR: syntax-error
|
2022-08-11 15:22:03 +00:00
|
|
|
# CHECKERR: ^~~~~~~~~~~^
|
2019-06-25 20:01:53 +00:00
|
|
|
# CHECKERR: from sourcing file ~//fish/config.fish
|
|
|
|
|
# CHECKERR: called during startup
|
|
|
|
|
|
|
|
|
|
$fish -c "echo normal command" -C "echo init"
|
|
|
|
|
# CHECK: broken
|
|
|
|
|
# CHECK: init
|
|
|
|
|
# CHECK: normal command
|
|
|
|
|
end
|
2023-08-02 19:24:57 +00:00
|
|
|
|
|
|
|
|
# should not crash or segfault in the presence of an invalid locale
|
|
|
|
|
LC_ALL=hello echo hello world
|
|
|
|
|
# CHECK: hello world
|
