Make tests usable with path with spaces
This is somewhat subtle:
The #RUN line in a littlecheck file will be run by a posix shell,
which means the substitutions will also be mangled by it.
Now, we *have* shell-quoted them, but unfortunately what we need is to
quote them for inside a pre-existing layer of quotes, e.g.
# RUN: fish -C 'set -g fish %fish'
here, %fish can't be replaced with `'path with spaces/fish'`, because
that ends up as
# RUN: fish -C 'set -g fish 'path with spaces/fish''
which is just broken.
So instead, we pass it as a variable to that fish:
# RUN: fish=%fish fish...
In addition, we need to not mangle the arguments in our test_driver.
For that, because we insist on posix shell, which has only one array,
and we source a file, we *need* to stop having that file use
arguments.
Which is okay - test_env.sh could previously be used to start a test,
and now it no longer can because that is test_*driver*.sh's job.
For the interactive tests, it's slightly different:
pexpect.spawn(foo) is sensitive to shell metacharacters like space.
So we shell-quote it.
But if you pass any args to pexpect.spawn, it no longer uses a shell,
and so we cannot shell-quote it.
There could be a better way to fix this?
2024-12-27 19:54:43 +00:00
|
|
|
#RUN: fish=%fish %fish %s
|
2020-02-17 10:12:01 +00:00
|
|
|
|
|
|
|
# Test that fish -n doesn't check for command existence - function autoloading throws a wrench in that.
|
|
|
|
echo "type foo" | $fish -n
|
|
|
|
echo $status
|
|
|
|
#CHECK: 0
|
|
|
|
|
2020-02-17 10:38:21 +00:00
|
|
|
# Test that it doesn't time non-execution.
|
|
|
|
echo "time echo foo" | $fish -n
|
|
|
|
echo $status
|
|
|
|
#CHECK: 0
|
|
|
|
|
2020-02-17 10:12:01 +00:00
|
|
|
# Test that it doesn't check globs.
|
|
|
|
echo "echo /asfjidhfiusnlkxcnvklxcvlkmcxlv*" | $fish -n
|
|
|
|
echo $status
|
|
|
|
#CHECK: 0
|
|
|
|
|
|
|
|
# Test that it does print syntax errors.
|
|
|
|
echo "begin; echo oops" | $fish -n
|
|
|
|
#CHECKERR: fish: Missing end to balance this begin
|
|
|
|
#CHECKERR: begin; echo oops
|
2022-08-11 15:22:03 +00:00
|
|
|
#CHECKERR: ^~~~^
|
2020-02-17 10:12:01 +00:00
|
|
|
echo $status
|
|
|
|
#CHECK: 127
|
|
|
|
|
2023-12-28 09:18:00 +00:00
|
|
|
echo "begin" > broken
|
|
|
|
$fish -n $PWD/broken
|
|
|
|
#CHECKERR: /{{.*}}broken (line 1): Missing end to balance this begin
|
|
|
|
#CHECKERR: begin
|
|
|
|
#CHECKERR: ^~~~^
|
|
|
|
#CHECKERR: warning: Error while reading file /{{.*}}broken
|
|
|
|
|
|
|
|
rm broken
|
|
|
|
|
2020-02-17 10:12:01 +00:00
|
|
|
# Littlecheck assumes a status of 127 means the shebang was invalid.
|
|
|
|
exit 0
|