Mirrors/fish-shell
2
0
Fork 0
mirror of https://github.com/fish-shell/fish-shell synced 2024-12-29 14:23:09 +00:00
Code Issues Projects Releases Packages Wiki Activity
fish-shell/tests/checks/syntax-error-location.fish

138 lines
4.7 KiB
Fish
Raw Normal View History

Extended & human-friendly keys See the changelog additions for user-visible changes. Since we enable/disable terminal protocols whenever we pass terminal ownership, tests can no longer run in parallel on the same terminal. For the same reason, readline shortcuts in the gdb REPL will not work anymore. As a remedy, use gdbserver, or lobby for CSI u support in libreadline. Add sleep to some tests, otherwise they fall (both in CI and locally). There are two weird failures on FreeBSD remaining, disable them for now https://github.com/fish-shell/fish-shell/pull/10359/checks?check_run_id=23330096362 Design and implementation borrows heavily from Kakoune. In future, we should try to implement more of the kitty progressive enhancements. Closes #10359
2024-03-30 15:10:12 +00:00
#RUN: %fish -C 'set -g fish %fish' %s | %filter-ctrlseqs
Don't set error offset for $status This would break the location of any prior errors without doing anything of value. E.g. ```fish echo foo | exec grep # this exec is not allowed! $status somethingelse # The error might be found here! ``` Would apply the offset of `$status` to the offset of `exec`, locating the error for `exec` somewhere after $status!
2021-09-28 15:15:33 +00:00
# A $status used as a command should not impact the location of other errors.
echo 'echo foo | exec grep # this exec is not allowed!
$status
# The error might be found here!' | $fish 2>| string replace -r '(.*)' '<$1>'
# CHECK: <fish: The 'exec' command can not be used in a pipeline>
# CHECK: <echo foo | exec grep # this exec is not allowed!>
Add length to the parse_util syntax errors
2022-08-12 14:53:31 +00:00
# CHECK: < ^~~~~~~~^>
Don't add expansion error offset twice Like the $status commit, this would add the offset to already existing errors, so ```fish (foo) (bar) something ``` would see the "(foo)" error, store the correct error location, then see the "(bar)" error, and *add the offset of (bar)* to the "(foo)" error location. Solve this by making a new error list and appending it to the existing ones. There's a few other ways to solve this, including: - Stopping after the first error (we only display the first anyway, I think?) - Making it so the source location has an "absolute" flag that shows the offset has already been added (but do we ever need to add two offsets?) I went with the simpler fix.
2021-09-28 15:59:59 +00:00
Emit an error if time is used past the first command in a pipeline Fixes #8841
2022-03-31 23:14:59 +00:00
echo 'true | time false' | $fish 2>| string replace -r '(.*)' '<$1>'
# CHECK: <fish: The 'time' command may only be at the beginning of a pipeline>
# CHECK: <true | time false>
Add length to the parse_util syntax errors
2022-08-12 14:53:31 +00:00
# CHECK: < ^~~~~~~~~^>
Emit an error if time is used past the first command in a pipeline Fixes #8841
2022-03-31 23:14:59 +00:00
Don't add expansion error offset twice Like the $status commit, this would add the offset to already existing errors, so ```fish (foo) (bar) something ``` would see the "(foo)" error, store the correct error location, then see the "(bar)" error, and *add the offset of (bar)* to the "(foo)" error location. Solve this by making a new error list and appending it to the existing ones. There's a few other ways to solve this, including: - Stopping after the first error (we only display the first anyway, I think?) - Making it so the source location has an "absolute" flag that shows the offset has already been added (but do we ever need to add two offsets?) I went with the simpler fix.
2021-09-28 15:59:59 +00:00
echo '
Unallowed command subst error: add missing newline and simplify Fixes ommitted newline char shown after complete -n'(foo)' Also axes the 'contains syntax errors' line before the error. Update tests before > complete -n'(foo)' complete: Condition '(foo)' contained a syntax error complete: Command substitutions not allowed⏎ after > complete -n'(foo)' complete: -n '(foo)': command substitutions not allowed here
2022-10-27 02:50:46 +00:00
FOO=BAR (true one)
Don't add expansion error offset twice Like the $status commit, this would add the offset to already existing errors, so ```fish (foo) (bar) something ``` would see the "(foo)" error, store the correct error location, then see the "(bar)" error, and *add the offset of (bar)* to the "(foo)" error location. Solve this by making a new error list and appending it to the existing ones. There's a few other ways to solve this, including: - Stopping after the first error (we only display the first anyway, I think?) - Making it so the source location has an "absolute" flag that shows the offset has already been added (but do we ever need to add two offsets?) I went with the simpler fix.
2021-09-28 15:59:59 +00:00
(true two)
# more things
' | $fish 2>| string replace -r '(.*)' '<$1>'
Add hint to error message about cmdsub in command position We might end up allowing this but let's add some help for now. See #5575
2023-11-18 11:24:58 +00:00
# CHECK: <fish: command substitutions not allowed in command position. Try var=(your-cmd) $var ...>
Unallowed command subst error: add missing newline and simplify Fixes ommitted newline char shown after complete -n'(foo)' Also axes the 'contains syntax errors' line before the error. Update tests before > complete -n'(foo)' complete: Condition '(foo)' contained a syntax error complete: Command substitutions not allowed⏎ after > complete -n'(foo)' complete: -n '(foo)': command substitutions not allowed here
2022-10-27 02:50:46 +00:00
# CHECK: <FOO=BAR (true one)>
# CHECK: < ^~~~~~~~~^>
Report sub-token error locations again This fixes a regression about where we report errors: echo error(here old: ^ fixed: ^ Commit 0c22f67bd (Remove the old parser bits, 2020-07-02) removed uses of "error_offset_within_token" so we always report errors at token start. Add it back, hopefully restoring the 3.1.2 behavior. Note that for cases like echo "$(" we report "unbalanced quotes" because we treat the $( as double quote. Giving a better error seems hard because of the ambguity - we don't know if quote is meant to be inside or outside the command substitution.
2021-12-04 13:41:54 +00:00
$fish -c 'echo "unfinished "(subshell' 2>| string replace -r '.*' '<$0>'
# CHECK: <fish: Unexpected end of string, expecting ')'>
# CHECK: <echo "unfinished "(subshell>
# CHECK: < ^>
$fish -c 'echo "unfinished "$(subshell' 2>| string replace -r '.*' '<$0>'
# CHECK: <fish: Unexpected end of string, expecting ')'>
# CHECK: <echo "unfinished "$(subshell>
# CHECK: < ^>
Autoload: Call the parser directly instead of going via "subshell" This used to call exec_subshell, which has two issues: 1. It creates a command substitution block which shows up in a stack trace 2. It does much more work than necessary This removes a useless "in command substitution" from an error message in an autoloaded file, and it speeds up autoloading a bit (not measurable in actual benchmarks, but microbenchmarks are 2x).
2022-03-23 16:33:24 +00:00
Make string syntax error location a bit more precise String tokens are subdivided by command substitutions. Some syntax errors can occur in the gap between two command substitutions. Make the caret point to the start of that gap, instead of the token start.
2022-04-03 14:29:13 +00:00
$fish -c 'echo "ok $(echo still ok)syntax error: \x"' 2>| string replace -r '.*' '<$0>'
# CHECK: <fish: Invalid token '"ok $(echo still ok)syntax error: \x"'>
# CHECK: <echo "ok $(echo still ok)syntax error: \x">
Add length to the parse_util syntax errors
2022-08-12 14:53:31 +00:00
# CHECK: < ^~~~~~~~~~~~~~~~^>
Make string syntax error location a bit more precise String tokens are subdivided by command substitutions. Some syntax errors can occur in the gap between two command substitutions. Make the caret point to the start of that gap, instead of the token start.
2022-04-03 14:29:13 +00:00
tests: Rename a function NetBSD actually has a /usr/bin/error by default, so we ended up starting that.
2022-07-24 15:51:26 +00:00
echo "function this_should_be_an_error" >$TMPDIR/this_should_be_an_error.fish
$fish -c "set -g fish_function_path $(string escape $TMPDIR); this_should_be_an_error"
# CHECKERR: ~/temp/this_should_be_an_error.fish (line 1): Missing end to balance this function definition
# CHECKERR: function this_should_be_an_error
Add acceptable errors to tests
2022-08-11 15:22:03 +00:00
# CHECKERR: ^~~~~~~^
tests: Rename a function NetBSD actually has a /usr/bin/error by default, so we ended up starting that.
2022-07-24 15:51:26 +00:00
# CHECKERR: from sourcing file ~/temp/this_should_be_an_error.fish
# CHECKERR: source: Error while reading file '{{.*}}/this_should_be_an_error.fish'
# CHECKERR: fish: Unknown command: this_should_be_an_error
Make string syntax error location a bit more precise String tokens are subdivided by command substitutions. Some syntax errors can occur in the gap between two command substitutions. Make the caret point to the start of that gap, instead of the token start.
2022-04-03 14:29:13 +00:00
# CHECKERR: fish:
tests: Rename a function NetBSD actually has a /usr/bin/error by default, so we ended up starting that.
2022-07-24 15:51:26 +00:00
# CHECKERR: set -g fish_function_path {{.*}}; this_should_be_an_error
Add acceptable errors to tests
2022-08-11 15:22:03 +00:00
# CHECKERR: ^~~~~~~~~~~~~~~~~~~~~~^
Fix error for {$} Fixes #9337
2022-11-15 18:02:30 +00:00
$fish -c 'echo {$}'
fixup!
2022-11-15 18:03:06 +00:00
# CHECKERR: fish: Expected a variable name after this $.
Fix error for {$} Fixes #9337
2022-11-15 18:02:30 +00:00
# CHECKERR: echo {$}
# CHECKERR: ^
$fish -c 'echo {$,}'
# CHECKERR: fish: Expected a variable name after this $.
# CHECKERR: echo {$,}
# CHECKERR: ^
Revert "Remove print_hints from builtin_missing_argument and builtin_unknown_option" Unfortunately print_hints was true *by default* - so for all builtins that didn't pass it it would now be false instead. This resulted in the trailer missing, which includes the line number and context. So if you ran a script that includes `bind -M` the error message would now just be "bind: -M: option requires an argument", with no indication as to where. This reverts commit 8a50d47a469b547581c8fafede50d740230d42f2.
2022-12-22 16:23:42 +00:00
echo "bind -M" | $fish
# CHECKERR: bind: -M: option requires an argument
# CHECKERR: Standard input (line 1):
# CHECKERR: bind -M
# CHECKERR: ^
Fix tests I always forget that littlecheck escapes these
2022-12-22 16:34:10 +00:00
# CHECKERR: (Type 'help bind' for related documentation)
Revert "Remove print_hints from builtin_missing_argument and builtin_unknown_option" Unfortunately print_hints was true *by default* - so for all builtins that didn't pass it it would now be false instead. This resulted in the trailer missing, which includes the line number and context. So if you ran a script that includes `bind -M` the error message would now just be "bind: -M: option requires an argument", with no indication as to where. This reverts commit 8a50d47a469b547581c8fafede50d740230d42f2.
2022-12-22 16:23:42 +00:00
ast: Require `--help` to parse more keywords as decorated statement (#10000) This makes it so ```fish if -e foo # do something end ``` complains about `-e` not being a command instead of `end` being used outside of an if-block. That means both that `-e` could now be used as a command name (it already can outside of `if`!) *and* that we get a better error! The only way to get `if` to be a decorated statement now is to use `if -h` or `if --help` specifically (with a literal option). The same goes for switch, while and begin. It would be possible, alternatively, to disallow `if -e` and point towards using `test` instead, but the "unknown command" message should already point towards using `test` more than pointing at the "end" (that might be quite far away).
2023-09-19 15:34:13 +00:00
$fish -c 'if -e; end'
# CHECKERR: fish: Unknown command: -e
# CHECKERR: fish:
# CHECKERR: if -e; end
# CHECKERR: ^^
$fish -c 'begin --notanoption; end'
# CHECKERR: fish: Unknown command: --notanoption
# CHECKERR: fish:
# CHECKERR: begin --notanoption; end
# CHECKERR: ^~~~~~~~~~~~^
$fish -c 'begin --help'
# CHECKERR: fish: begin: missing man page
# CHECKERR: Documentation may not be installed.
# CHECKERR: `help begin` will show an online version
expand_cmdsubst: Make more errors known These printed "Unknown error while evaluating command substitution". Now they print something like ``` fish: for: status: cannot overwrite read-only variable for status in foo; end ^~~~~^ in command substitution fish: Invalid arguments echo (for status in foo; end) ^~~~~~~~~~~~~~~~~~~~~~~^ ``` for `echo (for status in foo; end)` This is, of course, still not *great*. Mostly the `fish: Invalid arguments` is basically entirely redundant. An alternative is to simply skip the error message, but that requires some more scaffolding (describe_with_prefix adds some error messages on its own, so we can't simply say "don't add the prefix if we don't have a message") (cherry picked from commit 1b5eec2af6e71998c2af31830be5236aeb15ffd6)
2023-10-13 14:27:35 +00:00
$fish -c 'echo (for status in foo; end)'
# CHECKERR: fish: for: status: cannot overwrite read-only variable
# CHECKERR: for status in foo; end
# CHECKERR: ^~~~~^
# CHECKERR: in command substitution
# CHECKERR: fish: Invalid arguments
# CHECKERR: echo (for status in foo; end)
# CHECKERR: ^~~~~~~~~~~~~~~~~~~~~~~^
$fish -c 'echo (echo <&foo)'
# CHECKERR: fish: Requested redirection to 'foo', which is not a valid file descriptor
# CHECKERR: echo <&foo
# CHECKERR: ^~~~^
# CHECKERR: in command substitution
# CHECKERR: fish: Invalid arguments
# CHECKERR: echo (echo <&foo)
# CHECKERR: ^~~~~~~~~~~^
$fish -c 'echo (time echo foo &)'
# CHECKERR: fish: 'time' is not supported for background jobs. Consider using 'command time'.
# CHECKERR: time echo foo &
# CHECKERR: ^~~~~~~~~~~~~~^
# CHECKERR: in command substitution
# CHECKERR: fish: Invalid arguments
# CHECKERR: echo (time echo foo &)
# CHECKERR: ^~~~~~~~~~~~~~~~^
$fish -c 'echo (set -l foo 1 2 3; for $foo in foo; end)'
# CHECKERR: fish: Unable to expand variable name ''
# CHECKERR: set -l foo 1 2 3; for $foo in foo; end
# CHECKERR: ^~~^
# CHECKERR: in command substitution
# CHECKERR: fish: Expansion error
# CHECKERR: echo (set -l foo 1 2 3; for $foo in foo; end)
# CHECKERR: ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
$fish -c 'echo (echo *nosuchname*)'
# CHECKERR: fish: No matches for wildcard '*nosuchname*'. See `help wildcards-globbing`.
# CHECKERR: echo *nosuchname*
# CHECKERR: ^~~~~~~~~~~^
# CHECKERR: in command substitution
# CHECKERR: fish: Unmatched wildcard
# CHECKERR: echo (echo *nosuchname*)
# CHECKERR: ^~~~~~~~~~~~~~~~~~^
Reference in a new issue Copy permalink