Mirrors/dioxus
2
0
Fork 0
mirror of https://github.com/DioxusLabs/dioxus synced 2024-11-10 06:34:20 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix memorization for the fragment component (#2360)

Browse source
This commit is contained in:
Evan Almloff 2024-04-25 23:48:06 -05:00 committed by GitHub
parent 47c87568e1
commit fc2b441ee1
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 10 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
packages/core/src/error_boundary.rs
View file

@ -344,7 +344,8 @@ impl Properties for ErrorBoundaryProps {
fn builder() -> Self::Builder {
ErrorBoundaryProps::builder()
}
fn memoize(&mut self, _: &Self) -> bool {
fn memoize(&mut self, other: &Self) -> bool {
*self = other.clone();
false
}
}

11
packages/core/src/fragment.rs
View file

@ -27,7 +27,7 @@ use crate::innerlude::*;
/// You want to use this free-function when your fragment needs a key and simply returning multiple nodes from rsx! won't cut it.
#[allow(non_upper_case_globals, non_snake_case)]
pub fn Fragment(cx: FragmentProps) -> Element {
cx.0.clone()
cx.0
}
#[derive(Clone, PartialEq)]
@ -90,7 +90,12 @@ impl Properties for FragmentProps {
fn builder() -> Self::Builder {
FragmentBuilder(None)
}
fn memoize(&mut self, _other: &Self) -> bool {
false
fn memoize(&mut self, new: &Self) -> bool {
let equal = self == new;
if !equal {
let new_clone = new.clone();
self.0 = new_clone.0;
}
equal
}
}