Mirrors/dioxus
2
0
Fork 0
mirror of https://github.com/DioxusLabs/dioxus synced 2024-09-22 15:21:58 +00:00
Code Issues Projects Releases Packages Wiki Activity

Don't expect all components to have a scope in ScopeArena.ensure_drop_safety

Browse source 
Not all components will be mounted when using a Router, so we cannot assume
all components have a scope.
This commit is contained in:
Dave Rolsky 2022-01-14 15:40:01 -06:00
parent 81c094ed29
commit 9b282d877b
1 changed files with 3 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
packages/core/src/scopes.rs
View file

@ -198,12 +198,9 @@ impl ScopeArena {
// run the hooks (which hold an &mut Reference)
// recursively call ensure_drop_safety on all children
items.borrowed_props.drain(..).for_each(|comp| {
let scope_id = comp
.scope
.get()
.expect("VComponents should be associated with a valid Scope");
self.ensure_drop_safety(scope_id);
if let Some(scope_id) = comp.scope.get() {
self.ensure_drop_safety(scope_id);
}
drop(comp.props.take());
});