Mirrors/dioxus
2
0
Fork 0
mirror of https://github.com/DioxusLabs/dioxus synced 2024-09-22 23:32:01 +00:00
Code Issues Projects Releases Packages Wiki Activity

feat: handle bool attrs properly

Browse source
This commit is contained in:
Jonathan Kelley 2022-01-08 02:09:02 -05:00
parent 14da441c7b
commit 8d685f40b7
2 changed files with 14 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
packages/desktop/src/index.js
View file

@ -369,7 +369,11 @@ class Interpreter {
node.innerHTML = value;
break;
default:
node.setAttribute(name, value);
if (value == "false") {
node.removeAttribute(name);
} else {
node.setAttribute(name, value);
}
}
}
}

10
packages/web/src/dom.rs
View file

@ -347,7 +347,15 @@ impl WebsysDom {
fallback();
}
}
_ => fallback(),
_ => {
if value == "false" {
if let Some(el) = node.dyn_ref::<Element>() {
let _ = el.remove_attribute(name);
}
} else {
fallback();
}
}
}
}
}