Mirrors/dioxus
2
0
Fork 0
mirror of https://github.com/DioxusLabs/dioxus synced 2025-02-17 06:08:26 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix recycling on component callbacks (#2247)

Browse source
This commit is contained in:
Jonathan Kelley 2024-04-04 16:48:06 -07:00 • committed by GitHub
parent 0a3291084f
commit 702509cb7e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 10 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/core/src/nodes.rs
View file

@ -157,7 +157,7 @@ impl Drop for VNode {
for attrs in self.vnode.dynamic_attrs.iter() { for attrs in self.vnode.dynamic_attrs.iter() {
for attr in attrs.iter() { for attr in attrs.iter() {
if let AttributeValue::Listener(listener) = &attr.value { if let AttributeValue::Listener(listener) = &attr.value {
listener.callback.manually_drop(); listener.callback.recycle();
} }
} }
} }

13
packages/generational-box/src/lib.rs
View file

@ -198,12 +198,17 @@ impl<T, S: Storage<T>> GenerationalBox<T, S> {
} }
} }
/// Drop the value out of the generational box and invalidate the generational box. This will return the value if the value was taken. /// Recycle the generationalbox, dropping the value.
pub fn recycle(&self) {
_ = Storage::take(&self.raw.0.data);
<S as AnyStorage>::recycle(&self.raw);
}
/// Drop the value out of the generational box and invalidate the generational box.
/// This will return the value if the value was taken.
pub fn manually_drop(&self) -> Option<T> { pub fn manually_drop(&self) -> Option<T> {
if self.validate() { if self.validate() {
let o = Storage::take(&self.raw.0.data); Storage::take(&self.raw.0.data)
<S as AnyStorage>::recycle(&self.raw);
o
} else { } else {
None None
} }