mirror of
https://github.com/DioxusLabs/dioxus
synced 2024-11-10 06:34:20 +00:00
Fix recycling on component callbacks (#2247)
This commit is contained in:
parent
0a3291084f
commit
702509cb7e
2 changed files with 10 additions and 5 deletions
|
@ -157,7 +157,7 @@ impl Drop for VNode {
|
|||
for attrs in self.vnode.dynamic_attrs.iter() {
|
||||
for attr in attrs.iter() {
|
||||
if let AttributeValue::Listener(listener) = &attr.value {
|
||||
listener.callback.manually_drop();
|
||||
listener.callback.recycle();
|
||||
}
|
||||
}
|
||||
}
|
||||
|
|
|
@ -198,12 +198,17 @@ impl<T, S: Storage<T>> GenerationalBox<T, S> {
|
|||
}
|
||||
}
|
||||
|
||||
/// Drop the value out of the generational box and invalidate the generational box. This will return the value if the value was taken.
|
||||
/// Recycle the generationalbox, dropping the value.
|
||||
pub fn recycle(&self) {
|
||||
_ = Storage::take(&self.raw.0.data);
|
||||
<S as AnyStorage>::recycle(&self.raw);
|
||||
}
|
||||
|
||||
/// Drop the value out of the generational box and invalidate the generational box.
|
||||
/// This will return the value if the value was taken.
|
||||
pub fn manually_drop(&self) -> Option<T> {
|
||||
if self.validate() {
|
||||
let o = Storage::take(&self.raw.0.data);
|
||||
<S as AnyStorage>::recycle(&self.raw);
|
||||
o
|
||||
Storage::take(&self.raw.0.data)
|
||||
} else {
|
||||
None
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue