From 4b800af30019c39e2d0423d6c0f755ebaa1bb47c Mon Sep 17 00:00:00 2001 From: Miles Murgaw Date: Tue, 4 Jul 2023 16:56:38 -0400 Subject: [PATCH 1/4] fix: clippy --- playwrite-tests/fullstack/src/main.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/playwrite-tests/fullstack/src/main.rs b/playwrite-tests/fullstack/src/main.rs index c44a0c0ae..98caadbb6 100644 --- a/playwrite-tests/fullstack/src/main.rs +++ b/playwrite-tests/fullstack/src/main.rs @@ -53,6 +53,7 @@ struct AppProps { count: i32, } +#[allow(unused)] fn app(cx: Scope) -> Element { let mut count = use_state(cx, || cx.props.count); let text = use_state(cx, || "...".to_string()); From c14b942fdad8fed3ed87a1df42bc7af160103a2c Mon Sep 17 00:00:00 2001 From: Miles Murgaw Date: Wed, 5 Jul 2023 12:50:01 -0400 Subject: [PATCH 2/4] fix: doc typos - trigger CI --- .../guide/src/en/contributing/project_structure.md | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/docs/guide/src/en/contributing/project_structure.md b/docs/guide/src/en/contributing/project_structure.md index 0f4fa64c8..38b6cbde4 100644 --- a/docs/guide/src/en/contributing/project_structure.md +++ b/docs/guide/src/en/contributing/project_structure.md @@ -4,15 +4,15 @@ There are many packages in the Dioxus organization. This document will help you ## Renderers -- [Desktop](https://github.com/DioxusLabs/dioxus/tree/master/packages/desktop): A Render that Runs Dioxus applications natively, but renders them with the system webview -- [Mobile](https://github.com/DioxusLabs/dioxus/tree/master/packages/mobile): A Render that Runs Dioxus applications natively, but renders them with the system webview. This is currently a copy of the desktop render -- [Web](https://github.com/DioxusLabs/dioxus/tree/master/packages/Web): Renders Dioxus applications in the browser by compiling to WASM and manipulating the DOM -- [Liveview](https://github.com/DioxusLabs/dioxus/tree/master/packages/liveview): A Render that Runs on the server, and renders using a websocket proxy in the browser -- [Rink](https://github.com/DioxusLabs/dioxus/tree/master/packages/rink): A Renderer that renders a HTML-like tree into a terminal -- [TUI](https://github.com/DioxusLabs/dioxus/tree/master/packages/dioxus-tui): A Renderer that uses Rink to render a Dioxus application in a terminal +- [Desktop](https://github.com/DioxusLabs/dioxus/tree/master/packages/desktop): A renderer that runs Dioxus applications natively, but renders them with the system webview. +- [Mobile](https://github.com/DioxusLabs/dioxus/tree/master/packages/mobile): A renderer that runs Dioxus applications natively, but renders them with the system webview. This is currently a copy of the desktop renderer. +- [Web](https://github.com/DioxusLabs/dioxus/tree/master/packages/Web): Renders Dioxus applications in the browser by compiling to WASM and manipulating the DOM. +- [Liveview](https://github.com/DioxusLabs/dioxus/tree/master/packages/liveview): A renderer that runs on the server, and renders using a websocket proxy in the browser. +- [Rink](https://github.com/DioxusLabs/dioxus/tree/master/packages/rink): A renderer that renders a HTML-like tree into a terminal. +- [TUI](https://github.com/DioxusLabs/dioxus/tree/master/packages/dioxus-tui): A renderer that uses Rink to render a Dioxus application in a terminal. - [Blitz-Core](https://github.com/DioxusLabs/blitz/tree/master/blitz-core): An experimental native renderer that renders a HTML-like tree using WGPU. - [Blitz](https://github.com/DioxusLabs/blitz): An experimental native renderer that uses Blitz-Core to render a Dioxus application using WGPU. -- [SSR](https://github.com/DioxusLabs/dioxus/tree/master/packages/ssr): A Render that Runs Dioxus applications on the server, and renders them to HTML +- [SSR](https://github.com/DioxusLabs/dioxus/tree/master/packages/ssr): A renderer that runs Dioxus applications on the server, and renders them to HTML. ## State Management/Hooks From a5aa7db3da425bd79afdc64eda53cf029c6430dd Mon Sep 17 00:00:00 2001 From: Miles Murgaw Date: Wed, 5 Jul 2023 12:52:54 -0400 Subject: [PATCH 3/4] fix: trigger it now? --- packages/desktop/headless_tests/events.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/desktop/headless_tests/events.rs b/packages/desktop/headless_tests/events.rs index 0281969ec..f0f31c4ea 100644 --- a/packages/desktop/headless_tests/events.rs +++ b/packages/desktop/headless_tests/events.rs @@ -20,6 +20,7 @@ pub(crate) fn check_app_exits(app: Component) { Config::new().with_window(WindowBuilder::new().with_visible(false)), ); + // Stop deadman's switch should_panic.store(false, std::sync::atomic::Ordering::SeqCst); } From df41c81d14e412067e3c19095766711e8b493f85 Mon Sep 17 00:00:00 2001 From: Miles Murgaw Date: Wed, 5 Jul 2023 12:55:18 -0400 Subject: [PATCH 4/4] fix: add playwright tests to CI workflow --- .github/workflows/main.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 1a4b156cd..b44aab843 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -13,6 +13,7 @@ on: - lib.rs - Cargo.toml - Makefile.toml + - playwrite-tests/** pull_request: types: [opened, synchronize, reopened, ready_for_review]