Mirrors/dioxus
2
0
Fork 0
mirror of https://github.com/DioxusLabs/dioxus synced 2025-02-17 06:08:26 +00:00
Code Issues Projects Releases Packages Wiki Activity

remove node refs before dropping nodes

Browse source
This commit is contained in:
Evan Almloff 2023-08-31 15:38:31 -05:00
parent c5ebdc9635
commit 036e1ff0f5
1 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
packages/core/src/arena.rs
View file

@ -118,6 +118,10 @@ impl VirtualDom {
} }
fn drop_scope_inner(&mut self, node: &VNode) { fn drop_scope_inner(&mut self, node: &VNode) {
if let Some(id) = node.parent.get() {
self.element_refs.remove(id.0);
}
node.dynamic_nodes.iter().for_each(|node| match node { node.dynamic_nodes.iter().for_each(|node| match node {
DynamicNode::Component(c) => { DynamicNode::Component(c) => {
if let Some(f) = c.scope.get() { if let Some(f) = c.scope.get() {
@ -128,7 +132,11 @@ impl VirtualDom {
DynamicNode::Fragment(nodes) => { DynamicNode::Fragment(nodes) => {
nodes.iter().for_each(|node| self.drop_scope_inner(node)) nodes.iter().for_each(|node| self.drop_scope_inner(node))
} }
DynamicNode::Placeholder(_) => {} DynamicNode::Placeholder(placeholder) => {
if let Some(id) = placeholder.parent.get() {
self.element_refs.remove(id.0);
}
}
DynamicNode::Text(_) => {} DynamicNode::Text(_) => {}
}); });
} }