mirror of
https://github.com/matrix-org/dendrite
synced 2024-12-14 15:22:50 +00:00
3db9e98456
This is apparently some incorrect behaviour that we built as a result of a spec bug (matrix-org/matrix-spec#1314) where we were applying a filter to the `"state"` section of the `/sync` response incorrectly. The client then has no way to know that the state was limited. This PR removes the state limiting, which probably also helps #2842.
115 lines
3.9 KiB
Go
115 lines
3.9 KiB
Go
// Copyright 2017 Vector Creations Ltd
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package sync
|
|
|
|
import (
|
|
"database/sql"
|
|
"encoding/json"
|
|
"fmt"
|
|
"math"
|
|
"net/http"
|
|
"strconv"
|
|
"time"
|
|
|
|
"github.com/matrix-org/gomatrixserverlib"
|
|
"github.com/matrix-org/util"
|
|
"github.com/sirupsen/logrus"
|
|
|
|
"github.com/matrix-org/dendrite/syncapi/storage"
|
|
"github.com/matrix-org/dendrite/syncapi/types"
|
|
userapi "github.com/matrix-org/dendrite/userapi/api"
|
|
)
|
|
|
|
const defaultSyncTimeout = time.Duration(0)
|
|
const DefaultTimelineLimit = 20
|
|
|
|
func newSyncRequest(req *http.Request, device userapi.Device, syncDB storage.Database) (*types.SyncRequest, error) {
|
|
timeout := getTimeout(req.URL.Query().Get("timeout"))
|
|
fullState := req.URL.Query().Get("full_state")
|
|
wantFullState := fullState != "" && fullState != "false"
|
|
since, sinceStr := types.StreamingToken{}, req.URL.Query().Get("since")
|
|
if sinceStr != "" {
|
|
var err error
|
|
since, err = types.NewStreamTokenFromString(sinceStr)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
}
|
|
|
|
// Create a default filter and apply a stored filter on top of it (if specified)
|
|
filter := gomatrixserverlib.DefaultFilter()
|
|
filterQuery := req.URL.Query().Get("filter")
|
|
if filterQuery != "" {
|
|
if filterQuery[0] == '{' {
|
|
// Parse the filter from the query string
|
|
if err := json.Unmarshal([]byte(filterQuery), &filter); err != nil {
|
|
return nil, fmt.Errorf("json.Unmarshal: %w", err)
|
|
}
|
|
} else {
|
|
// Try to load the filter from the database
|
|
localpart, _, err := gomatrixserverlib.SplitID('@', device.UserID)
|
|
if err != nil {
|
|
util.GetLogger(req.Context()).WithError(err).Error("gomatrixserverlib.SplitID failed")
|
|
return nil, fmt.Errorf("gomatrixserverlib.SplitID: %w", err)
|
|
}
|
|
if err := syncDB.GetFilter(req.Context(), &filter, localpart, filterQuery); err != nil && err != sql.ErrNoRows {
|
|
util.GetLogger(req.Context()).WithError(err).Error("syncDB.GetFilter failed")
|
|
return nil, fmt.Errorf("syncDB.GetFilter: %w", err)
|
|
}
|
|
}
|
|
}
|
|
|
|
// A loaded filter might have overwritten these values,
|
|
// so set them after loading the filter.
|
|
if since.IsEmpty() {
|
|
// Send as much account data down for complete syncs as possible
|
|
// by default, otherwise clients do weird things while waiting
|
|
// for the rest of the data to trickle down.
|
|
filter.AccountData.Limit = math.MaxInt32
|
|
filter.Room.AccountData.Limit = math.MaxInt32
|
|
}
|
|
|
|
logger := util.GetLogger(req.Context()).WithFields(logrus.Fields{
|
|
"user_id": device.UserID,
|
|
"device_id": device.ID,
|
|
"since": since,
|
|
"timeout": timeout,
|
|
"limit": filter.Room.Timeline.Limit,
|
|
})
|
|
|
|
return &types.SyncRequest{
|
|
Context: req.Context(), //
|
|
Log: logger, //
|
|
Device: &device, //
|
|
Response: types.NewResponse(), // Populated by all streams
|
|
Filter: filter, //
|
|
Since: since, //
|
|
Timeout: timeout, //
|
|
Rooms: make(map[string]string), // Populated by the PDU stream
|
|
WantFullState: wantFullState, //
|
|
MembershipChanges: make(map[string]struct{}), // Populated by the PDU stream
|
|
}, nil
|
|
}
|
|
|
|
func getTimeout(timeoutMS string) time.Duration {
|
|
if timeoutMS == "" {
|
|
return defaultSyncTimeout
|
|
}
|
|
i, err := strconv.Atoi(timeoutMS)
|
|
if err != nil {
|
|
return defaultSyncTimeout
|
|
}
|
|
return time.Duration(i) * time.Millisecond
|
|
}
|