2021-01-08 16:59:06 +00:00
|
|
|
package streams
|
|
|
|
|
|
|
|
import (
|
|
|
|
"context"
|
2022-04-07 14:08:19 +00:00
|
|
|
"database/sql"
|
2022-04-20 15:06:46 +00:00
|
|
|
"fmt"
|
2021-01-29 16:32:54 +00:00
|
|
|
"time"
|
2021-01-08 16:59:06 +00:00
|
|
|
|
2022-04-19 08:46:45 +00:00
|
|
|
"github.com/matrix-org/dendrite/internal/caching"
|
2022-04-26 08:53:17 +00:00
|
|
|
roomserverAPI "github.com/matrix-org/dendrite/roomserver/api"
|
2022-08-11 16:23:35 +00:00
|
|
|
"github.com/matrix-org/dendrite/syncapi/internal"
|
|
|
|
"github.com/matrix-org/dendrite/syncapi/storage"
|
2021-01-08 16:59:06 +00:00
|
|
|
"github.com/matrix-org/dendrite/syncapi/types"
|
|
|
|
userapi "github.com/matrix-org/dendrite/userapi/api"
|
2022-08-05 12:27:27 +00:00
|
|
|
|
2023-01-12 09:06:03 +00:00
|
|
|
"github.com/matrix-org/dendrite/syncapi/notifier"
|
2021-01-08 16:59:06 +00:00
|
|
|
"github.com/matrix-org/gomatrixserverlib"
|
2022-08-11 16:23:35 +00:00
|
|
|
"github.com/sirupsen/logrus"
|
2021-01-08 16:59:06 +00:00
|
|
|
)
|
|
|
|
|
2021-01-29 16:32:54 +00:00
|
|
|
// The max number of per-room goroutines to have running.
|
|
|
|
// Too high and this will consume lots of CPU, too low and complete
|
|
|
|
// sync responses will take longer to process.
|
|
|
|
const PDU_STREAM_WORKERS = 256
|
|
|
|
|
|
|
|
// The maximum number of tasks that can be queued in total before
|
|
|
|
// backpressure will build up and the rests will start to block.
|
|
|
|
const PDU_STREAM_QUEUESIZE = PDU_STREAM_WORKERS * 8
|
|
|
|
|
2021-01-08 16:59:06 +00:00
|
|
|
type PDUStreamProvider struct {
|
2022-09-30 11:48:10 +00:00
|
|
|
DefaultStreamProvider
|
2021-01-29 16:32:54 +00:00
|
|
|
|
2022-04-19 08:46:45 +00:00
|
|
|
// userID+deviceID -> lazy loading cache
|
2022-05-06 13:33:34 +00:00
|
|
|
lazyLoadCache caching.LazyLoadCache
|
2022-05-05 08:56:03 +00:00
|
|
|
rsAPI roomserverAPI.SyncRoomserverAPI
|
2022-08-05 12:27:27 +00:00
|
|
|
notifier *notifier.Notifier
|
2021-01-29 16:32:54 +00:00
|
|
|
}
|
|
|
|
|
2022-09-30 11:48:10 +00:00
|
|
|
func (p *PDUStreamProvider) Setup(
|
|
|
|
ctx context.Context, snapshot storage.DatabaseTransaction,
|
|
|
|
) {
|
|
|
|
p.DefaultStreamProvider.Setup(ctx, snapshot)
|
2021-01-08 16:59:06 +00:00
|
|
|
|
|
|
|
p.latestMutex.Lock()
|
|
|
|
defer p.latestMutex.Unlock()
|
|
|
|
|
2022-09-30 11:48:10 +00:00
|
|
|
id, err := snapshot.MaxStreamPositionForPDUs(ctx)
|
2021-01-08 16:59:06 +00:00
|
|
|
if err != nil {
|
|
|
|
panic(err)
|
|
|
|
}
|
|
|
|
p.latest = id
|
|
|
|
}
|
|
|
|
|
|
|
|
func (p *PDUStreamProvider) CompleteSync(
|
|
|
|
ctx context.Context,
|
2022-09-30 11:48:10 +00:00
|
|
|
snapshot storage.DatabaseTransaction,
|
2021-01-08 16:59:06 +00:00
|
|
|
req *types.SyncRequest,
|
|
|
|
) types.StreamPosition {
|
|
|
|
from := types.StreamPosition(0)
|
|
|
|
to := p.LatestPosition(ctx)
|
|
|
|
|
|
|
|
// Get the current sync position which we will base the sync response on.
|
|
|
|
// For complete syncs, we want to start at the most recent events and work
|
|
|
|
// backwards, so that we show the most recent events in the room.
|
|
|
|
r := types.Range{
|
|
|
|
From: to,
|
|
|
|
To: 0,
|
|
|
|
Backwards: true,
|
|
|
|
}
|
|
|
|
|
|
|
|
// Extract room state and recent events for all rooms the user is joined to.
|
2022-09-30 11:48:10 +00:00
|
|
|
joinedRoomIDs, err := snapshot.RoomIDsWithMembership(ctx, req.Device.UserID, gomatrixserverlib.Join)
|
2021-01-08 16:59:06 +00:00
|
|
|
if err != nil {
|
|
|
|
req.Log.WithError(err).Error("p.DB.RoomIDsWithMembership failed")
|
|
|
|
return from
|
|
|
|
}
|
|
|
|
|
2021-01-19 18:00:42 +00:00
|
|
|
stateFilter := req.Filter.Room.State
|
|
|
|
eventFilter := req.Filter.Room.Timeline
|
2021-01-08 16:59:06 +00:00
|
|
|
|
2022-09-30 11:48:10 +00:00
|
|
|
if err = p.addIgnoredUsersToFilter(ctx, snapshot, req, &eventFilter); err != nil {
|
2022-04-07 14:08:19 +00:00
|
|
|
req.Log.WithError(err).Error("unable to update event filter with ignored users")
|
|
|
|
}
|
|
|
|
|
2023-02-07 13:31:23 +00:00
|
|
|
recentEvents, err := snapshot.RecentEvents(ctx, joinedRoomIDs, r, &eventFilter, true, true)
|
|
|
|
if err != nil {
|
|
|
|
return from
|
|
|
|
}
|
|
|
|
// Build up a /sync response. Add joined rooms.
|
2022-08-05 12:27:27 +00:00
|
|
|
for _, roomID := range joinedRoomIDs {
|
2023-02-07 13:31:23 +00:00
|
|
|
events := recentEvents[roomID]
|
|
|
|
// Invalidate the lazyLoadCache, otherwise we end up with missing displaynames/avatars
|
|
|
|
// TODO: This might be inefficient, when joined to many and/or large rooms.
|
2022-08-05 12:27:27 +00:00
|
|
|
joinedUsers := p.notifier.JoinedUsers(roomID)
|
|
|
|
for _, sharedUser := range joinedUsers {
|
|
|
|
p.lazyLoadCache.InvalidateLazyLoadedUser(req.Device, roomID, sharedUser)
|
|
|
|
}
|
|
|
|
|
2023-02-07 13:31:23 +00:00
|
|
|
// get the join response for each room
|
2022-09-30 11:48:10 +00:00
|
|
|
jr, jerr := p.getJoinResponseForCompleteSync(
|
2023-02-07 13:31:23 +00:00
|
|
|
ctx, snapshot, roomID, &stateFilter, req.WantFullState, req.Device, false,
|
|
|
|
events.Events, events.Limited,
|
2022-09-30 11:48:10 +00:00
|
|
|
)
|
|
|
|
if jerr != nil {
|
|
|
|
req.Log.WithError(jerr).Error("p.getJoinResponseForCompleteSync failed")
|
2022-10-28 06:17:40 +00:00
|
|
|
if ctxErr := req.Context.Err(); ctxErr != nil || jerr == sql.ErrTxDone {
|
2022-09-30 16:07:37 +00:00
|
|
|
return from
|
|
|
|
}
|
2022-10-03 10:38:20 +00:00
|
|
|
continue
|
2022-09-30 11:48:10 +00:00
|
|
|
}
|
2022-10-05 12:47:13 +00:00
|
|
|
req.Response.Rooms.Join[roomID] = jr
|
2022-09-30 11:48:10 +00:00
|
|
|
req.Rooms[roomID] = gomatrixserverlib.Join
|
2021-01-08 16:59:06 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
// Add peeked rooms.
|
2022-09-30 11:48:10 +00:00
|
|
|
peeks, err := snapshot.PeeksInRange(ctx, req.Device.UserID, req.Device.ID, r)
|
2021-01-08 16:59:06 +00:00
|
|
|
if err != nil {
|
|
|
|
req.Log.WithError(err).Error("p.DB.PeeksInRange failed")
|
|
|
|
return from
|
|
|
|
}
|
2023-02-07 13:31:23 +00:00
|
|
|
if len(peeks) > 0 {
|
|
|
|
peekRooms := make([]string, 0, len(peeks))
|
|
|
|
for _, peek := range peeks {
|
|
|
|
if !peek.Deleted {
|
|
|
|
peekRooms = append(peekRooms, peek.RoomID)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
recentEvents, err = snapshot.RecentEvents(ctx, peekRooms, r, &eventFilter, true, true)
|
|
|
|
if err != nil {
|
|
|
|
return from
|
|
|
|
}
|
|
|
|
|
|
|
|
for _, roomID := range peekRooms {
|
2021-01-08 16:59:06 +00:00
|
|
|
var jr *types.JoinResponse
|
2023-02-07 13:31:23 +00:00
|
|
|
events := recentEvents[roomID]
|
2021-01-08 16:59:06 +00:00
|
|
|
jr, err = p.getJoinResponseForCompleteSync(
|
2023-02-07 13:31:23 +00:00
|
|
|
ctx, snapshot, roomID, &stateFilter, req.WantFullState, req.Device, true,
|
|
|
|
events.Events, events.Limited,
|
2021-01-08 16:59:06 +00:00
|
|
|
)
|
|
|
|
if err != nil {
|
|
|
|
req.Log.WithError(err).Error("p.getJoinResponseForCompleteSync failed")
|
2022-10-03 10:38:20 +00:00
|
|
|
if err == context.DeadlineExceeded || err == context.Canceled || err == sql.ErrTxDone {
|
2022-09-30 16:07:37 +00:00
|
|
|
return from
|
|
|
|
}
|
2022-10-03 10:38:20 +00:00
|
|
|
continue
|
2021-01-08 16:59:06 +00:00
|
|
|
}
|
2023-02-07 13:31:23 +00:00
|
|
|
req.Response.Rooms.Peek[roomID] = jr
|
2021-01-08 16:59:06 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return to
|
|
|
|
}
|
|
|
|
|
|
|
|
func (p *PDUStreamProvider) IncrementalSync(
|
|
|
|
ctx context.Context,
|
2022-09-30 11:48:10 +00:00
|
|
|
snapshot storage.DatabaseTransaction,
|
2021-01-08 16:59:06 +00:00
|
|
|
req *types.SyncRequest,
|
|
|
|
from, to types.StreamPosition,
|
|
|
|
) (newPos types.StreamPosition) {
|
|
|
|
r := types.Range{
|
|
|
|
From: from,
|
|
|
|
To: to,
|
|
|
|
Backwards: from > to,
|
|
|
|
}
|
|
|
|
|
|
|
|
var err error
|
|
|
|
var stateDeltas []types.StateDelta
|
2022-08-19 13:32:24 +00:00
|
|
|
var syncJoinedRooms []string
|
2021-01-08 16:59:06 +00:00
|
|
|
|
2021-01-19 18:00:42 +00:00
|
|
|
stateFilter := req.Filter.Room.State
|
|
|
|
eventFilter := req.Filter.Room.Timeline
|
2021-01-08 16:59:06 +00:00
|
|
|
|
|
|
|
if req.WantFullState {
|
2022-09-30 11:48:10 +00:00
|
|
|
if stateDeltas, syncJoinedRooms, err = snapshot.GetStateDeltasForFullStateSync(ctx, req.Device, r, req.Device.UserID, &stateFilter); err != nil {
|
2021-01-08 16:59:06 +00:00
|
|
|
req.Log.WithError(err).Error("p.DB.GetStateDeltasForFullStateSync failed")
|
2022-10-03 10:38:20 +00:00
|
|
|
return from
|
2021-01-08 16:59:06 +00:00
|
|
|
}
|
|
|
|
} else {
|
2022-09-30 11:48:10 +00:00
|
|
|
if stateDeltas, syncJoinedRooms, err = snapshot.GetStateDeltas(ctx, req.Device, r, req.Device.UserID, &stateFilter); err != nil {
|
2021-01-08 16:59:06 +00:00
|
|
|
req.Log.WithError(err).Error("p.DB.GetStateDeltas failed")
|
2022-10-03 10:38:20 +00:00
|
|
|
return from
|
2021-01-08 16:59:06 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2022-08-19 13:32:24 +00:00
|
|
|
for _, roomID := range syncJoinedRooms {
|
2021-01-08 16:59:06 +00:00
|
|
|
req.Rooms[roomID] = gomatrixserverlib.Join
|
|
|
|
}
|
|
|
|
|
2022-03-25 12:38:16 +00:00
|
|
|
if len(stateDeltas) == 0 {
|
|
|
|
return to
|
|
|
|
}
|
|
|
|
|
2022-09-30 11:48:10 +00:00
|
|
|
if err = p.addIgnoredUsersToFilter(ctx, snapshot, req, &eventFilter); err != nil {
|
2022-04-07 14:08:19 +00:00
|
|
|
req.Log.WithError(err).Error("unable to update event filter with ignored users")
|
|
|
|
}
|
|
|
|
|
2022-03-25 12:38:16 +00:00
|
|
|
newPos = from
|
2021-01-08 16:59:06 +00:00
|
|
|
for _, delta := range stateDeltas {
|
2022-08-25 12:42:47 +00:00
|
|
|
newRange := r
|
|
|
|
// If this room was joined in this sync, try to fetch
|
|
|
|
// as much timeline events as allowed by the filter.
|
|
|
|
if delta.NewlyJoined {
|
|
|
|
// Reverse the range, so we get the most recent first.
|
|
|
|
// This will be limited by the eventFilter.
|
|
|
|
newRange = types.Range{
|
|
|
|
From: r.To,
|
|
|
|
To: 0,
|
|
|
|
Backwards: true,
|
|
|
|
}
|
|
|
|
}
|
2022-03-25 12:38:16 +00:00
|
|
|
var pos types.StreamPosition
|
2022-10-19 12:05:39 +00:00
|
|
|
if pos, err = p.addRoomDeltaToResponse(ctx, snapshot, req.Device, newRange, delta, &eventFilter, &stateFilter, req); err != nil {
|
2021-01-08 16:59:06 +00:00
|
|
|
req.Log.WithError(err).Error("d.addRoomDeltaToResponse failed")
|
2022-10-03 10:38:20 +00:00
|
|
|
if err == context.DeadlineExceeded || err == context.Canceled || err == sql.ErrTxDone {
|
2022-09-30 15:34:06 +00:00
|
|
|
return newPos
|
|
|
|
}
|
2022-10-03 10:38:20 +00:00
|
|
|
continue
|
2022-03-25 12:38:16 +00:00
|
|
|
}
|
2022-08-25 12:42:47 +00:00
|
|
|
// Reset the position, as it is only for the special case of newly joined rooms
|
|
|
|
if delta.NewlyJoined {
|
|
|
|
pos = newRange.From
|
|
|
|
}
|
2022-03-25 12:38:16 +00:00
|
|
|
switch {
|
|
|
|
case r.Backwards && pos < newPos:
|
|
|
|
fallthrough
|
|
|
|
case !r.Backwards && pos > newPos:
|
|
|
|
newPos = pos
|
2021-01-08 16:59:06 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2022-03-25 12:38:16 +00:00
|
|
|
return newPos
|
2021-01-08 16:59:06 +00:00
|
|
|
}
|
|
|
|
|
2022-10-28 11:40:51 +00:00
|
|
|
// Limit the recent events to X when going backwards
|
|
|
|
const recentEventBackwardsLimit = 100
|
|
|
|
|
2022-04-20 15:06:46 +00:00
|
|
|
// nolint:gocyclo
|
2021-01-08 16:59:06 +00:00
|
|
|
func (p *PDUStreamProvider) addRoomDeltaToResponse(
|
|
|
|
ctx context.Context,
|
2022-09-30 11:48:10 +00:00
|
|
|
snapshot storage.DatabaseTransaction,
|
2021-01-08 16:59:06 +00:00
|
|
|
device *userapi.Device,
|
|
|
|
r types.Range,
|
|
|
|
delta types.StateDelta,
|
2021-01-19 18:00:42 +00:00
|
|
|
eventFilter *gomatrixserverlib.RoomEventFilter,
|
2022-04-19 08:46:45 +00:00
|
|
|
stateFilter *gomatrixserverlib.StateFilter,
|
2022-10-19 12:05:39 +00:00
|
|
|
req *types.SyncRequest,
|
2022-03-25 12:38:16 +00:00
|
|
|
) (types.StreamPosition, error) {
|
2023-02-07 13:31:23 +00:00
|
|
|
var err error
|
2022-10-25 13:15:24 +00:00
|
|
|
originalLimit := eventFilter.Limit
|
2022-10-28 11:40:51 +00:00
|
|
|
// If we're going backwards, grep at least X events, this is mostly to satisfy Sytest
|
|
|
|
if r.Backwards && originalLimit < recentEventBackwardsLimit {
|
|
|
|
eventFilter.Limit = recentEventBackwardsLimit // TODO: Figure out a better way
|
|
|
|
diff := r.From - r.To
|
|
|
|
if diff > 0 && diff < recentEventBackwardsLimit {
|
|
|
|
eventFilter.Limit = int(diff)
|
|
|
|
}
|
2021-01-08 16:59:06 +00:00
|
|
|
}
|
2022-10-28 11:40:51 +00:00
|
|
|
|
2023-02-07 13:31:23 +00:00
|
|
|
dbEvents, err := snapshot.RecentEvents(
|
|
|
|
ctx, []string{delta.RoomID}, r,
|
2021-01-19 18:00:42 +00:00
|
|
|
eventFilter, true, true,
|
2021-01-08 16:59:06 +00:00
|
|
|
)
|
|
|
|
if err != nil {
|
2022-04-20 15:06:46 +00:00
|
|
|
if err == sql.ErrNoRows {
|
|
|
|
return r.To, nil
|
|
|
|
}
|
|
|
|
return r.From, fmt.Errorf("p.DB.RecentEvents: %w", err)
|
2021-01-08 16:59:06 +00:00
|
|
|
}
|
2023-02-07 13:31:23 +00:00
|
|
|
|
|
|
|
recentStreamEvents := dbEvents[delta.RoomID].Events
|
|
|
|
limited := dbEvents[delta.RoomID].Limited
|
|
|
|
|
2022-10-31 15:14:08 +00:00
|
|
|
recentEvents := gomatrixserverlib.HeaderedReverseTopologicalOrdering(
|
|
|
|
snapshot.StreamEventsToEvents(device, recentStreamEvents),
|
|
|
|
gomatrixserverlib.TopologicalOrderByPrevEvents,
|
|
|
|
)
|
2021-01-08 16:59:06 +00:00
|
|
|
|
2022-03-25 12:38:16 +00:00
|
|
|
// If we didn't return any events at all then don't bother doing anything else.
|
2021-01-08 16:59:06 +00:00
|
|
|
if len(recentEvents) == 0 && len(delta.StateEvents) == 0 {
|
2022-03-25 12:38:16 +00:00
|
|
|
return r.To, nil
|
|
|
|
}
|
|
|
|
|
|
|
|
// Work out what the highest stream position is for all of the events in this
|
|
|
|
// room that were returned.
|
|
|
|
latestPosition := r.To
|
2022-11-04 14:39:09 +00:00
|
|
|
if r.Backwards {
|
|
|
|
latestPosition = r.From
|
|
|
|
}
|
2022-03-25 12:38:16 +00:00
|
|
|
updateLatestPosition := func(mostRecentEventID string) {
|
2022-04-19 08:46:45 +00:00
|
|
|
var pos types.StreamPosition
|
2022-09-30 11:48:10 +00:00
|
|
|
if _, pos, err = snapshot.PositionInTopology(ctx, mostRecentEventID); err == nil {
|
2022-03-25 12:38:16 +00:00
|
|
|
switch {
|
2022-08-02 08:43:48 +00:00
|
|
|
case r.Backwards && pos < latestPosition:
|
2022-03-25 12:38:16 +00:00
|
|
|
fallthrough
|
2022-08-02 08:43:48 +00:00
|
|
|
case !r.Backwards && pos > latestPosition:
|
2022-03-25 12:38:16 +00:00
|
|
|
latestPosition = pos
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2021-01-08 16:59:06 +00:00
|
|
|
|
2022-04-19 08:46:45 +00:00
|
|
|
if stateFilter.LazyLoadMembers {
|
|
|
|
delta.StateEvents, err = p.lazyLoadMembers(
|
2022-09-30 11:48:10 +00:00
|
|
|
ctx, snapshot, delta.RoomID, true, limited, stateFilter,
|
2022-04-19 08:46:45 +00:00
|
|
|
device, recentEvents, delta.StateEvents,
|
|
|
|
)
|
2022-04-20 15:06:46 +00:00
|
|
|
if err != nil && err != sql.ErrNoRows {
|
|
|
|
return r.From, fmt.Errorf("p.lazyLoadMembers: %w", err)
|
2022-04-19 08:46:45 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2022-04-01 15:14:38 +00:00
|
|
|
hasMembershipChange := false
|
|
|
|
for _, recentEvent := range recentStreamEvents {
|
|
|
|
if recentEvent.Type() == gomatrixserverlib.MRoomMember && recentEvent.StateKey() != nil {
|
2022-10-19 12:05:39 +00:00
|
|
|
if membership, _ := recentEvent.Membership(); membership == gomatrixserverlib.Join {
|
|
|
|
req.MembershipChanges[*recentEvent.StateKey()] = struct{}{}
|
|
|
|
}
|
2022-04-01 15:14:38 +00:00
|
|
|
hasMembershipChange = true
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2022-08-11 16:23:35 +00:00
|
|
|
// Applies the history visibility rules
|
2022-11-02 09:34:19 +00:00
|
|
|
events, err := applyHistoryVisibilityFilter(ctx, snapshot, p.rsAPI, delta.RoomID, device.UserID, recentEvents)
|
2022-08-11 16:23:35 +00:00
|
|
|
if err != nil {
|
|
|
|
logrus.WithError(err).Error("unable to apply history visibility filter")
|
|
|
|
}
|
|
|
|
|
2022-10-25 13:15:24 +00:00
|
|
|
if r.Backwards && len(events) > originalLimit {
|
|
|
|
// We're going backwards and the events are ordered chronologically, so take the last `limit` events
|
|
|
|
events = events[len(events)-originalLimit:]
|
|
|
|
limited = true
|
|
|
|
}
|
|
|
|
|
2022-11-03 16:56:21 +00:00
|
|
|
prevBatch, err := snapshot.GetBackwardTopologyPos(ctx, events)
|
|
|
|
if err != nil {
|
|
|
|
return r.From, fmt.Errorf("p.DB.GetBackwardTopologyPos: %w", err)
|
|
|
|
}
|
|
|
|
|
2022-10-31 15:14:08 +00:00
|
|
|
// Now that we've filtered the timeline, work out which state events are still
|
|
|
|
// left. Anything that appears in the filtered timeline will be removed from the
|
|
|
|
// "state" section and kept in "timeline".
|
|
|
|
delta.StateEvents = gomatrixserverlib.HeaderedReverseTopologicalOrdering(
|
2022-11-03 10:19:37 +00:00
|
|
|
removeDuplicates(delta.StateEvents, events),
|
2022-10-31 15:14:08 +00:00
|
|
|
gomatrixserverlib.TopologicalOrderByAuthEvents,
|
|
|
|
)
|
|
|
|
|
2022-08-11 16:23:35 +00:00
|
|
|
if len(delta.StateEvents) > 0 {
|
2022-11-01 14:45:15 +00:00
|
|
|
if last := delta.StateEvents[len(delta.StateEvents)-1]; last != nil {
|
|
|
|
updateLatestPosition(last.EventID())
|
|
|
|
}
|
2022-08-11 16:23:35 +00:00
|
|
|
}
|
2022-08-25 12:42:47 +00:00
|
|
|
if len(events) > 0 {
|
2022-11-01 14:45:15 +00:00
|
|
|
if last := events[len(events)-1]; last != nil {
|
|
|
|
updateLatestPosition(last.EventID())
|
|
|
|
}
|
2022-08-25 12:42:47 +00:00
|
|
|
}
|
2022-08-11 16:23:35 +00:00
|
|
|
|
2021-01-08 16:59:06 +00:00
|
|
|
switch delta.Membership {
|
|
|
|
case gomatrixserverlib.Join:
|
|
|
|
jr := types.NewJoinResponse()
|
2022-04-01 15:14:38 +00:00
|
|
|
if hasMembershipChange {
|
2023-01-12 09:06:03 +00:00
|
|
|
jr.Summary, err = snapshot.GetRoomSummary(ctx, delta.RoomID, device.UserID)
|
|
|
|
if err != nil {
|
|
|
|
logrus.WithError(err).Warn("failed to get room summary")
|
|
|
|
}
|
2022-04-01 15:14:38 +00:00
|
|
|
}
|
2021-01-08 16:59:06 +00:00
|
|
|
jr.Timeline.PrevBatch = &prevBatch
|
2022-08-11 16:23:35 +00:00
|
|
|
jr.Timeline.Events = gomatrixserverlib.HeaderedToClientEvents(events, gomatrixserverlib.FormatSync)
|
|
|
|
// If we are limited by the filter AND the history visibility filter
|
|
|
|
// didn't "remove" events, return that the response is limited.
|
2022-10-19 12:05:39 +00:00
|
|
|
jr.Timeline.Limited = (limited && len(events) == len(recentEvents)) || delta.NewlyJoined
|
2021-01-08 16:59:06 +00:00
|
|
|
jr.State.Events = gomatrixserverlib.HeaderedToClientEvents(delta.StateEvents, gomatrixserverlib.FormatSync)
|
2022-10-19 12:05:39 +00:00
|
|
|
req.Response.Rooms.Join[delta.RoomID] = jr
|
2021-01-13 14:32:49 +00:00
|
|
|
|
2021-01-08 16:59:06 +00:00
|
|
|
case gomatrixserverlib.Peek:
|
|
|
|
jr := types.NewJoinResponse()
|
|
|
|
jr.Timeline.PrevBatch = &prevBatch
|
2022-08-11 16:23:35 +00:00
|
|
|
// TODO: Apply history visibility on peeked rooms
|
2021-01-08 16:59:06 +00:00
|
|
|
jr.Timeline.Events = gomatrixserverlib.HeaderedToClientEvents(recentEvents, gomatrixserverlib.FormatSync)
|
|
|
|
jr.Timeline.Limited = limited
|
|
|
|
jr.State.Events = gomatrixserverlib.HeaderedToClientEvents(delta.StateEvents, gomatrixserverlib.FormatSync)
|
2022-10-19 12:05:39 +00:00
|
|
|
req.Response.Rooms.Peek[delta.RoomID] = jr
|
2021-01-13 14:32:49 +00:00
|
|
|
|
2021-01-08 16:59:06 +00:00
|
|
|
case gomatrixserverlib.Leave:
|
|
|
|
fallthrough // transitions to leave are the same as ban
|
2021-01-13 14:32:49 +00:00
|
|
|
|
2021-01-08 16:59:06 +00:00
|
|
|
case gomatrixserverlib.Ban:
|
|
|
|
lr := types.NewLeaveResponse()
|
|
|
|
lr.Timeline.PrevBatch = &prevBatch
|
2022-08-11 16:23:35 +00:00
|
|
|
lr.Timeline.Events = gomatrixserverlib.HeaderedToClientEvents(events, gomatrixserverlib.FormatSync)
|
|
|
|
// If we are limited by the filter AND the history visibility filter
|
|
|
|
// didn't "remove" events, return that the response is limited.
|
|
|
|
lr.Timeline.Limited = limited && len(events) == len(recentEvents)
|
2021-01-08 16:59:06 +00:00
|
|
|
lr.State.Events = gomatrixserverlib.HeaderedToClientEvents(delta.StateEvents, gomatrixserverlib.FormatSync)
|
2022-10-19 12:05:39 +00:00
|
|
|
req.Response.Rooms.Leave[delta.RoomID] = lr
|
2021-01-08 16:59:06 +00:00
|
|
|
}
|
|
|
|
|
2022-03-25 12:38:16 +00:00
|
|
|
return latestPosition, nil
|
2021-01-08 16:59:06 +00:00
|
|
|
}
|
|
|
|
|
2022-08-11 16:23:35 +00:00
|
|
|
// applyHistoryVisibilityFilter gets the current room state and supplies it to ApplyHistoryVisibilityFilter, to make
|
|
|
|
// sure we always return the required events in the timeline.
|
|
|
|
func applyHistoryVisibilityFilter(
|
|
|
|
ctx context.Context,
|
2022-09-30 11:48:10 +00:00
|
|
|
snapshot storage.DatabaseTransaction,
|
2022-08-11 16:23:35 +00:00
|
|
|
rsAPI roomserverAPI.SyncRoomserverAPI,
|
|
|
|
roomID, userID string,
|
|
|
|
recentEvents []*gomatrixserverlib.HeaderedEvent,
|
|
|
|
) ([]*gomatrixserverlib.HeaderedEvent, error) {
|
2023-01-17 09:08:23 +00:00
|
|
|
// We need to make sure we always include the latest state events, if they are in the timeline.
|
|
|
|
alwaysIncludeIDs := make(map[string]struct{})
|
|
|
|
var stateTypes []string
|
|
|
|
var senders []string
|
|
|
|
for _, ev := range recentEvents {
|
|
|
|
if ev.StateKey() != nil {
|
|
|
|
stateTypes = append(stateTypes, ev.Type())
|
|
|
|
senders = append(senders, ev.Sender())
|
|
|
|
}
|
2022-08-11 16:23:35 +00:00
|
|
|
}
|
2023-01-17 09:08:23 +00:00
|
|
|
|
|
|
|
// Only get the state again if there are state events in the timeline
|
|
|
|
if len(stateTypes) > 0 {
|
|
|
|
filter := gomatrixserverlib.DefaultStateFilter()
|
|
|
|
filter.Types = &stateTypes
|
|
|
|
filter.Senders = &senders
|
|
|
|
stateEvents, err := snapshot.CurrentState(ctx, roomID, &filter, nil)
|
|
|
|
if err != nil {
|
|
|
|
return nil, fmt.Errorf("failed to get current room state for history visibility calculation: %w", err)
|
|
|
|
}
|
|
|
|
|
|
|
|
for _, ev := range stateEvents {
|
|
|
|
alwaysIncludeIDs[ev.EventID()] = struct{}{}
|
|
|
|
}
|
2022-08-11 16:23:35 +00:00
|
|
|
}
|
2023-01-17 09:08:23 +00:00
|
|
|
|
2022-08-11 16:23:35 +00:00
|
|
|
startTime := time.Now()
|
2022-09-30 11:48:10 +00:00
|
|
|
events, err := internal.ApplyHistoryVisibilityFilter(ctx, snapshot, rsAPI, recentEvents, alwaysIncludeIDs, userID, "sync")
|
2022-08-11 16:23:35 +00:00
|
|
|
if err != nil {
|
|
|
|
return nil, err
|
|
|
|
}
|
|
|
|
logrus.WithFields(logrus.Fields{
|
|
|
|
"duration": time.Since(startTime),
|
|
|
|
"room_id": roomID,
|
2022-08-25 12:42:47 +00:00
|
|
|
"before": len(recentEvents),
|
|
|
|
"after": len(events),
|
2023-02-07 13:31:23 +00:00
|
|
|
}).Debugf("Applied history visibility (sync)")
|
2022-08-11 16:23:35 +00:00
|
|
|
return events, nil
|
|
|
|
}
|
|
|
|
|
2021-01-08 16:59:06 +00:00
|
|
|
func (p *PDUStreamProvider) getJoinResponseForCompleteSync(
|
|
|
|
ctx context.Context,
|
2022-09-30 11:48:10 +00:00
|
|
|
snapshot storage.DatabaseTransaction,
|
2021-01-08 16:59:06 +00:00
|
|
|
roomID string,
|
|
|
|
stateFilter *gomatrixserverlib.StateFilter,
|
2021-02-04 12:20:37 +00:00
|
|
|
wantFullState bool,
|
2021-01-19 18:00:42 +00:00
|
|
|
device *userapi.Device,
|
2022-08-11 16:23:35 +00:00
|
|
|
isPeek bool,
|
2023-02-07 13:31:23 +00:00
|
|
|
recentStreamEvents []types.StreamEvent,
|
|
|
|
limited bool,
|
2021-01-08 16:59:06 +00:00
|
|
|
) (jr *types.JoinResponse, err error) {
|
2022-04-20 15:51:37 +00:00
|
|
|
jr = types.NewJoinResponse()
|
2021-01-08 16:59:06 +00:00
|
|
|
// TODO: When filters are added, we may need to call this multiple times to get enough events.
|
|
|
|
// See: https://github.com/matrix-org/synapse/blob/v0.19.3/synapse/handlers/sync.py#L316
|
|
|
|
|
2022-03-16 10:18:08 +00:00
|
|
|
// Work our way through the timeline events and pick out the event IDs
|
|
|
|
// of any state events that appear in the timeline. We'll specifically
|
|
|
|
// exclude them at the next step, so that we don't get duplicate state
|
|
|
|
// events in both `recentStreamEvents` and `stateEvents`.
|
|
|
|
var excludingEventIDs []string
|
|
|
|
if !wantFullState {
|
|
|
|
excludingEventIDs = make([]string, 0, len(recentStreamEvents))
|
|
|
|
for _, event := range recentStreamEvents {
|
|
|
|
if event.StateKey() != nil {
|
|
|
|
excludingEventIDs = append(excludingEventIDs, event.EventID())
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2022-09-30 11:48:10 +00:00
|
|
|
stateEvents, err := snapshot.CurrentState(ctx, roomID, stateFilter, excludingEventIDs)
|
2022-03-16 10:18:08 +00:00
|
|
|
if err != nil {
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2023-01-12 09:06:03 +00:00
|
|
|
jr.Summary, err = snapshot.GetRoomSummary(ctx, roomID, device.UserID)
|
|
|
|
if err != nil {
|
|
|
|
logrus.WithError(err).Warn("failed to get room summary")
|
|
|
|
}
|
2022-04-01 15:14:38 +00:00
|
|
|
|
2021-01-08 16:59:06 +00:00
|
|
|
// We don't include a device here as we don't need to send down
|
|
|
|
// transaction IDs for complete syncs, but we do it anyway because Sytest demands it for:
|
|
|
|
// "Can sync a room with a message with a transaction id" - which does a complete sync to check.
|
2022-09-30 11:48:10 +00:00
|
|
|
recentEvents := snapshot.StreamEventsToEvents(device, recentStreamEvents)
|
2022-04-19 08:46:45 +00:00
|
|
|
|
2022-08-11 16:23:35 +00:00
|
|
|
events := recentEvents
|
|
|
|
// Only apply history visibility checks if the response is for joined rooms
|
|
|
|
if !isPeek {
|
2022-11-02 09:34:19 +00:00
|
|
|
events, err = applyHistoryVisibilityFilter(ctx, snapshot, p.rsAPI, roomID, device.UserID, recentEvents)
|
2022-08-11 16:23:35 +00:00
|
|
|
if err != nil {
|
|
|
|
logrus.WithError(err).Error("unable to apply history visibility filter")
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// If we are limited by the filter AND the history visibility filter
|
|
|
|
// didn't "remove" events, return that the response is limited.
|
|
|
|
limited = limited && len(events) == len(recentEvents)
|
2022-11-03 10:19:37 +00:00
|
|
|
stateEvents = removeDuplicates(stateEvents, events)
|
2022-04-19 08:46:45 +00:00
|
|
|
if stateFilter.LazyLoadMembers {
|
|
|
|
if err != nil {
|
|
|
|
return nil, err
|
|
|
|
}
|
2022-09-30 11:48:10 +00:00
|
|
|
stateEvents, err = p.lazyLoadMembers(
|
|
|
|
ctx, snapshot, roomID,
|
2022-08-30 12:18:47 +00:00
|
|
|
false, limited, stateFilter,
|
2022-04-19 08:46:45 +00:00
|
|
|
device, recentEvents, stateEvents,
|
|
|
|
)
|
2022-04-20 15:51:37 +00:00
|
|
|
if err != nil && err != sql.ErrNoRows {
|
2022-04-19 08:46:45 +00:00
|
|
|
return nil, err
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2022-11-03 16:56:21 +00:00
|
|
|
// Retrieve the backward topology position, i.e. the position of the
|
|
|
|
// oldest event in the room's topology.
|
|
|
|
var prevBatch *types.TopologyToken
|
|
|
|
if len(events) > 0 {
|
|
|
|
var backwardTopologyPos, backwardStreamPos types.StreamPosition
|
|
|
|
event := events[0]
|
|
|
|
// If this is the beginning of the room, we can't go back further. We're going to return
|
|
|
|
// the TopologyToken from the last event instead. (Synapse returns the /sync next_Batch)
|
|
|
|
if event.Type() == gomatrixserverlib.MRoomCreate && event.StateKeyEquals("") {
|
|
|
|
event = events[len(events)-1]
|
|
|
|
}
|
|
|
|
backwardTopologyPos, backwardStreamPos, err = snapshot.PositionInTopology(ctx, event.EventID())
|
|
|
|
if err != nil {
|
|
|
|
return
|
|
|
|
}
|
|
|
|
prevBatch = &types.TopologyToken{
|
|
|
|
Depth: backwardTopologyPos,
|
|
|
|
PDUPosition: backwardStreamPos,
|
|
|
|
}
|
|
|
|
prevBatch.Decrement()
|
|
|
|
}
|
|
|
|
|
2021-01-08 16:59:06 +00:00
|
|
|
jr.Timeline.PrevBatch = prevBatch
|
2022-08-11 16:23:35 +00:00
|
|
|
jr.Timeline.Events = gomatrixserverlib.HeaderedToClientEvents(events, gomatrixserverlib.FormatSync)
|
|
|
|
// If we are limited by the filter AND the history visibility filter
|
|
|
|
// didn't "remove" events, return that the response is limited.
|
|
|
|
jr.Timeline.Limited = limited && len(events) == len(recentEvents)
|
2021-01-08 16:59:06 +00:00
|
|
|
jr.State.Events = gomatrixserverlib.HeaderedToClientEvents(stateEvents, gomatrixserverlib.FormatSync)
|
|
|
|
return jr, nil
|
|
|
|
}
|
|
|
|
|
2022-04-19 08:46:45 +00:00
|
|
|
func (p *PDUStreamProvider) lazyLoadMembers(
|
2022-09-30 11:48:10 +00:00
|
|
|
ctx context.Context, snapshot storage.DatabaseTransaction, roomID string,
|
2022-08-30 12:18:47 +00:00
|
|
|
incremental, limited bool, stateFilter *gomatrixserverlib.StateFilter,
|
2022-04-19 08:46:45 +00:00
|
|
|
device *userapi.Device,
|
|
|
|
timelineEvents, stateEvents []*gomatrixserverlib.HeaderedEvent,
|
|
|
|
) ([]*gomatrixserverlib.HeaderedEvent, error) {
|
|
|
|
if len(timelineEvents) == 0 {
|
|
|
|
return stateEvents, nil
|
|
|
|
}
|
|
|
|
// Work out which memberships to include
|
|
|
|
timelineUsers := make(map[string]struct{})
|
|
|
|
if !incremental {
|
|
|
|
timelineUsers[device.UserID] = struct{}{}
|
|
|
|
}
|
|
|
|
// Add all users the client doesn't know about yet to a list
|
|
|
|
for _, event := range timelineEvents {
|
|
|
|
// Membership is not yet cached, add it to the list
|
|
|
|
if _, ok := p.lazyLoadCache.IsLazyLoadedUserCached(device, roomID, event.Sender()); !ok {
|
|
|
|
timelineUsers[event.Sender()] = struct{}{}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
// Preallocate with the same amount, even if it will end up with fewer values
|
|
|
|
newStateEvents := make([]*gomatrixserverlib.HeaderedEvent, 0, len(stateEvents))
|
|
|
|
// Remove existing membership events we don't care about, e.g. users not in the timeline.events
|
|
|
|
for _, event := range stateEvents {
|
|
|
|
if event.Type() == gomatrixserverlib.MRoomMember && event.StateKey() != nil {
|
|
|
|
// If this is a gapped incremental sync, we still want this membership
|
|
|
|
isGappedIncremental := limited && incremental
|
|
|
|
// We want this users membership event, keep it in the list
|
2022-08-16 13:42:00 +00:00
|
|
|
stateKey := *event.StateKey()
|
2022-11-22 21:38:27 +00:00
|
|
|
if _, ok := timelineUsers[stateKey]; ok || isGappedIncremental || stateKey == device.UserID {
|
2022-04-19 08:46:45 +00:00
|
|
|
newStateEvents = append(newStateEvents, event)
|
2022-08-30 12:18:47 +00:00
|
|
|
if !stateFilter.IncludeRedundantMembers {
|
2022-08-16 13:42:00 +00:00
|
|
|
p.lazyLoadCache.StoreLazyLoadedUser(device, roomID, stateKey, event.EventID())
|
2022-04-19 08:46:45 +00:00
|
|
|
}
|
2022-08-16 13:42:00 +00:00
|
|
|
delete(timelineUsers, stateKey)
|
2022-04-19 08:46:45 +00:00
|
|
|
}
|
|
|
|
} else {
|
|
|
|
newStateEvents = append(newStateEvents, event)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
wantUsers := make([]string, 0, len(timelineUsers))
|
|
|
|
for userID := range timelineUsers {
|
|
|
|
wantUsers = append(wantUsers, userID)
|
|
|
|
}
|
|
|
|
// Query missing membership events
|
2022-08-16 13:42:00 +00:00
|
|
|
filter := gomatrixserverlib.DefaultStateFilter()
|
|
|
|
filter.Senders = &wantUsers
|
|
|
|
filter.Types = &[]string{gomatrixserverlib.MRoomMember}
|
2022-09-30 11:48:10 +00:00
|
|
|
memberships, err := snapshot.GetStateEventsForRoom(ctx, roomID, &filter)
|
2022-04-19 08:46:45 +00:00
|
|
|
if err != nil {
|
|
|
|
return stateEvents, err
|
|
|
|
}
|
|
|
|
// cache the membership events
|
|
|
|
for _, membership := range memberships {
|
2022-08-16 13:42:00 +00:00
|
|
|
p.lazyLoadCache.StoreLazyLoadedUser(device, roomID, *membership.StateKey(), membership.EventID())
|
2022-04-19 08:46:45 +00:00
|
|
|
}
|
|
|
|
stateEvents = append(newStateEvents, memberships...)
|
|
|
|
return stateEvents, nil
|
|
|
|
}
|
|
|
|
|
2022-04-07 14:08:19 +00:00
|
|
|
// addIgnoredUsersToFilter adds ignored users to the eventfilter and
|
|
|
|
// the syncreq itself for further use in streams.
|
2022-09-30 11:48:10 +00:00
|
|
|
func (p *PDUStreamProvider) addIgnoredUsersToFilter(ctx context.Context, snapshot storage.DatabaseTransaction, req *types.SyncRequest, eventFilter *gomatrixserverlib.RoomEventFilter) error {
|
|
|
|
ignores, err := snapshot.IgnoresForUser(ctx, req.Device.UserID)
|
2022-04-07 14:08:19 +00:00
|
|
|
if err != nil {
|
|
|
|
if err == sql.ErrNoRows {
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
req.IgnoredUsers = *ignores
|
2022-04-11 07:05:23 +00:00
|
|
|
userList := make([]string, 0, len(ignores.List))
|
2022-04-07 14:08:19 +00:00
|
|
|
for userID := range ignores.List {
|
2022-04-11 07:05:23 +00:00
|
|
|
userList = append(userList, userID)
|
|
|
|
}
|
|
|
|
if len(userList) > 0 {
|
|
|
|
eventFilter.NotSenders = &userList
|
2022-04-07 14:08:19 +00:00
|
|
|
}
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2021-01-08 16:59:06 +00:00
|
|
|
func removeDuplicates(stateEvents, recentEvents []*gomatrixserverlib.HeaderedEvent) []*gomatrixserverlib.HeaderedEvent {
|
|
|
|
for _, recentEv := range recentEvents {
|
|
|
|
if recentEv.StateKey() == nil {
|
|
|
|
continue // not a state event
|
|
|
|
}
|
|
|
|
// TODO: This is a linear scan over all the current state events in this room. This will
|
|
|
|
// be slow for big rooms. We should instead sort the state events by event ID (ORDER BY)
|
|
|
|
// then do a binary search to find matching events, similar to what roomserver does.
|
|
|
|
for j := 0; j < len(stateEvents); j++ {
|
|
|
|
if stateEvents[j].EventID() == recentEv.EventID() {
|
|
|
|
// overwrite the element to remove with the last element then pop the last element.
|
|
|
|
// This is orders of magnitude faster than re-slicing, but doesn't preserve ordering
|
|
|
|
// (we don't care about the order of stateEvents)
|
|
|
|
stateEvents[j] = stateEvents[len(stateEvents)-1]
|
|
|
|
stateEvents = stateEvents[:len(stateEvents)-1]
|
|
|
|
break // there shouldn't be multiple events with the same event ID
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return stateEvents
|
|
|
|
}
|