mirror of
https://github.com/uutils/coreutils
synced 2024-12-14 23:32:39 +00:00
ce2a5d5b9a
* expr fuzz: add missing ops. found thanks to oss fuzz coverage https://storage.googleapis.com/oss-fuzz-coverage/rust-coreutils/reports/20231118/linux/src/rust-coreutils/src/uu/expr/src/syntax_tree.rs.html Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
95 lines
3 KiB
Rust
95 lines
3 KiB
Rust
// This file is part of the uutils coreutils package.
|
|
//
|
|
// For the full copyright and license information, please view the LICENSE
|
|
// file that was distributed with this source code.
|
|
// spell-checker:ignore parens
|
|
|
|
#![no_main]
|
|
use libfuzzer_sys::fuzz_target;
|
|
use uu_expr::uumain;
|
|
|
|
use rand::seq::SliceRandom;
|
|
use rand::Rng;
|
|
use std::{env, ffi::OsString};
|
|
|
|
mod fuzz_common;
|
|
use crate::fuzz_common::CommandResult;
|
|
use crate::fuzz_common::{
|
|
compare_result, generate_and_run_uumain, generate_random_string, run_gnu_cmd,
|
|
};
|
|
static CMD_PATH: &str = "expr";
|
|
|
|
fn generate_expr(max_depth: u32) -> String {
|
|
let mut rng = rand::thread_rng();
|
|
let ops = [
|
|
"+", "-", "*", "/", "%", "<", ">", "=", "&", "|", "!=", "<=", ">=", ":", "index", "length", "substr",
|
|
];
|
|
|
|
let mut expr = String::new();
|
|
let mut depth = 0;
|
|
let mut last_was_operator = false;
|
|
|
|
while depth <= max_depth {
|
|
if last_was_operator || depth == 0 {
|
|
// Add a number
|
|
expr.push_str(&rng.gen_range(1..=100).to_string());
|
|
last_was_operator = false;
|
|
} else {
|
|
// 90% chance to add an operator followed by a number
|
|
if rng.gen_bool(0.9) {
|
|
let op = *ops.choose(&mut rng).unwrap();
|
|
expr.push_str(&format!(" {} ", op));
|
|
last_was_operator = true;
|
|
}
|
|
// 10% chance to add a random string (potentially invalid syntax)
|
|
else {
|
|
let random_str = generate_random_string(rng.gen_range(1..=10));
|
|
expr.push_str(&random_str);
|
|
last_was_operator = false;
|
|
}
|
|
}
|
|
depth += 1;
|
|
}
|
|
|
|
// Ensure the expression ends with a number if it ended with an operator
|
|
if last_was_operator {
|
|
expr.push_str(&rng.gen_range(1..=100).to_string());
|
|
}
|
|
|
|
expr
|
|
}
|
|
|
|
fuzz_target!(|_data: &[u8]| {
|
|
let mut rng = rand::thread_rng();
|
|
let expr = generate_expr(rng.gen_range(0..=20));
|
|
let mut args = vec![OsString::from("expr")];
|
|
args.extend(expr.split_whitespace().map(OsString::from));
|
|
|
|
// Use C locale to avoid false positives, like in https://github.com/uutils/coreutils/issues/5378,
|
|
// because uutils expr doesn't support localization yet
|
|
// TODO remove once uutils expr supports localization
|
|
env::set_var("LC_COLLATE", "C");
|
|
let rust_result = generate_and_run_uumain(&args, uumain);
|
|
|
|
let gnu_result = match run_gnu_cmd(CMD_PATH, &args[1..], false) {
|
|
Ok(result) => result,
|
|
Err(error_result) => {
|
|
eprintln!("Failed to run GNU command:");
|
|
eprintln!("Stderr: {}", error_result.stderr);
|
|
eprintln!("Exit Code: {}", error_result.exit_code);
|
|
CommandResult {
|
|
stdout: String::new(),
|
|
stderr: error_result.stderr,
|
|
exit_code: error_result.exit_code,
|
|
}
|
|
}
|
|
};
|
|
|
|
compare_result(
|
|
"expr",
|
|
&format!("{:?}", &args[1..]),
|
|
&rust_result,
|
|
&gnu_result,
|
|
false, // Set to true if you want to fail on stderr diff
|
|
);
|
|
});
|