Terts Diepraam
f5ba8b1811
Merge pull request #2499 from 353fc443/uresult-kill
...
Add Uresult for false, echo, pwd, true and kill
2021-07-13 17:29:26 +02:00
353fc443
a6b0cf29e0
kill: added suggestions
2021-07-13 14:55:12 +00:00
353fc443
bd45fe26dc
true: added uresult
...
Related to #2464
2021-07-13 13:47:06 +00:00
353fc443
7d94121b95
kill: added uresult
...
Related to #2464
2021-07-13 09:49:39 +00:00
353fc443
425de97650
pwd: added uresult
...
Related to #2464
2021-07-13 09:10:47 +00:00
353fc443
2845dd3140
echo: adding uresult
...
Related to #2464
2021-07-13 08:55:33 +00:00
353fc443
5730c8693f
sleep: fixing clippy warnings
2021-07-13 07:25:18 +00:00
353fc443
c48e623a80
false: addding uresult
...
Related to #2464
2021-07-13 06:56:27 +00:00
Son Nguyen
6c26976edb
sleep: use UResult ( #2492 )
...
* sleep: use UResult in util
* sleep: add in error + test for it
* sleep: UResult - removed some verbosity
2021-07-12 20:20:23 +02:00
Sylvestre Ledru
35a9b7f1fb
fix the base32 dep
2021-07-11 21:32:01 +02:00
Sylvestre Ledru
26a882551b
update the dep to uucore_procs 0.0.6
2021-07-11 21:04:11 +02:00
Sylvestre Ledru
f534963dec
bump uucore_procs to 0.0.6
2021-07-11 20:55:55 +02:00
Sylvestre Ledru
1d8a66b7d3
Update to version 0.0.7
2021-07-11 18:04:56 +02:00
Sylvestre Ledru
f37446eb1f
update uucore to 0.0.9
2021-07-11 18:03:18 +02:00
Sylvestre Ledru
d4f27f1454
rustfmt the recent change
2021-07-11 11:23:51 +02:00
Sylvestre Ledru
caf984bd55
fix various clippy issues
2021-07-11 11:22:33 +02:00
Sylvestre Ledru
52c6593ef5
Merge pull request #2486 from hbina/hbina-tr-return-err-when-extra-args
...
`tr` should error out when if user provides more than 2 sets
2021-07-10 20:51:27 +02:00
Hanif Bin Ariffin
15f6e35163
Use map/default instead of match
...
Signed-off-by: Hanif Bin Ariffin <hanif.ariffin.4326@gmail.com>
2021-07-10 18:51:24 +08:00
Hanif Bin Ariffin
199b4e437b
Removed manual checks to just using clap instead
...
Also added tests for this.
Signed-off-by: Hanif Bin Ariffin <hanif.ariffin.4326@gmail.com>
2021-07-10 18:49:13 +08:00
Sylvestre Ledru
dcac295db3
Merge pull request #2489 from jhscheer/tr_2485
...
tr: fix squeeze and complement with two sets (#2485 )
2021-07-10 00:41:09 +02:00
Jan Scheer
30b80d0c82
tr: fix squeeze and complement with two sets ( #2485 )
2021-07-09 23:05:00 +02:00
Terts Diepraam
4f6c995726
uucore_procs: add full feature flag to syn
2021-07-09 19:17:01 +02:00
Hanif Bin Ariffin
c4c6819dae
Reimplemented simply using args
...
Signed-off-by: Hanif Bin Ariffin <hanif.ariffin.4326@gmail.com>
2021-07-09 23:51:37 +08:00
Hanif Bin Ariffin
db79b5abb2
tr
should error out when if user provides more than 2 sets
...
Signed-off-by: Hanif Bin Ariffin <hanif.ariffin.4326@gmail.com>
2021-07-09 23:22:12 +08:00
Sylvestre Ledru
cea0fc844a
Merge pull request #2476 from siebenHeaven/du_uresult
...
du: Use UResult
2021-07-07 15:44:11 +02:00
Sylvestre Ledru
df683f8c84
Merge pull request #2465 from miDeb/install-test
...
[: install test as [ as well
2021-07-07 15:43:38 +02:00
Sylvestre Ledru
7018ff8925
Merge pull request #2477 from dhodder/uname_target_env
...
uname: don't report OS as "GNU/Linux" without GNU
2021-07-07 08:46:50 +02:00
Dave Hodder
7a62d8e4e7
uname: add NetBSD to operating systems list
2021-07-06 23:42:16 +01:00
Sylvestre Ledru
9ad70a4f5d
Merge pull request #2480 from miDeb/sort/key-args
...
sort: make -k only take one argument per flag
2021-07-06 18:58:50 +02:00
Michael Debertol
8ace291b32
sort: make -k only take one argument per flag
...
This makes it so that `sort -k 1 file` treats `file` as the input file
and not the second key.
2021-07-06 15:47:32 +02:00
Michael Debertol
bc0727cc4d
[: add support for --help and --version
...
I copied the help text verbatim from GNU, I hope that's ok.
2021-07-06 13:15:07 +02:00
Sylvestre Ledru
d5b2320a59
Fix clippy warning
...
Useless use of format
2021-07-06 12:44:33 +02:00
Sylvestre Ledru
16a5faf886
Silent buggy clippy warnings
2021-07-06 12:12:36 +02:00
Terts Diepraam
e253fb89db
Merge branch 'master' into hostname-uresult
2021-07-06 11:21:42 +02:00
Dave Hodder
c74b77aec8
uname: don't report OS as "GNU/Linux" without GNU
...
The `uname` `-o` switch reports the operating system used. If the GNU C
standard library (glibc) is not in use, for example if musl is being
used instead, report "Linux" instead of "GNU/Linux".
2021-07-05 22:42:42 +01:00
Andreas Hartmann
9d94307880
mv: Adapt for new backup_control utilities
2021-07-05 12:44:44 +02:00
Andreas Hartmann
a783d05101
backup_control: Add module tests
...
Adds a tests submodule that performs tests on the
`determine_backup_mode` function to ensure it handles backup options
like specified by [GNU][1].
[1]: https://www.gnu.org/software/coreutils/manual/html_node/Backup-options.html
2021-07-05 12:44:44 +02:00
Andreas Hartmann
89c6d32a20
backup_control: Refactor backup mode determination
...
Refactor the function that determines which backup mode to select based
on user input. It now complies with what the [GNU manual][1] specifies.
[1]: https://www.gnu.org/software/coreutils/manual/html_node/Backup-options.html
2021-07-05 12:44:40 +02:00
Andreas Hartmann
1309757d4d
backup_control: Make utility functions private
2021-07-05 12:43:28 +02:00
Andreas Hartmann
fa0b4861b9
backup_control: Match abbreviated backup options
...
Add a function that takes a user-supplied backup option and checks if it
matches any of the valid backup options. This is because GNU allows to
abbreviate backup options, as long as they are valid and unambiguous.
In case a backup option is either invalid or ambiguous, an error type is
returned that contains a formatted error string for output to the user.
2021-07-05 12:43:28 +02:00
Andreas Hartmann
3b8f135842
backup_control: Add backup help string from GNU utils
...
The previous help string for the backup subroutines didn't comply with
the formatting found in the `--help` output of e.g. `mv` or `ln`.
Use the exact help string from these utilities instead.
2021-07-05 12:43:28 +02:00
Anup Mahindre
a9ba4c6d9f
du: Use UResult
2021-07-04 22:44:25 +05:30
Sylvestre Ledru
f2e12fee0a
Silent buggy clippy warnings
...
Fails with:
```
error: use of irregular braces for `write!` macro
--> src/uucore/src/lib/features/encoding.rs:19:17
|
19 | #[derive(Debug, Error)]
| ^^^^^
|
= note: `-D clippy::nonstandard-macro-braces` implied by `-D warnings`
help: consider writing `Error`
--> src/uucore/src/lib/features/encoding.rs:19:17
|
19 | #[derive(Debug, Error)]
| ^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonstandard_macro_braces
= note: this error originates in the derive macro `Error` (in Nightly builds, run with -Z macro-backtrace for more info)
```
2021-07-04 19:06:37 +02:00
Sylvestre Ledru
1136221f6f
rustfmt the recent change
2021-07-04 13:01:31 +02:00
353fc443
d0805605e0
imported UUsageError
2021-07-04 16:09:55 +05:30
Sylvestre Ledru
38c0880989
fix the clippy warning
2021-07-04 12:03:36 +02:00
Sylvestre Ledru
e4204fcf07
Merge pull request #2436 from hbina/hbina-ls-refactor-options-module
...
ls: Refactored options and other long constants to fix formatting
2021-07-04 11:59:06 +02:00
Sylvestre Ledru
ec1a301c56
Merge pull request #2473 from tertsdiepraam/usage-error
...
uucore: add usage errors
2021-07-04 11:46:07 +02:00
Sylvestre Ledru
91078cfcb3
Merge pull request #2445 from syukronrm/du-inodes
...
du: add `--inodes`
2021-07-04 11:28:03 +02:00
Sylvestre Ledru
010919a9a9
Merge pull request #2460 from miDeb/completions-errors
...
coreutils: better errors for invalid args for completions
2021-07-04 11:27:26 +02:00
Sylvestre Ledru
d3652cc3c0
Merge pull request #2457 from Funky185540/install-implement-backup
...
install: implement --backup, -b and -S
2021-07-04 09:57:45 +02:00
Terts Diepraam
e46ce2947e
add usage error
2021-07-02 19:31:16 +02:00
353fc443
23f5f55560
Added UResult for dirname
2021-07-02 12:14:24 +00:00
353fc443
f66f10c4ed
Added UResult for hostid
2021-07-02 12:03:14 +00:00
353fc443
330db2eb3e
Added UResult for hostname
2021-07-02 08:19:33 +00:00
Terts Diepraam
5a40148602
Merge pull request #2463 from miDeb/wrap-help
...
all utils: enable wrap_help
2021-07-01 13:18:32 +02:00
Terts Diepraam
7a0a7aecc4
Merge pull request #2461 from miDeb/sort/check-no-out
...
sort: disable -o with -C and -c
2021-07-01 13:07:05 +02:00
Terts Diepraam
6213a2a967
Merge pull request #2462 from miDeb/sort/version
...
sort/ls: implement version cmp matching GNU spec
2021-07-01 13:02:59 +02:00
Dean Li
b21e01bcb0
arch: match GNU error
...
Follow up for #2466 as suggested by @miDeb
2021-06-30 22:32:59 +08:00
Dean Li
92bfaea3fa
arch: use UResult
2021-06-29 19:48:20 +08:00
Michael Debertol
cd83aed89c
test: go into '[' mode when executable ends with [
...
This makes [ work even when installed with a custom prefix, e.g. as uu-[.
2021-06-29 00:28:01 +02:00
Terts Diepraam
0cfaaeceda
touch: adapt to standardized error handling
2021-06-28 13:55:55 +02:00
Terts Diepraam
73a7ead857
mktemp: adapt to standardized error handling
2021-06-28 13:55:55 +02:00
Terts Diepraam
8c5052fcb7
mkdir: adapt to standardized error handling
2021-06-28 13:55:37 +02:00
Terts Diepraam
e4eac825fb
ls: adapt to standardized error handling
2021-06-28 13:49:57 +02:00
Terts Diepraam
60e4621c3b
uucore_procs: add temporary proc macro gen_uumain for standardized error handling
2021-06-28 13:49:56 +02:00
Terts Diepraam
43bfec7170
uucore/error: add macros for standardized error handling
2021-06-28 13:49:45 +02:00
Terts Diepraam
66b1ac019d
uucore/error: add standardized error handling (adds UResult & UError)
2021-06-28 13:49:35 +02:00
Syukron Rifail M
27e0507844
du: more tests
2021-06-28 07:51:17 +07:00
Syukron Rifail M
d8a33da5b3
du: add --inodes
2021-06-28 07:51:17 +07:00
Andreas Hartmann
1a43a94e31
install: Apply rustfmt
2021-06-27 17:59:04 +02:00
Michael Debertol
d3732e08c4
sort: disable -o with -C and -c
2021-06-27 16:21:18 +02:00
Michael Debertol
2ebca384c6
all utils: enable wrap_help
...
This makes clap wrap the help text according to the terminal width,
which improves readability for terminal widths < 120 chars,
because clap defaults to a width of 120 chars without this feature.
2021-06-27 16:17:10 +02:00
Michael Debertol
0dda72eb60
coreutils: better errors for invalid args for completions
...
Use clap to extract command line arguments. This generates much better
error messages.
2021-06-27 16:07:43 +02:00
Michael Debertol
233a778963
sort/ls: implement version cmp matching GNU spec
...
This reimplements version_cmp, which is used in sort and ls to sort
according to versions.
However, it is not bug-for-bug identical with GNU's implementation.
I reported a bug with GNU here:
https://lists.gnu.org/archive/html/bug-coreutils/2021-06/msg00045.html
This implementation does not contain the bugs regarding the handling of
file extensions and null bytes.
2021-06-27 15:29:17 +02:00
Andreas Hartmann
df41fed640
install: Mark '-S', '-b' and '--backup' as implemented
...
Removes the "unimplemented" notice from the respective help texts. Stop
printing errors if the options are supplied via CLI.
2021-06-27 09:54:55 +02:00
Andreas Hartmann
5437985705
install: Implement '--backup' and '-b'
...
Adds the ability to perform file backups before installing newer files on top
of existing ones. Adds a status message about backups to stdout if running in
verbose mode.
2021-06-27 09:54:17 +02:00
Andreas Hartmann
49a9f359bb
install: Make use of 'backup_controls' for '--backup' opts
...
Use the methods and types offered by the 'backup_controls' module to implement
the logic for backing up files instead of overwriting.
2021-06-27 09:54:07 +02:00
Hanif Bin Ariffin
4778a64989
ls: Refactored options and other long constants to fix formatting
...
Signed-off-by: Hanif Bin Ariffin <hanif.ariffin.4326@gmail.com>
Keep one of the texts in-place
Signed-off-by: Hanif Bin Ariffin <hanif.ariffin.4326@gmail.com>
Reduced the fix to just formatting changes
Signed-off-by: Hanif Bin Ariffin <hanif.ariffin.4326@gmail.com>
2021-06-27 14:55:55 +08:00
Andreas Hartmann
a85adf3c3f
install: Internally rename short '-b' option
...
Rename from OPT_BACKUP_2 to a more descriptive name "OPT_BACKUP_NO_ARGS".
2021-06-26 00:27:08 +02:00
Andreas Hartmann
3155cd510f
install: Fix argument parsing for '--backup'
...
The '--backup' option would previously accept arguments separated from the
option either by a space or an equals sign. The GNU implementation strictly
requires an "equals" for argument separation.
As the argument to '--backup' is optional, the equals sign mustn't be ommited
as otherwise there is no way to tell a file argument apart from an argument
that's meant for the '--backup' option. This ensures that if '--backup' is
present it either has no further associated arguments (i.e. fallback to the
default), or the arguments are separated by an equals sign.
2021-06-26 00:27:08 +02:00
Andreas Hartmann
211af9a3ea
backup_control: Add todo for gnu compliant behavior
...
The logic behind the file-backup implementation currently doesn't comply 100%
with what the GNU manual [1] describes. Adds a TODO so it isn't forgotten.
[1]: https://www.gnu.org/software/coreutils/manual/html_node/Backup-options.html
2021-06-26 00:27:08 +02:00
Michael Debertol
73cfcc27e7
cp: insert some spaces into the help text
2021-06-25 21:23:45 +02:00
Michael Debertol
2e027bf45d
true, false: enable --help and --version
2021-06-25 21:23:45 +02:00
Michael Debertol
0fec449de3
mkfifo: make rustfmt work
2021-06-25 21:23:45 +02:00
Michael Debertol
a8d62b9b23
fmt: fix indentation for help
2021-06-25 21:23:45 +02:00
Michael Debertol
a9e79c72c7
uutils: enable shell completions
...
This adds a hidden `completion` subcommand to coreutils. When invoked with
`coreutils completion <utility> <shell>` a completion file will be printed
to stdout. When running `make install` those files will be created for all
utilities and copied to the appropriate locations.
`make install` will install completions for zsh, fish and bash; however,
clap also supports generating completions for powershell and elvish.
With this patch all utilities are required to have a publich uu_app function
that returns a clap::App in addition to the uumain function.
2021-06-25 21:23:45 +02:00
Michael Debertol
0531153fa6
uutils: move clap::App creation to separate functions
2021-06-25 21:23:45 +02:00
Michael Debertol
004b5d1b38
format: formatting
2021-06-25 19:35:33 +02:00
Michael Debertol
548a895cd6
sort: compatibility of human-numeric sort
...
Closes #1985 .
This makes human-numeric sort follow the same algorithm as GNU's/FreeBSD's sort.
As documented by GNU in https://www.gnu.org/software/coreutils/manual/html_node/sort-invocation.html ,
we first compare by sign, then by si unit and finally by the numeric value.
2021-06-25 18:19:00 +02:00
Sylvestre Ledru
fef8761ac1
Merge pull request #2443 from miDeb/sort/data-oriented
...
sort: separate additional data from the Line struct
2021-06-24 21:19:23 +02:00
Sylvestre Ledru
ab5d581fa4
Merge pull request #2439 from tertsdiepraam/numfmt/round-and-c-locale
...
`numfmt`: add `--round` and other minor improvements
2021-06-24 21:18:59 +02:00
Sylvestre Ledru
5d7cf61128
Merge pull request #2429 from miDeb/install/target-dir
...
install: support --target-directory
2021-06-24 21:06:44 +02:00
Michael Debertol
8bebfbb3e6
sort: don't store slices for general numeric sort
...
Gerenal numeric sort works by comparing pre-parsed floating point
numbers. That means that we don't have to store the &str the float was
parsed from.
As a result, memory usage was slightly reduced for general numeric sort.
2021-06-24 18:33:33 +02:00
Sylvestre Ledru
3b2d0d17fa
Merge pull request #2446 from jhscheer/groups_gnu_testsuite
...
groups: fixes to pass GNU's Testsuite
2021-06-23 20:15:12 +02:00
Sylvestre Ledru
44c770d234
Merge pull request #2450 from jhscheer/id_refactor_identifier
...
id: refactor identifiers
2021-06-23 19:05:57 +02:00
Jan Scheer
11f36eae3b
tests/groups: fix/add tests for (multiple) username(s)
2021-06-23 16:50:03 +02:00
Sylvestre Ledru
d40fc65ee6
Merge branch 'master' into numfmt/round-and-c-locale
2021-06-23 12:39:55 +02:00
Sylvestre Ledru
a73e71ba74
Merge pull request #2437 from miDeb/cp/reflink-auto
...
cp: default to --reflink=auto on linux and macos
2021-06-23 12:37:44 +02:00
Sylvestre Ledru
87eaf6e80a
Merge pull request #2447 from jhscheer/locale_c
...
fix some issues with locale (replace "LANGUAGE" with "LC_ALL")
2021-06-23 12:36:40 +02:00