coreutils

mirror of https://github.com/uutils/coreutils synced 2024-12-27 13:33:22 +00:00

Author	SHA1	Message	Date
Terts Diepraam	dfe0314d8d	Merge pull request #2397 from miDeb/sort/args sort: refactor command line arguments	2021-06-14 12:49:19 +02:00
Terts Diepraam	05c8883b1a	Merge pull request #2395 from miDeb/timeout/cmd-args timeout: handle arguments for the command to run	2021-06-14 12:01:31 +02:00
Michael Debertol	13458b4806	sort: use values_of	2021-06-14 11:39:26 +02:00
Michael Debertol	7acb9373a6	kill: fix signal table printing	2021-06-14 11:10:41 +02:00
Jan Scheer	052202ca19	Merge branch 'master' into id_zero_2351	2021-06-13 11:30:43 +02:00
Jan Scheer	b4c47cc5bd	id: make `id` pass GNU's testssuite for "tests/id/uid.sh" and "tests/id/zero.sh"	2021-06-13 11:12:53 +02:00
Jan Scheer	9af9343745	uucore: entries: add documentation	2021-06-13 10:12:00 +02:00
Anup Mahindre	da7b02cf9d	du: Refactor threshold handling	2021-06-12 23:12:44 +05:30
Anup Mahindre	d6181ce7d4	du: Add threshold argument support - Add --threshold parameter and corresponding logic to skip listing entires that don't adhere to the threshold	2021-06-12 19:56:05 +05:30
Hanif Bin Ariffin	083e745976	Simplified page down implementation Signed-off-by: Hanif Bin Ariffin <hanif.ariffin.4326@gmail.com>	2021-06-12 20:34:21 +08:00
Hanif Bin Ariffin	9ed5091be6	Fixed hanging with smaller content Using 'seq 10 \| cargo run -- more' should no longer hangs. Signed-off-by: Hanif Bin Ariffin <hanif.ariffin.4326@gmail.com>	2021-06-12 20:30:15 +08:00
Michael Debertol	af6e92e012	Merge branch 'master' of https://github.com/uutils/coreutils into sort/args	2021-06-12 13:16:46 +02:00
Michael Debertol	a69c2d52f9	Merge branch 'master' of https://github.com/uutils/coreutils into timeout/cmd-args	2021-06-12 13:14:16 +02:00
Michael Debertol	a57313f01b	core: represent signal values by their index	2021-06-12 13:12:15 +02:00
Hanif Bin Ariffin	28c6fad6e3	Now displays the unknown key entered Signed-off-by: Hanif Bin Ariffin <hanif.ariffin.4326@gmail.com>	2021-06-12 18:25:14 +08:00
Hanif Bin Ariffin	ee6419f11c	Fixing display when resizing terminal Signed-off-by: Hanif Bin Ariffin <hanif.ariffin.4326@gmail.com>	2021-06-12 18:11:12 +08:00
Hanif Bin Ariffin	63ee42826b	Fixed numeric type 1. Its better to bump u16 to usize than the other way round. 2. Highly unlikely to have a terminal with usize rows...makes making sense of the code easier. Signed-off-by: Hanif Bin Ariffin <hanif.ariffin.4326@gmail.com>	2021-06-12 18:02:31 +08:00
Hanif Bin Ariffin	b335e7f2ae	Now stops at the last line first. Press down again to go to next file or quit Signed-off-by: Hanif Bin Ariffin <hanif.ariffin.4326@gmail.com>	2021-06-12 17:57:35 +08:00
Terts Diepraam	440eba628c	Merge pull request #2338 from miDeb/ln/dst-symlink ln: canonicalize the parent directory of the destination, not the destination itself	2021-06-12 11:28:19 +02:00
Terts Diepraam	8afc923796	Merge pull request #2237 from wfscheper/wfscheper/issue2118 chgrp: replace getopts with clap (#2118)	2021-06-12 11:20:24 +02:00
Terts Diepraam	7f754dc1a5	Merge pull request #2382 from tertsdiepraam/more/rewrite-drawing-logic `more`: rewrite drawing logic	2021-06-12 11:12:29 +02:00
Jan Scheer	39f5f70f2b	Merge branch 'master' into refactoring_parse_size	2021-06-12 02:24:07 +02:00
Tyler	fc110bb656	Implements status=LEVEL - Adds print fn's - Modifies internal fn's as needed to track read/write state - Modifies status update thread to respect status level - Adds signal handler for SIGUSR1 (print xfer stats)	2021-06-11 17:00:25 -07:00
Terts Diepraam	b7460a61a9	Merge pull request #2398 from youknowone/err-return clean up returning Err	2021-06-12 00:14:28 +02:00
Michael Debertol	b8d4411291	sort: fix ignore-leading-blanks long option	2021-06-11 20:46:23 +02:00
Michael Debertol	fb035aa049	sort: allow --check=<value> syntax * --check=silent and --check=quiet, which are equivalent to -C. * --check=diagnose-first, which is the same as --check We also allow -c=<value>, which confuses GNU sort.	2021-06-11 20:46:23 +02:00
Michael Debertol	cc0df6ea43	sort: move options to the `options` module Be more consistent with other utilities	2021-06-11 20:46:23 +02:00
Michael Debertol	f909751155	timeout: don't kill the process if -k is not set `timeout` used to set the timeout to 0 when -k was not set. This collided with the behavior of 0 timeouts, which disable the timeout. When -k is not set the process should not be killed.	2021-06-11 20:44:25 +02:00
Terts Diepraam	ddb196dd1d	chgrp: fix clippy and spell-check warnings	2021-06-11 17:24:12 +02:00
Jeong YunWon	6734d5df93	basename: trim separators with function	2021-06-11 23:35:15 +09:00
Jeong YunWon	6003d95974	comm: clean up line-end check	2021-06-11 23:35:15 +09:00
Jeong YunWon	9e8be3093f	chown: clean up parse_spec	2021-06-11 23:27:09 +09:00
Jeong YunWon	e985131c83	uucore: remove unused warning of sort_groups	2021-06-11 23:26:58 +09:00
Jeong YunWon	fb67e54e20	uucore: clean up returning Err	2021-06-11 23:26:58 +09:00
Jeong YunWon	b59c1dae59	stdbuf: clean up returning Err	2021-06-11 23:26:58 +09:00
Jeong YunWon	9c56a40bcb	shuf: clean up returning Err	2021-06-11 23:26:58 +09:00
Jeong YunWon	2dd9822d57	rmdir: clean up returning Err	2021-06-11 23:26:58 +09:00
Jeong YunWon	7cc4bf6e36	pr: clean up returning Err	2021-06-11 23:26:58 +09:00
Jeong YunWon	e45f5404db	nl: fix clippy error	2021-06-11 23:26:58 +09:00
Jeong YunWon	3ea18173cb	od: clean up returning Err	2021-06-11 23:26:58 +09:00
Jeong YunWon	d329c7c864	install : clean up returning Err	2021-06-11 23:26:58 +09:00
Jeong YunWon	27ce4bb0a4	head: clean up returning Err	2021-06-11 23:26:58 +09:00
Jeong YunWon	bbae78db67	expr: clean up returning Err	2021-06-11 23:26:58 +09:00
Jeong YunWon	f01121f5b7	env: clean up returning Err	2021-06-11 23:26:58 +09:00
Jeong YunWon	6736faec4a	csplit: clean up returning Err	2021-06-11 23:26:58 +09:00
Jeong YunWon	7cc17c15c2	cp: clean up returning Err	2021-06-11 23:26:58 +09:00
Jeong YunWon	526ed7afdc	cksum: clean up returning Err	2021-06-11 23:26:58 +09:00
Jeong YunWon	a197d35039	chown: clean up returning Err	2021-06-11 23:26:58 +09:00
Jeong YunWon	c5594bc9bc	base32: clean up returning Err	2021-06-11 23:26:58 +09:00
Terts Diepraam	4abe4c4ac5	Merge branch 'master' into more/rewrite-drawing-logic	2021-06-11 14:03:11 +02:00
Terts Diepraam	f104f8868c	Merge pull request #2356 from syukronrm/du-x du: add `--one-file-system`	2021-06-11 13:51:28 +02:00
Terts Diepraam	960828ba70	Merge pull request #2376 from deantvv/more-option-d more: Implement option '-d'	2021-06-11 13:49:13 +02:00
Syukron Rifail M	0c364e635b	du: add --one-file-system	2021-06-11 16:18:57 +07:00
Walter Scheper	cff75f242a	chgrp: replace getopts with clap (#2118 )	2021-06-10 16:38:44 -04:00
Michael Debertol	32f5e8baf8	Merge branch 'master' of https://github.com/uutils/coreutils into ln/dst-symlink	2021-06-10 21:48:43 +02:00
Yagiz Degirmenci	3347dacfc8	chroot: refactor undocumented features (#2365 )	2021-06-10 21:46:17 +02:00
Sylvestre Ledru	e35cafd2f2	Merge pull request #2370 from tertsdiepraam/ln/update-arg-handling `ln`: refactor argument handling and fix #2359	2021-06-10 21:39:43 +02:00
Sylvestre Ledru	d79268de05	Merge pull request #2374 from tertsdiepraam/who/cleanup-arg-handling `who`: cleanup argument handling	2021-06-10 21:38:11 +02:00
Sylvestre Ledru	be9104b084	Merge pull request #2383 from tertsdiepraam/whoami/use-winapi `whoami`: remove `advapi32-sys` dependency and use `winapi`	2021-06-10 21:34:50 +02:00
Sylvestre Ledru	667af7ea16	Merge pull request #2388 from youknowone/du-winapi du winapi dependency only for windows	2021-06-10 21:31:08 +02:00
Sylvestre Ledru	de6829fec3	Merge pull request #2390 from youknowone/tr-reuse-chars tr parse_sequence reuses chars iterator	2021-06-10 21:30:28 +02:00
Sylvestre Ledru	cadd7810ef	Merge pull request #2393 from youknowone/pathchk bytes operation for pathchk	2021-06-10 21:30:14 +02:00
Jeong YunWon	0a1dcc27bb	prevent utf8 iteration for ascii str from shred (#2389 )	2021-06-10 21:29:56 +02:00
Sylvestre Ledru	c6d8932698	Merge pull request #2392 from youknowone/tail Remove unnessassary chars() and unwrap_or() from tail	2021-06-10 21:28:58 +02:00
Sylvestre Ledru	249ac23aab	Merge pull request #2394 from youknowone/cleanup-trivial clean up to remove unnessessary unwraps and to use ? operators	2021-06-10 21:28:37 +02:00
Michael Debertol	b4efd5a749	timeout: disable pre-existing SIGCHLD handlers Needed to make a GNU test pass	2021-06-10 21:24:43 +02:00
Michael Debertol	0f9bc8e974	timeout: disable timeout if it is set to zero	2021-06-10 21:24:43 +02:00
Michael Debertol	8e0ed2d20e	timeout: support --verbose	2021-06-10 21:24:43 +02:00
Michael Debertol	b0b937dc3e	core: add signal name lookup by value	2021-06-10 21:24:43 +02:00
Michael Debertol	ceb5a2998c	core: add EXIT signal EXIT is supported by GNU (see `993ca832d2/lib/sig2str.c (L258)`), so we have to support it too to pass GNU tests.	2021-06-10 18:28:37 +02:00
Michael Debertol	ed646090c2	timeout: fix usage string	2021-06-10 17:03:39 +02:00
Michael Debertol	c5d7cbda32	timeout: handle arguments for the command to run To prevent clap from parsing flags for the command to run as flags for timeout, remove the "args" positional argument, but allow to pass flags via the "command" positional arg.	2021-06-10 17:03:32 +02:00
Michael Debertol	5997853cc4	Merge branch 'master' of https://github.com/uutils/coreutils into ln/dst-symlink	2021-06-10 16:06:32 +02:00
Sylvestre Ledru	3e8c009a50	Merge pull request #2379 from youknowone/rotate get_groups_gnu sort with rotate_right	2021-06-10 16:05:54 +02:00
Dean Li	dc57e1535e	more: Implement option '-d' Implement option '-d' (silent mode) Related to #2320	2021-06-10 19:34:21 +08:00
Jeong YunWon	8433c7726d	tr parse_sequence reuses chars iterator	2021-06-10 19:16:55 +09:00
Jeong YunWon	b9611b71ee	use ? operator for od	2021-06-10 18:39:48 +09:00
Jeong YunWon	b21d189fcf	Remove trivially unnessessary unwrap() pr	2021-06-10 18:39:48 +09:00
Jeong YunWon	cc6c2f64b1	clean up fold, hashsum, kill, nl, printf, truncate	2021-06-10 18:39:48 +09:00
Jeong YunWon	3ee09fa783	only matches Some() in match	2021-06-10 18:39:11 +09:00
Jeong YunWon	1fecd98ebe	bytes operation for pathchk	2021-06-10 18:30:45 +09:00
Jeong YunWon	e3197bea39	dircolor purify forward match '#'	2021-06-10 18:14:23 +09:00
Jeong YunWon	8a03ac6caa	Prevent double scanning from dircolors	2021-06-10 18:08:54 +09:00
Jeong YunWon	357886b599	Remove unnessassary chars() and unwrap_or() from tail	2021-06-10 18:06:40 +09:00
Terts Diepraam	96dffc8700	Merge pull request #2384 from sylvestre/getopt remove a legacy declaration to getopt	2021-06-10 10:45:16 +02:00
Jeong YunWon	9c6750252d	du winapi dependency only for windows	2021-06-10 15:07:46 +09:00
Jeong YunWon	ded92dbca0	clean up fold, hashsum, kill	2021-06-10 13:11:36 +09:00
Jeong YunWon	1ac4eb171e	move cmode rather than mut	2021-06-10 13:11:36 +09:00
Jeong YunWon	797c4a340e	Remove trivially unnessessary unwrap() from od	2021-06-10 13:11:36 +09:00
Jeong YunWon	da9558c684	Remove trivially unnessessary unwrap() from expr	2021-06-10 13:11:36 +09:00
Jeong YunWon	774c01f008	Remove trivially unnessessary unwrap() from du	2021-06-10 13:11:36 +09:00
Jeong YunWon	3eae399ec4	Remove trivially unnessessary unwrap() from base32/64	2021-06-10 13:11:36 +09:00
Jeong YunWon	23f655e2a5	Use inclusive range Co-authored-by: Michael Debertol <michael.debertol@gmail.com>	2021-06-10 11:15:01 +09:00
Jan Scheer	00c05b8687	id: add error handling (stderr/exit_code) for '-ugG'	2021-06-10 00:19:23 +02:00
Sylvestre Ledru	6d7d57e13c	remove a legacy declaration to getopt	2021-06-09 22:58:50 +02:00
Jan Scheer	026570ff9c	id: add more tests for '--zero' * fix clippy warnings	2021-06-09 22:45:39 +02:00
Sylvestre Ledru	393164f4a7	Merge pull request #2377 from tertsdiepraam/use-atty `cat`/`cut`/`tty`/`nohup`: replace `is_std{in, out, err}_interactive` with atty	2021-06-09 22:42:56 +02:00
Terts Diepraam	44f6dc6098	whoami: remove advapi32-sys dependency	2021-06-09 22:10:28 +02:00
Terts Diepraam	e73743eb0d	more: simpler page_down	2021-06-09 21:56:32 +02:00
Terts Diepraam	40720dc52d	more: rewrite drawing logic	2021-06-09 21:00:48 +02:00
Jeong YunWon	cebf1f09df	get_groups_gnu sort with rotate_right	2021-06-10 01:56:48 +09:00
Jeong YunWon	7009cb0486	Add "process" dependency to groups/Cargo.toml	2021-06-10 01:07:01 +09:00
Terts Diepraam	be8e5f5f30	use the same spec for atty everywhere	2021-06-09 17:15:42 +02:00
Terts Diepraam	394eb82af1	cat/cut/tty/nohup: replace is_std{in, out, err}_interactive with atty	2021-06-09 17:12:03 +02:00
Jeong YunWon	f40f9fbf91	Fix build when not(feature = "process")	2021-06-09 23:51:04 +09:00
Jan Scheer	1b824f4914	fix clippy warnings	2021-06-09 15:56:29 +02:00
Terts Diepraam	3818e54415	who: cleanup argument handling	2021-06-09 14:34:37 +02:00
Jan Scheer	be8650278b	Merge branch 'master' into refactoring_parse_size	2021-06-09 13:44:40 +02:00
Tyler	a511db504b	Minor optimization in calculation of lcm for internal r/w buffer.	2021-06-08 14:33:48 -07:00
Jan Scheer	babf6ecae4	Merge branch 'master' into id_zero_2351	2021-06-08 23:22:29 +02:00
Tyler	96fd665ce1	Implements internal read/write buffer optimization - Spoiler Alert: Turns out it was just the lcm.	2021-06-08 14:14:19 -07:00
Sylvestre Ledru	4471335609	Merge pull request #2360 from rivy/fix+rf build and lots of clippy fixes	2021-06-08 22:06:11 +02:00
Tyler	ef6c850833	Adds additional conv=sync test for short reads.	2021-06-08 12:37:03 -07:00
Jan Scheer	26ad05cbb4	uucore: fix order of group IDs returned from entries::get_groups() As discussed here: https://github.com/uutils/coreutils/pull/2361 the group IDs returned for GNU's 'group' and GNU's 'id --groups' starts with the effective group ID. This implements a wrapper for `entris::get_groups()` which mimics GNU's behaviour. * add tests for `id` * add tests for `groups` * fix `id --groups --real` to no longer ignore `--real`	2021-06-08 18:39:05 +02:00
Tyler	841faebdac	Impl conv=sync - Adds tests where ibs causes extention - Impl conv=sync. All tests passing.	2021-06-07 16:13:46 -07:00
Terts Diepraam	448caa3d1c	ln: refactor argument handling	2021-06-07 14:53:18 +02:00
Jan Scheer	98225105af	id: implement '--zero' flag * add tests for '--zero' flag * add a bunch of requires/conflicts rules for flags (incl. tests)	2021-06-07 14:35:13 +02:00
Roy Ivy III	423f4f9bf1	fix/cp ~ correct `cargo clippy` complaint exception (allow clippy::unnecessary_wraps)	2021-06-06 19:28:25 -05:00
Roy Ivy III	3f0ac06122	refactor/od ~ fix `cargo clippy` complaint (allow clippy::enum_variant_names)	2021-06-06 19:28:25 -05:00
Roy Ivy III	8f0d42da39	refactor/wc ~ fix `cargo clippy` complaint (clippy::needless_borrow)	2021-06-06 19:28:24 -05:00
Roy Ivy III	a8a2b3ec84	refactor/timeout ~ fix `cargo clippy` complaint (clippy::needless_borrow)	2021-06-06 19:28:24 -05:00
Roy Ivy III	6e98ea78ac	refactor/stdbuf ~ fix `cargo clippy` complaint (clippy::needless_borrow)	2021-06-06 19:28:24 -05:00
Roy Ivy III	c8c14ca40c	refactor/stat ~ fix `cargo clippy` complaint (clippy::needless_borrow)	2021-06-06 19:28:24 -05:00
Roy Ivy III	79a33728ca	refactor/split ~ fix `cargo clippy` complaint (clippy::needless_borrow)	2021-06-06 19:28:24 -05:00
Roy Ivy III	39dbcda66e	refactor/sort ~ fix `cargo clippy` complaint (clippy::needless_borrow)	2021-06-06 19:28:24 -05:00
Roy Ivy III	08713d22ec	refactor/shred ~ fix `cargo clippy` complaint (clippy::needless_borrow)	2021-06-06 19:28:24 -05:00
Roy Ivy III	2f7c488425	refactor/rmdir ~ fix `cargo clippy` complaint (clippy::needless_borrow)	2021-06-06 19:28:24 -05:00
Roy Ivy III	84e08cd071	refactor/ptx ~ fix `cargo clippy` complaint (clippy::needless_borrow)	2021-06-06 19:28:24 -05:00
Roy Ivy III	750b68a44c	refactor/printf ~ fix `cargo clippy` complaint (clippy::needless_borrow)	2021-06-06 19:28:24 -05:00
Roy Ivy III	ad486a77dc	refactor/pr ~ fix `cargo clippy` complaint (clippy::needless_borrow)	2021-06-06 19:28:24 -05:00
Roy Ivy III	f7028c4175	refactor/pinky ~ fix `cargo clippy` complaint (clippy::needless_borrow)	2021-06-06 19:28:24 -05:00
Roy Ivy III	02f35c8965	refactor/pathchk ~ fix `cargo clippy` complaint (clippy::needless_borrow)	2021-06-06 19:28:24 -05:00
Roy Ivy III	b3dd80d39c	refactor/printf ~ fix `cargo clippy` complaint (clippy::needless_borrow)	2021-06-06 19:28:24 -05:00
Roy Ivy III	94f5011662	refactor/od ~ fix `cargo clippy` complaint (clippy::needless_borrow)	2021-06-06 19:28:24 -05:00
Roy Ivy III	63112783b2	refactor/numfmt ~ fix `cargo clippy` complaint (clippy::needless_borrow)	2021-06-06 19:28:24 -05:00
Roy Ivy III	ca50eae003	refactor/mv ~ fix `cargo clippy` complaint (clippy::needless_borrow)	2021-06-06 19:28:23 -05:00
Roy Ivy III	768b343ff9	refactor/mktemp ~ fix `cargo clippy` complaint (clippy::needless_borrow)	2021-06-06 19:28:23 -05:00
Roy Ivy III	5889d81fde	refactor/mkfifo ~ fix `cargo clippy` complaint (clippy::needless_borrow)	2021-06-06 19:28:23 -05:00
Roy Ivy III	380e28dde5	refactor/mkdir ~ fix `cargo clippy` complaint (clippy::needless_borrow)	2021-06-06 19:28:23 -05:00
Roy Ivy III	99fae850ae	refactor/ls ~ fix `cargo clippy` complaint (clippy::needless_borrow)	2021-06-06 19:28:23 -05:00
Roy Ivy III	e8e28f1508	refactor/ln ~ fix `cargo clippy` complaint (clippy::needless_borrow)	2021-06-06 19:28:23 -05:00
Roy Ivy III	4a09c72fe7	refactor/join ~ fix `cargo clippy` complaint (clippy::needless_borrow)	2021-06-06 19:28:23 -05:00
Roy Ivy III	c66d67a0b9	refactor/install ~ fix `cargo clippy` complaint (clippy::needless_borrow)	2021-06-06 19:28:23 -05:00
Roy Ivy III	9f2cb2e5e9	refactor/hashsum ~ fix `cargo clippy` complaint (clippy::needless_borrow)	2021-06-06 19:28:23 -05:00
Roy Ivy III	2bf06c3104	refactor/fold ~ fix `cargo clippy` complaint (clippy::needless_borrow)	2021-06-06 19:28:23 -05:00
Roy Ivy III	28e176cbba	refactor/expr ~ fix `cargo clippy` complaint (clippy::needless_borrow)	2021-06-06 19:28:23 -05:00
Roy Ivy III	489f9e8386	refactor/expand ~ fix `cargo clippy` complaint (clippy::manual_str_repeat)	2021-06-06 19:28:23 -05:00
Roy Ivy III	122d82e835	refactor/expand ~ fix `cargo clippy` complaint (clippy::needless_borrow)	2021-06-06 19:28:23 -05:00
Roy Ivy III	9964a21fe3	refactor/env ~ fix `cargo clippy` complaint (clippy::needless_borrow)	2021-06-06 19:28:23 -05:00
Roy Ivy III	b08c568748	refactor/echo ~ fix `cargo clippy` complaint (clippy::needless_borrow)	2021-06-06 19:28:23 -05:00
Roy Ivy III	3409dc93e3	refactor/du ~ fix `cargo clippy` complaint (clippy::needless_borrow)	2021-06-06 19:28:23 -05:00
Roy Ivy III	14bb9ec616	refactor/csplit ~ fix `cargo clippy` complaint (clippy::needless_borrow)	2021-06-06 19:28:22 -05:00
Roy Ivy III	1e418e8d84	refactor/chroot ~ fix `cargo clippy` complaint (clippy::needless_borrow)	2021-06-06 19:28:22 -05:00
Roy Ivy III	baa656ca8a	refactor/chown ~ fix `cargo clippy` complaint (clippy::needless_borrow)	2021-06-06 19:28:22 -05:00
Roy Ivy III	35b360b8e4	refactor/chmod ~ fix `cargo clippy` complaint (clippy::needless_borrow)	2021-06-06 19:28:22 -05:00
Roy Ivy III	c115ad4274	refactor/cat ~ fix `cargo clippy` complaint (clippy::needless_borrow)	2021-06-06 19:28:22 -05:00
Roy Ivy III	777e3906f8	refactor/basename ~ fix `cargo clippy` complaint (clippy::needless_borrow)	2021-06-06 19:28:22 -05:00
Roy Ivy III	f5e2daa056	refactor/uucore ~ fix `cargo clippy` complaint (clippy::needless_borrow)	2021-06-06 19:28:22 -05:00
Roy Ivy III	c192550f22	refactor ~ polish spelling + add spelling exceptions	2021-06-06 19:28:22 -05:00
Roy Ivy III	1ef820212c	refactor/rm ~ fix `cargo clippy` warning (clippy::upper_case_acronyms)	2021-06-06 19:17:18 -05:00
Roy Ivy III	3cfb956684	refactor/du ~ fix `cargo clippy` warning (clippy::ptr_arg)	2021-06-06 19:17:18 -05:00
Jan Scheer	12de58aec0	Merge branch 'master' of github.com:uutils/coreutils into refactoring_parse_size	2021-06-06 22:54:02 +02:00
Jan Scheer	884f570125	du/od/sort: refactor - replace map_or_else with unwrap_or_else	2021-06-06 21:55:39 +02:00
Sylvestre Ledru	a3b520abde	Merge pull request #2363 from sylvestre/doc-hashsum hashsum: document how to benchmark blake2	2021-06-06 21:28:23 +02:00
Michael Debertol	d6da143c4e	sort: ignore errors when waiting for child	2021-06-06 19:53:28 +02:00
Michael Debertol	7c9da82b39	sort: implement --batch-size	2021-06-06 18:01:08 +02:00
Michael Debertol	8d213219c7	sort: implement --compress-program	2021-06-06 18:01:08 +02:00
Michael Debertol	5a5c7c5a34	sort: properly check for empty reads	2021-06-06 18:01:08 +02:00
Michael Debertol	66359a0f56	sort: insert line separators after non-empty files If files don't end witht a line separator we have to insert one, otherwise the last line will be combined with the first line of the next file.	2021-06-06 18:01:08 +02:00
Michael Debertol	2dd6824e76	sort: never use a bigger buffer than requested A min buffer size of 8KB makes sense in practice, but decreases testability.	2021-06-06 18:01:08 +02:00
Sylvestre Ledru	7f07bd82d4	hashsum: document how to benchmark blake2	2021-06-06 13:26:45 +02:00
Sylvestre Ledru	27456fc8fb	Merge pull request #2296 from oconnor663/blake2b_simd switch from blake2-rfc to blake2b_simd	2021-06-06 13:14:39 +02:00
Terts Diepraam	6324df890f	Merge pull request #2357 from deantvv/more-show-next-file more: Show next file at bottom line	2021-06-06 10:52:03 +02:00
Dean Li	b9fe76ab92	more: Show next file at bottom line Implement feature requested in #2318.	2021-06-06 09:26:47 +08:00
Jan Scheer	74a7da7b52	id: clean-up of clap options and usage/help text * add conflicts_with for '-G' * add required flags for '-r' and '-n' * add usage/help texts from BSD's `id`	2021-06-05 20:43:12 +02:00
Sylvestre Ledru	9ae3c7634c	Merge pull request #2354 from tertsdiepraam/more/fix-not-showing-last-line `more`: Do not accidentically hide last line	2021-06-05 16:05:43 +02:00
Terts Diepraam	2760efb01d	more: fix test	2021-06-05 14:42:43 +02:00
Terts Diepraam	420e9322ea	more: do not accidentically hide last line	2021-06-05 14:07:09 +02:00
Sylvestre Ledru	285b27c9b3	du: add --app as alias of --apparent-size to match GNU	2021-06-05 11:04:42 +02:00
Sylvestre Ledru	4143e3f54f	Merge pull request #2332 from mitchellmebane/dircolors-clap dircolors: replace getopts with clap	2021-06-05 10:12:57 +02:00
Tyler	f7eaf96eda	Fixes bugs. Prepares for conv=sync - Splits read fn into conv=sync and standard (consecutive) versions. - Fixes bug in previous read/fill where short reads would copy to wrong position in output buffer. - Fixes bug in unit tests. Empty source would pass (since no bytes failed to match).	2021-06-04 11:29:41 -07:00
Sylvestre Ledru	9712ecb4d5	Merge pull request #2340 from deantvv/more-unicode more: fix unicode bug	2021-06-04 19:51:32 +02:00
Michael Debertol	e7fa6715a7	Merge branch 'master' of https://github.com/uutils/coreutils into ln/dst-symlink	2021-06-04 19:42:19 +02:00
Dean Li	acd290d11f	more: fix unicode bug for breakline - Use `unicode_segmentation` and `unicode_width` to determine proper `break_line` position. - Keep track of total_width as suggested by @tertsdiepraam. - Add unittest for ZWJ unicode case Related to #2319.	2021-06-04 22:06:27 +08:00
Jan Scheer	f8e96150f8	fix clippy warnings and spelling * add some missing LICENSE headers	2021-06-04 15:39:34 +02:00
Mitchell Mebane	754082886c	dircolors: Address code review comments	2021-06-03 20:49:25 -05:00
Jan Scheer	130bf49e5d	Merge branch 'master' of github.com:uutils/coreutils into refactoring_parse_size	2021-06-03 22:32:34 +02:00
Sylvestre Ledru	6a8d15f92e	gnu/rm: match gnu's output	2021-06-03 22:19:14 +02:00
Jan Scheer	db3ee61742	du/sort/od/stdbuf: make error handling of SIZE/BYTES/MODE arguments more consistent * od: add stderr info for not yet implemented '--strings' flag	2021-06-03 21:00:03 +02:00
Jan Scheer	ad26b7a042	head/tail/split: make error handling of NUM/SIZE arguments more consistent * add tests for each flag that takes NUM/SIZE arguments * fix bug in tail where 'quiet' and 'verbose' flags did not override each other POSIX style	2021-06-03 20:37:29 +02:00
Michael Debertol	6c46d09397	ln: canonicalize the parent directory of dst, not dst dst may or may not exist. In case it exists it might already be a symlink. In neither case we should try to canonicalize dst, only its parent directory. https://www.gnu.org/software/coreutils/manual/html_node/ln-invocation.html > Relative symbolic links are generated based on their canonicalized > containing directory, and canonicalized targets.	2021-06-03 19:10:22 +02:00
Michael Debertol	af8f47ea6a	ln: remove redundant check if `dst.exists()` and `settings.overwrite` is `OverwriteMode::Force`, we already delete the file in the match above.	2021-06-03 16:30:45 +02:00
Sylvestre Ledru	841b689477	Merge pull request #2334 from sylvestre/crate_version use crate_version!() instead of reading the env + rustfmt	2021-06-03 10:56:57 +02:00
Sylvestre Ledru	24032498ad	Merge pull request #2339 from sylvestre/gnu-compat Improve the gnu compat and use it for "touch"	2021-06-03 10:53:47 +02:00
Sylvestre Ledru	963a0da0b4	Merge pull request #2288 from syukronrm/du-time du: fix `--time` behavior	2021-06-03 07:56:41 +02:00
Syukron Rifail M	05aeaf3061	du: fix --time behavior	2021-06-03 08:18:23 +07:00
Tyler	787b9696cb	Implements Unblock - Adds unit tests - Implements unblock - All tests passing	2021-06-02 15:11:14 -07:00
Sylvestre Ledru	31875a241f	touch/gnu compat: 'touch no-file' exit code should be 1	2021-06-02 23:50:35 +02:00
Sylvestre Ledru	eb2c06c37e	touch/gnu compat: when touch fails because of a permission error, change the error message + return 1 as error code when having this error	2021-06-02 23:48:16 +02:00
Jan Scheer	5898b99627	truncate: add error handling for SIZE argument * add tests for SIZE argument * fix clap argument handling for --size and --reference	2021-06-02 22:08:42 +02:00
Jan Scheer	2f5f7c6fa1	split: use "parse_size" from uucore * make stderr of parsing SIZE/NUMBER argument consistent with GNU's behavior * add error handling * add tests	2021-06-02 21:32:41 +02:00
Michael Debertol	ed69d797b5	ln: reject --relative without --symbolic	2021-06-02 21:02:12 +02:00
Michael Debertol	87570bbc10	ln: remove redundant `force` flag This information is already encoded in the `OverwriteMode` enum.	2021-06-02 20:56:37 +02:00
Michael Debertol	efa89de463	ln: fix LINK_NAME in help output	2021-06-02 19:58:29 +02:00
Sylvestre Ledru	d8c06dd6bb	use clap::crate_version macro instead of the env variable	2021-06-02 19:00:19 +02:00
Michael Debertol	dfaaa8c787	Merge branch 'master' of https://github.com/uutils/coreutils into cp/close-fd	2021-06-02 11:37:37 +02:00
Sylvestre Ledru	132ddf98b6	Merge pull request #2328 from miDeb/seq/validator seq: reject NaN arguments	2021-06-02 11:20:13 +02:00
Jan Scheer	6b8de1dd8b	sort: use "parse_size" from uucore * make parsing of SIZE argument consistent with GNU's behavior * add error handling * add tests	2021-06-02 05:13:57 +02:00
Mitchell Mebane	850a56ccea	dircolors: rustfmt	2021-06-01 19:22:17 -05:00
Mitchell Mebane	efe1850087	dircolors: replace getopts with clap Port argument parsing from getopts to clap. The only difference I have observed is that clap auto-generates -h and -V short options for help and version, and there is no way (in clap 2.x) to disable them.	2021-06-01 19:22:08 -05:00
Michael Debertol	a323e9cda1	cp: show errors in cow on linux	2021-06-01 23:06:38 +02:00
Jan Scheer	a900c7421a	od: use "parse_size" from uucore	2021-06-01 22:07:29 +02:00
Michael Debertol	23f89d1494	cp: close file descriptors after cow on linux Instead of using into_raw_fd(), which transfers ownership and requires us to close the file descriptor manually, use as_raw_fd(), which does not transfer ownership to us but drops the file descriptor when the original file is dropped (in our case at the end of the function).	2021-06-01 22:04:19 +02:00
Tyler	7bc151d561	Project structure refactor (cont'd) - Move test macros to specific modules.	2021-06-01 13:02:02 -07:00
Tyler	ead3c8c8fc	Project structure refactor. - Unit tests split into individual folders - Parseargs test module renamed unit_tests to match new structure	2021-06-01 12:53:23 -07:00
Tyler	391a175dbb	Fix regression in converison logic.	2021-06-01 12:34:15 -07:00
Tyler	48374ab0a2	Imlements block. All tests passing.	2021-06-01 11:39:18 -07:00
Michael Debertol	5329d77cc2	seq: adapt output to GNU seq	2021-06-01 20:35:18 +02:00
Michael Debertol	9b29ac98a5	seq: reject NaN arguments Move the validation logic to an argument validator.	2021-06-01 18:30:18 +02:00
Michael Debertol	67b83647ac	sort: simplify handling of negative zeros We can simply parse the sign of negative zero as positive, instead of handling the comparison of zeros differently.	2021-06-01 18:20:24 +02:00
Michael Debertol	06b3092f5f	sort: fix debug output for zeros / invalid numbers We were reporting "no match" when sorting something like "0 ". This is because we don't distinguish between 0 and invalid lines when sorting. For debug output we have to get this information back.	2021-06-01 18:18:51 +02:00
Jan Scheer	cc659c8572	Merge branch 'master' of github.com:uutils/coreutils into refactoring_parse_size	2021-06-01 12:35:48 +02:00
Jan Scheer	3c7175f00d	head/tail: add fixes and tests for bytes/lines NUM arg (undocumented sign) * change tail bytes/lines clap parsing to fix posix override behavior * change tail bytes/lines NUM parsing logic to be consistent with head	2021-06-01 12:17:11 +02:00
Sylvestre Ledru	3625d98fc3	Merge pull request #2326 from tertsdiepraam/ls/hide-ignore-help-text `ls`: add help text and value name for `--hide` and `--ignore`	2021-06-01 11:41:39 +02:00
Terts Diepraam	1dc4ab92d9	ls: add help text and value name for --hide and --ignore	2021-06-01 10:27:50 +02:00
Sylvestre Ledru	448c8419d3	Merge pull request #2325 from tertsdiepraam/fix-sum-help-text `sum`: fix help text for System V argument	2021-06-01 10:25:35 +02:00
Jan Scheer	a3e047ff16	uucore: add more tests to parse_size	2021-06-01 10:22:44 +02:00
Terts Diepraam	c1f2d41a27	sum: fix help text for system v argument	2021-06-01 09:54:49 +02:00
Jan Scheer	84f2bff778	head: use "parse_size" from uucore	2021-06-01 09:30:43 +02:00
Sylvestre Ledru	a017c1b589	Merge pull request #2323 from miDeb/maint/spellcheck-all maint: actually run spellcheck on all files	2021-05-31 23:36:56 +02:00
Sylvestre Ledru	8618771f2e	Merge pull request #2322 from miDeb/seq/improvements seq: improve compatibility	2021-05-31 23:09:13 +02:00
Michael Debertol	46470fc607	refactor/rmdir: polish spelling	2021-05-31 22:46:06 +02:00
Michael Debertol	41878f1bf4	refactor/pr: polish spelling	2021-05-31 22:46:01 +02:00
Michael Debertol	4cf18e96f3	seq: change default value for -t and remove dubious escape sequences GNU seq does not support -t, but always outputs a newline at the end. Therefore, our default for -t should be \n. Also removes support for escape sequences (interpreting a literal "\n" as a newline). This is not what GNU seq is doing, and unexpected.	2021-05-31 21:20:19 +02:00
Michael Debertol	c78cc65421	seq: make arguments required Right now seq panics when invoked without args.	2021-05-31 21:20:19 +02:00
Michael Debertol	6ccc305513	seq: implement integer sequences If we notice that we can represent all arguments as BigInts, take a different code path. Just like GNU seq this means we can print an infinite amount of numbers in this case.	2021-05-31 21:20:12 +02:00
Sylvestre Ledru	badf7aacb7	Merge pull request #2300 from tertsdiepraam/pr Implement `pr` (resurrection of the resurrected PR)	2021-05-31 21:14:57 +02:00
Sylvestre Ledru	15da98d84e	Merge pull request #2315 from rivy/maint.fmt+spell Spell check and correct the project	2021-05-31 21:00:04 +02:00
Jan Scheer	8bf1e33b5d	Merge branch 'master' of github.com:uutils/coreutils into refactoring_parse_size * truncate: use "parse_size" from uucore * workaround fix for "test_reference"	2021-05-31 19:11:06 +02:00
Sylvestre Ledru	8d714b0ab0	Merge pull request #2317 from deantvv/fix-touch-parse-date Fix touch parse date error	2021-05-31 18:18:44 +02:00
Dean Li	9d8e7b9acb	Fix touch parse date error Now it can parse `touch -d 2000-01-23 file` and add test for parse date error. Related to #2311	2021-05-31 22:04:03 +08:00
Roy Ivy III	3f35e0a421	refactor ~ `cargo make format`	2021-05-31 08:23:58 -05:00
Roy Ivy III	98aff50d4b	docs/tail ~ fix markdownlint complaints	2021-05-31 08:23:58 -05:00
Roy Ivy III	ceda51dd5c	docs/ls ~ fix spelling + whitespace	2021-05-31 08:23:58 -05:00
Roy Ivy III	1ca44fbbc3	docs/factor ~ fix markdownlint complaints	2021-05-31 08:23:58 -05:00
Roy Ivy III	b418f19c2d	docs/date ~ convert usage text document to a markdown text segment	2021-05-31 08:23:57 -05:00
Roy Ivy III	3fb8a37ace	refactor ~ (bin/coreutils) polish spelling (comments, names, and exceptions)	2021-05-31 08:23:57 -05:00
Roy Ivy III	5c9b474cc8	refactor/whoami ~ polish spelling (comments, names, and exceptions)	2021-05-31 08:23:57 -05:00
Roy Ivy III	dff33a0edb	refactor/wc ~ polish spelling (comments, names, and exceptions)	2021-05-31 08:23:57 -05:00
Roy Ivy III	3d42454ebc	refactor/users ~ polish spelling (comments, names, and exceptions)	2021-05-31 08:23:57 -05:00
Roy Ivy III	40e136d092	refactor/uucore ~ polish spelling (comments, names, and exceptions)	2021-05-31 08:23:57 -05:00
Roy Ivy III	954b3436d9	refactor/truncate ~ polish spelling (comments, names, and exceptions)	2021-05-31 08:23:57 -05:00
Roy Ivy III	f6a079a77f	refactor/timeout ~ polish spelling (comments, names, and exceptions)	2021-05-31 08:23:57 -05:00
Roy Ivy III	b1a2f6e044	refactor/tee ~ polish spelling (comments, names, and exceptions)	2021-05-31 08:23:57 -05:00
Roy Ivy III	879ac263bd	refactor/test ~ polish spelling (comments, names, and exceptions)	2021-05-31 08:23:57 -05:00
Roy Ivy III	8e824742a1	refactor/stat ~ polish spelling (comments, names, and exceptions)	2021-05-31 08:23:57 -05:00
Roy Ivy III	451110bba0	refactor/split ~ polish spelling (comments, names, and exceptions)	2021-05-31 08:23:57 -05:00
Roy Ivy III	00a2e17c80	refactor/splice ~ polish spelling (comments, names, and exceptions)	2021-05-31 08:23:57 -05:00
Roy Ivy III	f8e04c562b	refactor/sort ~ polish spelling (comments, names, and exceptions)	2021-05-31 08:23:57 -05:00
Roy Ivy III	a15f8af99f	refactor/shred ~ polish spelling (comments, names, and exceptions)	2021-05-31 08:23:57 -05:00
Roy Ivy III	13561cb5ae	refactor/ptx ~ polish spelling (comments, names, and exceptions)	2021-05-31 08:23:56 -05:00
Roy Ivy III	324605c78c	refactor/printf ~ polish spelling (comments, names, and exceptions)	2021-05-31 08:23:56 -05:00
Roy Ivy III	aa385cf23c	refactor/od ~ polish spelling (comments, names, and exceptions)	2021-05-31 08:23:56 -05:00
Roy Ivy III	5079972ba6	refactor/nl ~ polish spelling (comments, names, and exceptions)	2021-05-31 08:23:56 -05:00
Roy Ivy III	00c02505a1	refactor/more ~ polish spelling (comments, names, and exceptions)	2021-05-31 08:23:56 -05:00
Terts Diepraam	7690dc018f	Merge branch 'master' into pr	2021-05-31 15:23:06 +02:00
Sylvestre Ledru	13fd02862c	Merge pull request #2316 from deantvv/rmdir-match-gnu-error rmdir: match GNU error output	2021-05-31 15:23:03 +02:00
Jan Scheer	f9a088cecf	du: use "parse_size" from uucore * fix stderr to be the same than GNU's `du` in case of invalid SIZE	2021-05-31 15:22:37 +02:00
Roy Ivy III	57e342d2b2	refactor/mktemp ~ polish spelling (comments, names, and exceptions)	2021-05-31 08:11:32 -05:00
Roy Ivy III	e3784eff47	refactor/mknod ~ polish spelling (comments, names, and exceptions)	2021-05-31 08:11:32 -05:00
Roy Ivy III	5942ba05ef	refactor/ls ~ polish spelling (comments, names, and exceptions)	2021-05-31 08:11:32 -05:00
Roy Ivy III	96faa4efb6	refactor/ln ~ polish spelling (comments, names, and exceptions)	2021-05-31 08:11:32 -05:00
Roy Ivy III	785343db7f	refactor/head ~ polish spelling (comments, names, and exceptions)	2021-05-31 08:11:32 -05:00
Roy Ivy III	a481e8230b	refactor/hashsum ~ polish spelling (comments, names, and exceptions)	2021-05-31 08:11:32 -05:00
Roy Ivy III	1a37d502d1	refactor/factor ~ polish spelling (comments, names, and exceptions)	2021-05-31 08:11:32 -05:00
Roy Ivy III	ba7939e142	refactor/env ~ polish spelling (comments, names, and exceptions)	2021-05-31 08:11:32 -05:00
Roy Ivy III	6e1bd6027a	refactor/du ~ polish spelling (comments, names, and exceptions)	2021-05-31 08:11:32 -05:00
Roy Ivy III	dfe594e918	refactor/date ~ polish spelling (comments, names, and exceptions)	2021-05-31 08:11:32 -05:00
Roy Ivy III	1b1086146b	refactor/cp ~ polish spelling (comments, names, and exceptions)	2021-05-31 08:11:32 -05:00
Roy Ivy III	fc5451b5e7	refactor/cksum ~ polish spelling (comments, names, and exceptions)	2021-05-31 08:11:32 -05:00
Roy Ivy III	43f5c13a7f	refactor/chmod ~ polish spelling (comments, names, and exceptions)	2021-05-31 08:11:31 -05:00
Roy Ivy III	48e509546a	refactor/uucore ~ polish spelling (comments, names, and exceptions)	2021-05-31 08:11:31 -05:00
Roy Ivy III	9c0c8eb59f	change ~ remove 'main.rs' spell-checker exceptions	2021-05-31 08:11:31 -05:00
Terts Diepraam	77a0a077b8	pr: update dependencies	2021-05-31 14:48:12 +02:00
Dean Li	9f1deb2df6	rmdir: match GNU error output Related to #2258	2021-05-31 19:30:54 +08:00
Sylvestre Ledru	8c5dcd0765	Merge branch 'master' into implement-more	2021-05-31 10:17:15 +02:00
Jan Scheer	3a6605844f	uucore: move 'parse_time' to 'parser' "parse_time" only uses stdlib and does not need to be feature gated. A more suitable place is the newly created "src/uucore/src/lib/parser/"	2021-05-31 09:54:31 +02:00
Jan Scheer	1c41efd732	stdbuf: use "parse_size" from uucore	2021-05-31 09:35:46 +02:00
Anup Mahindre	898d325aea	ls: Fix minor output mismatch When a single directory is passed to ls in recursive mode, uutils ls won't print the directory name ====================== GNU ls: z: ====================== ====================== uutils ls: ====================== This commit fixes this minor inconsistency and adds corresponding test.	2021-05-30 18:00:52 +05:30
Sylvestre Ledru	3913731222	Revert "rmdir: match GNU error output"	2021-05-30 09:55:02 +02:00
Sylvestre Ledru	13b2a4afd3	Merge branch 'master' into blake2b_simd	2021-05-30 09:29:40 +02:00
Sylvestre Ledru	83bb8795bd	add a comment to explain the why	2021-05-30 09:16:46 +02:00
Dean Li	5b417e251d	rmdir: match GNU error output Related to #2258	2021-05-30 10:45:54 +08:00
Terts Diepraam	f9bc80e42c	pr: remove comments that are obvious through types	2021-05-30 00:35:40 +02:00
Terts Diepraam	a54fc7a4ba	pr: remove unused asref implementations	2021-05-30 00:28:44 +02:00
Tyler	f2fa1e1be1	Adds additional test resources & unit tests for block.	2021-05-29 15:22:42 -07:00
Michael Debertol	dc63133f14	sort: correctly inherit global flags for keys (#2302 ) Closes #2254. We should only inherit global settings for keys when there are absolutely no options attached to the key. The default key (matching the whole line) is implicitly added only if no keys are supplied. Improved some error messages by including more context.	2021-05-29 23:25:56 +02:00
Michael Debertol	d821719c67	expr: support arbitrary precision integers (#2271 ) * expr: support arbitrary precision integers Instead of i64s we now use BigInts for integer operations. This means that no result or input can be out of range. The representation of integer flags was changed from i64 to u8 to make their intention clearer. * expr: allow big numbers as arguments as well Also adds some tests * expr: use num-traits to check bigints for 0 and 1 * expr: remove obsolete refs match ergonomics made these avoidable. * formatting Co-authored-by: Sylvestre Ledru <sylvestre@debian.org>	2021-05-29 23:25:23 +02:00
Terts Diepraam	bc1870c0a7	Merge branch 'master' into pr	2021-05-29 19:21:31 +02:00
Terts Diepraam	4744b35796	pr: explicit none in match expressions	2021-05-29 19:09:50 +02:00
Terts Diepraam	2e1035b350	pr: static to const	2021-05-29 19:02:42 +02:00
Terts Diepraam	0913a77667	pr: let type inference do its works	2021-05-29 19:01:39 +02:00
Terts Diepraam	12287fcc9c	pr: fix clippy lints	2021-05-29 18:44:12 +02:00
Jeffrey Finkelstein	0999b00ff9	truncate: re-organize into one func for each mode Reorganize the code in `truncate.rs` into three distinct functions representing the three modes of operation of the `truncate` program. The three modes are - `truncate -r RFILE FILE`, which sets the length of `FILE` to match the length of `RFILE`, - `truncate -r RFILE -s NUM FILE`, which sets the length of `FILE` relative to the given `RFILE`, - `truncate -s NUM FILE`, which sets the length of `FILE` either absolutely or relative to its curent length. This organization of the code makes it more concise and easier to follow.	2021-05-29 15:11:27 +02:00
Jeffrey Finkelstein	5129114ddc	truncate: create TruncateMode::to_size() method Create a method that computes the final target size in bytes for the file to truncate, given the reference file size and the parameter to the `TruncateMode`.	2021-05-29 15:11:27 +02:00
Jeffrey Finkelstein	005bc259da	truncate: add parse_mode_and_size() helper func Add a helper function to contain the code for parsing the size and the modifier symbol, if any. This commit also changes the `TruncateMode` enum so that the parameter for each "mode" is stored along with the enumeration value. This is because the parameter has a different meaning in each mode.	2021-05-29 15:11:27 +02:00
Jeffrey Finkelstein	b898e54d7a	truncate: remove read permissions from OpenOptions Remove "read" permissions from the `OpenOptions` when opening a new file just to truncate it. We will never read from the file, only write to it. (Specifically, we will only call `File::set_len()`.)	2021-05-29 15:11:27 +02:00
Gilad Naaman	17b0939dee	Moved factor to use clap Issue: https://github.com/uutils/coreutils/issues/2121	2021-05-29 15:11:27 +02:00
Jan Scheer	e4aa8ee159	users: fix long_help text and clippy warning	2021-05-29 15:11:27 +02:00
Jan Scheer	3aeccfd802	fix a lot of clippy warnings	2021-05-29 15:11:22 +02:00
Terts Diepraam	d94ee87d15	pr: move options into mod	2021-05-29 14:42:24 +02:00
Terts Diepraam	0487360507	pr: make tests compile again	2021-05-29 14:30:30 +02:00
Terts Diepraam	762da0bd37	more: comment out unimplemented arguments	2021-05-29 12:51:47 +02:00
Terts Diepraam	9d17c1fddf	more: add todo for unicode width	2021-05-29 12:45:12 +02:00
Terts Diepraam	40ee9023e8	more: simplify main loop	2021-05-29 12:42:46 +02:00
Terts Diepraam	101e55702c	more: simplify and fix logic for multiple files	2021-05-29 12:35:03 +02:00
Sylvestre Ledru	3d42d41a72	Merge pull request #2247 from jfinkels/truncate-split-three-functions truncate: re-organize truncate() into one function for each mode of operation	2021-05-29 10:31:02 +02:00
Sylvestre Ledru	0746b3e1e6	Merge pull request #2292 from Gilnaa/2121-factor-clap Moved factor to use clap	2021-05-29 10:30:06 +02:00
Jan Scheer	714661774b	users: fix long_help text and clippy warning	2021-05-29 02:34:43 +02:00
Jan Scheer	a2947f6897	fix clippy warning	2021-05-29 00:46:25 +02:00
Michael Debertol	bb268d1500	sort: crash when failing to open an input file (#2265 ) * sort: crash when failing to open an input file Instead of ignoring files we fail to open, crash. The error message does not exactly match gnu, but that would require more effort. * use split_whitespace instead of a manual implementation * fix expected error on windows * sort: update expected error message	2021-05-28 22:39:33 +02:00
Michael Debertol	e9656a6c32	sort: make GNU test sort-debug-keys pass (#2269 ) * sort: disable support for thousand separators In order to be compatible with GNU, we have to disable thousands separators. GNU does not enable them for the C locale, either. Once we add support for locales we can add this feature back. * sort: delete unused fixtures * sort: compare -0 and 0 equal I must have misunderstood this when implementing, but GNU considers -0, 0, and invalid numbers to be equal. * sort: strip blanks before applying the char index * sort: don't crash when key start is after key end * sort: add "no match" for months at the first non-whitespace char We should put the "^ no match for key" indicator at the first non-whitespace character of a field. * sort: improve support for e notation * sort: use maches! macros	2021-05-28 22:38:29 +02:00
Jan Scheer	0bf14da490	tail: use "parse_size" from uucore	2021-05-28 22:21:03 +02:00
Jan Scheer	b1b3475e11	truncate: use "parse_size" from uucore	2021-05-28 22:21:03 +02:00
Jan Scheer	0c502f587b	uucore: add new module "parse_size" This adds a function to parse size strings, e.g. "2KiB" or "3MB". It is based on similar functions used by head/tail/truncate, etc.	2021-05-28 22:20:31 +02:00
Sylvestre Ledru	a2143dcfbf	Merge pull request #2293 from miDeb/maint-minrustv maint: adapt code to new MinRustV	2021-05-28 21:48:51 +02:00
Jack O'Connor	80b9bfdd18	switch from blake2-rfc to blake2b_simd	2021-05-28 14:08:46 -04:00
Sylvestre Ledru	fe42808e9b	Merge branch 'master' into implement-more	2021-05-28 19:49:48 +02:00
Terts Diepraam	0a2f74fd8e	More: update crossterm dependency	2021-05-28 19:43:03 +02:00
Michael Debertol	b5cbd506bc	maint: remove trailing commas from matches Trailing commas are only supported starting from 1.48.	2021-05-28 18:58:06 +02:00
Gilad Naaman	6a9ffee548	Moved factor to use clap Issue: https://github.com/uutils/coreutils/issues/2121	2021-05-28 19:48:28 +03:00
Terts Diepraam	c7930a63f7	Merge pull request #2285 from blesson3/cp-backup-arg-fix cp: fix regressed issue with `--backup` and `-b`	2021-05-28 18:44:09 +02:00
Michael Debertol	a9e0208ee2	maint: remove obsolete attributes	2021-05-28 18:03:47 +02:00
Michael Debertol	59a42f1254	maint: format recent changes	2021-05-28 18:03:47 +02:00
Michael Debertol	263b122540	maint: use the matches! macro when possible	2021-05-28 18:03:37 +02:00
Tyler	d0b4fe34c1	Refactor. Returns code to buildable - Pushes file/stdout specific logic to trait objects. - Extracts read/write helper - Extracts conv/block/unblock helper - Impl block - WIP: Many failing tests!	2021-05-27 15:55:29 -07:00
Terts Diepraam	835a17d79f	mktemp: use tempfile instead of custom tempdir	2021-05-27 22:48:10 +02:00
Terts Diepraam	ebe6341ae3	chore: replace tempdir with tempfile	2021-05-27 22:47:03 +02:00
Matt Blessed	41bea72f23	cp: fix regressed issue with `--backup` and `-b` - add test for regressed issue	2021-05-26 18:29:03 -04:00
Matt Blessed	f11f5f3abb	mv: refactor backup logic to use shared uucore backup control - add mv backup tests	2021-05-26 18:23:48 -04:00
Terts Diepraam	b4f6c81810	Merge pull request #2281 from deantvv/chmod-match-gnu-error chmod: match GNU error	2021-05-26 21:13:05 +02:00
Terts Diepraam	658e52dde0	Merge pull request #2275 from blesson3/cp-backup-support cp: implement backup support	2021-05-26 21:12:01 +02:00
Matt Blessed	25ed5eeb0e	cp: move option check to uumain and use `show_usage_error` - add test for conflicting options `--backup` and `--no-clobber`	2021-05-26 11:10:04 -04:00
Dean Li	fe25b51a66	chmod: match GNU error Related to #2260 Signed-off-by: Dean Li <deantvv@gmail.com>	2021-05-26 22:31:02 +08:00
Terts Diepraam	00dd8d29cb	Merge pull request #2213 from syukronrm/du-clap du: replace getopts with clap	2021-05-26 16:15:36 +02:00
Sylvestre Ledru	c08eae8e9a	Merge pull request #2276 from ycd/clear-macros uucore: delete unused macros	2021-05-26 13:45:30 +02:00
Syukron Rifail M	eda72b5208	du: replace getopts with clap	2021-05-26 11:23:05 +07:00
Matt Blessed	a8a1ec7faf	cp: implement backup control with tests	2021-05-25 23:22:32 -04:00
Matt Blessed	7240b12895	uucore: implement backup control Most of these changes were sourced from mv's existing backup control implementation. A later commit will update the mv utility to use this new share backup control.	2021-05-25 19:44:09 -04:00
Yağız can Değirmenci	898d2eb489	chore: delete 'error:' prefix on show_error	2021-05-26 02:32:02 +03:00
Yağız can Değirmenci	c78a7937f8	chore: delete show_info macro and replace with show_error	2021-05-26 02:27:10 +03:00
Yağız can Değirmenci	a77e92cc96	chore: delete unused macros	2021-05-26 01:53:40 +03:00
Yağız can Değirmenci	e5e7ca8dc5	fix: simplify logic	2021-05-24 21:20:59 +03:00
Yağız can Değirmenci	991fcc548c	fix: log error messages properly on permission errors	2021-05-24 21:07:45 +03:00
Terts Diepraam	da085eca98	Merge pull request #2259 from jfinkels/wc-compute-each-file-and-print wc: print counts for each file as soon as computed	2021-05-24 17:55:10 +02:00
Michael Debertol	218f523e1b	expr: make substr infallible Instead of returning an Err it should return the "null string" (in our case that's the empty string) when the offset or length is invalid.	2021-05-23 22:22:34 +02:00
Sylvestre Ledru	7bf076505f	Merge branch 'master' into who_fix_runlevel	2021-05-23 09:32:37 +02:00
Sylvestre Ledru	b175534a97	Merge pull request #2264 from miDeb/sort-sort-flag sort: support --sort flag and check for conflicts	2021-05-23 09:30:03 +02:00
Sylvestre Ledru	41bd025d00	Merge pull request #2209 from jfinkels/head-ring-buffer head: add abstractions for "all but last n lines"	2021-05-23 09:28:17 +02:00
Jeffrey Finkelstein	bc9db289e8	head: add abstractions for "all but last n lines" Add some abstractions to simplify the `rbuf_but_last_n_lines()` function, which implements the "take all but the last `n` lines" functionality of the `head` program. This commit adds - `RingBuffer`, a fixed-size ring buffer, - `ZLines`, an iterator over zero-terminated "lines", - `TakeAllBut`, an iterator over all but the last `n` elements of an iterator. These three together make the implementation of `rbuf_but_last_n_lines()` concise.	2021-05-22 23:56:48 -04:00
Jeffrey Finkelstein	1f1cd3d966	truncate: re-organize into one func for each mode Reorganize the code in `truncate.rs` into three distinct functions representing the three modes of operation of the `truncate` program. The three modes are - `truncate -r RFILE FILE`, which sets the length of `FILE` to match the length of `RFILE`, - `truncate -r RFILE -s NUM FILE`, which sets the length of `FILE` relative to the given `RFILE`, - `truncate -s NUM FILE`, which sets the length of `FILE` either absolutely or relative to its curent length. This organization of the code makes it more concise and easier to follow.	2021-05-22 23:54:39 -04:00
Jeffrey Finkelstein	c6d4d0c07d	truncate: create TruncateMode::to_size() method Create a method that computes the final target size in bytes for the file to truncate, given the reference file size and the parameter to the `TruncateMode`.	2021-05-22 23:54:00 -04:00
Jeffrey Finkelstein	544ae87575	truncate: add parse_mode_and_size() helper func Add a helper function to contain the code for parsing the size and the modifier symbol, if any. This commit also changes the `TruncateMode` enum so that the parameter for each "mode" is stored along with the enumeration value. This is because the parameter has a different meaning in each mode.	2021-05-22 23:53:59 -04:00
Jeffrey Finkelstein	5eb2a5c3e1	truncate: remove read permissions from OpenOptions Remove "read" permissions from the `OpenOptions` when opening a new file just to truncate it. We will never read from the file, only write to it. (Specifically, we will only call `File::set_len()`.)	2021-05-22 23:45:05 -04:00
Jan Scheer	44c033a013	who: exclude --runlevel from non Linux targets (fix #2239 )	2021-05-23 03:05:15 +02:00
Sylvestre Ledru	4aaeede3d8	rustfmt the recent change	2021-05-23 00:13:53 +02:00
Michael Debertol	c1f67ed775	sort: support --sort flag and check for conflicts `sort` supports three ways to specify the sort mode: a long option (e.g. --numeric-sort), a short option (e.g. -n) and the sort flag (e.g. --sort=numeric). This adds support for the sort flag. Additionally, sort modes now conflict, which means that an error is shown when multiple modes are passed, instead of silently picking a mode. For consistency, I added the `random` sort mode to the `SortMode` enum, instead of it being a bool flag.	2021-05-22 23:10:41 +02:00
Sylvestre Ledru	726f271273	Merge pull request #2239 from devnexen/fbsd_who_build_fix who freebsd build fix unsupported RUN_LVL option only for other platf…	2021-05-22 21:34:09 +02:00
Jeffrey Finkelstein	4521aa2659	wc: print counts for each file as soon as computed Change the behavior of `wc` to print the counts for a file as soon as it is computed, instead of waiting to compute the counts for all files before writing any output to `stdout`. The new behavior matches the behavior of GNU `wc`. The old behavior looked like this (the word "hello" is entered on `stdin`): $ wc emptyfile.txt - hello 0 0 0 emptyfile.txt 1 1 6 1 1 6 total The new behavior looks like this: $ wc emptyfile.txt - 0 0 0 emptyfile.txt hello 1 1 6 1 1 6 total	2021-05-22 14:27:37 -04:00
Sylvestre Ledru	73fb426b2b	Merge pull request #2252 from jfinkels/realpath-simplify realpath: use uucore::fs::canonicalize() to reduce code duplication	2021-05-22 19:10:59 +02:00
David Carlier	fcb079e20e	who freebsd build fix unsupported RUN_LVL option only for other platforms.	2021-05-22 18:07:02 +01:00
Sylvestre Ledru	542deb8888	Merge pull request #2246 from miDeb/sort-automatic-extsort sort: automatically fall back to extsort	2021-05-22 17:21:02 +02:00
Sylvestre Ledru	8055f26a73	Merge pull request #2228 from jfinkels/tail-obo-positive-bytes tail: fix off-by-one issue for +NUM args	2021-05-22 17:18:55 +02:00
Jeffrey Finkelstein	4b5c3efe85	realpath: use uucore::fs::canonicalize() Use the `uucore::fs::canonicalize()` function to simplify the implementation of `realpath`.	2021-05-22 11:18:16 -04:00
Jeffrey Finkelstein	bee3b1237c	uucore::fs: don't canonicalize last component Change the behavior of `uucore::fs::canonicalize()` when `can_mode` is `CanonicalizeMode::None` so that it does not attempt to resolve the final component if it is a symbolic link. This matches the behavior of the function for the non-final components of a path when `can_mode` is `None`.	2021-05-22 11:18:16 -04:00
Sylvestre Ledru	66cfdb8644	Merge pull request #2143 from nbraud/factor/faster/table factor::table: Implement a batched version w/ improved performance	2021-05-22 17:18:07 +02:00
Sylvestre Ledru	66dd6dbeff	Merge pull request #2244 from jfinkels/truncate-fix-round-up-character truncate: fix character used to indicate round up	2021-05-22 14:03:59 +02:00
Michael Debertol	088443276a	sort: improve handling of buffer size cmd arg Instead of overflowing when calculating the buffer size, use saturating_{pow, mul}. When failing to parse the buffer size, we now crash instead of silently ignoring the error.	2021-05-22 14:00:07 +02:00
Sylvestre Ledru	4d3be19de3	Merge pull request #2240 from jhscheer/macos_test_coreutils who/stat/pinky: adjust tests to be compatible with running on macOS	2021-05-22 12:39:05 +02:00
Sylvestre Ledru	424a99f0e6	Merge pull request #2193 from jfinkels/2186-min-width-stdin wc: compute minimum width to format counts up front	2021-05-22 12:37:42 +02:00
Michael Debertol	e7da8058dc	sort: automatically fall back to extsort To make this work we make default sort a special case of external sort. External sorting uses auxiliary files for intermediate chunks. However, when we can keep our intermediate chunks in memory, we don't write them to the file system at all. Only when we notice that we can't keep them in memory they are written to the disk. Additionally, we don't allocate buffers with the capacity of their maximum size anymore. Instead, they start with a capacity of 8kb and are grown only when needed. This makes sorting smaller files about as fast as it was before (I'm seeing a regression of ~3%), and allows us to seamlessly continue with auxiliary files when needed.	2021-05-21 23:09:46 +02:00
Anup Mahindre	414c92eed7	ls: Fix printing paths behavior For any commandline arguments, ls should print the argument as is (and not truncate to just the file name) For any other files it reaches (say through recursive exploration), ls should print just the filename (as path is printed once when we enter the directory)	2021-05-21 22:22:28 +05:30
Jan Scheer	007e0a4e7f	who/stat/pinky: adjust tests to be compatible with running on macOS A lot of tests depend on GNU's coreutils to be installed in order to obtain reference values during testing. In these cases testing is limited to `target_os = linux`. This PR installs GNU's coreutils on "github actions" and adjusts the tests for `who`, `stat` and `pinky` in order to be compatible with macOS. * `brew install coreutils` (prefix is 'g', e.g. `gwho`, `gstat`, etc. * switch paths for testing to something that's available on both OSs, e.g. `/boot` -> `/bin`, etc. * switch paths for testing to the macOS equivalent, e.g. `/dev/pts/ptmx` -> `/dev/ptmx`, etc. * exclude paths when no equivalent is available, e.g. `/proc`, `/etc/fstab`, etc. * refactor tests to make better use of the testing API * fix a warning in utmpx.rs to print to stderr instead of stdout * fix long_usage text in `who` * fix minor output formatting in `stat` * the `expected_result` function should be refactored to reduce duplicate code * more tests should be adjusted to not only run on `target_os = linux`	2021-05-21 11:55:20 +02:00
Sylvestre Ledru	df45b20dc1	Merge pull request #2243 from jfinkels/truncate-min-max truncate: use min() and max() instead of if/else statements	2021-05-21 10:09:43 +02:00
Jeffrey Finkelstein	a23555e857	truncate: fix character used to indicate round up Fix a bug in which the incorrect character was being used to indicate "round up to the nearest multiple" mode. The character was "*" but it should be "%". This commit corrects that.	2021-05-20 23:19:58 -04:00
Jeffrey Finkelstein	17b95246cd	truncate: use min() and max() instead of if stmts	2021-05-20 21:24:43 -04:00
Jeffrey Finkelstein	fc29846b45	truncate: fix error message for file not found Change the error message for when the reference file (the `-r` argument) is not found to match GNU coreutils. This commit also eliminates a redundant call to `File::open`; the file need not be opened because the size in bytes can be read from the result of `std::fs::metadata()`.	2021-05-20 20:59:59 -04:00
Sylvestre Ledru	efb781f59a	Merge pull request #2221 from jfinkels/head-display-multiple-errors-2 head: display errors for each input file instead of terminating at the first error	2021-05-20 23:24:35 +02:00
Sylvestre Ledru	ca196a6dad	Merge pull request #2218 from miDeb/sort-chunks sort: read files as chunks, off-thread	2021-05-20 23:24:02 +02:00
nicoo	a0a103b15e	factor::table::chunked: Add test (equivalent to the single-number version)	2021-05-20 17:01:33 +02:00
nicoo	998b3c11d3	factor: Make random Factors instance generatable for tests	2021-05-20 17:00:49 +02:00
Jeffrey Finkelstein	63b496eaa8	truncate: refactor parse_size() function Change the interface provided by the `parse_size()` function to reduce its responsibilities to just a single task: parsing a number of bytes from a string of the form '123KB', etc. Previously, the function was also responsible for deciding which mode truncate would operate in. Furthermore, this commit simplifies the code for parsing the number and unit to be less verbose and use less mutable state. Finally, this commit adds some unit tests for the `parse_size()` function.	2021-05-19 23:07:11 -04:00
Jan Scheer	8032c6d750	fix clippy warnings	2021-05-19 01:37:28 +02:00
Sylvestre Ledru	cacd078a49	Merge pull request #2227 from jfinkels/tail-iocopy-bounded-tail tail: use std::io::copy() to write bytes to stdout	2021-05-18 20:42:59 +02:00
Jan Scheer	ce5b852a31	stat: remove unused/duplicate tests	2021-05-18 19:58:33 +02:00
Arijit Dey	1596c65dfd	Downgrade crossterm version	2021-05-18 22:29:59 +05:30
Arijit Dey	7a88df9fb4	Fix broken terminal in tests	2021-05-18 12:42:33 +05:30
Jeffrey Finkelstein	bc29645531	tail: fix off-by-one issue for +NUM args Fix an off-by-one issue for `tail -c +NUM` and `tail -n +NUM` command line options.	2021-05-17 19:45:42 -04:00
Jeffrey Finkelstein	fea1026669	tail: use std::io::copy() to write bytes to stdout	2021-05-17 18:15:39 -04:00
nicoo	00322b986b	factor: Move benchmarks out-of-crate	2021-05-17 19:43:38 +02:00
nicoo	1cd001f529	factor::benches::table: Match BenchmarkId w/ criterion's conventions See https://bheisler.github.io/criterion.rs/book/user_guide/comparing_functions.html	2021-05-17 19:43:38 +02:00
nicoo	7c649bc74e	factor::benches: Add check against ASLR	2021-05-17 19:43:38 +02:00
nicoo	ddfcd2eb14	factor::benchmarking: Add wishlist / planned work	2021-05-17 19:43:38 +02:00
nicoo	1d75f09743	factor::benchmarking(doc): Add guidance on writing µbenches	2021-05-17 19:43:38 +02:00
nicoo	e9f8194266	factor::benchmarking(doc): Add guidance on running µbenches	2021-05-17 19:43:38 +02:00
nicoo	ae15bf16a8	factor::benches::table: Report throughput (in numbers/s)	2021-05-17 19:43:38 +02:00
nicoo	12efaa6add	factor: Add BENCHMARKING.md	2021-05-17 19:43:38 +02:00
nicoo	7c287542c7	factor::table: Fixup microbenchmark Previous version would perform an amount of work proportional to `CHUNK_SIZE`, so this wasn't a valid way to benchmark at multiple values of that constant. The `TryInto` implementation for `&mut [T]` to `&mut [T; N]` relies on `const` generics, and is available in (stable) Rust v1.51 and later.	2021-05-17 19:43:38 +02:00
nicoo	1fd5f9da25	factor::table::factor_chunk: Turn loop inside-out This keeps the traversal of `P_INVS_U64` (a large table) to a single pass in-order, rather than `CHUNK_SIZE` passes.	2021-05-17 19:43:38 +02:00
nicoo	cd047425aa	factor::table: Add chunked implementation and microbenchmarks The factor_chunk implementation is a strawman, but getting it in place allows us to set up the microbenchmarking etc.	2021-05-17 19:43:38 +02:00
nicoo	c68c83c6dd	factor::table: Take mutable refs This will be easier to adapt to working with multiple numbers to process at once.	2021-05-17 19:43:38 +02:00
Jeffrey Finkelstein	eeef8290df	head: display errors for each input file Change the behavior of `head` to display an error for each problematic file, instead of displaying an error message for the first problematic file and terminating immediately at that point. This change now matches the behavior of GNU `head`. Before this commit, the first error caused the program to terminate immediately: $ head a b c head: error: head: cannot open 'a' for reading: No such file or directory After this commit: $ head a b c head: cannot open 'a' for reading: No such file or directory head: cannot open 'b' for reading: No such file or directory head: cannot open 'c' for reading: No such file or directory	2021-05-17 08:19:47 -04:00
Michael Debertol	fcd48813e0	sort: read files as chunks, off-thread Instead of using a BufReader and reading each line separately, allocating a String for each one, we read to a chunk. Lines are references to this chunk. This makes the allocator's job much easier and yields performance improvements. Chunks are read on a separate thread to further improve performance.	2021-05-16 21:13:37 +02:00
Arijit Dey	c930509095	Fix clippy warning	2021-05-16 22:30:46 +05:30
Arijit Dey	22ba21d8ab	Fix bug with terminal getting weird	2021-05-16 22:26:54 +05:30
Jeffrey Finkelstein	659bf58a4c	head: print headings when reading multiple files Fix a bug in which `head` failed to print headings for `stdin` inputs when reading from multiple files, and fix another bug in which `head` failed to print a blank line between the contents of a file and the heading for the next file when reading multiple files. The output now matches that of GNU `head`.	2021-05-16 12:03:10 -04:00
Jeffrey Finkelstein	733d347fa8	head: simplify rbuf_n_bytes() in head.rs Simplify the code in `rbuf_n_bytes()` to use existing abstractions provided by the standard library.	2021-05-15 23:04:01 -04:00
Jeffrey Finkelstein	97a49c7c95	wc: compute min width to format counts up front Fix two issues with the string formatting width for counts displayed by `wc`. First, the output was previously not using the default minimum width (seven characters) when reading from `stdin`. This commit corrects this behavior to match GNU `wc`. For example, $ cat alice_in_wonderland.txt \| wc 5 57 302 Second, if at least 10^7 bytes were read from `stdin` after reading from a smaller regular file, then every output row would have width 8. This disagrees with GNU `wc`, in which only the `stdin` row and the total row would have width 8. This commit corrects this behavior to match GNU `wc`. For example, $ printf "%.0s0" {1..10000000} \| wc emptyfile.txt - 0 0 0 emptyfile.txt 0 1 10000000 0 1 10000000 total Fixes #2186.	2021-05-15 21:41:47 -04:00
Sylvestre Ledru	620a5a5df6	Merge pull request #2210 from jhscheer/dns_lookup who: fix `--lookup`	2021-05-15 21:18:12 +02:00
Jeffrey Finkelstein	e8d911d9d5	wc: correct some error messages for invalid inputs Change the error messages that get printed to `stderr` for compatibility with GNU `wc` when an input is a directory and when an input does not exist. Fixes #2211.	2021-05-15 10:35:21 -04:00
Jan Scheer	a4fc2b5106	who: fix `--lookup` This closes #2181. `who --lookup` is failing with a runtime panic (double free). Since `crate::dns-lookup` already includes a safe wrapper for `getaddrinfo` I used this crate instead of further debugging the existing code in utmpx::canon_host(). * It was neccessary to remove the version constraint for libc in uucore.	2021-05-13 22:16:15 +02:00
Jeffrey Finkelstein	2e621759b2	tail: refactor code into ReverseChunks iterator Refactor code from the `backwards_thru_file()` function into a new `ReverseChunks` iterator, and use that iterator to simplify the implementation of the `backwards_thru_file()` function. The `ReverseChunks` iterator yields `Vec<u8>` objects, each of which references bytes of a given file.	2021-05-12 18:43:58 -04:00
Jeffrey Finkelstein	3114fd77be	tail: use &mut File instead of mut file: &File	2021-05-12 18:43:35 -04:00
Sylvestre Ledru	2178edf628	Merge pull request #2207 from jhscheer/issue_2204 date: fix format literal for nanoseconds	2021-05-12 13:14:23 +02:00
Jan Scheer	12a43d6eb3	date: fix format literal for nanoseconds	2021-05-12 10:21:24 +02:00
Sylvestre Ledru	a5f8ca60b5	Merge pull request #2199 from jhscheer/refactor_fsext df/stat: refactor - reduce duplicate code	2021-05-12 08:41:16 +02:00
Sylvestre Ledru	6635301f32	Merge pull request #2194 from miDeb/sort-stable-merge sort: make merging stable	2021-05-12 08:38:48 +02:00
Sylvestre Ledru	57ae202037	Merge pull request #2195 from nthery/wc_dash wc: emit '-' in ouput when set on command-line	2021-05-12 08:37:55 +02:00
Sylvestre Ledru	8f24ec9414	Merge pull request #2198 from jfinkels/tail-refactor tail: simplify unbounded_tail() function	2021-05-12 08:35:45 +02:00
Sylvestre Ledru	68a3488cdc	Merge pull request #2202 from drocco007/test-negated-boolean test: improve handling of inverted Boolean expressions	2021-05-12 08:34:41 +02:00
Jan Scheer	8200d399e8	date: fix format for nanoseconds	2021-05-11 23:03:59 +02:00
Daniel Rocco	2ec4bee350	test: improve handling of inverted Boolean expressions - add `==` as undocumented alias of `=` - handle negated comparison of `=` as literal - negation generally applies to only the first expression of a Boolean chain, except when combining evaluation of two literal strings	2021-05-10 22:48:40 -04:00
Jan Scheer	381f8dafc6	df/uucore: refactor - move duplicate code to uucore/fsext.rs	2021-05-10 23:37:01 +02:00
Sylvestre Ledru	ed42652803	Merge pull request #2200 from jhscheer/fix_clippy fix clippy warnings	2021-05-10 16:13:27 +02:00
Jan Scheer	4ac75898c3	fix clippy warnings	2021-05-10 15:48:32 +02:00
Jan Scheer	203ee463c7	stat/uucore: refactor - move fsext.rs to uucore	2021-05-10 10:46:00 +02:00
Jeffrey Finkelstein	0cc779c733	tail: simplify unbounded_tail() function Refactor common code out of two branches of the `unbounded_tail()` function into a new `unbounded_tail_collect()` helper function, that collects from an iterator into a `VecDeque` and keeps either the last `n` elements or all but the first `n` elements. This commit also adds a new struct, `RingBuffer`, in a new module, `ringbuffer.rs`, to be responsible for keeping the last `n` elements of an iterator.	2021-05-09 23:47:13 -04:00
Gilad Naaman	8747800697	Switched 'arch' to use clap instead of getopts	2021-05-09 21:53:03 +03:00
Sylvestre Ledru	7c51fb4946	Merge pull request #2165 from miDeb/sort-optimize-line sort: optimize the line struct	2021-05-09 18:41:39 +02:00
Nicolas Thery	112b042769	wc: emit '-' in ouput when set on command-line When stdin is explicitly specified on the command-line with '-', emit it in the output stats to match GNU wc output. Fixes #2188.	2021-05-09 15:47:05 +02:00
Michael Debertol	e0ebf907a4	sort: make merging stable When merging files we need to prioritize files that occur earlier in the command line arguments with -m. This also makes the extsort merge step (and thus extsort itself) stable again.	2021-05-09 11:43:38 +02:00
Sylvestre Ledru	d43af35147	Merge pull request #2145 from tertsdiepraam/ls/device_information `ls`: implement device symbol and id	2021-05-09 00:50:35 +02:00
Terts Diepraam	f6e5f86fe7	Merge branch 'master' into ls/device_information	2021-05-08 23:21:44 +02:00
Michael Debertol	d686f7e48f	sort: improve comments	2021-05-08 22:31:53 +02:00
Sylvestre Ledru	01a702c6fd	Merge branch 'master' into issue2167	2021-05-08 20:26:21 +02:00
Michael Debertol	1afeb55881	Merge branch 'master' of https://github.com/uutils/coreutils into sort-optimize-line	2021-05-08 15:47:19 +02:00
Samuel Ainsworth	2ff9cc6570	Typo in comment	2021-05-08 14:25:21 +02:00
Samuel Ainsworth	bacad8ed93	Use u128 instead of usize for large numbers, and consistency across architectures	2021-05-08 14:25:21 +02:00
Samuel Ainsworth	7c1395366e	Fix split's handling of non-UTF-8 files	2021-05-08 14:25:21 +02:00
Samuel Ainsworth	a9ac7af9e1	Simplify parsing of --bytes for the split command	2021-05-08 14:25:21 +02:00
Jeffrey Finkelstein	ba8f4ea670	wc: move counting code into WordCount::from_line() Refactor the counting code from the inner loop of the `wc` program into the `WordCount::from_line()` associated function. This commit also splits that function up into other helper functions that encapsulate decoding characters and finding word boundaries from raw bytes. This commit also implements the `Sum` trait for the `WordCount` struct, so that we can simply call `sum()` on an iterator that yields `WordCount` instances.	2021-05-08 14:24:07 +02:00
Jeffrey Finkelstein	50f4941d49	wc: refactor WordCount into its own module Move the `WordCount` struct and its implementations into the `wordcount.rs`.	2021-05-08 14:24:07 +02:00
Jeffrey Finkelstein	ee43655bdb	fixup! wc: rm leading space when printing multiple counts	2021-05-08 13:11:09 +02:00
Jeffrey Finkelstein	525f71bada	wc: rm leading space when printing multiple counts Remove the leading space from the output of `wc` when printing two or more types of counts. Fixes #2173.	2021-05-08 13:11:09 +02:00
Jan Scheer	a885376583	uucore: refactor - reduce duplicate code related to `fs::display_permissions` This is a refactor to reduce duplicate code, it affects chmod/ls/stat. * merge `stat/src/fsext::pretty_access` into `uucore/src/lib/feature/fs::display_permissions_unix` * move tests for `fs::display_permissions` from `test_stat::test_access` to `uucore/src/lib/features/fs::test_display_permissions` * adjust `uu_chmod`, `uu_ls` and `uu_stat` to use `uucore::fs::display_permissions`	2021-05-08 11:52:41 +02:00
Michael Debertol	38effc93b3	sort: use FileMerger for extsort merge step FileMerger is much more efficient than the previous algorithm, which looped over all elements every time to determine the next element. FileMerger uses a BinaryHeap, which should bring the complexity for the merge step down from O(n²) to O(n log n).	2021-05-08 11:51:32 +02:00
Michael Debertol	64c1f16421	sort: allow some functions to be called with OsStr	2021-05-08 11:51:32 +02:00
Terts Diepraam	3b6c7bc9e9	Fix mistakes with merging	2021-05-08 00:50:36 +02:00
Michael Debertol	8c9faa16b9	sort: improve memory usage for extsort	2021-05-07 21:51:31 +02:00
Michael Debertol	c38373946a	sort: optimize the Line struct	2021-05-07 21:51:25 +02:00
Terts Diepraam	6834d0256e	Merge branch 'master' into ls/device_information	2021-05-07 18:56:44 +02:00
Arijit Dey	d2ab0dcded	Make a nice error when file does not exist	2021-05-06 22:12:15 +05:30
Idan Attias	34b9809223	logname: fix test & style warning	2021-05-06 14:19:47 +02:00
Idan Attias	41eb930292	logname: align profile	2021-05-06 14:19:47 +02:00
Idan Attias	b24b9d501b	logname: replace getopts with clap	2021-05-06 14:19:47 +02:00
jaggededgedjustice	a2658250fc	Fix fmt crashing on subtracting unsigned numbers (#2178 )	2021-05-05 23:12:17 +02:00
Anup Mahindre	7d2b051866	Implement Total size feature (#2170 ) * ls: Implement total size feature - Implement total size reporting that was missing - Fix minor formatting / readability nits * tests: Add tests for ls total sizes feature * ls: Fix MSRV build errors due to unsupported attributes for if blocks * ls: Add windows support for total sizes feature - Add windows support (defaults to file size as block sizes related infromation is not avialable on windows) - Renamed some functions	2021-05-05 23:03:25 +02:00
rethab	231bb7be93	Migrate mknod to clap, closes #2051 (#2056 ) * mknod: add tests for fifo * mknod: add test for character device	2021-05-05 22:59:40 +02:00
Sylvestre Ledru	f83316f36e	Merge pull request #2156 from miDeb/sort-no-json-extsort sort: don't rely on serde-json for extsort	2021-05-05 22:33:18 +02:00
Sylvestre Ledru	482e340e11	Merge branch 'master' into implement-more	2021-05-04 13:35:38 +02:00
Sylvestre Ledru	1edf4064f3	Merge pull request #2162 from bashi8128/basename-clap basename: move from getopts to clap	2021-05-04 10:59:19 +02:00
Sylvestre Ledru	3f5dda66f4	Merge pull request #2138 from jhscheer/who2clap who: move from getopts to clap (#2124)	2021-05-04 10:58:52 +02:00
Sylvestre Ledru	e3b7a8bd22	Merge pull request #2166 from jfinkels/wc-word-countable-lines wc: add lines() method for iterating over lines	2021-05-04 09:53:08 +02:00
Jan Scheer	56761ba584	stat: implement support for macos	2021-05-03 22:30:56 +02:00
David CARLIER	224c8b3f94	df output update (non inode mode) proposal specific for mac. on this platform, capacity column is also displayed.	2021-05-03 15:49:55 +01:00
bashi8128	5a4bb610ff	basename: rename variable names Rename variable names to be more explicit ones	2021-05-03 23:32:01 +09:00
bashi8128	74802f9f0f	basename: improve error messages Remove duplicated utility name from error messages	2021-05-03 23:26:46 +09:00
Jeffrey Finkelstein	0a3e2216d7	wc: add lines() method for iterating over lines Add the `WordCountable::lines()` method that returns an iterator over lines of a file-like object. This mirrors the `std::io::BufRead::lines()` method, with some minor differences due to the particular use case of `wc`. This commit also creates a new module, `countable.rs`, to contain the `WordCountable` trait and the new `Lines` struct returned by `lines()`.	2021-05-02 16:32:38 -04:00
Sylvestre Ledru	6c04d0d21e	Merge pull request #2155 from nthery/kill_clap kill: migrate to clap	2021-05-02 18:45:29 +02:00
Michael Debertol	e99f157e6a	Merge branch 'master' of https://github.com/uutils/coreutils into sort-no-json-extsort	2021-05-02 18:08:15 +02:00
Sylvestre Ledru	9b7e7bbbc6	Merge pull request #2144 from miDeb/sort-no-transforms sort: add some custom string comparisons	2021-05-02 18:04:27 +02:00
Michael Debertol	dc5bd9f0be	improve memory usage estimation	2021-05-02 17:27:44 +02:00
Sylvestre Ledru	f8ec4a554c	Merge pull request #2161 from tertsdiepraam/ls/sort_order_and_subdirectory_listing `ls`: C sort order and fix subdirectory listing	2021-05-02 17:21:56 +02:00
Jan Scheer	acd30526a2	tr: fix clippy warning	2021-05-02 13:53:11 +02:00
Jan Scheer	000bd73edc	tr: fix merge conflict	2021-05-02 12:39:25 +02:00
Jan Scheer	8739139a7f	Merge branch 'master' into issue2147	2021-05-02 12:35:19 +02:00
Nicolas Thery	1dccbfd21e	kill: migrate to clap Fixes #2122.	2021-05-02 12:31:41 +02:00
Jan Scheer	34c22dc3ad	tr: fix complement if set2 is range	2021-05-02 12:15:16 +02:00
Sylvestre Ledru	9554710ab5	cat: the function 'unistd::write' doesn't need a mutable reference	2021-05-02 10:31:28 +02:00
Sylvestre Ledru	09178360d8	date: unneeded 'return' statement	2021-05-02 10:30:28 +02:00
Terts Diepraam	eb3206737b	ls: give '.' a file_type	2021-05-02 10:20:14 +02:00
bashi8128	47a5dd0f97	basename: move from getopts to clap (#2117 ) Use clap for argument parsing instead of getopts Also, make the following changes * Use `executable!()` macro to output the name of utility * Add another usage to help message	2021-05-02 17:08:14 +09:00
Terts Diepraam	361408cbe5	ls: remove case-insensitivity and leading period of name sort	2021-05-02 10:04:11 +02:00
Terts Diepraam	28c7800f73	ls: fix subdirectory name	2021-05-02 10:03:01 +02:00
Sylvestre Ledru	108f9928ef	cp: fix 'variable does not need to be mutable'	2021-05-02 09:39:09 +02:00
Sylvestre Ledru	e723b8db43	factor: unneeded statement	2021-05-02 09:35:59 +02:00
Sylvestre Ledru	5e82b195bd	ls: remove redundant import	2021-05-02 09:35:00 +02:00
Sylvestre Ledru	2d0f4daf5b	Merge pull request #2152 from deantvv/link-clap link: replace getopts with clap	2021-05-02 09:33:11 +02:00
Dean Li	f5c7d9bd80	link: replace getopts with clap	2021-05-02 10:40:48 +08:00
Daniel Rocco	3c126bad72	test: implement parenthesized expressions, additional tests - Replace the parser with a recursive descent implementation that handles parentheses and produces a stack of operations in postfix order. Parsing now operates directly on OsStrings passed by the uucore framework. - Replace the dispatch mechanism with a stack machine operating on the symbol stack produced by the parser. - Add tests for parenthesized expressions. - Begin testing character encoding handling.	2021-05-01 22:40:47 -04:00
Sylvestre Ledru	7e07438b38	Merge pull request #2151 from jfinkels/2141-translate-and-squeeze tr: implement translate and squeeze (-s) mode	2021-05-01 23:27:43 +02:00
Michael Debertol	484558e37d	Update src/uu/sort/BENCHMARKING.md Co-authored-by: Sylvestre Ledru <sledru@mozilla.com>	2021-05-01 21:38:36 +02:00
Michael Debertol	b21a309c3f	add a benchmarking example	2021-05-01 21:29:18 +02:00
Michael Debertol	83554f4475	add benchmarking instructions	2021-05-01 21:16:29 +02:00
Ricardo Iglesias	193ad56c2a	Removed clippy warnings.	2021-05-01 11:36:46 -07:00
Ricardo Iglesias	f307de22d0	base64: Refactor argument parsing Moved most of the argument parsing logic to `base32/base_common.rs` to allow for significant code reuse.	2021-05-01 11:36:46 -07:00
Ricardo Iglesias	05b20c32a9	base64: Moved argument parsing to clap. Moved argument parsing to clap and added tests to cover using "-" as stdin, passing in too many file arguments, and updated the "wrap" error message in the tests.	2021-05-01 11:36:46 -07:00
Jeffrey Finkelstein	5674d09327	fixup! tr: implement translate and squeeze (-s) mode	2021-05-01 13:01:55 -04:00
Jan Scheer	83eb704415	Merge branch 'master' into issue2147	2021-05-01 18:52:35 +02:00
Jan Scheer	117e84eed3	tr: implement complement separately from delete or squeeze (#2147 )	2021-05-01 18:46:13 +02:00
Sylvestre Ledru	bffcb431b5	Merge pull request #2148 from jhscheer/pinky2clap pinky: move from getopts to clap (#2123)	2021-05-01 17:49:10 +02:00
Sylvestre Ledru	34bf7cc5ea	Merge pull request #2150 from jhscheer/fix_clap_short tr/dirname: fix clap short_alias	2021-05-01 17:39:15 +02:00
Michael Debertol	be0c924c95	Merge branch 'master' of https://github.com/uutils/coreutils into sort-no-json-extsort	2021-05-01 17:29:03 +02:00
Michael Debertol	01d178cf17	sort: don't rely on serde-json for extsort It is much faster to just write the lines to disk, separated by \n (or \0 if zero-terminated is enabled), instead of serializing to json. external_sort now knows of the Line struct instead of interacting with it using the ExternallySortable trait. Similarly, it now uses the crash_if_err! macro to handle errors, instead of bubbling them up. Some functions were changed from taking &[Line] as the input to taking an Iterator<Item = Line>. This removes the need to collect to a Vec when not necessary.	2021-05-01 17:20:56 +02:00
Nicolas Thery	70ab0d01d2	kill: change default signal The default signal is SIGTERM, not SIGKILL.	2021-05-01 16:47:42 +02:00
Sylvestre Ledru	d2913f8080	rustfmt the recent change	2021-05-01 13:12:10 +02:00
Sylvestre Ledru	59ea28628b	printf: remove useless declaration	2021-05-01 13:11:41 +02:00
Jeffrey Finkelstein	0f3bc23739	tr: implement translate and squeeze (-s) mode Add translate and squeeze mode to the `tr` program. For example: $ printf xx \| tr -s x y y Fixes #2141.	2021-04-30 18:17:05 -04:00
Jan Scheer	798a033311	pinky: move from getopts to clap (#2123 )	2021-04-30 20:57:38 +02:00
Jan Scheer	45dd9d4e96	tr/dirname: fix clap short_alias	2021-04-30 20:19:43 +02:00
Terts Diepraam	d300895d28	ls: add birth time for windows and attampt to fix test	2021-04-29 22:23:04 +02:00
Terts Diepraam	d624827913	ls: fix windows and add more file types	2021-04-29 18:44:46 +02:00
Terts Diepraam	c69afa00ff	ls: implement device symbol and id	2021-04-29 18:25:34 +02:00
Michael Debertol	fecbf3dc85	sort: remove an unneeded clone()	2021-04-29 18:05:55 +02:00
Michael Debertol	a4813c2646	sort: actually use the f64 cache This was probably reverted accidentally.	2021-04-29 18:05:43 +02:00
Michael Debertol	9f45431bf0	sort: add some custom string comparisons This removes the need to allocate a new string for each line when used with -f, -d or -i. Instead, a custom string comparison algorithm takes care of these cases. The resulting performance improvement is about 20% per flag (i.e. there is a 60% improvement when combining all three flags) As a side-effect, the size of the Line struct was reduced from 96 to 80 bytes, reducing the overhead for each line.	2021-04-29 18:05:14 +02:00
Arijit Dey	2593b3f2e1	Rewrite the cli usage function Add crossterm as dependency Complete the paging portion Fixed tests cp: extract linux COW logic into function cp: add --reflink support for macOS Fixes #1773 Fix error in Cargo.lock Quit automatically if not much output is left Remove unnecessary redox and windows specific code Handle line wrapping Put everything according to uutils coding standards Add support for multiple files Fix failing test Use the args argument to get cli arguments Fix bug where text is repeated multiple times during printing Add a little prompt Add a top file prompt for multiple files Change println in loops to stdout.write and setup terminal only once Fix bug where all lines were printed in a single row Remove useless file and fix failing test Fix another test	2021-04-29 20:23:35 +05:30
nicoo	b89978a4c9	factor: Add annotations for coz, the causal profiler (#2142 ) * factor: Add annotations for coz, the causal profiler * Update Cargo.lock Generated with `nix-shell -p rustup --run 'cargo +1.40.0 update'`	2021-04-29 15:56:56 +02:00
Jan Scheer	512d206f1e	who: move from getopts to clap 2.33.3 (#2124 )	2021-04-29 00:11:21 +02:00
Jan Scheer	6f16cafe88	who: move from getopts to clap (#2124 )	2021-04-28 22:58:28 +02:00
Rein F	a60fd07bc3	ls: improvements on time handling (#1986 ) * ls: added creation time * ls: Added most time features Missing support for posix-,Format+, translating via locales. Also required more tests * ls: rustfmt * ls: Additional changes and fixes Fixed the argument order, fixed a wrong iso format. * ls: additional tests for styles * ls: perfected arg parsing on time styles * fix birthime test * ls: Use 'stdout_str' in new tests * ls: Disabled birthtime test for windows * ls: removed indoc as a dependency * ls: birthime test, sync first created file * ls: birthime test, add comment explaining sync * Removed ruby testfile birth_test.rb This accidentally got commited in a merge	2021-04-28 20:54:27 +02:00
Sylvestre Ledru	167520067c	Merge pull request #2111 from cbjadwani/cut_optimizations cut: optimizations	2021-04-28 20:40:28 +02:00
Chirag Jadwani	25f99097cc	cut: add BENCHMARKING.md and minor refactoring	2021-04-28 23:28:26 +05:30
Sylvestre Ledru	a37e3181a2	Merge pull request #2130 from electricboogie/master sort: implement --buffer-size and --temporary-directory (external sort)	2021-04-28 09:21:14 +02:00
Sylvestre Ledru	33139817a2	Merge pull request #2136 from jaggededgedjustice/allow-truncate-size-and-reference Allow truncate to take --size and --reference	2021-04-27 22:43:25 +02:00
electricboogie	ec19bb72d5	Modified to remove 2 unnecessary consts now that we use std::env::temp_dir	2021-04-27 15:39:20 -05:00
Tyler	d97672dfd3	Continues impl - Completes impl of skip=N, and seek=N - Parses cbs=N	2021-04-27 12:21:35 -07:00
Sylvestre Ledru	30cf6ec235	Merge pull request #2131 from ricardoaiglesias/base32-clap Base32 clap	2021-04-27 09:20:45 +02:00
Ricardo Iglesias	ae0cabc60a	Moved argument parsing to uumain.	2021-04-26 20:15:11 -07:00
Tyler	4d7be2f098	Implements functionality for seeking output files - Adds duplicate dd fn :-( for differentiating between File backed and non-File outputs. - Implements cflag=sparse,fsync,fdatasync which were previously blocked. - Adds plumbing for IFlags & OFlags incl parsing. - Partial impl for seek=N and skip=N which were previously blocked.	2021-04-26 15:17:48 -07:00
Sylvestre Ledru	7a3b44d972	Merge pull request #2133 from tertsdiepraam/ls/fix_color_grid_alignment `ls`: fix grid alignment with `--color`	2021-04-26 22:51:21 +02:00
Sylvestre Ledru	ece5e14b0d	fix a typo	2021-04-26 22:51:02 +02:00
James Robson	a7037b1ca9	Allow truncate to take --size and --reference	2021-04-26 18:39:32 +01:00
Terts Diepraam	35838dc8a9	ls: document hyperfine script	2021-04-26 18:36:15 +02:00
Terts Diepraam	4023e40174	ls: further reduce OsStr -> String conversions	2021-04-26 18:03:56 +02:00
Ricardo Iglesias	11d0565f0e	base32: Moved clap argument parsing to base32.rs Now, all base_common.rs has is the handle_input function.	2021-04-26 08:22:41 -07:00
Ricardo Iglesias	d56462a4b3	base32: Fixed style violations. Added tests Tests now cover using "-" as standard input and reading from a file.	2021-04-26 08:00:55 -07:00
electricboogie	f3ed5a100f	Possible fix to Windows issues, ext_sort bool setting	2021-04-26 08:54:40 -05:00
Terts Diepraam	c69b72c840	ls: forgot to commit Cargo.{toml, lock}	2021-04-26 15:04:55 +02:00
Terts Diepraam	58fd61b3e8	ls: fix grid alignment for unicode	2021-04-26 15:00:39 +02:00

... 9 10 11 12 13 ...

3292 commits