Commit graph

4967 commits

Author SHA1 Message Date
Daniel Hofstetter
742d39300b wc: fix two incorrect code comments 2024-01-29 10:42:34 +01:00
Harsh Ranjan
1528b35113
refactor wc.rs to remove clippy's cognitive complexity lint (#5897)
* refactor wc.rs to remove clippy's cognitive complexity lint

* fix for tracking line length and number of words correctly if chunking occurs within them

* removing more of the cognitive complexity from the Err variant in the match block

* running cargo clippy once

* wc: add empty line to separate functions

---------

Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
2024-01-29 10:41:11 +01:00
Jeffrey Finkelstein
d782fd1bd3 dd: parse big numbers and return u64::MAX
Change the behavior of `dd` so that it parses numbers that would be too
big and instead treats them as `u64::MAX`. This allows `dd` to run
without error on

    dd count=00x9999999999999999999999999999999999999999999999999999999999999

This matches the behavior of GNU `dd`.
2024-01-28 13:41:34 -05:00
kralo
ee7f99aad0 cp: use inclusive range
as suggested by clippy::range-plus-one
2024-01-28 09:42:40 +01:00
kralo
d046d33bee split: use inclusive range
as suggested by clippy::range-plus-one
2024-01-28 09:42:40 +01:00
kralo
9906e66096 uucore: remove unneccessary closues
This adresses only those where the fix has less letters than the
original and is "trivial" (There are possibly a lot of std::string::ToString::to_string
and those may only be shortened with additional imports).

Found with clippy::redundant-closure-for-method-calls
2024-01-28 09:42:40 +01:00
kralo
bd43a7ed99 nl: fix redundant clone (clippy warning) 2024-01-28 09:42:40 +01:00
Sylvestre Ledru
7fa4b389a9
Merge pull request #5892 from kralo/fix-5883
factor: rename input parameter
2024-01-28 09:28:36 +01:00
kralo
9adceb4f65 factor: rename input parameter
Closes: #5883
2024-01-28 08:24:16 +01:00
kralo
12dd1e4d7d cp: remove lint exceptions
Could not even reproduce what they would complain for.
Closes: #5885
2024-01-27 19:21:05 +01:00
kralo
3eba95728c factor: remove clippy exceptions by reformatting "unreadable literals"
Closes: #5884
2024-01-27 17:23:44 +01:00
Daniel Hofstetter
c8cd355708 cut: set exit code to 1 if dir is specified 2024-01-26 10:18:44 +01:00
Daniel Lungu
61c730d1b3
expand: Continue work when one of given files doesn't exist (#5873)
* expand: continues work when one of given files doesn't exist

* fixed test for nonexisting file
2024-01-25 09:10:59 +01:00
Sylvestre Ledru
1693640446 whoami: add missing feature 2024-01-24 21:33:25 +01:00
Biplab Mochan Gartia
150b287fe8
unexpand: allow multiple files & show error message if a directory is specified
* unexpand: should allow multiple files #5852 and unexpand: show error message if a directory is specified #5845

* test file added for #5845 #5852

* test case test_multiple_files improve

* cakebaker suggestion for a better code #5845 #5852

---------

Co-authored-by: biplab5464 <biplab5464@outlook.com>
2024-01-24 16:01:26 +01:00
Daniel Hofstetter
d690e8fb99
Merge pull request #5752 from sylvestre/0.0.24
0.0.23 => 0.0.24
2024-01-21 13:35:10 +01:00
Sylvestre Ledru
dd5c6c2d00 0.0.23 => 0.0.24 2024-01-20 20:12:19 +01:00
Sylvestre Ledru
5e29c60b26 hashsum: when the filename contains some special chars, escape them
Should fix tests/cksum/md5sum-newline.pl
2024-01-20 19:27:45 +01:00
SaHHiiLL
746a7b14d0
tsort: returns error when input is dir - same as GNU tsort (#5860)
* fix: return error when input is dir

* test: when tsort is given a dir

* fix: do not need to mention tsort in error message

* test: using concrete directory name

* tsort: fix formatting in test

---------

Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
2024-01-19 15:39:00 +01:00
Ulrich Hornung
dc533a915a
install: fix strip program stdout and destination hyphen handling #5718 (#5848)
* Fix missing dependency to "process" to make it compile.

* fix issue of not forwarding stdout from strip program

* fix issue of applying "./" redundantly

* cargo fmt
2024-01-17 10:07:34 +01:00
Sylvestre Ledru
66637a6503 move the file_has_acl function into uucore 2024-01-16 13:12:02 +01:00
Sylvestre Ledru
2ec4e9f784 mv: preserve the xattr
Should make tests/mv/acl pass
2024-01-16 13:12:02 +01:00
Daniel Hofstetter
112eb21eb3
Merge pull request #5791 from sylvestre/handle-error
Handle better some errors
2024-01-15 15:19:10 +01:00
Sylvestre Ledru
fff83995fb
cp: --preserve should keep xattr (#5834)
* cp: --preserve should keep xattr

Should help with tests/cp/acl.sh

* Update tests/by-util/test_cp.rs

Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>

* Update tests/by-util/test_cp.rs

Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>

* Update tests/by-util/test_cp.rs

Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>

---------

Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
2024-01-15 10:59:04 +01:00
Biplab Mochan Gartia
076b905513
cksum: stops when one of given files doesn't exist #5809 (#5820)
* cksum: stops when one of given files doesn't exist #5809

* removed printld  cksum: stops when one of given files doesn't exist #5809

* formatting the code cksum: stops when one of given files doesn't exist #5809

* formatting the code cksum: stops when one of given files doesn't exist #5809

* set exist status cksum: stops when one of given files doesn't exist #5809

* code quality formatting issue cksum: stops when one of given files doesn't exist #5809

* tertsdiepraam idea cksum: stops when one of given files doesn't exist #5809

* one new test case and deleted duplicate show cksum: stops when one of given files doesn't exist #5809

* formatting the test cases cksum: stops when one of given files doesn't exist #5809

* Revert "formatting the test cases cksum: stops when one of given files doesn't exist #5809"

This reverts commit 8c382f1e8f.

* reverting the changes and committing again due to a mistake cksum: stops when one of given files doesn't exist #5809

---------

Co-authored-by: biplab5464 <biplab5464@outlook.com>
2024-01-15 09:37:56 +01:00
Sylvestre Ledru
36039a819d
Merge pull request #5739 from cakebaker/cp_backup_with_symlink_to_source
cp: backup dest symlink linking to source
2024-01-14 23:30:06 +01:00
Sylvestre Ledru
e3beda08ac
Merge pull request #5762 from cakebaker/cp_link_same_file
cp: show no "same file" error for `--link a a`
2024-01-14 23:29:33 +01:00
Sylvestre Ledru
ef03a4625f
Merge pull request #5806 from cakebaker/nl_is_a_directory
nl: don't exit if input is directory
2024-01-14 23:29:05 +01:00
Sylvestre Ledru
3d356d47b3 expand: avoid an infinite loop 2024-01-14 23:27:00 +01:00
Sylvestre Ledru
8d24036f5c basenc: handle '--base32 .' arg 2024-01-14 23:27:00 +01:00
Sylvestre Ledru
4f33a375cd factor: handle the '< .' arg 2024-01-14 23:26:57 +01:00
Sylvestre Ledru
e01d5f75f7
ls: if acl are used, show the + in the perms (#5816)
* ls: if acl are used, show the + in the perms

Tested by tests/mkdir/p-acl.sh

* CICD.yml: fix small formatting issue

---------

Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
2024-01-14 15:57:22 +01:00
Daniel Hofstetter
ac27b6c4b0
Merge pull request #5833 from sylvestre/cut-multiple
cut: allow the same option to be passed multiple times
2024-01-13 16:58:04 +01:00
Sylvestre Ledru
bc51b8d216 cut: allow the same option to be passed multiple times 2024-01-13 15:09:16 +01:00
Atomei Alexandru
563df4b79d
Made cksum return an error if used on a directory. (#5822)
* Made cksum to return an error if it is used on a directory regardless of the algorithm

* Added one more test for cksum on folders and deleted an old one that expected it to succeed instead of fail

* Made cksum work on more than one item if it fails and added a test for this case
2024-01-13 14:43:36 +01:00
Sudhakar Verma
cd4568f5d9 printf: simplify loop 2024-01-12 17:12:30 +05:30
Sudhakar Verma
4e5a65ee41 printf: fix clippy warnings 2024-01-12 16:23:38 +05:30
Sudhakar Verma
2aa8a3502f printf : no infinite loop 2024-01-12 16:08:47 +05:30
D9nni
9a76997b0a cksum: fixed clippy and fmt errors 2024-01-10 16:49:52 +02:00
D9nni
911df1d76c cksum: code improvements for cksum --raw --algorithm 2024-01-10 15:15:23 +02:00
D9nni
c7b15ddce9 cksum: fixed cksum --raw --algorithm 2024-01-10 15:04:19 +02:00
D9nni
96271ffa3c cksum: added tests for --raw with each algorithm, not working for crc, sysv, bsd 2024-01-09 23:12:40 +02:00
Daniel Hofstetter
1c6bf6991c nl: don't exit if input is directory 2024-01-08 11:01:07 +01:00
Sylvestre Ledru
d72343bc64
Merge branch 'main' into cksum 2024-01-08 09:02:11 +01:00
D9nni
f03ef79bc8 cksum: added tests for --raw and fixed fmt whitespace error 2024-01-08 08:51:06 +02:00
Atomei Alexandru Constantin
288ad97878 Made cksum to return an error if the algorithm blake2b is used on a directory 2024-01-07 23:39:33 +02:00
D9nni
8c1fc8b287 Added --raw argument, with error for multiple files 2024-01-07 21:43:31 +02:00
Kostiantyn Hryshchuk
c867d6bfb1
shred: implemented "--remove" arg (#5790) 2024-01-06 22:50:21 +01:00
Daniel Hofstetter
e13f0d80ee
Merge pull request #5778 from RenjiSann/main
ls: Support QUOTING_STYLE environment variable
2024-01-05 15:55:23 +01:00
Sylvestre Ledru
e64a0b4a26 Various fixes
Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
2024-01-05 12:56:27 +01:00
Sylvestre Ledru
aabf5fa577 cp: manages target with trailing '/' 2024-01-05 12:56:27 +01:00
Sylvestre Ledru
108dc4a0cd Move path_ends_with_terminator from mv into uucore 2024-01-05 12:56:27 +01:00
Sylvestre Ledru
4c698d58e0 mv: support the case mkdir a && mv a e/ 2024-01-05 12:56:24 +01:00
cre4ture
9b3cc5437c
head: head_backwards for non-seekable files like /proc/* or fifos (named pipes) (#5732)
* implement head_backwards for non-seekable files like /proc/* or pipes

Signed-off-by: Ulrich Hornung <hornunguli@gmx.de>
2024-01-05 00:25:59 +01:00
Dorian Péron
6760d63539 ls: Fix clippy warning 2024-01-04 16:51:30 +01:00
Dorian Péron
e30f191579 ls: Handle the use of QUOTING_STYLE variable 2024-01-03 18:37:51 +01:00
Daniel Hofstetter
e4fbc31714 du: ignore duplicate names with --files0-from 2024-01-03 09:39:16 +01:00
Daniel Hofstetter
239e5426e6 du: show error for nul names with --files0-from 2024-01-02 16:06:41 +01:00
Daniel Hofstetter
01e12120c1 mv: simplify condition 2024-01-01 16:48:06 +01:00
Daniel Hofstetter
7ddeba4b98 cp: show no "same file" error for --link a a 2024-01-01 14:30:27 +01:00
Daniel Hofstetter
5673f32c63 cp: show error if source & dest are same file 2023-12-31 16:01:34 +01:00
Daniel Hofstetter
902a128ea8 cp: rename function
is_forbidden_copy_to_same_file -> is_forbidden_to_copy_to_same_file
2023-12-31 14:36:18 +01:00
Daniel Hofstetter
2c42623b6e cp: backup dest symlink linking to source 2023-12-31 14:09:08 +01:00
Sylvestre Ledru
b07ea957d3 rm: improve the code a tiny bit 2023-12-31 12:03:42 +01:00
Sylvestre Ledru
5fc01f718a
Merge pull request #5747 from Ato2207/fix_docs
Fix docs issues.
2023-12-30 19:28:54 +01:00
Vardhan Patil
d990021572 cksum: remove redundant guard 2023-12-30 20:39:09 +05:30
Vardhan Patil
e7cb4e9ff0 cksum: properly handle cases where --lenghth is 0 or >512 2023-12-30 20:28:03 +05:30
Atomei Alexandru
5ade45f8e9
Merge branch 'main' into fix_docs 2023-12-30 15:43:54 +02:00
Vardhan Patil
aec0cfa6e3 cksum: remove commented code 2023-12-30 16:05:20 +05:30
Vardhan Patil
7caa0bcdea cksum: fix formatting in cksum.rs 2023-12-30 16:02:10 +05:30
Vardhan Patil
037073d852 cksum: make the output formatting match GNU 2023-12-30 15:59:29 +05:30
Sylvestre Ledru
138b11efbd
remove extra spaces 2023-12-30 09:53:32 +01:00
Vardhan Patil
231987b109 cksum: create initial implementation of the --length option 2023-12-30 12:48:19 +05:30
Matei Mantu
21d09dd404
ls: unquoted names should be indented with a space if there is a quoted name (#5740)
* ls: change indentation when file names include quotes to match GNU's

* display_grid: Changed order of parameters because it made more sense

* ls -l: Add padding for unquoted filenames

* Fix checking for quoted filenames

* Simplify if
2023-12-29 15:19:26 +01:00
Sylvestre Ledru
448e4c2224
Merge pull request #5745 from cakebaker/cp_adapt_warning
cp: adapt warning if source is used more than once
2023-12-29 15:09:24 +01:00
Alexandru-Constantin Atomei
d15981650a Fixed one typo 2023-12-29 15:08:50 +01:00
Alexandru-Constantin Atomei
1e5244765d Made one more modification to test usage string. 2023-12-29 15:08:50 +01:00
Alexandru-Constantin Atomei
e61318413e Added documentation for the vdir command. 2023-12-29 15:08:50 +01:00
Alexandru-Constantin Atomei
ce28ae5c02 Fixed more and test docs 2023-12-29 15:08:50 +01:00
Sylvestre Ledru
f8f82774c3
Merge pull request #5696 from dvalere/my-conts
src: Fixing typos in signatures for the argument parser
2023-12-29 15:08:39 +01:00
Daniel Hofstetter
7025619325 cp: adapt warning if source is used more than once 2023-12-29 10:24:08 +01:00
Daniel Hofstetter
9bb725cefc clippy: fix warnings introduced by Rust 1.75 2023-12-28 18:17:06 +01:00
Sylvestre Ledru
2c0f15be55 install: if run as root, revert the uid & gid to root 2023-12-28 10:06:13 +01:00
Sylvestre Ledru
0fb3ffb8ad install: document the need_copy function 2023-12-28 10:05:44 +01:00
Sylvestre Ledru
c0206c5ea4 install: document the need_copy function 2023-12-28 10:05:28 +01:00
Sylvestre Ledru
ce18f8a2a1 install: split the need_copy check 2023-12-28 10:03:42 +01:00
Daniel Hofstetter
179f0a7c3c
Merge pull request #5733 from sylvestre/getegid_geteuid
use our getegid & geteuid wrappers function instead of libc calls
2023-12-28 08:49:34 +01:00
Sylvestre Ledru
ad16313c59
head: -c allocate memory as needed (#5704)
* head: -c allocate memory as needed

Improve the execution of tests/head/head-c.sh

* simplify the code

Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>

---------

Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
2023-12-28 07:15:01 +01:00
Sylvestre Ledru
c38a43210c use our getegid & geteuid wrappers function instead of libc calls 2023-12-28 00:35:20 +01:00
Daniel Hofstetter
0701f535ac cp: fix backup of destination symlink 2023-12-27 15:39:54 +01:00
Matei Mantu
bf26eda786
install: remove / from end of path if it exists so as not to mess with .exists() (#5730)
* remove / from end of path if it exists so as not to mess with .exists()

* install: fix / removal from path

* Fix clippy warnings

* Add test for install target ends with /
2023-12-27 13:37:17 +01:00
Darius
edbb7d5b02 join: fixed parameter
basenc: fixed parameter
cut: fixed parameter
mkdir: fixed parameter
nohup: fixed parameter
pr: fixed parameter
printenv: fixed parameter
printf: added parameters
runcon: fixed typo
shuf: fixed typo
sum: fixed typo
uniq: fixed parameter
unlink: fixed parameter
2023-12-26 16:13:18 +01:00
Sylvestre Ledru
167acb5147
Merge pull request #5484 from cakebaker/cp_l_with_dest_hardlink_to_source
cp --link: don't fail if destination is hardlink to source
2023-12-26 16:12:15 +01:00
Sylvestre Ledru
30eb77ac79
du: implement files0-from (#5721)
* du: implement files0-from

Should make tests/du/files0-from-dir pass

* du: prepare tests/du/files0-from.pl

* fix the build on Windows

* add testfile to the ignore list

* remove useless comment

Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>

* mkdir is enough

Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>

* address review comments

---------

Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
2023-12-26 14:40:31 +01:00
Paul Houssel
eb3dd521ee
touch: address cognitive_complexity lint
Signed-off-by: Paul  Houssel <paul.houssel@telecom-sudparis.eu>
2023-12-26 13:02:00 +01:00
Paul Houssel
da43183fc7
cat: address cognitive_complexity lint
Signed-off-by: Paul  Houssel <paul.houssel@telecom-sudparis.eu>
2023-12-26 13:02:00 +01:00
Sylvestre Ledru
db9f4cc315
Merge pull request #5483 from cakebaker/mv_fix_5481
mv: fix subdir detection
2023-12-25 22:02:23 +01:00
Daniel Hofstetter
f10c6f1d56
Merge pull request #5699 from sylvestre/mv-cp-seen
cp/mv/ln: add support for the "will not overwrite just-created"
2023-12-25 14:58:50 +01:00
Daniel Hofstetter
03f1b8aa3a mv: fix subdir detection 2023-12-25 13:12:18 +01:00
Daniel Hofstetter
4946478409 cp: -l don't fail if dest is hardlink to source 2023-12-25 13:03:11 +01:00