Commit graph

5060 commits

Author SHA1 Message Date
Sylvestre Ledru
53b3c782ef add a link to d_type doc 2023-12-24 14:57:06 +01:00
Sylvestre Ledru
a3c7359056 ls: refactor the code 2023-12-24 14:57:06 +01:00
Sylvestre Ledru
5120acb27a fix a clippy warning 2023-12-24 14:57:06 +01:00
Sylvestre Ledru
445d0af277 ls: rename get_metadata_with_deref_opt 2023-12-24 14:57:06 +01:00
Sylvestre Ledru
147721c24b ls: Improve the access to metadata of the files Should fix tests/ls/stat-free-color.sh 2023-12-24 14:57:06 +01:00
Sylvestre Ledru
95fa81250e ls/color_name: use the DirEntry if available 2023-12-24 14:57:06 +01:00
Sylvestre Ledru
1bd8ce5ddf ls/color_name: use PathData instead of a Path as we want to check for DirEntry 2023-12-24 14:57:06 +01:00
Sylvestre Ledru
c0c5ec25b6 ls: rename a function for something more explicit 2023-12-24 14:57:06 +01:00
Sylvestre Ledru
28d684b5ac ls: add a comment 2023-12-24 14:57:06 +01:00
Daniel Hofstetter
4d05f208e0
Merge pull request #5701 from sylvestre/debug
cp: debug with --update=none should show 'skipped'
2023-12-24 14:25:57 +01:00
Daniel Hofstetter
8ede675088
Merge pull request #5712 from sylvestre/shred
shred: improve some output to match GNU's
2023-12-24 14:05:35 +01:00
Daniel Hofstetter
0d05a41f46
Merge pull request #5702 from sylvestre/runcon
runcon: remove trailing '.'
2023-12-24 13:54:52 +01:00
Sylvestre Ledru
c5b08f1c4a shred: improve some output to match GNU's 2023-12-24 11:40:15 +01:00
Sylvestre Ledru
9b78016ac5 runcon: remove trailing '.'
Upstream doesn't have in:
https://github.com/coreutils/coreutils/blob/master/tests/runcon/runcon-no-reorder.sh#L22
2023-12-23 23:03:18 +01:00
Sylvestre Ledru
8685e05f4e cp: debug with --update=none should show 'skipped' 2023-12-23 17:58:05 +01:00
Daniel Hofstetter
be822009f0
Merge pull request #5686 from sylvestre/install-basic
install: with -t, check if we aren't passed a file
2023-12-23 15:33:45 +01:00
Sylvestre Ledru
2832694056
install: support when a hyphen is passed (#5697)
* install: support when a hyphen is passed

Should fix: tests/install/strip-program.sh

Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
2023-12-23 15:29:32 +01:00
Sylvestre Ledru
ceecac110c ln: manages the 'seen' file list before linking
Should help with tests/mv/childproof.sh
2023-12-23 13:53:26 +01:00
Sylvestre Ledru
c94773f522 mv: make sure it continues when hiting an error 2023-12-23 13:27:00 +01:00
Sylvestre Ledru
9c7fd5e8cb mv: rename the variable to match the name in cp 2023-12-23 13:07:54 +01:00
Sylvestre Ledru
3af8ad0fe6 mv: manages the 'seen' file list before moving
Should help with tests/mv/childproof.sh
2023-12-23 13:07:39 +01:00
Sylvestre Ledru
06c98fbdd3 cp: don't fail when --backup=numbered is passed 2023-12-23 12:48:38 +01:00
Sylvestre Ledru
837640bc02 cp: manages the 'seen' file list before copying
Should help with tests/mv/childproof.sh
2023-12-23 12:11:35 +01:00
Sylvestre Ledru
6b1f51385f
Merge pull request #5693 from cakebaker/ls_second_blocksize
ls: introduce 2nd blocksize & fix todos in tests
2023-12-23 09:57:08 +01:00
Sylvestre Ledru
9ca7c3e107 install: with -t, check if we aren't passed a file
Should pass tests/install/basic-1
2023-12-22 18:16:23 +01:00
Daniel Hofstetter
1c6317af76 mv: allow dest with slash when using --update 2023-12-22 17:03:59 +01:00
Daniel Hofstetter
a8a5931cae ls: introduce 2nd blocksize & fix todos in tests 2023-12-22 11:42:01 +01:00
Sylvestre Ledru
e071fd3042
Merge pull request #5684 from allaboutevemirolive/v10_expand
expand: fix duplicate flags
2023-12-21 11:03:09 +01:00
Sylvestre Ledru
95852dbaa5
Merge pull request #5687 from cakebaker/ls_remove_condition
ls: remove condition with unreachable "else" block
2023-12-21 10:44:58 +01:00
Daniel Hofstetter
f16a4ae9c9 ls: remove condition with unreachable "else" block 2023-12-21 09:37:36 +01:00
allaboutevemirolive
3e6187269e fix duplicate flags 2023-12-20 23:30:46 +02:00
Justin !
a6ba81db20
sort: allow -f to be pass multiple time
Fix #5667
2023-12-20 12:42:57 -05:00
Daniel Hofstetter
d8709d2839 ls: recognize BLOCKSIZE env var 2023-12-19 15:00:06 +01:00
Sylvestre Ledru
6bcf4e2cec
tr: add 'boop' to the ignore spell check 2023-12-19 13:26:39 +01:00
Sylvestre Ledru
9920f13a34
Merge pull request #5640 from tertsdiepraam/tr-no-output
`tr`: operate on bytes instead of chars
2023-12-19 11:42:44 +01:00
Sylvestre Ledru
3d42619027
Merge pull request #5674 from cakebaker/ls_ignore_invalid_block_size_from_env_vars
ls: ignore invalid block size from env vars
2023-12-19 11:11:11 +01:00
Daniel Hofstetter
d8f299eb48 ls: mention config.hyperlink in comment 2023-12-19 10:50:36 +01:00
Daniel Hofstetter
ebfbd8b1fe ls: rename display_file_name -> display_item_name 2023-12-19 10:50:36 +01:00
Daniel Hofstetter
a5606613bd ls: ignore invalid block size from env vars 2023-12-19 10:02:34 +01:00
Sylvestre Ledru
52af36d80b
Merge pull request #5673 from tertsdiepraam/expr-fix-comparison
`expr`: coerce to string before comparing values
2023-12-18 22:50:42 +01:00
Terts Diepraam
00b9cbe09e expr: coerce to string before comparing values 2023-12-18 22:24:31 +01:00
Sylvestre Ledru
b32c93ee5e
Merge pull request #5672 from cakebaker/ls_hyperlink_dirs
ls: support hyperlinks for dir names
2023-12-18 18:24:27 +01:00
Sylvestre Ledru
ece9e91593
Merge pull request #5671 from Yykz/wc_args_override
wc: fix arguments not overriding
2023-12-18 15:56:10 +01:00
Daniel Hofstetter
917c6a4743 ls: support hyperlinks for dir names 2023-12-18 15:26:09 +01:00
Daniel Hofstetter
8c6463c525 ls: extract "create_hyperlink" function 2023-12-18 14:25:13 +01:00
Sylvestre Ledru
0fa074fcba
Merge pull request #5629 from cakebaker/ls_hyperlink_encode
ls: encode path when using --hyperlink
2023-12-18 13:38:08 +01:00
Yykz
bd22aba03b make args of wc overriding 2023-12-18 12:47:37 +01:00
Daniel Hofstetter
e79eb097af
Merge pull request #5656 from sylvestre/ls-var
ls: manages the COLOR and COLORTERM variables
2023-12-18 07:16:38 +01:00
Sylvestre Ledru
5b45159996
Improve the comment 2023-12-17 17:40:44 +01:00
Sylvestre Ledru
af2625c8ce
fix order
Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
2023-12-17 17:39:02 +01:00
Akmal
052f38f14d
unexpand: remove crash! macro (#5588)
* unexpand_macro_fixed

* unexpand

* Remove crash

* Passed local test case

* Small changes

* unexpand: remove #[allow(clippy::cognitive_complexity)]

---------

Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
2023-12-17 16:43:00 +01:00
Sylvestre Ledru
35ae43e71f
Merge pull request #5620 from lcheylus/openbsd-utmpx
Support unix feature on OpenBSD (utmpx not supported)
2023-12-16 18:15:11 +01:00
Daniel Hofstetter
9167a84358 ls: enable "colors" feature 2023-12-16 17:17:44 +01:00
Sylvestre Ledru
afc6ac8114
Apply change from c32e730a1f 2023-12-16 10:30:47 +01:00
Sylvestre Ledru
6621a1d6d6
Apply the change from c32e730a1f too 2023-12-16 10:30:17 +01:00
Sylvestre Ledru
1bfac9b25a
Merge branch 'main' into openbsd-utmpx 2023-12-16 10:29:16 +01:00
Sylvestre Ledru
f6d3f9afbf ls: manages the COLOR and COLORTERM variables
Should fix GNU tests/ls/color-term.sh
2023-12-16 09:50:37 +01:00
Sylvestre Ledru
01000a37a3 fix two minor clippy warnings 2023-12-16 09:40:38 +01:00
Daniel Hofstetter
f5b228d876
Merge pull request #5651 from tertsdiepraam/remove-parsemode
`mknod`: remove `parsemode.rs`
2023-12-15 16:36:32 +01:00
Daniel Hofstetter
88428cf5d7
Merge pull request #5649 from tertsdiepraam/remove-collect-lossy-and-ignore
all: remove `collect_{lossy,ignore}` calls where possible
2023-12-15 16:30:08 +01:00
Terts Diepraam
30c27c143c mknod: remove parsemode.rs
This file was entirely unused, so it's probably safe to remove it
2023-12-15 15:56:41 +01:00
Terts Diepraam
c32e730a1f all: remove collect_{lossy,ignore} calls where possible 2023-12-15 14:38:27 +01:00
Arpit Bhadauria
3a7a3bf639
fmt: remove crash! macro (#5589)
* fmt: remove crash! macro

* Fix styling in fmt

* Revert "Fix styling in fmt"

This reverts commit 002e02f50c.

* Revert "fmt: remove crash! macro"

This reverts commit d65a3f85a1.

* Replace crash! with unreachable! macro

* Remove crash! import

* Remove unreachable! from fmt

* keep the helpful comment

* Fix lint and format issues

* review fixes
2023-12-15 12:14:31 +01:00
Sylvestre Ledru
f248cc641c
Merge pull request #5614 from Arp-1/feat-refactor-expr
expr: Optimizing for integer values
2023-12-14 18:50:50 +01:00
Terts Diepraam
7f23faf899 expr: clean up conversion from bigint to usize 2023-12-14 16:35:56 +01:00
Daniel Hofstetter
42558344f1 ls: enable "args override self" 2023-12-12 14:23:51 +01:00
Daniel Hofstetter
89cb4acb99 ls: encode path when using --hyperlink 2023-12-12 10:03:55 +01:00
Arpit Bhadauria
3bf966df56 remove from trait for NumOrStr 2023-12-11 20:47:36 +00:00
Laurent Cheylus
e1032e1f06 who: tool unsupported on OpenBSD
- utmpx not supported on OpenBSD

  - add src/uu/who/src/platform directory and platform/mod.rs for conditional compilation according
    to target_os
  - platform/openbsd.rs: implementation on OpenBSD (unsupported tool)
  - platform/unix.rs: implementation on other OS
  - src/uu/who/src/who.rs: use platform module for uucore::main function
2023-12-11 18:23:35 +01:00
Laurent Cheylus
fdd6ecb713 users: tool unsupported on OpenBSD
- utmpx not supported on OpenBSD

  - add src/uu/users/src/platform directory and platform/mod.rs for conditional compilation
    according to target_os
  - platform/openbsd.rs: implementation on OpenBSD (unsupported tool)
  - platform/unix.rs: implementation on other OS
  - src/uu/users/src/users.rs: use platform module for uucore::main function
2023-12-11 18:23:35 +01:00
Laurent Cheylus
8c6d722916 uptime: tool unsupported on OpenBSD
- utmpx not supported on OpenBSD

  - add src/uu/uptime/src/platform directory and platform/mod.rs for conditional compilation
    according to target_os
  - platform/openbsd.rs: implementation on OpenBSD (unsupported tool)
  - platform/unix.rs: implementation on other OS
  - src/uu/uptime/src/uptime.rs: use platform module for uucore::main function
2023-12-11 18:23:35 +01:00
Laurent Cheylus
d3e6e7a947 pinky: tool unsupported on OpenBSD
- utmpx not supported on OpenBSD

  - add src/uu/pinky/src/platform directory and platform/mod.rs for conditional compilation
    according to target_os
  - platform/openbsd.rs: implementation on OpenBSD (unsupported tool)
  - platform/unix.rs: implementation on other OS
  - src/uu/pinky/src/pinky.rs: use platform module for uucore::main function
2023-12-11 18:23:35 +01:00
Laurent Cheylus
38ea40d0bf nohup: fix for OpenBSD with _vprocmgr_detach_from_console function 2023-12-11 18:23:35 +01:00
Laurent Cheylus
94537d3b34 id: fix support for OpenBSD
- add target_os cfg for pline function
  - add target_os cfg for auditd function (void on OpenBSD)
2023-12-11 18:23:35 +01:00
Laurent Cheylus
d239b2f47b chroot: add OpenBSD support for set_groups function 2023-12-11 18:23:35 +01:00
Daniel Hofstetter
6711dd5694 ls: make --block-size and --human-readable/--si
override each other
2023-12-11 16:38:55 +01:00
Terts Diepraam
181cfc885b
Merge pull request #5634 from cakebaker/ls_use_show_dir_name
ls: use show_dir_name to output dir name
2023-12-11 14:38:47 +01:00
Daniel Hofstetter
3dad5d4d56
Merge pull request #5635 from tertsdiepraam/fix-echo-override
`echo`: make `-e` and `-E` override each other
2023-12-11 14:21:15 +01:00
Terts Diepraam
bc5b5e013a tr: operate on bytes instead of chars 2023-12-11 13:35:17 +01:00
Terts Diepraam
191eb9ac12 echo: make -e and -E override each other 2023-12-11 10:53:55 +01:00
Daniel Hofstetter
3dab2b7390 ls: use show_dir_name to output dir name 2023-12-11 09:33:36 +01:00
Sylvestre Ledru
4442b35370
Merge pull request #5626 from cakebaker/ls_invalid_block_size
ls: handle invalid block size as GNU does
2023-12-11 07:49:38 +01:00
Ian Douglas Scott
db91e12a1d Fix build on Redox, and add stat to Redox feature 2023-12-11 04:38:17 -08:00
Arpit Bhadauria
824371d884 style lint fixes 2023-12-11 02:12:24 +00:00
Arpit Bhadauria
fa0c64ddde review fixes 2023-12-11 02:05:55 +00:00
Arpit Bhadauria
17f2b830d8 Merge branch 'main' into feat-refactor-expr 2023-12-11 01:19:40 +00:00
Dorian Péron
673093f842
ls: set default quoting style to literal when not TTY (#5553)
* ls: set default quoting style to literal if output is not TTY

* tests/ls: Fix quoting tests that now run with Literal as default

* ls: Fix formatting/linting/spelling issues

* tests/ls: Fix windows escaped tests
2023-12-10 16:07:41 +01:00
Sylvestre Ledru
e071286eb0 address review comments 2023-12-09 13:10:41 +01:00
Sylvestre Ledru
268b180416 ls colors: create a stylemanager to carry the previous style to know if we need to reset or not 2023-12-09 13:10:38 +01:00
Sylvestre Ledru
b676216f9b ls: use the gnu_legacy feature from lscolors 2023-12-09 13:05:12 +01:00
Daniel Hofstetter
e9dc2930ee ls: handle invalid block size as GNU does 2023-12-08 19:19:51 +01:00
Daniel Hofstetter
7695fe3fb3
Merge pull request #5623 from tertsdiepraam/du-cleanup
`du` cleanup
2023-12-08 08:21:08 +01:00
Terts Diepraam
7861559f88 du: put excludes in traversaloptions and make size_format enum 2023-12-07 22:12:06 +01:00
Yury Zhytkou
0076c9f64c
Update src/uu/wc/src/count_fast.rs
Co-authored-by: Sylvestre Ledru <sledru@mozilla.com>
2023-12-07 12:13:34 -05:00
zhitkoff
a97b574fec wc: comments 2023-12-07 10:50:55 -05:00
zhitkoff
b7f708b233 wc: comments 2023-12-07 10:50:55 -05:00
zhitkoff
54ac5a7e1a wc: count_fast windows optimization 2023-12-07 10:50:55 -05:00
zhitkoff
9ff7b42d83 wc: stat casting 2023-12-07 10:50:55 -05:00
zhitkoff
9c4d88009d wc: clippy 2023-12-07 10:50:55 -05:00
zhitkoff
85e78376fe wc: count_fast seek optimization 2023-12-07 10:50:55 -05:00
zhitkoff
6186153a08 wc: count_fast optimization using seek 2023-12-07 10:50:55 -05:00
zhitkoff
253926f2e2 wc: unix input redirect 2023-12-07 10:50:55 -05:00
zhitkoff
054ca4a6b5 wc: better handle files in pseudo-filesystems 2023-12-07 10:50:55 -05:00
Sylvestre Ledru
ca024abe31
Merge pull request #5554 from cakebaker/mv_no_target_directory
mv: fix issue with -T and destination ending with "/"
2023-12-07 14:13:06 +01:00
Terts Diepraam
d6b10d4d72 du: split traversal and printing options 2023-12-07 11:26:44 +01:00
Terts Diepraam
6cae191569 du: remove ArgMatches from StatPrinter 2023-12-07 11:06:04 +01:00
Terts Diepraam
09999427cc du: merge imports 2023-12-07 10:02:29 +01:00
Sylvestre Ledru
fe730f8a49
Merge pull request #5611 from sylvestre/dirdb
dircolors: Move the static long string into structures.
2023-12-07 09:58:55 +01:00
Daniel Hofstetter
5a32ab8004 ls: implement --hyperlink 2023-12-07 08:14:25 +01:00
Sylvestre Ledru
80b1ccd665
Merge pull request #5609 from cakebaker/ls_ignore_value_of_posixly_correct
ls: ignore value of `POSIXLY_CORRECT`
2023-12-06 21:27:21 +01:00
Sylvestre Ledru
f99987bb35 fix rustfmt 2023-12-06 21:19:59 +01:00
Sylvestre Ledru
bd667efa7b
simplify the declaration
Co-authored-by: Terts Diepraam <terts.diepraam@gmail.com>
2023-12-06 21:15:43 +01:00
Sylvestre Ledru
97ec99cf28
use a single push_str
Co-authored-by: Terts Diepraam <terts.diepraam@gmail.com>
2023-12-06 21:14:59 +01:00
Arpit Bhadauria
4d2ae8485c impl from trait instead of into 2023-12-04 22:44:18 +00:00
Sylvestre Ledru
b0fdb1edef Rest of the comments 2023-12-04 23:39:10 +01:00
Sylvestre Ledru
dabbcff9fb dircolors: manage the --print-ls-colors pipe option 2023-12-04 22:41:03 +01:00
Daniel Hofstetter
cf853df2dc ls: remove "#[allow(unused_variables)]" 2023-12-04 14:48:25 +01:00
Arpit Bhadauria
9ecd6a296e Refactoring for lint issues 2023-12-03 23:32:51 +00:00
Arpit Bhadauria
21c041fa79 Fix lint issues in expr 2023-12-03 22:27:13 +00:00
Arpit Bhadauria
5672e3d9bd Fix errors 2023-12-03 22:07:56 +00:00
Arpit Bhadauria
f8573d5551 code and styling fixes in expr 2023-12-03 20:03:50 +00:00
Arpit Bhadauria
d8a64a90ec Formatting fixes in expr 2023-12-03 15:09:12 +00:00
Daniel Hofstetter
51fc2d7564 ls: ignore value of POSIXLY_CORRECT 2023-12-03 16:01:19 +01:00
Daniel Hofstetter
c77d389f5b ls: improve some var names related to block sizes 2023-12-03 14:58:14 +01:00
Daniel Hofstetter
a6d15d67ca ls: cleanup "spell-checker:ignore" entries 2023-12-03 14:58:14 +01:00
Arpit Bhadauria
117ab7737a Optimize expr for numerical values 2023-12-02 17:25:57 +00:00
Sylvestre Ledru
1a4ca7e65d fix clippy warnings 2023-12-02 15:19:37 +01:00
Sylvestre Ledru
e4b8750434 dircolors -p: generate it dynamically 2023-12-02 15:10:00 +01:00
Sylvestre Ledru
5d19f79cd0 dircolors should use the datastructures when printing 2023-12-02 15:04:39 +01:00
Sylvestre Ledru
0e8c171c80 dircolors: move the FILE_ATTRIBUTE_CODES datastructures and use it 2023-12-02 11:03:51 +01:00
Sylvestre Ledru
e24d6b2fbd
Merge pull request #5604 from cakebaker/ls_fix_padding
ls: fix padding of size column when using `-l`
2023-12-02 09:40:18 +01:00
Daniel Hofstetter
0ec6802459 ls: fix padding of size column when using -l 2023-11-30 16:19:27 +01:00
clara swanson
9061b2ba7e
libstdbuf: remove crash macro (#5565)
* libstdbuf: remove crash macro

* libstdbuf: remove uucore macro/struct and use gnu messages

* libstdbuf: remove crash macro

* libstdbuf: remove uucore macro/struct and use gnu messages

* libstdbuf: remove :? from print by printing file descriptor instead of file

* merge main into libstdbuf-remove-crash-macro

* libstdbuf: remove uucore from dependencies
2023-11-30 11:01:31 +01:00
Sylvestre Ledru
3cadeb734d
Merge pull request #5561 from tertsdiepraam/fixup-macros
all: reduce imports needed for `show` and `show_if_err` macros
2023-11-29 15:10:59 +01:00
Sylvestre Ledru
203e79d74b
Fix unused import: UError 2023-11-29 14:09:13 +01:00
Daniel Hofstetter
6eec4fe8f9 cut: add test & improve error message 2023-11-29 09:41:11 +01:00
Daniel Hofstetter
2d5ea26410 fmt: rename pfxind_end -> prefix_indent_end 2023-11-28 14:42:28 +01:00
Daniel Hofstetter
32bc2e4bc8
Merge pull request #5592 from tertsdiepraam/fmt-small-refactor
`fmt`: a collection of small refactors
2023-11-28 14:15:30 +01:00
Terts Diepraam
2a8f4ec294 fmt: inline parse_arguments function 2023-11-28 12:42:23 +01:00
Terts Diepraam
0b4d4b610c fmt: put options into module and change static to const 2023-11-28 12:42:23 +01:00
Terts Diepraam
8a49453057 fmt: clean up imports 2023-11-28 12:42:23 +01:00
Terts Diepraam
96ca5e609e fmt: refactor width and goal calculation 2023-11-28 12:42:23 +01:00
Terts Diepraam
f5206ce783 fmt: merge prefix and use_prefix options (same for anti_prefix) 2023-11-28 12:42:20 +01:00
Terts Diepraam
d78923e4cc fmt: extract determining options to separate function 2023-11-28 12:37:09 +01:00
Terts Diepraam
01c32a5220 fmt: clean up some small bits 2023-11-28 11:40:33 +01:00
Sylvestre Ledru
b5ce876fef
Merge pull request #5580 from zhitkoff/split-r-chunk
split: passing GNU test r-chunk.sh
2023-11-28 10:38:00 +01:00
Sylvestre Ledru
14a8e8a452
Merge pull request #5128 from tertsdiepraam/printf-rewrite
`printf` rewrite (with a lot of `seq` changes)
2023-11-28 07:52:58 +01:00
Terts Diepraam
83784b2d96 expr: refactor AST and parsing 2023-11-27 15:18:14 +01:00
Terts Diepraam
8eb66ab7ea printf: remove whitespace, remove redundant spelling ignore and revert matching on result 2023-11-27 11:53:26 +01:00
Sylvestre Ledru
88d63be3a0
Merge pull request #4545 from jfinkels/dd-reblock
dd: buffer partial blocks in the output writer
2023-11-27 09:31:36 +01:00
Daniel Hofstetter
55d931e853
Merge pull request #5582 from zhitkoff/wc-files
wc: pass GNU test wc-files0-from.pl
2023-11-27 06:57:43 +01:00
Jeffrey Finkelstein
ceccd2ecc6 dd: buffer partial blocks in the output writer
Add buffering of partial blocks in the output block writer until they
are completed.
2023-11-26 18:03:06 -05:00
Jeffrey Finkelstein
f343b7e964 dd: use read statistics for termination condition
Correct the behavior of `dd` so that the termination condition of the
main loop uses the number of bytes read, not the number of bytes
written, when the `count` command-line option is given in bytes
instead of blocks.
2023-11-26 18:03:06 -05:00
Jeffrey Finkelstein
b383e60998 dd: implement Add for WriteStat 2023-11-26 18:03:06 -05:00
Jeffrey Finkelstein
5142f35f83 dd: add BufferedOutput to buffer partial blocks 2023-11-26 18:03:06 -05:00
Jeffrey Finkelstein
016ae34d50 dd: add Settings.buffered field
Add the `Settings.buffered` field to indicate whether partial output
blocks should be buffered until they are complete.
2023-11-26 18:03:06 -05:00
zhitkoff
16f6a13697 wc: change where to unwrap 2023-11-26 15:14:48 -05:00
Gary Yendell
b6553edfb7 hashsum: Remove usage of crash! macro 2023-11-26 10:38:01 +00:00
zhitkoff
f8f6346126 wc: fix FilesDisabled error message 2023-11-25 18:16:34 -05:00
zhitkoff
7b2a3e236e split: r-chunk tests and infinite input 2023-11-25 11:12:08 -05:00
zhitkoff
440e7b1a59 split: r-chunk test compliance 2023-11-25 11:12:08 -05:00
zhitkoff
dc92a434ef split: handling system limit on open files 2023-11-25 11:12:08 -05:00
Clint Teece
84b5e6f0a1
du: start printing output immediately (#5552)
* du: very rough draft of continuously printing output

* du: clean up printing logic, still needs some polishing

* du: gracefully handle case where `du` returns no `Stat`s

* du: print output using separate thread

* du: clean up print thread implementation

* du: send ownership of `Stat`s to printing thread as soon as `du` is done with them

* du: add basic error handling for communication between threads, use `StatPrinter` to handle printing thread logic

* du: move printing grand total into `StatPrinter`, and move initialization of printing-related variables into `StatPrinter::new`

* du: clean up calculation of `convert_size` function, and separate printing a single stat our into its own method in `StatPrinter`

* du: have printing thread handle printing IO-related errors, to ensure error messages and regular output message are written one at a time

* du: add comment explaining print thread, remove outdated comments and clippy allows

* du: restore clippy allows for cognitive complexity

---------

Co-authored-by: clint <cteece3@gatech.edu>
2023-11-25 15:13:12 +01:00
Sylvestre Ledru
64d47730bc
Merge pull request #5555 from cakebaker/cp_adapt_omitting_dir_msg
cp: improve error msg if -r is not specified
2023-11-24 21:51:04 +01:00
zhitkoff
4dc46f10e9 split: pass GNU test l-chunk 2023-11-24 10:06:16 +01:00
Coba Weel
7efe33108a Fix issue 5576 (regex matching bug in expr)
Issue 5576 reported a bug in expr, found by the fuzzer. The problem
turns out to be with the regex match operator `:`, which is defined in
POSIX and the GNU manual to match the pattern only when it occurs at
the beginning of the string, i.e., the regex has an implicit `^`
prepended to it. We hadn't been doing that.
2023-11-23 16:26:37 +01:00
Daniel Hofstetter
c2bfb6a465 expr: adapt error messages, revert most of #5559 2023-11-23 15:14:25 +01:00
Daniel Hofstetter
2e77d99dd4 expr: fail fast if there are no operands 2023-11-23 14:35:02 +01:00
Sylvestre Ledru
af021e0d4f
Merge pull request #5559 from pawelngei/expr-substr-error
expr: different stderr with `expr "56" "substr"`
2023-11-22 14:56:42 +01:00
Zhuoxun Yang
17d21d2d9c expr: check prefix operation 2023-11-21 22:05:41 +08:00
Terts Diepraam
da7c168f9d all: reduce imports needed for show and show_if_err macros 2023-11-21 12:49:07 +01:00
ALXD
d2ede92736 expr: make error messages align with GNU expr 2023-11-21 10:14:24 +01:00
Terts Diepraam
5c04283d6e printf: address fmt, clippy, spelling and failing test 2023-11-21 00:42:02 +01:00
Terts Diepraam
6d2698b802 Merge branch 'main' into printf-rewrite 2023-11-20 13:53:11 +01:00
clara swanson
58087df02a
stdbuf: remove crash macro (#5549)
* stdbuf: remove crash! macro

* stdbuf: change target_vendor back to apple

* tests/stdbuf: change stderr_only to usage_error in test_stdbuf_invalid_mode_fails

* stdbuf: add exit code to check_option

* stdbuf: remove set_exit_code line from error
2023-11-20 10:16:18 +01:00
Daniel Hofstetter
285e580b6e cp: improve error msg if -r is not specified 2023-11-20 09:15:15 +01:00
Daniel Hofstetter
8e796d3bb6 mv: fix issue with -T and dest ending with "/" 2023-11-19 15:10:28 +01:00
Yury Zhytkou
eb00c195c6
split: pass GNU tests/b-chunk.sh (#5475)
---------

Co-authored-by: Terts Diepraam <terts.diepraam@gmail.com>
Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
Co-authored-by: Brandon Elam Barker <brandon.barker@gmail.com>
Co-authored-by: Kostiantyn Hryshchuk <statheres@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-11-17 17:19:10 +01:00
Terts Diepraam
4aafb3f88b printf: exit correctly on \c 2023-11-17 14:46:00 +01:00
Daniel Hofstetter
a7e5af4770
Merge pull request #5540 from cswn/join-remove-crash-macro
join: remove crash! macro
2023-11-17 07:00:55 +01:00
Terts Diepraam
eaf5006379 printf: parse arguments and handle escape codes 2023-11-16 17:00:41 +01:00
Daniel Hofstetter
2f9fcf73fa clippy: fix warnings introduced by Rust 1.74 2023-11-16 16:21:28 +01:00
Terts Diepraam
e7d58f673f seq: simplify and use new printf implementation 2023-11-16 14:29:49 +01:00
cswn
65dc70b553 join: remove match in uumain and return exec result 2023-11-16 12:02:39 +01:00
cswn
a064c88656 join: replace match with JoinError with map_err_context 2023-11-16 09:35:32 +01:00
cswn
5dff5f2f73 join: rename f variable to file_buf 2023-11-15 13:52:01 +01:00
cswn
94f6702ba5 join: remove crash! macro 2023-11-15 13:20:22 +01:00
Daniel Hofstetter
0db834e04c
Merge pull request #5533 from cswn/split-remove-crash-macro
split: remove crash macro
2023-11-15 10:14:43 +01:00
Sylvestre Ledru
3f86bc59de add missing features to uucore 2023-11-15 08:31:53 +01:00
cswn
c4580df2a4 split: remove crash macro 2023-11-14 18:07:35 +01:00
Sylvestre Ledru
ff92bfb25b Prepare version 0.0.23 2023-11-13 22:02:01 +01:00
Terts Diepraam
6481d63ea4 uucore/format: implement single specifier formats 2023-11-13 15:22:49 +01:00
Terts Diepraam
0a07d47243
Merge pull request #5493 from cakebaker/du_inodes_with_count_links
du: make -l/--count-links work
2023-11-13 13:12:35 +01:00
Daniel Hofstetter
7202d01767
Merge pull request #5510 from ceteece/expand-remove-crash-macro
expand: remove crash! macro
2023-11-10 14:42:23 +01:00
clint
a29ddea4e9 expand: clarify tabstops argument name for expand_line 2023-11-09 15:58:12 -05:00
Daniel Hofstetter
85777e6a42 du: rename inodes -> seen_inodes 2023-11-09 16:11:56 +01:00
Daniel Hofstetter
12e61d451c du: make -l/--count-links work 2023-11-09 16:07:02 +01:00
Terts Diepraam
ee0e2c042b dd: use num_format::Float directly instead of printf 2023-11-09 16:05:38 +01:00
Daniel Hofstetter
6fa8a6d200
Merge pull request #5501 from alexhausen/du-remove-crash-macro
du: remove crash! macro
2023-11-09 10:04:37 +01:00
clint
fc00b6bfc9 expand: move logic to expand a single line into its own function 2023-11-08 23:36:46 -05:00
Zhuoxun Yang
7279bc1741 printf.md: support %q 2023-11-09 10:16:53 +08:00
Alexandre Hausen
4d40555cd5 fixup! du: remove crash! macro 2023-11-08 20:32:03 -03:00
clint
3411c25112 expand: make error output the same as it was 2023-11-07 20:18:58 -05:00
clint
46d4ebff4c expand: remove crash! macro 2023-11-07 18:02:13 -05:00
Sylvestre Ledru
4a3efadf70
Merge pull request #5506 from cakebaker/du_h_dereference_args
du: add -H (alias for --dereference-args)
2023-11-07 13:05:41 +01:00
Terts Diepraam
188b26e8aa
Merge pull request #5504 from cakebaker/du_use_blocks
du: use blocks to remove some cfgs
2023-11-07 12:03:41 +01:00
Taylor
6678c17c52
mktemp: add func to expose functionality (for use in nushell) (#5479)
* mktemp: add func to expose functionality

* mktemp: cleanup
2023-11-07 11:43:58 +01:00
Daniel Hofstetter
7afb8461cb du: add -H (alias for --dereference-args) 2023-11-07 10:30:54 +01:00
Daniel Hofstetter
993a995f8a du: remove unnecessary return 2023-11-06 10:22:01 +01:00
Daniel Hofstetter
2571af8ede du: use blocks to remove some cfgs 2023-11-06 10:15:47 +01:00
Alexandre Hausen
e11878e7ba du: remove crash! macro 2023-11-05 20:58:04 -03:00
Kostiantyn Hryshchuk
6ac1af6953 Fix clippy::implicit_clone 2023-11-04 21:04:29 +01:00
Daniel Hofstetter
29f6631554 du: add -P/--no-dereference 2023-11-03 17:17:44 +01:00
Daniel Hofstetter
f8c474ecb3
Merge pull request #5449 from zhitkoff/split-suffix-length-refactor
split: suffix length refactor
2023-11-03 08:28:48 +01:00
Daniel Hofstetter
0cad85f2fb
Merge pull request #5486 from tertsdiepraam/cp-remove-crash-call
`cp`: remove `crash!` call
2023-11-03 08:23:24 +01:00
zhitkoff
62887c7a58 split: directory separator in additional suffix 2023-11-02 17:17:38 +01:00
zhitkoff
f05474a33a split: slash separator 2023-11-02 17:17:38 +01:00
zhitkoff
8372a3d2cc split: refactor filename suffix 2023-11-02 17:17:38 +01:00
zhitkoff
fbb454a080 split: suffix auto-widening and auto-width tests 2023-11-02 17:17:38 +01:00
zhitkoff
733359d48b split: refactor suffix auto-widening and auto-width 2023-11-02 17:17:38 +01:00
Terts Diepraam
a6522e0114 cp: remove crash! call
It seems to be unnecessary since we have already made the path relative
using `construct_dest_path`.
2023-11-02 16:23:31 +01:00
tommady
a4775d288b
cp: fix cp -rT dir dir2 leads to different result than with GNU cp (#5467)
* add a test case test_cp_treat_dest_as_a_normal_file

* fix 5457

* cp: fix comment

---------

Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
2023-10-30 17:55:03 +01:00
Daniel Hofstetter
f39ab620a6 cat: use error code 62 for ELOOP on FreeBSD 2023-10-30 07:14:26 +01:00
Sylvestre Ledru
c24a51403a
cat: return the same error message as GNU with loop symlink (#5466)
* cat: return the same error message as GNU with loop symlink

Should fix tests/du/long-sloop.sh because it is using cat as a ref
for error messages

Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
2023-10-28 22:29:24 +02:00
Terts Diepraam
f117fc1bab printf rewrite: fix compilation 2023-10-28 17:36:43 +02:00
Daniel Hofstetter
e887944ef1 Remove "last synced with" comments 2023-10-28 16:53:09 +02:00
Terts Diepraam
28810906a3 Merge branch 'main' into printf-rewrite 2023-10-28 16:35:58 +02:00
Mick van Gelderen
5c100dd088
mv: Fix stderr output mv file into dir and dir into file where both are files (#5464)
* Add tests mv file into dir and dir into file where both are files

* Fix test_mv_dir_into_file_where_both_are_files

* Fix test_mv_file_into_dir_where_both_are_files

* Store String in error instead of PathBuf

* Implement path_ends_with_terminator for windows

* Fix compilation on windows
2023-10-28 15:04:51 +02:00
Daniel Hofstetter
32b335a73a mv: rename canonized_* -> canonicalized_* 2023-10-25 16:46:33 +02:00
Daniel Hofstetter
6085cf12e3
Merge pull request #5353 from tommady/fix-5327
cp: fix cp -a --no-preserve=mode doesn't keep fully the mode
2023-10-25 13:34:45 +02:00
Terts Diepraam
96d0830952
Merge pull request #5446 from cakebaker/ls_try_get_matches_from
ls: use try_get_matches_from instead of get_matches_from
2023-10-25 11:25:40 +02:00
Daniel Hofstetter
f8a30d524e
cp: rename handling_no_preserve_mode
to handle_no_preserve_mode
2023-10-25 10:43:23 +02:00
Daniel Hofstetter
086f7b548c
cp: replace word in comment 2023-10-25 10:20:01 +02:00
Daniel Hofstetter
6f84e56e28 ls: return exit code 2 for invalid time-style 2023-10-24 16:33:04 +02:00
Daniel Hofstetter
fd18d2686f ls: return exit code 2 for -l --dired --zero 2023-10-24 14:48:24 +02:00
David Matos
769eb29cd3
mv: moving directory itself should fail (#5429)
* mv: moving directory itself should fail

* mv: Check trailing slash also fails on target containing itself

* mv: add "spell-checker:ignore mydir" to test

---------

Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
2023-10-24 10:54:23 +02:00
Daniel Hofstetter
d7b7dfeb16 ls: use try_get_matches_from instead of
get_matches_from to replace clap's exit code
2023-10-24 10:07:28 +02:00
Yury Zhytkou
a3fed79b5c
split: suffix auto length (#5433) 2023-10-23 22:47:39 +02:00
Sylvestre Ledru
209ffe831d
Merge pull request #5441 from n1000/test_ot_fix
test: use mtime for -ot and fix direction of comparison
2023-10-23 20:59:30 +02:00
Daniel Hofstetter
aa2e9c11bc
Merge pull request #5439 from sylvestre/runcon-error
runcon: generate the same error as GNUs
2023-10-23 07:28:23 +02:00
Nathan Houghton
dbfd700502 test: use mtime for -ot and fix direction of comparison
- Use the file modification time instead of the creation time (matches
  GNU coreutils documentation)

- Fix direction of comparison (a < b instead of a > b)

- Extend test case to cover both the 0 and 1 exit code cases
2023-10-22 17:44:40 -07:00
Daniel Hofstetter
94492c98a5 cp: --rem don't fail if dest is hardlink to source 2023-10-22 22:17:49 +02:00
Sylvestre Ledru
03d598d08b
Merge pull request #5430 from cakebaker/cp_remove_destination_shouldnt_fail
cp --remove-destination: don't fail if destination is symlink to source
2023-10-22 22:17:32 +02:00
Sylvestre Ledru
897af02d9d runcon: generate the same error as GNUs
tested in tests/runcon/runcon-no-reorder.sh
2023-10-22 21:43:49 +02:00
Sylvestre Ledru
4472acf909 ls --dired: document the whole thing 2023-10-20 13:29:38 +02:00
Daniel Hofstetter
772892e2e4 cp: --rem don't fail if dest is symlink to source 2023-10-20 09:41:30 +02:00
Yury Zhytkou
eede467e21
split : --filter and stdin updates (#5418) 2023-10-20 08:47:32 +02:00
Sylvestre Ledru
f971a69d69
ls --dired -R: fix the positions (#5341)
* move get_offset_from_previous_line into a specific function

* dired: improve the -R support

* dired: fix the display with subdir

* ls --dired -R: fix the positions

* ls --dired -R: verify also the SUBDIRED coordinate

* ls --dired -R: add a long file name and fix a windows test

* dired: always put dired first in the args + minor fixes

Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>

* ls: add cognitive_complexity to silent a warning

---------

Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
2023-10-19 14:17:34 +02:00
Daniel Hofstetter
383dcde51a
mv: comment why some imports are public 2023-10-19 10:08:45 +02:00
David Matos
90c2dbb0cc mv: make UpdateMode public 2023-10-19 09:50:21 +02:00
Daniel Hofstetter
a3c6d6d91e
Merge pull request #5423 from Luv-Ray/fix-pathchk-issue5314
`pathchk`: check empty path by default
2023-10-19 09:33:42 +02:00
Sylvestre Ledru
4573eb693f
Merge pull request #5357 from zhitkoff/issue5334-uucore-parse-r-q
Implement SI prefixes R and Q
2023-10-18 18:55:17 +02:00
Zhuoxun Yang
1ab8555a94 pathchk: check empty path 2023-10-18 22:50:43 +08:00
Daniel Hofstetter
7a608196dc
Merge pull request #5356 from terade/refactoring_prompt_file
`rm`: refactor `prompt_file`, issue #5345
2023-10-18 07:04:22 +02:00
terade
b6a6a4dc65 rm: apply suggestion of retrieving metatada in function 2023-10-17 17:26:27 +02:00
zhitkoff
cb7479e823 uucore: implement SI suffixes R and Q 2023-10-17 10:50:50 -04:00
Zhuoxun Yang
d325a952ee expr: return "0" for | 2023-10-17 22:27:47 +08:00
Zhuoxun Yang
8a67224917 expr: add assert for & 2023-10-17 22:27:10 +08:00
Daniel Hofstetter
ce0cf7a569
Merge pull request #5367 from sylvestre/join
join: remove a clippy::cognitive_complexity by moving some content in functions
2023-10-16 11:41:47 +02:00
Sylvestre Ledru
f8436728dc
add field_reassign_with_default ignore
Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
2023-10-16 10:47:38 +02:00
Daniel Hofstetter
541ac6a813
Merge pull request #5403 from sylvestre/rm
rm: In some cases, remove_dir is doing a better job than remove_dir_all
2023-10-16 09:35:44 +02:00
Sylvestre Ledru
3a780453a9 join: remove a clippy::cognitive_complexity by moving some content into functions 2023-10-16 08:15:02 +02:00
Sylvestre Ledru
73b7c46131
Merge pull request #5409 from sylvestre/version-22
0.0.21 => 0.0.22
2023-10-15 15:50:01 +02:00
Sylvestre Ledru
e1bd47d549 0.0.21 => 0.0.22 2023-10-15 14:33:23 +02:00
Daniel Hofstetter
6ef5b272da
expr: add missing word to comment 2023-10-15 14:30:17 +02:00
Zhuoxun Yang
4f20773b4f expr: fix escape 2023-10-14 23:20:45 +08:00
Sylvestre Ledru
226680aa00
Ignore inacc spell 2023-10-14 13:45:29 +02:00
Sylvestre Ledru
505ef714b9 rm: In some cases, remove_dir is doing a better job than remove_dir_all
use it when remove_dir_all failed

GNU compatibility (rm/empty-inacc.sh)
2023-10-14 12:09:27 +02:00
Zhuoxun Yang
ae1c4ccfd2 expr: short-circuit evaluation for & 2023-10-14 01:56:38 +08:00
Sylvestre Ledru
3cd5f9d175
Merge pull request #5401 from cakebaker/clippy_suppress_cognitive_complexity_warning
clippy: suppress cognitive_complexity lint in some tests
2023-10-13 15:41:35 +02:00
Daniel Hofstetter
a69d48fb8c clippy: suppress cognitive_complexity lint 2023-10-13 14:53:32 +02:00
Daniel Hofstetter
617de9b636
Merge pull request #5397 from sylvestre/ls-42
ls: Document a bit tests/ls/stat-dtype.sh
2023-10-13 14:38:31 +02:00
Sylvestre Ledru
8931cfa93d
improve the wordin
Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
2023-10-13 11:18:00 +02:00
Sylvestre Ledru
8826e47d36
ignore dtype in the spell 2023-10-13 10:30:31 +02:00
Daniel Hofstetter
f1f4823feb who: suppress cognitive_complexity lint 2023-10-13 08:26:06 +02:00
Sylvestre Ledru
94972d45c7 ls: Document a bit tests/ls/stat-dtype.sh 2023-10-12 23:37:07 +02:00
tommady
c9fa07035b
fix linter errors 2023-10-12 02:52:02 +00:00
tommady
9be5583d36
Update src/uu/cp/src/cp.rs
Co-authored-by: Sylvestre Ledru <sledru@mozilla.com>
2023-10-12 10:42:52 +08:00
tommady
7ea19c7c5d
Update src/uu/cp/src/cp.rs
Co-authored-by: Sylvestre Ledru <sledru@mozilla.com>
2023-10-12 10:42:44 +08:00
zhitkoff
a920464952 split: undocumented options aliases + help fix 2023-10-11 12:13:22 -04:00
tommady
254007ffe0
Merge branch 'main' into fix-5327 2023-10-11 18:15:18 +08:00
tommady
c59b0f11fd
fix linter 2023-10-11 08:57:04 +00:00
tommady
edb5b65b01
Merge branch 'main' of github.com:uutils/coreutils into fix-5327 2023-10-11 08:39:52 +00:00
tommady
78e1eae1ef
address comment 2023-10-11 08:29:13 +00:00
Miles Liu
3b971e4806
ls: move to uutils-term-grid 2023-10-11 16:26:36 +08:00
tommady
6cb0d5ad7d
add comment for explicit in the Preserve enum 2023-10-11 07:53:03 +00:00
Sylvestre Ledru
f3f82c14af
Merge pull request #5381 from howard0su/df_wsl
Fix overflow error on WSL. Default to 0 when the values are non-sense.
2023-10-10 13:10:40 +02:00
Sylvestre Ledru
95a1a08de3
Add two words to the ignore spell list 2023-10-10 09:07:32 +02:00
Daniel Hofstetter
c70a47fa93
Merge pull request #5329 from KAAtheWiseGit/main
`mkdir`: make `mkdir` public and document it
2023-10-10 08:21:17 +02:00
Howard Su
d2cacdfce2 Fix overflow error on WSL. Default to 0 when the values are non-sense. 2023-10-09 22:16:09 +08:00
Sylvestre Ledru
b802c8cc3f
Merge branch 'main' into clippy2 2023-10-09 15:49:25 +02:00
Sylvestre Ledru
8e8a91be5d Ignore more cognitive_complexity 2023-10-08 17:46:11 +02:00
Daniel Hofstetter
7e08562ee6 expr: add some empty lines 2023-10-08 15:02:01 +02:00
Daniel Hofstetter
94f5fa9487
Merge pull request #5365 from Luv-Ray/fix-expr
`expr`: short-circuit evaluation for `|`
2023-10-08 14:55:59 +02:00
Sylvestre Ledru
c53ca6d6fc
Merge pull request #5372 from sanpii/ls-panic
ls: fix panic when file removed too quickly
2023-10-08 10:54:19 +02:00
Daniel Hofstetter
1038508a58
Merge pull request #5335 from PThorpe92/mv_nushell
mv: expose main functionality for nushell
2023-10-07 16:46:45 +02:00
Sylvestre Ledru
77c120db2d
Merge pull request #5373 from cakebaker/head_add_some_empty_lines
head: add some empty lines
2023-10-07 16:32:41 +02:00
Daniel Hofstetter
f86469f6d5 head: add some empty lines 2023-10-07 16:04:21 +02:00
Daniel Hofstetter
2ba7400d05 clippy: suppress cognitive_complexity lint
for two functions
2023-10-07 15:15:44 +02:00
Sylvestre Ledru
3e1d3caceb
head: remove clippy::cognitive_complexity by moving some content in a function (#5366)
* head: remove a clippy::cognitive_complexity by moving some content into a function

* Remove duplicate comment
2023-10-07 13:37:24 +02:00