Nick Fitzgerald
1be7d31d5a
tests/tail: Refactor the test_single_big_args test to use ScopedFile
2016-03-27 14:34:59 -07:00
Nick Fitzgerald
a629bb3076
tests: Create the ScopedFile type for temporary files in tests
...
This commit adds the `ScopedFile` type, which wraps and derefs to a `File`. When
a `ScopedFile` is dropped, it removes the underlying file from the
filesystem. This is useful for temporary, generated files in tests.
2016-03-27 14:34:59 -07:00
Nick Fitzgerald
2b2c2b64c2
tail: When tailing a file in bytes mode, seek directly to the specified byte
...
When tailing a file, as opposed to stdin, and we are tailing bytes rather than
lines, we can seek the requested number of bytes from the end of the file. This
side steps the whole `backwards_thru_file` file loop and blocks of reads.
Fixes #833 .
2016-03-27 14:34:58 -07:00
Nick Fitzgerald
f851611001
tail: Pre-fill the buffer with zeroes
...
Rather than fill the buffer on every file read iteration, pre-fill it with
zeroes once at initialization time.
2016-03-27 14:34:58 -07:00
Heather
183224db15
Merge pull request #852 from jbcrail/contributing-commit-msgs
...
CONTRIBUTING: add guidelines for commit msgs
2016-03-27 19:50:56 +04:00
Joseph Crail
ec14be84aa
tests/pwd: fix broken Windows test
...
Due to canonicalize()'s use of GetFinalPathNameByHandleW() on Windows,
the resolved path starts with '\\?\' to extend the limit of a given path
to 32,767 wide characters.
To address this issue, we remove this prepended string if available.
2016-03-27 03:28:55 -04:00
Joseph Crail
e0c21b99c5
Merge pull request #851 from fitzgen/tests-for-tail-bytes
...
Tests for `tail -c <bytes>`
2016-03-26 18:38:41 -04:00
Joseph Crail
7990fa11bf
CONTRIBUTING: add guidelines for commit msgs
2016-03-26 18:31:01 -04:00
Nick Fitzgerald
9824bc4db3
Add a test for tail -c <BYTES> from stdin
2016-03-26 11:56:00 -07:00
Nick Fitzgerald
445233389e
Add a test for tail -c <BYTES> <FILE>
2016-03-26 11:52:10 -07:00
Michael Gehring
1922267076
Merge pull request #844 from jbcrail/sort_add_month
...
sort: refactor and add month sort
2016-03-26 07:26:13 +01:00
Jeremiah Peschka
e7458b6086
Fixing trailing semicolon in display_permissions
2016-03-25 18:43:43 -07:00
Jeremiah Peschka
539da3ba1a
Changed display_symlink_count to use the right variable name. Removed dead code.
2016-03-25 16:36:34 -07:00
Jeremiah Peschka
6e562faae1
tabs not spaces
2016-03-25 15:30:25 -07:00
Jeremiah Peschka
0bb0c40c36
Adding tests for ls. Corrected issue with ls on the present directory throwing panic!()
2016-03-25 14:25:52 -07:00
Jeremiah Peschka
825a850fa9
Wishing I could spell my own name.
2016-03-25 14:18:23 -07:00
Jeremiah Peschka
9716862cfe
Adding skeleton of ls
2016-03-25 14:00:27 -07:00
Joseph Crail
491320747b
sort: remove explicit enum values
2016-03-25 16:55:58 -04:00
Joseph Crail
faedb2dd2e
tests/sort: fix flag for human numeric test
2016-03-25 16:55:58 -04:00
Joseph Crail
55c0b1786f
tests/sort: add tests for month sort
2016-03-25 16:55:58 -04:00
Joseph Crail
2cdccb10bb
sort: fix whitespace and spelling
2016-03-25 16:55:58 -04:00
Joseph Crail
cc63565051
sort: add month sort
2016-03-25 16:55:58 -04:00
Joseph Crail
678a3d1451
sort: fix flag for human numeric sort
2016-03-25 16:55:50 -04:00
Joseph Crail
6488f168fb
sort: refactor settings into dedicated struct
2016-03-25 16:51:39 -04:00
Heather
9c477a9ca8
Merge pull request #843 from llogiq/clippy
...
fix two clippy warnings
2016-03-24 15:38:45 +04:00
Andre Bogus
986c00cd91
fix two clippy warnings
2016-03-24 12:15:01 +01:00
Heather
e382ee637b
Merge pull request #840 from ebfe/travis
...
travis: build/test everything on stable
2016-03-23 17:20:54 +04:00
Michael Gehring
1183dcd7a1
travis: build/test everything on stable
2016-03-23 13:15:36 +01:00
Heather
2d07ec7a58
Merge pull request #839 from Shiroy/uucore_lib_name
...
Add missing lib.name for uucore
2016-03-23 15:25:58 +04:00
Shiroy
c8ff895018
Add missing lib.name for uucore
...
Fix build on Linux
2016-03-23 08:44:09 +01:00
Alex Lyon
94b8f9fe37
Merge pull request #836 from jamwt/fix_sleep
...
Fix sleep duration calculations.
2016-03-22 18:00:18 -07:00
Joseph Crail
9e500532d0
Merge pull request #837 from skade/move_to_stable
...
Move to stable
2016-03-22 20:47:41 -04:00
Florian Gilcher
d75cb627c9
Remove nightly note
2016-03-22 22:03:16 +01:00
Florian Gilcher
0be3e61d9f
Avoid using char() in tr
2016-03-22 22:03:06 +01:00
Florian Gilcher
2befeef179
Remove use of str_char in fmt
2016-03-22 21:57:52 +01:00
Jamie Turner
7d89717d4b
Fix sleep duration calculations.
...
Durations longer than ~4s were overflowing u32 and just.. not working.
2016-03-22 13:00:01 -07:00
Florian Gilcher
509d6efc78
Remove rustc_unicode dependency
2016-03-22 19:56:14 +01:00
Michael Gehring
6e629b1115
Merge pull request #832 from fitzgen/tail-large-files
...
Tail large files
2016-03-22 01:57:06 +01:00
Nick Fitzgerald
d7974c56a0
tests/tail: Add a test for tail'ing large files
...
This tests both large files and iterating backwards through the file when we
need to search backwards further than our BUFFER_SIZE.
2016-03-21 07:51:48 -07:00
Nick Fitzgerald
161f96dc8c
tests/tail: Rename tail test fixture contents to be easier to read
...
The repetition of "foo" and "bar" made for difficult-to-read assertion failures
when hacking on `tail`. I think that having each line have unique contents makes
it a bit easier to parse.
2016-03-21 07:51:42 -07:00
Nick Fitzgerald
56d16ca7e7
tail: Optimize tail for bounded searches in files
...
When tail'ing a file, we do not need to read the whole file from start to finish
just to find the last n lines or bytes. Instead, we can seek to the end of the
file, and then read the file "backwards" in chunks until we find the location of
the first line/byte we wish to print. This ends up being a nice performance win
for very large files.
Fixes #764
2016-03-21 07:51:38 -07:00
Nick Fitzgerald
977742f209
tail: Take ownership of the provided BufReader<T>
...
The `BufReader` argument passed to the `fn tail<T: Read>(&mut BufReader<T>,
settings: &settings)` function is never reused, so the `tail` function should
just take ownership of it.
2016-03-21 07:51:32 -07:00
Heather
bbd55b283a
Merge pull request #829 from lucaotta/fix-chmod-reference
...
chmod: fix reference option
2016-03-11 10:37:57 +04:00
Luca Ottaviano
5dc0a55630
chmod: fix reference option
...
Reference option must have a file path.
Fix C interface using CString.
Better error message if the file doesn't exist.
2016-03-10 20:34:49 +01:00
Heather
8d278913c2
Merge pull request #825 from nathanross/dirname-fix-impl
...
Dirname: fix windows' failing test for absolute-path behavior (approach 2/2: platform-independent behavior)
2016-03-01 11:55:54 +04:00
Heather
49a67bae33
Merge pull request #828 from cbjadwani/uniq_add_tests
...
Uniq add tests
2016-02-29 10:50:59 +04:00
Chirag B. Jadwani
d674a3bb63
uniq: minor refactoring in skip_fields
2016-02-29 11:16:58 +05:30
Chirag B. Jadwani
fc5b798ff1
uniq: fix skip & check characters logic
2016-02-29 11:10:38 +05:30
Chirag B. Jadwani
676e3718c3
uniq: add tests
2016-02-29 11:07:16 +05:30
Michael Gehring
68efb303bd
Merge pull request #823 from nathanross/comm-additional-tests
...
comm: remaining tests for feature completion
2016-02-24 08:23:32 +01:00
