Commit graph

63 commits

Author SHA1 Message Date
Michael Gehring
3eb5a814a3 Fix most unstable feature warnings 2015-02-03 23:54:37 +01:00
Michael Gehring
db8506532e derive(Show) -> derive(Debug) 2015-02-03 22:42:36 +01:00
Alex Lyon
9c0ed7236c Merge pull request #517 from keunwoo/keunwoo-fix-address-radix-20150127
od: fix --address-radix interpretation and minor cleanups
2015-02-01 12:13:37 -08:00
Michael Gehring
d187dc574b std::io -> std::old_io 2015-01-29 08:45:37 +01:00
Keunwoo Lee
f6a07663e8 od: proper interpretation of -A flag
Prior to this CL, --address-radix was being used to determine the format
of the output bytes.  This was wrong: this flag controls the printing of
the address (in the POSIX spec for od, this is called the "input offset
base"), not the printing of the content bytes.
2015-01-27 21:51:28 -08:00
Keunwoo Lee
55be34a2c4 od: clean up fname usage
+ rm superfluous clone
+ rm superfluous mut variable
2015-01-27 21:51:28 -08:00
Keunwoo Lee
71bc68a987 od: rm -v alias for --version
This shortflag conflicts with --output-duplicates.
2015-01-27 21:51:28 -08:00
Keunwoo Lee
b756a57345 od: clean up parse_radix code and use site
+ Make parse_radix terser and clearer.
+ Make purpose of radix clearer at use site
  (note that the code currently completely misuses the --address-radix
  flag; this is inherited from the previous code)
+ Don't panic! inside parse_radix; instead return Result<> and let the
  caller handle errors (currently we panic, but probably we'll want to use
  some less alarming error routine); this will be more testable later as
  well.
2015-01-27 21:51:28 -08:00
Keunwoo Lee
288179be49 address Arcterus comments on uutils/coreutils PR 515
Mostly style things.
2015-01-27 19:32:26 -08:00
Keunwoo Lee
1954274700 od: fix warnings 2015-01-25 00:17:38 -08:00
Keunwoo Lee
a6e5deaa16 od: whitespace fix (4-space indents, 99-column) 2015-01-25 00:03:14 -08:00
Keunwoo Lee
2d8e7f6dec od: fix build
Just the minimal stuff needed to make od build again.  I have restrained
myself from making more invasive changes.
2015-01-24 23:56:10 -08:00
Keunwoo Lee
3739c82c95 mv od/ -> src/ 2015-01-24 23:16:13 -08:00