Commit graph

2340 commits

Author SHA1 Message Date
Alexander Batischev
655804cff4 tests/chmod: protect umask with a mutex
`test_chmod_ugoa` and `test_chmod_many_options` both change umask, which
is global state. Since tests run concurrently, this might lead to
a situation where one of the tests changes umask to a value that screws
another test's checks. To prevent this, we introduce a mutex that should
be held by any test that changes umask.

Unfortunately, there's no way to hide umask behind this mutex and
enforce its usage: programmers will have to maintain the discipline
themselves.
2016-12-19 13:14:38 +03:00
Alexander Batischev
60f6f61ac9 tests/chmod: don't make assumptions about umask
`test_chmod_many_options` relied on user's umask not denying read access
for anyone. 022, which is the default umask for many, indeed allows read
access for everyone. I'm using 027, which disallows read for everyone
but owner and group. This made tests fail.

Now tests set and reset umask, ensuring checks are run in a reliable,
predictable environment.
2016-12-19 13:07:18 +03:00
Jian Zeng
797281936c Merge pull request #1010 from antiagainst/fuchsia
Enable compilation of more and ls on Fuchisa.
2016-12-18 21:41:13 -06:00
Lei Zhang
e57f987190 All generic utilities compilable on Fuchsia now. 2016-12-14 23:29:40 -05:00
Lei Zhang
c36917b35f Update dependencies.
libc v0.2.18 adds support for Fuchsia.
2016-12-14 23:29:40 -05:00
Lei Zhang
a34cd30f54 Enable compilation of ls on Fuchsia.
This updates the dependency of pretty-bytes to v0.2.
2016-12-14 23:29:38 -05:00
Lei Zhang
ba244794f0 Enable compilation of more on Fuchisa. 2016-12-08 13:08:17 -05:00
mpkh
fd7be06e5b Merge pull request #1011 from uutils/fix-build-error
Temporary fix for errors in testing
2016-12-08 10:38:07 +04:00
knight42
a0ff0f623a Temporary fix for errors in testing
The errors were caused by the missing env $OUT_DIR which should be set by
cargo.

[Related issue](https://github.com/rust-lang/cargo/issues/3368).
2016-12-08 12:36:07 +08:00
Alex Lyon
bb8e5b5824 Merge pull request #1008 from wimh/od-help
od: fix od --help
2016-12-04 20:02:29 -08:00
Wim Hueskes
829ea9f445 od: fix od --help 2016-12-04 22:24:36 +01:00
mpkh
a47d7d1a5b Merge pull request #1003 from Arcterus/fix-preserve-root
chgrp: fix more --preserve-root problems
2016-12-03 11:13:17 +04:00
Arcterus
5d9437bcaf chgrp: remove unwrap() in is_bind_root() 2016-12-01 06:02:58 -08:00
Alex Lyon
a6cda50ac8 Merge pull request #1005 from antiagainst/fuchsia
mktemp, nproc, ptx, and uniq compilable on Fuchsia now.
2016-11-30 11:45:20 -08:00
Lei Zhang
55470e17b5 cat no longer need extern crate libc anymore. 2016-11-30 10:57:47 -05:00
Lei Zhang
c2882da2e7 mktemp, nproc, ptx, and uniq compilable on Fuchsia now. 2016-11-30 10:50:47 -05:00
Arcterus
dc6ba887ba uucore: compile on Windows again 2016-11-30 03:51:49 -08:00
Arcterus
f5fce8dadb chgrp: detect bind mounted root 2016-11-30 03:50:07 -08:00
Arcterus
3ab82f9a66 uucore: read symlinked directories correctly in resolve_relative_path() 2016-11-30 03:50:07 -08:00
Alex Lyon
c403270ac3 Merge pull request #992 from kevgeniy/master
cat utility refactoring
2016-11-30 03:24:05 -08:00
Alex Lyon
04fcd823cc Merge pull request #1002 from antiagainst/itertools
Update dependencies and solve deprecated warnings.
2016-11-30 03:11:43 -08:00
Alex Lyon
7ec754ec1b Merge pull request #985 from knight42/fix-preserve-root
chgrp: fix bug in option --preserve-root
2016-11-30 02:59:19 -08:00
Lei Zhang
7d7fc68dee Solve compiler warning about using deprecated item.
PutBackN::new() is replaced by put_back_n.
2016-11-29 12:57:09 -05:00
Lei Zhang
3b06a6e292 Update dependencies. 2016-11-29 12:56:30 -05:00
Michael Gehring
268fe45f24 Merge pull request #1000 from antiagainst/fuchsia
Add a new feature to list all utilities that can compile for Fuchsia right now
2016-11-26 10:01:55 +01:00
Michael Gehring
7122f265b0 Merge pull request #997 from wimh/stat-travis
stat: fix test on travis
2016-11-26 09:40:05 +01:00
Michael Gehring
0a60911cdf Merge pull request #1001 from jbcrail/clippy-and-spelling
Fix clippy warnings and misspellings
2016-11-26 09:33:32 +01:00
Joseph Crail
45ebfdf35f Fix test 2016-11-25 14:58:42 -05:00
Joseph Crail
78d2e8db27 Fix comment spelling 2016-11-25 14:36:56 -05:00
Joseph Crail
b3680a5baf Fix clippy warnings 2016-11-25 14:14:46 -05:00
Lei Zhang
546f2855d5 Create a new feature for Fuchsia-enabled utilities. 2016-11-24 18:15:50 -05:00
Lei Zhang
59c12433e0 Add Fuchsia as recognized host OS in uname. 2016-11-24 17:30:03 -05:00
Lei Zhang
e37468b630 Turn off utmpx and signals for Fuchsia.
Fuchsia uses musl as its libc; musl only has stub implementation
for utmpx. From their wiki, that is deliberately chosen.

Fuchsia doesn't have signals mechanism.
2016-11-24 17:15:43 -05:00
mpkh
9db91285bd Merge pull request #998 from antiagainst/libc-dependency
Remove unnecessary dependencies on libc in various utilities and update Cargo.lock.
2016-11-24 21:18:06 +04:00
Lei Zhang
a529bff697 Update Cargo.lock about dependencies. 2016-11-24 11:18:36 -05:00
Lei Zhang
a2071c258e Remove unnecessary dependencies on libc in various utilities. 2016-11-24 11:17:36 -05:00
Wim Hueskes
e2519bf0b3 stat: fix test on travis
/dev/pts/ptmx seems to be the only character special file in /dev
which is not a bind-mount in the docker container run by travis.
gnu stat does not detect these mounts, so produces a different
output for /dev/zero.
2016-11-21 19:36:23 +01:00
mpkh
de8d96ff7c Merge pull request #994 from Will-W/windowsfixes
Windowsfixes
2016-11-19 16:34:31 +04:00
kevgeniy
6d13bcf2da cat: fixed indentation 2016-11-18 22:30:12 +03:00
mpkh
02f7d80aca Merge pull request #995 from antiagainst/build-dependency
Remove unnecessary dependencies of getopts & libc for utilities.
2016-11-18 22:53:42 +04:00
Will Wykeham
b9ddb52630 Make Cargo.toml match the Makefile 2016-11-18 13:58:50 +00:00
Will Wykeham
2ad896a6ca Move 'mv' into generic now it builds properly on Windows 2016-11-18 13:58:49 +00:00
Will Wykeham
0809dce4a2 Fix a number of Windows build warnings 2016-11-18 13:58:36 +00:00
Will Wykeham
d55e2ee80a Fix mv build on Windows 2016-11-18 13:58:13 +00:00
Lei Zhang
aaa7274b63 Remove unnecessary dependencies of getopts & libc for utilities. 2016-11-17 17:43:31 -05:00
Alex Lyon
4f5e8f4566 Merge pull request #965 from wimh/od
od: implement remaining functionality
2016-11-10 15:13:10 -08:00
Wim Hueskes
2550e0f3c7 od: several small changes after review
* update status in README.md
* enable busybox tests
  Adding `CONFIG_DESKTOP` and `CONFIG_LONG_OPTS` to busybox config.
  These flags also enable other tests, but those utilities are not
  included in `TEST_PROGS`. (eg. awk)
* fix whitespace and small issues
* fix Eq imp for FormatWriter on nightly + beta
* fix indention in multifilereader.rs
* fix intermittent errors in tests
2016-11-09 20:26:55 +01:00
mpkh
29a2eca451 Merge pull request #993 from Zephiris/windows
trivial windows fixes
2016-11-05 13:39:12 +04:00
Zephiris
0d0087053f ls: Fix '-aR' recursion.
ls with -aR was recursing infinitely becacuse it
added ./.. to every node. I don't see a way to
avoid this except by cloning when that option
is used.
2016-11-05 01:29:55 -07:00
Zephiris
606c1badd2 ls: Change symlink behavior to be more POSIX compliant.
Symlink directories are read by default, and symlink targets are listed on
Windows.
2016-11-05 00:22:55 -07:00