Commit graph

4698 commits

Author SHA1 Message Date
Roy Ivy III
ab87a1ab5f refactor/polish ~ fix cargo clippy complaints ('better' ref indirection) 2020-01-27 21:33:51 -06:00
Roy Ivy III
94c088f452 refactor/polish ~ fix cargo clippy complaints (redundant return variable) 2020-01-27 21:33:51 -06:00
Roy Ivy III
88a45a157b refactor/polish ~ fix cargo clippy complaints (redundant return) 2020-01-27 21:33:51 -06:00
Roy Ivy III
564168ccfc refactor/polish ~ fix cargo clippy complaints (redundant clone) 2020-01-27 21:33:51 -06:00
Roy Ivy III
2e90c78fae refactor/polish ~ fix cargo clippy complaints (redundant closure) 2020-01-27 21:33:51 -06:00
Roy Ivy III
fa8540cb15 refactor/polish ~ fix cargo clippy complaints (DRY struct def) 2020-01-27 21:33:51 -06:00
Roy Ivy III
ea8ed8d5da refactor/polish ~ fix cargo clippy complaints (&Vec => &[]) 2020-01-27 21:33:50 -06:00
Roy Ivy III
a72422fb0e refactor/polish ~ fix cargo clippy complaints (Vec<> => []) 2020-01-27 21:33:50 -06:00
Roy Ivy III
ec5ca193ac refactor/polish ~ fix cargo clippy complaints (char not string) 2020-01-27 21:33:50 -06:00
Roy Ivy III
11d68d3e51 refactor/polish ~ fix cargo clippy complaints (number readability) 2020-01-27 21:33:50 -06:00
Roy Ivy III
3da2a69e11 refactor/polish ~ fix cargo clippy complaints (unneeded String::from) 2020-01-27 21:33:50 -06:00
Roy Ivy III
bf6368269c refactor/polish ~ fix cargo clippy complaints (unneeded parens) 2020-01-27 21:33:50 -06:00
Roy Ivy III
1216378c72 refactor/polish ~ fix cargo clippy complaints (unneeded ref for copiable) 2020-01-27 21:33:50 -06:00
Roy Ivy III
bc558f301a refactor/polish ~ fix cargo clippy complaints (unneeded mut) 2020-01-27 21:33:50 -06:00
Roy Ivy III
25b1f98cf8 refactor/polish ~ fix cargo clippy complaints (unneeded format) 2020-01-27 21:33:50 -06:00
Roy Ivy III
3bff70967c refactor/polish ~ fix cargo clippy complaints (use starts_with()) 2020-01-27 21:33:50 -06:00
Roy Ivy III
e676447b3d refactor/polish ~ fix cargo clippy complaints (while let ... = some => for ... in) 2020-01-27 21:33:49 -06:00
Roy Ivy III
8142ecf325 refactor/polish ~ fix cargo clippy complaints (default/tests => let ... = if ...) 2020-01-27 21:33:49 -06:00
Roy Ivy III
d192ebea5b refactor/polish ~ fix cargo clippy complaints (unwrap_or_else) 2020-01-27 21:33:49 -06:00
Roy Ivy III
4ddc65f255 refactor/polish ~ fix cargo clippy complaints (String => str) 2020-01-27 21:33:49 -06:00
Roy Ivy III
2d95cfdcbd refactor/polish ~ fix cargo clippy complaints (remove allow unused_must_use) 2020-01-27 21:33:49 -06:00
Roy Ivy III
90a64a831a refactor/polish ~ fix cargo clippy complaints (for in => iter.take) 2020-01-27 21:33:49 -06:00
Roy Ivy III
1642933275 refactor/polish ~ fix cargo clippy complaints (if is_none => as_ref()?) 2020-01-27 21:33:49 -06:00
Roy Ivy III
88db11a328 refactor/polish ~ fix cargo clippy complaints (negation instead of * -1) 2020-01-27 21:33:49 -06:00
Roy Ivy III
3c2e609bfe refactor/polish ~ fix cargo clippy complaints (use values()) 2020-01-27 21:33:49 -06:00
Roy Ivy III
c6e9808224 refactor/polish ~ fix cargo clippy complaints (match function signatures) 2020-01-27 21:33:49 -06:00
Roy Ivy III
c6817aefb3 refactor/polish ~ fix cargo clippy complaints (or_else) 2020-01-27 21:33:49 -06:00
Roy Ivy III
413c64fa12 refactor/polish ~ fix cargo clippy complaints ('better' as println!()) 2020-01-27 21:33:48 -06:00
Roy Ivy III
291d2f5d48 refactor/polish ~ fix cargo clippy complaints ('better' as println!(...)) 2020-01-27 21:33:48 -06:00
Roy Ivy III
ba5a2435be refactor/polish ~ fix cargo clippy complaints (unneeded _) 2020-01-27 21:33:48 -06:00
Roy Ivy III
493f5f1496 refactor/polish ~ fix cargo clippy complaints (use +=/-= notation) 2020-01-27 21:33:48 -06:00
Roy Ivy III
768ed71725 refactor/polish ~ fix cargo clippy complaints (use b'...' notation) 2020-01-27 21:33:48 -06:00
Roy Ivy III
b276f4758f refactor/polish ~ fix cargo clippy complaints (iter.collect => to_vec) 2020-01-27 21:33:48 -06:00
Roy Ivy III
a9b1a03b37 refactor/polish ~ fix cargo clippy complaints (fatal/write_all) 2020-01-27 21:33:48 -06:00
Roy Ivy III
662db61336 refactor/polish ~ fix cargo clippy complaints (fatal/unneeded drop) 2020-01-27 21:33:48 -06:00
Roy Ivy III
181c9d6cae refactor/polish ~ fix cargo clippy complaints (fatal/unneeded clone) 2020-01-27 21:33:48 -06:00
Roy Ivy III
6043ac1cbd refactor/polish ~ fix cargo clippy complaints (fatal/temporary_cstring_as_ptr) 2020-01-27 21:33:48 -06:00
Roy Ivy III
1f5749e304 refactor/polish ~ fix cargo clippy complaints (fatal/same if clause) 2020-01-27 21:33:48 -06:00
Roy Ivy III
b3846bf8f1 tests/fix ~ (stat) remove '%a', '%d', '%f' from file system test format due to race conditions 2020-01-27 21:33:47 -06:00
Roy Ivy III
95809ae98e Add 'windows_legacy' feature to allow build for older windows versions 2020-01-27 21:33:47 -06:00
Roy Ivy III
1f137c245f refactor/polish ~ fix cargo clippy complaints (fatal/cast_ptr_alignment) 2020-01-27 21:33:47 -06:00
Roy Ivy III
823fc17c2c tests/fix ~ (stat) refactor '%w' and '%W' tests due to stat limitations
- allow actual outputs to differ from expected (ie, `stat`) if `stat` is reporting "unknown" creation time

.# [why]

For many *nix flavors, `stat` is unable to detect birth/creation date
for directories/files. The information is available via the `statx()`
system call (for linux kernels >= v4.11), and rust supplies that
information via fs::MetadataExt for v1.40+. So, for rust v1.40+, there
will likely be a mismatch between the output of the system `stat` and
this ('uutils') `stat`.

* ref: <https://askubuntu.com/questions/470134/how-do-i-find-the-creation-time-of-a-file> @@ <https://archive.is/IsEAJ>
2020-01-27 21:33:47 -06:00
Roy Ivy III
c969becbf8 refactor ~ remove unneeded mem::uninitialized() code
.# [why]

`mem::ununitialized()` is deprecated as of rust v1.39.0.

And this use is likely a premature optimization attempting to avoid
initializing the byte array to 0, which is usually a *very* fast operation.

* ref: <https://github.com/rust-lang/rust/blob/master/RELEASES.md>
* ref: <https://stackoverflow.com/questions/3654905/faster-way-to-zero-memory-than-with-memset>
2020-01-27 21:33:47 -06:00
Roy Ivy III
14c3f3aa17 tests ~ fix WSL testing
+ ToDO added ~ when possible, test under WSL2 and differentiate/liberalize if possible
2020-01-27 21:33:47 -06:00
Roy Ivy III
244bdf3d4f who: fix ~ remove unneeded/incorrect time format size change 2020-01-27 21:33:47 -06:00
Roy Ivy III
9416709c9c stat: fix birth/created time transformation 2020-01-27 21:33:47 -06:00
Roy Ivy III
25d4fb71ca tests/refactor ~ change to use of common code (TestScenario::...) for testing 2020-01-27 21:33:47 -06:00
Roy Ivy III
d0f6f3d07e tests/refactor ~ change output test macros to 'actual = expected' format
- rust usually uses `assert_eq!(ACTUAL, EXPECTED)`
- ref: https://users.rust-lang.org/t/assert-eq-expected-and-actual/20304/3 @@ https://archive.is/xPp9R
2020-01-27 21:33:47 -06:00
Roy Ivy III
2f23a2e2cb maint/cicd ~ allow rust 'beta' failures (Travis CI) 2020-01-27 21:33:47 -06:00
Roy Ivy III
45a04ce5fc refactor ~ replace deprecated trim_{left,right}... with trim_{start,end}...
- `trim_{start,end}{,_matches}` stabilized in rust v1.30.0
- `trim_{start,end}{,_matches}` deprecated (with compiler warnings) in rust v1.33.0

+ requires MinSRV >= v1.30.0

* ref: https://github.com/rust-lang/rust/blob/master/RELEASES.md
2020-01-27 21:33:47 -06:00