Kevin Burke
7fc1b16115
sort: fix panic on write to closed pipe
...
If the output of sort is piped to another program that closes the file
descriptor, sort currently panics. The GNU coreutils is able to handle
this case.
Replacing panic with crash_if_err reports the closed pipe and exits
with a return code, which seems like the correct behavior. Tested on
my Mac and the panic disappears.
Add a test which pipes data to sort - it won't protect against this
specific regression, but it increases the test coverage, at least.
Fixes #1608 .
2020-10-21 16:55:10 -07:00
Sylvestre Ledru
f5dce475c5
Merge pull request #1605 from rivy/chg.disable-macos-tests
...
tests/cp ~ disable intermittent failures on MacOS (includes FixME comments)
2020-10-17 09:53:44 +02:00
Sylvestre Ledru
143c2198d8
Merge pull request #1606 from rivy/fix.warning
...
refactor/polish ~ (factor) fix `cargo clippy` complaint (unused_imports)
2020-10-17 09:53:13 +02:00
Roy Ivy III
92075c7d14
refactor/polish ~ (factor) fix cargo clippy
complaint (unused_imports)
2020-10-16 20:25:49 -05:00
Roy Ivy III
96092b01fc
tests/cp ~ disable intermittent failures on MacOS (includes FixME comments)
...
- track repair progress at GH:uutils/coreutils/issues/1590
2020-10-16 20:24:57 -05:00
Sylvestre Ledru
aa1285e305
Merge pull request #1607 from rivy/rf.update-deps
...
update dependencies ~ Cargo.lock
2020-10-15 09:34:25 +02:00
Roy Ivy III
3a4f12c2fb
maint/CICD ~ improve robustness of MinRustV package dependency calculation
2020-10-14 21:42:09 -05:00
Roy Ivy III
79b054b016
update deps ~ Cargo.lock
2020-10-14 14:44:07 -05:00
Sylvestre Ledru
fba62f39c6
Merge pull request #1603 from rivy/fix.warnings
...
Fix `cargo clippy` warnings
2020-10-12 09:23:15 +02:00
Sylvestre Ledru
dd583030b9
Merge pull request #1604 from rivy/fix.versioning
...
Fix versioning
2020-10-12 09:22:31 +02:00
Roy Ivy III
df57df8c93
docs ~ use version calculated from *Cargo.toml*
2020-10-11 17:39:50 -05:00
Roy Ivy III
77a04546f0
fix/printf ~ use calculated VERSION
2020-10-11 17:39:50 -05:00
Roy Ivy III
46f30f3836
refactor/polish ~ fix cargo clippy
complaint (stable_sort_primitive)
2020-10-10 20:35:35 -05:00
Roy Ivy III
10b6926ccc
refactor/polish ~ fix cargo clippy
complaint (allow match_like_matches_macro)
2020-10-10 20:35:35 -05:00
Roy Ivy III
6fa16343f1
refactor/polish ~ fix cargo clippy
complaint (same_item_push)
2020-10-10 20:35:35 -05:00
Roy Ivy III
7b4d81efd4
refactor/polish ~ fix cargo clippy
complaint (needless_collect)
2020-10-10 20:35:35 -05:00
Roy Ivy III
4a041f95e3
Merge pull request #1598 from sylvestre/nproc
...
cleanup(nproc): remove some artifacts from the clap migration
2020-10-10 16:28:22 -05:00
Roy Ivy III
02e4226c26
refactor/polish ~ cargo make format
2020-10-02 16:03:21 -05:00
Roy Ivy III
0fa249a944
Fix tr
argument handling for missing arguments ( #1601 )
...
* tests/tr ~ confirm failure for missing argument(s)
* fix/tr ~ mimic GNU error reponse for missing argument(s)
2020-10-02 22:43:57 +02:00
Sylvestre Ledru
c660684a8c
nproc: use the variable name
2020-09-26 23:09:08 +02:00
Sylvestre Ledru
805801ec39
nproc: remove the extern crate declaration
2020-09-26 23:09:02 +02:00
nicoo
9a1c560aba
factor: Refactor and optimise the Factors
datastructure ( #1572 )
...
* factor: Introduce a type alias for exponents
This way, we can easily replace u8 with a larger type when moving to support
larger integers.
* factor::Factors: Split off a Decomposition type
The new type can be used to represent in-progress factorisations,
which contain non-prime factors.
* factor::Decomposition: Use a flat vector representation
~18% faster than BTreeMap, and ~5% faster than “master”.
* factor::Factors: Use a RefCell rather than copy data when printing
~2.9% faster than the previous commit, ~11% faster than “master” overall.
2020-09-21 21:44:50 +02:00
Roy Ivy III
2516fd847c
Merge pull request #1597 from Katzmann1983/master
...
feature/split ~ add additional-suffix option to split
2020-09-21 10:15:49 -05:00
Jens Humrich
bfca334ec1
style issues
2020-09-17 12:40:48 +02:00
Katzmann1983
f322f72c34
Update src/uu/split/src/split.rs
...
Co-authored-by: Sylvestre Ledru <sledru@mozilla.com>
2020-09-17 10:27:40 +02:00
Jens Humrich
5a75905476
Add additional-suffix option to split
2020-09-16 17:59:39 +02:00
Roy Ivy III
2ff6b67077
stat: fix cargo clippy
complaint (unnecessary_sort_by) ( #1594 )
2020-09-04 08:01:53 +02:00
Roy Ivy III
4b76849de7
Merge pull request #1589 (from nbraud:factor/gcd/test_divisor)
2020-09-03 15:23:14 -05:00
Roy Ivy III
c33284f38b
factor::numeric::gcd: modify divisor()
test to return correct true/false results for all possible inputs
2020-09-03 14:56:14 -05:00
nicoo
07eaa7fe5a
factor::numeric::gcd: Add explicit test for the 0 case
2020-09-03 14:56:14 -05:00
nicoo
c11cebc4d3
factor::numeric::gcd: Exclude the 0 case from test divisor
2020-09-03 14:56:10 -05:00
16yuki0702
19e967ef31
ls: deleting user defined max function ( #1591 )
...
This is trivial refactor.
```usize``` can call max method, so deleting user defined max function.
2020-08-26 09:42:27 +02:00
Roy Ivy III
e7a1d13380
Merge pull request #1583 from rivy/fix.test-utils
...
Fix sub-crate/utility testing
2020-08-23 01:05:35 -05:00
Roy Ivy III
74510d2fa4
refactor/polish ~ cargo fmt
2020-08-19 09:13:09 -05:00
Roy Ivy III
72a5d93a4d
maint/CICD ~ remove old/unneeded grcov
setup scripting
2020-08-19 09:13:09 -05:00
Roy Ivy III
74200f368b
tests ~ (sub-crate/mknod) fix WSL variation in expected test values
2020-08-19 09:13:09 -05:00
Roy Ivy III
2a50dc42c1
tests ~ (sub-crate/factor) fix divisor(0,0)
test of factor::numeric::gcd() with early value check and return ( fixes #1587 )
2020-08-19 09:13:09 -05:00
Roy Ivy III
63315747a5
maint/CICD ~ job naming improvement (decreased jargon) + feature name normalization
2020-08-16 17:02:19 -05:00
Roy Ivy III
bb4b20db81
maint/CICD ~ use alternate grcov configuration recipe (direct CLI options)
...
- `ignore` and `excl-br-line` options used to target code coverage analysis
- direct/repeated (non-DRY) CLI options are used by necessity (`grcov` is ignoring command line env variables)
2020-08-16 17:02:19 -05:00
Roy Ivy III
c6274b4003
tests ~ disable failing tail
test under windows code coverage (with future FixME)
...
* FixME/note: test_mktemp::test_mktemp_make_temp_dir, test_mktemp::test_mktemp_mktemp, and test_mktemp::test_mktemp_suffix are also failing locally though not for CICD coverage builds
2020-08-16 17:02:19 -05:00
Roy Ivy III
ec964d1b36
maint/dev ~ improve code coverage scripting
2020-08-16 17:02:19 -05:00
Roy Ivy III
9711e5ad42
maint/CICD ~ update CICD code coverage recipe
2020-08-10 10:20:15 -05:00
Roy Ivy III
1c9b12c0d2
maint/CICD ~ add individual uutil/sub-crate testing to CICD code coverage
2020-08-10 10:19:42 -05:00
Roy Ivy III
5478ca9108
tests ~ (sub-crate/od) fix expected f16 formatted test value
2020-08-10 10:19:42 -05:00
Roy Ivy III
b2483cb3c3
tests ~ (sub-crate/od) fix/remove inadvertent doc test (by using ignore
)
2020-08-10 10:19:42 -05:00
Roy Ivy III
49d17f9587
tests ~ (sub-crate/od) fix compiler error (mismatched types)
2020-08-10 10:19:42 -05:00
Roy Ivy III
4fa27345be
tests ~ (sub-crate/od) fix cargo clippy
complaints (from deprecated half::consts to f16::...)
2020-08-10 10:19:42 -05:00
Roy Ivy III
c7cb5cbc37
tests ~ (sub-crate/cat) fix incorrect test attribute usage
2020-08-10 10:19:42 -05:00
Roy Ivy III
c3893edf94
tests ~ (sub-crates) fix 'edition=2018' module import errors
...
- ref: <https://users.rust-lang.org/t/imports-can-only-refer-to-extern-crate-names/24388 > @@ <https://archive.is/iCaXp >
2020-08-10 10:19:42 -05:00
Roy Ivy III
925137afce
tests ~ (sub-crate/od) fix cargo clippy
complaints (unused imports)
2020-08-10 10:19:41 -05:00