Commit graph

1111 commits

Author SHA1 Message Date
Alex Lyon
42794e9f11 echo: write using locked stdout 2019-04-05 22:23:01 -07:00
Alex Lyon
23f6dbf2d3
Merge pull request #1306 from rinconjc/1235
tests: untrimmed stdout assertion (fix #1235)
2019-04-05 22:22:18 -07:00
Alex Lyon
dbc9527b00
Merge pull request #1336 from rinconjc/1321
Fix #1321 tsort handle self-loops
2019-04-05 19:15:23 -07:00
Alex Lyon
100f6df2bf
Merge pull request #1354 from ccbrown/rewrite-echo
echo: rewrite for readability and tests
2019-04-05 18:39:18 -07:00
Alex Lyon
5934666da3
Merge pull request #1338 from Arcterus/refactor-base32_64
base32, base64, uucore: merge base32/base64 code
2019-04-05 16:07:18 -07:00
Christopher Brown
1e223b0b58 echo: rewrite for readability and tests 2019-04-05 18:55:48 -04:00
Alex Lyon
94838dd54c
Merge pull request #1317 from rivy/fix.expr
fix ~ expr: update onig/onig_sys dependency (fixes windows compilation bug)
2019-04-03 16:03:26 -07:00
Alex Lyon
dd753e2c78
Merge pull request #1315 from rivy/fix.rm
fix ~ rm: fix dir-type symlink removal on windows
2019-04-03 15:53:00 -07:00
Alex Lyon
9817f297b7
Merge pull request #1304 from rivy/fix.cp
fix "`cp` always creates backup"
2019-04-03 15:51:18 -07:00
Alex Lyon
8d15f36977
Merge pull request #1305 from rivy/fix.mv
fix "`mv` fails transfers between dirs"
2019-04-03 15:50:32 -07:00
Roy Ivy III
e977e29d6a expr: fix ~ update onig/onig_sys dependency (fix windows compilation bugs)
* fixes compile bugs blocking compilation "onig_sys" (required for `expr`) on windows
  - MSVC/VS tools are no longer required to be prepped and available on the PATH (via
    `vsvarsall` or the "VCX command prompt")
  - GNU `gcc` compilation/targets are possible on windows
* restrict onig version to v4.3.2 (or later patches [only]; see discussion)

.# Discussion

onig v4.3.0/v4.3.1 inadvertently introduced a new minimum rust version (requiring
v1.31+; see https://github.com/rust-onig/rust-onig/issues/97). This was repaired with
v4.3.2 (requiring only v1.27.0+), and onig now specifies a rust minimum version that will
stay the same for patches, but may change between minor version increments.
2019-03-13 01:33:50 -05:00
Alex Lyon
f49395b1e8 base32, base64, uucore: merge base32/base64 code 2019-02-21 05:10:12 -08:00
Alex Lyon
39b5760f8e
Merge pull request #1307 from PaulCapron/master
Remove some useless BufReader wrappers around stdin
2019-02-21 04:26:32 -08:00
Julio Rincon
63bc9985e0 Fix #1321 tsort handle self-loops 2019-02-14 07:45:11 +11:00
Roy Ivy III
52c7f0aa34 mv: refactor try! to ? 2019-02-09 13:23:43 -06:00
Julio Rincon
29c6ad5f6a tests: untrimmed stdout assertion (fix #1235) 2019-02-08 07:54:48 +11:00
Roy Ivy III
41fb27e0a7 rm: fix dir-type symlink removal on windows 2019-02-07 08:30:51 -06:00
Roy Ivy III
1d64162218 cp: fix "cp always creates backup" 2019-02-07 08:22:41 -06:00
Roy Ivy III
fb1d844e14 mv: fix "mv fails transfers between dirs" 2019-02-07 08:19:22 -06:00
Roy Ivy III
556a96406c mv: improve error message 2019-02-07 08:19:22 -06:00
Roy Ivy III
e00d586af1 mv: fix failing tests 2019-02-07 08:19:22 -06:00
Alex Lyon
677953b2b6
Merge pull request #1314 from teresy/shorthand-fields
refactor: use shorthand fields
2019-02-07 00:41:00 -08:00
Alex Lyon
313ad332fa
Merge pull request #1290 from ArniDagur/ls-formatting
Change `ls -l -h` formatting to match GNU ls
2019-02-07 00:12:43 -08:00
Alex Lyon
8a7442d257
Merge pull request #1312 from E5ten/patch-3
Remove unused nlink
2019-02-07 00:08:46 -08:00
Alex Lyon
5a17daa963
Merge pull request #1281 from rivy/alt/win-cli-globbing
Add command line globbing to all utilities (for windows targets)
2019-02-06 23:21:53 -08:00
Rijnard van Tonder
436892269f refactor: use shorthand fields 2018-11-07 13:26:03 -05:00
E5ten
cc8899cb5b
Remove unused nlink
Now that --apparent-size does not use stat.nlink * stat.size, nlink is not used anywhere in du and can be removed from what I can see.
2018-10-30 10:49:08 -04:00
E5ten
13e57616b4
Fix --apparent-size on ext4 and MacOS
All credit goes to @JJJollyjim in this PR https://github.com/uutils/coreutils/pull/1294, but that PR needs to be rebased over master to be mergeable and hasn't been after multiple weeks.
2018-10-29 09:29:48 -04:00
Paul Capron
324cbad7a3 factor: Don’t wrap stdin in BufReader & use lock()
stdin() is already buffered.

Locking upfront explicitely avoid the overhead of mutex locking/unlocking
everytime a new line is read. See https://stackoverflow.com/a/17546731
and https://www.reddit.com/r/rust/comments/3rj54u/how_can_i_read_char_by_char_from_stdin/cwpojn1/

The code cannot be simplified to “for line in stdin().lock().lines()”
until non-lexical lifetimes are implemented. The compiler complains at
the moment about a temporary value not living long enough/being dropped
while still borrowed. See https://github.com/rust-lang/rust/issues/33520

This commit is related to issue #1103.
2018-10-24 15:21:05 +02:00
Paul Capron
bb9cc77858 Don’t wrap stdin in a BufReader when prompting
stdin() is already buffered.

stdin().read_line() calls stdin().lock() behind the hood (see
https://doc.rust-lang.org/src/std/io/stdio.rs.html#274)
Here we are reading user input, prompting them to confirm their action:
it seems useless to handle mutex locking/unlocking explicitely and
beforehand to avoid its overhead.

This commit is related to issue #1103.
2018-10-24 15:08:51 +02:00
Julio Rincon
4ac2de925d tee: handle '-' as filename (POSIX spec) fix #1278 2018-10-16 22:10:53 +11:00
Vinzent Steinberg
fe21c4b7fd Update to Rand 0.5 (#1288)
* factor: Update to Rand 0.5

* shuf: Update to Rand 0.5

* shred: Update to Rand 0.5

* mktemp: Update to Rand 0.5
2018-10-14 13:33:44 +04:00
cnd
1b1751d721
Merge pull request #1297 from E5ten/patch-1
Fix -b flag
2018-10-14 13:28:21 +04:00
Roy Ivy III
f56a7d30ba fix: remove unused parens 2018-10-14 00:41:14 -05:00
Roy Ivy III
c56f8f6807 fix: remove unused 'mut' 2018-10-14 00:41:14 -05:00
Roy Ivy III
16d39cafcc fix: remove unused imports 2018-10-14 00:41:14 -05:00
Roy Ivy III
197bd2e10c fix: gate unix-only macros (silences "unused" warnings) 2018-10-14 00:41:14 -05:00
Roy Ivy III
a66f7a7a53 fix: remove deprecated 'std::ascii::AsciiExt' 2018-10-14 00:41:14 -05:00
E5ten
9ff5d4f1f9
Update du.rs
Remove extra parentheses around 1
2018-10-09 21:35:13 -04:00
Alex Lyon
5008b4db2e
Merge pull request #1293 from JJJollyjim/master
numfmt: support neither or both of --to and --from
2018-10-09 18:06:49 -07:00
E5ten
4a0f3b31ab
Fix -b flag
Fixes #1295 , making -b act like `du --block-size=1 --apparent-size`, the reason it uses `stat.size` instead of `stat.nlink * stat.size` is explained in #1292 and the fix for that issue #1294 is mirrored by the use of `stat.size` here.
2018-09-30 22:24:01 -04:00
Ron Kuslak
b09ccaf6b1 Fix comparison of empty string to numeric f64 sort 2018-09-30 09:14:18 -05:00
Jamie McClymont
f3a71215bc numfmt: support neither or both of --to and --from
matches GNU behaviour
2018-09-25 01:42:11 +12:00
Marcus Millin
a19d6d9d7c hostid: remove old enum
Remove old arg parsing enum
2018-09-18 19:48:53 -05:00
Árni Dagur
3367d3d979
Switch to using rust-number-prefix from pretty-bytes 2018-09-18 22:16:34 +00:00
Árni Dagur
9207269791
Change 'ls -l -h' formatting to match GNU ls
Before:
-rw-r--r--  1 arni arni  2.02 kB 2018-09-14 21:07 CONTRIBUTING.md
-rw-r--r--  1 arni arni 78.75 kB 2018-09-14 23:41 Cargo.lock
-rw-r--r--  1 arni arni  6.92 kB 2018-09-14 21:07 Cargo.toml
-rw-r--r--  1 arni arni  1.05 kB 2018-09-14 21:07 LICENSE
-rw-r--r--  1 arni arni  5.98 kB 2018-09-14 21:07 Makefile
-rw-r--r--  1 arni arni 10.68 kB 2018-09-14 21:07 README.md
-rw-r--r--  1 arni arni  2.22 kB 2018-09-14 21:07 appveyor.yml
-rw-r--r--  1 arni arni   2.9 kB 2018-09-14 21:07 build.rs
-rw-r--r--  1 arni arni     15 B 2018-09-14 21:07 codecov.yml
drwxr-xr-x  2 arni arni   4.1 kB 2018-09-14 21:07 docs
-rw-r--r--  1 arni arni    973 B 2018-09-14 21:07 mkmain.rs
drwxr-xr-x 97 arni arni   4.1 kB 2018-09-14 21:07 src
drwxr-xr-x  3 arni arni   4.1 kB 2018-09-14 21:08 target
drwxr-xr-x  4 arni arni   4.1 kB 2018-09-14 21:07 tests
-rw-r--r--  1 arni arni     48 B 2018-09-14 21:07 uumain.rs

After:
-rw-r--r--  1 arni arni  2.02K 2018-09-14 21:07 CONTRIBUTING.md
-rw-r--r--  1 arni arni 78.68K 2018-09-16 20:39 Cargo.lock
-rw-r--r--  1 arni arni  6.92K 2018-09-14 21:07 Cargo.toml
-rw-r--r--  1 arni arni  1.05K 2018-09-14 21:07 LICENSE
-rw-r--r--  1 arni arni  5.98K 2018-09-14 21:07 Makefile
-rw-r--r--  1 arni arni 10.68K 2018-09-14 21:07 README.md
-rw-r--r--  1 arni arni  2.22K 2018-09-14 21:07 appveyor.yml
-rw-r--r--  1 arni arni   2.9K 2018-09-14 21:07 build.rs
-rw-r--r--  1 arni arni     15 2018-09-14 21:07 codecov.yml
drwxr-xr-x  2 arni arni   4.1K 2018-09-14 21:07 docs
-rw-r--r--  1 arni arni    973 2018-09-14 21:07 mkmain.rs
drwxr-xr-x 97 arni arni   4.1K 2018-09-14 21:07 src
drwxr-xr-x  3 arni arni   4.1K 2018-09-14 21:08 target
drwxr-xr-x  4 arni arni   4.1K 2018-09-14 21:07 tests
-rw-r--r--  1 arni arni     48 2018-09-14 21:07 uumain.rs
2018-09-16 20:42:11 +00:00
cnd
1f64d83d6f
Merge pull request #1284 from vks/clippy
Misc code clean up
2018-09-05 10:43:51 +04:00
cnd
35b1e47a63
Merge pull request #1285 from arsdragonfly/master
numfmt: add suffixes and fix negative numbers
2018-09-05 10:39:26 +04:00
Zheyu Shen
1af0484360 numfmt: add suffixes and fix negative numbers
Also refactors the code.
2018-09-04 18:27:21 -04:00
Vinzent Steinberg
bc78bcac7d Remove utf8 feature
All code it provides can be implemented with `std`.
2018-09-04 14:49:27 +02:00