Commit graph

7051 commits

Author SHA1 Message Date
Daniel Hofstetter
35141deeee ln: fix help text 2024-02-15 14:38:26 +01:00
Daniel Hofstetter
6adaf31d49
Merge pull request #5962 from wolimst/cut/fix/multiple-mode-args
cut: show error for multiple mode args (`-b`, `-c`, `-f`)
2024-02-14 14:23:47 +01:00
wolimst
6bec96aad1 cut: refactor mode args counting by removing nested map 2024-02-14 20:02:42 +09:00
BaherSalama
5603305e75
fix tr with any flag with more than 2 operands (#5952)
* fix tr

* add tests

* fix clippy

* fix clippy2

* do suggestions

* do suggestions

* remove mut

* tr: move var to block & remove its type

---------

Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
2024-02-13 15:30:15 +01:00
Daniel Hofstetter
826cdbe3dc
Merge pull request #5940 from cre4ture/fix/stabilize_android_build_memory_kill_split
`split` fix android memory kill in split
2024-02-12 16:50:19 +01:00
Sylvestre Ledru
b4c8a1aee0
Merge pull request #5970 from cakebaker/ls_date_rename_duration_to_time_delta
ls,date: rename `chrono::Duration` to `chrono::TimeDelta`
2024-02-11 14:18:13 +01:00
Daniel Hofstetter
120a0e09fc ls,date: rename chrono::Duration to TimeDelta 2024-02-11 13:24:20 +01:00
Terts Diepraam
e0c2714d60 tsort: drastically reduce memory copies 2024-02-11 10:57:19 +01:00
Terts Diepraam
50cab572db uucore: ensure quoting-style feature is enabled if format is enabled 2024-02-10 21:37:28 +01:00
Ulrich Hornung
e68312cae9 sane blksize to avoid memory kill in split -n 3 /dev/zero 2024-02-10 14:33:13 +01:00
Terts Diepraam
a4f626efa2 uucore/format: refactor handling of flags to make clippy happy 2024-02-10 12:48:35 +01:00
Terts Diepraam
3a21d27c1e uucore/format: ignore the 0 flag if a precision is specified 2024-02-10 12:22:11 +01:00
Terts Diepraam
0602c197ff csplit: use uucore/format functionality for suffix 2024-02-10 11:51:20 +01:00
Terts Diepraam
a30dce0b7c uucore/format: cast signedint to unsignedint if possible 2024-02-10 11:51:20 +01:00
wolimst
0ac8606577 cut: add comments about handling multiple cutting mode args 2024-02-09 22:15:18 +09:00
Daniel Hofstetter
337bfeebc1 uucore/num_format: fix typo in comment 2024-02-09 13:28:18 +01:00
Terts Diepraam
3126e5f8a1 printf: fix padding and prefixes for unsigned ints 2024-02-09 13:28:18 +01:00
Terts Diepraam
4dae902429 printf: pad octal numbers with zeros on the left 2024-02-09 13:28:18 +01:00
wolimst
cb0ce0e1cb cut: show error for multiple mode args (-b, -c, -f) 2024-02-09 15:56:15 +09:00
Daniel Hofstetter
04ebd863a6 clippy: fix warnings introduced by Rust 1.76 2024-02-08 16:56:01 +01:00
BaherSalama
5c2ae5be4f
fix tr with delete flag if more than 1 operand given (#5945)
* fix tr

* fix

* adding a test

* tr: rename test function

---------

Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
2024-02-06 16:42:08 +01:00
Terts Diepraam
0b89a734b6 uucore: make help_{about,usage} fail if no text is found 2024-02-06 13:45:43 +01:00
Terts Diepraam
64cb591e3b seq: fix about text not found 2024-02-06 13:45:12 +01:00
Daniel Hofstetter
d2a75457f6 Fix errors reported by new version of cspell 2024-02-05 09:12:52 +01:00
Ludmuterol
96d96e7de3
more handle errors with multiple files (#4997)
* more handle errors with multiple files

* tests/more test refactor and new case

* tests/more new cases

* more: use show! and change exitstatus and adjust tests to new exitvalue

---------

Co-authored-by: Sylvestre Ledru <sylvestre@debian.org>
2024-02-04 16:32:14 +01:00
Ulrich Hornung
93d922f075
squash commit 2024-02-03 17:08:39 +01:00
Sylvestre Ledru
b485a480cf
Merge pull request #5932 from cakebaker/uucore_fix_never_used_warnings_on_redox
uucore: fix "X is never used" warnings on Redox
2024-02-03 07:46:29 +01:00
Biplab Mochan Gartia
fd4e1cfb28
stat: should fail without arguments #5928 (#5935)
* stat: should fail without arguments #5928

* style and lint issue  stat: should fail without arguments #5928

* style and lint issue  stat: should fail without arguments #5928

* style and lint 2 issue  stat: should fail without arguments #5928

---------

Co-authored-by: biplab5464 <biplab5464@outlook.com>
2024-02-02 17:00:35 +01:00
Samuel Larkin
c7f730470f doc: fixed benchmark table 2024-02-02 10:13:38 -05:00
Daniel Hofstetter
9c7675945f uucore: fix "X is never used" warnings on Redox 2024-02-02 09:33:35 +01:00
Daniel Hofstetter
47843dc8f5 ls: fix "unused variable" warning on Redox 2024-02-02 09:13:38 +01:00
Biplab Mochan Gartia
4a7dfa7904
stat.rs: Refactor to remove #[allow(clippy::cognitive_complexity)] #5881 (#5924)
* stat.rs: Refactor to remove #[allow(clippy::cognitive_complexity)] #5881

* remvoe Vec when ruturing  stat.rs: Refactor to remove #[allow(clippy::cognitive_complexity)] #5881

* formmating issue  stat.rs: Refactor to remove #[allow(clippy::cognitive_complexity)] #5881

* cakebaker suggestion stat.rs: Refactor to remove #[allow(clippy::cognitive_complexity)] #5881

* sytle and lint issue  stat.rs: Refactor to remove #[allow(clippy::cognitive_complexity)] #5881

---------

Co-authored-by: biplab5464 <biplab5464@outlook.com>
2024-02-01 16:20:32 +01:00
Daniel Hofstetter
d53077160f
Merge pull request #5914 from Ideflop/disable-row-mode-on-panic
more: Disable raw mode before exiting if a panic occurs
2024-02-01 15:08:08 +01:00
Ideflop
b9112da4b2 more: Disable raw mode before exiting if a panic occurs 2024-01-30 20:57:38 +01:00
Sylvestre Ledru
8691ec9a80
Merge pull request #5916 from cakebaker/du_non_existing
du: adapt error message to match GNU's
2024-01-30 17:13:37 +01:00
Sudhakar Verma
bd336ebbf1 dd: fail on missing number in count 2024-01-30 20:21:25 +05:30
Daniel Hofstetter
d1e1e9ce0f du: adapt error msg to match GNU's 2024-01-30 10:08:50 +01:00
Terts Diepraam
1b324da436 echo: do not infer long args 2024-01-29 17:40:22 +01:00
Daniel Hofstetter
742d39300b wc: fix two incorrect code comments 2024-01-29 10:42:34 +01:00
Harsh Ranjan
1528b35113
refactor wc.rs to remove clippy's cognitive complexity lint (#5897)
* refactor wc.rs to remove clippy's cognitive complexity lint

* fix for tracking line length and number of words correctly if chunking occurs within them

* removing more of the cognitive complexity from the Err variant in the match block

* running cargo clippy once

* wc: add empty line to separate functions

---------

Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
2024-01-29 10:41:11 +01:00
Jeffrey Finkelstein
d782fd1bd3 dd: parse big numbers and return u64::MAX
Change the behavior of `dd` so that it parses numbers that would be too
big and instead treats them as `u64::MAX`. This allows `dd` to run
without error on

    dd count=00x9999999999999999999999999999999999999999999999999999999999999

This matches the behavior of GNU `dd`.
2024-01-28 13:41:34 -05:00
kralo
ee7f99aad0 cp: use inclusive range
as suggested by clippy::range-plus-one
2024-01-28 09:42:40 +01:00
kralo
d046d33bee split: use inclusive range
as suggested by clippy::range-plus-one
2024-01-28 09:42:40 +01:00
kralo
9906e66096 uucore: remove unneccessary closues
This adresses only those where the fix has less letters than the
original and is "trivial" (There are possibly a lot of std::string::ToString::to_string
and those may only be shortened with additional imports).

Found with clippy::redundant-closure-for-method-calls
2024-01-28 09:42:40 +01:00
kralo
bd43a7ed99 nl: fix redundant clone (clippy warning) 2024-01-28 09:42:40 +01:00
Sylvestre Ledru
7fa4b389a9
Merge pull request #5892 from kralo/fix-5883
factor: rename input parameter
2024-01-28 09:28:36 +01:00
kralo
9adceb4f65 factor: rename input parameter
Closes: #5883
2024-01-28 08:24:16 +01:00
kralo
12dd1e4d7d cp: remove lint exceptions
Could not even reproduce what they would complain for.
Closes: #5885
2024-01-27 19:21:05 +01:00
kralo
3eba95728c factor: remove clippy exceptions by reformatting "unreadable literals"
Closes: #5884
2024-01-27 17:23:44 +01:00
Daniel Hofstetter
c8cd355708 cut: set exit code to 1 if dir is specified 2024-01-26 10:18:44 +01:00
Daniel Lungu
61c730d1b3
expand: Continue work when one of given files doesn't exist (#5873)
* expand: continues work when one of given files doesn't exist

* fixed test for nonexisting file
2024-01-25 09:10:59 +01:00
Sylvestre Ledru
1693640446 whoami: add missing feature 2024-01-24 21:33:25 +01:00
Biplab Mochan Gartia
150b287fe8
unexpand: allow multiple files & show error message if a directory is specified
* unexpand: should allow multiple files #5852 and unexpand: show error message if a directory is specified #5845

* test file added for #5845 #5852

* test case test_multiple_files improve

* cakebaker suggestion for a better code #5845 #5852

---------

Co-authored-by: biplab5464 <biplab5464@outlook.com>
2024-01-24 16:01:26 +01:00
Daniel Hofstetter
d690e8fb99
Merge pull request #5752 from sylvestre/0.0.24
0.0.23 => 0.0.24
2024-01-21 13:35:10 +01:00
Sylvestre Ledru
dd5c6c2d00 0.0.23 => 0.0.24 2024-01-20 20:12:19 +01:00
Sylvestre Ledru
5e29c60b26 hashsum: when the filename contains some special chars, escape them
Should fix tests/cksum/md5sum-newline.pl
2024-01-20 19:27:45 +01:00
SaHHiiLL
746a7b14d0
tsort: returns error when input is dir - same as GNU tsort (#5860)
* fix: return error when input is dir

* test: when tsort is given a dir

* fix: do not need to mention tsort in error message

* test: using concrete directory name

* tsort: fix formatting in test

---------

Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
2024-01-19 15:39:00 +01:00
Sylvestre Ledru
b7a14ac119
Merge pull request #5825 from tertsdiepraam/codecov-uucore-features
CI: test `uucore` with `coreutils` in codecov to run it with the proper features
2024-01-17 11:51:02 +01:00
Terts Diepraam
61de1dc23a uucore/sum: fix crlf test 2024-01-17 10:44:33 +01:00
Terts Diepraam
3bd9f0ec65
Merge pull request #5811 from spineki/fix-printf-hex-alternate-zero
Printf: Fix printf hex alternate zero
2024-01-17 10:28:30 +01:00
Ulrich Hornung
dc533a915a
install: fix strip program stdout and destination hyphen handling #5718 (#5848)
* Fix missing dependency to "process" to make it compile.

* fix issue of not forwarding stdout from strip program

* fix issue of applying "./" redundantly

* cargo fmt
2024-01-17 10:07:34 +01:00
Sylvestre Ledru
3872aca9c6 spell: ignore getxattr 2024-01-16 13:12:02 +01:00
Sylvestre Ledru
66637a6503 move the file_has_acl function into uucore 2024-01-16 13:12:02 +01:00
Sylvestre Ledru
2ec4e9f784 mv: preserve the xattr
Should make tests/mv/acl pass
2024-01-16 13:12:02 +01:00
Sylvestre Ledru
fe3f8293ef uucore: add a new feature called fsxattr 2024-01-16 13:11:58 +01:00
Daniel Hofstetter
112eb21eb3
Merge pull request #5791 from sylvestre/handle-error
Handle better some errors
2024-01-15 15:19:10 +01:00
Sylvestre Ledru
fff83995fb
cp: --preserve should keep xattr (#5834)
* cp: --preserve should keep xattr

Should help with tests/cp/acl.sh

* Update tests/by-util/test_cp.rs

Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>

* Update tests/by-util/test_cp.rs

Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>

* Update tests/by-util/test_cp.rs

Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>

---------

Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
2024-01-15 10:59:04 +01:00
Sylvestre Ledru
4557821adf
Merge branch 'main' into fix-printf-hex-alternate-zero 2024-01-15 10:41:09 +01:00
Sylvestre Ledru
e340d8177e
Merge pull request #5842 from cakebaker/uucore_fix_clippy_warning
uucore: fix clippy warning from if_not_else lint
2024-01-15 10:40:23 +01:00
Daniel Hofstetter
e91540fc07 uucore: fix clippy warning from if_not_else lint 2024-01-15 10:27:59 +01:00
Biplab Mochan Gartia
076b905513
cksum: stops when one of given files doesn't exist #5809 (#5820)
* cksum: stops when one of given files doesn't exist #5809

* removed printld  cksum: stops when one of given files doesn't exist #5809

* formatting the code cksum: stops when one of given files doesn't exist #5809

* formatting the code cksum: stops when one of given files doesn't exist #5809

* set exist status cksum: stops when one of given files doesn't exist #5809

* code quality formatting issue cksum: stops when one of given files doesn't exist #5809

* tertsdiepraam idea cksum: stops when one of given files doesn't exist #5809

* one new test case and deleted duplicate show cksum: stops when one of given files doesn't exist #5809

* formatting the test cases cksum: stops when one of given files doesn't exist #5809

* Revert "formatting the test cases cksum: stops when one of given files doesn't exist #5809"

This reverts commit 8c382f1e8f.

* reverting the changes and committing again due to a mistake cksum: stops when one of given files doesn't exist #5809

---------

Co-authored-by: biplab5464 <biplab5464@outlook.com>
2024-01-15 09:37:56 +01:00
Sylvestre Ledru
36039a819d
Merge pull request #5739 from cakebaker/cp_backup_with_symlink_to_source
cp: backup dest symlink linking to source
2024-01-14 23:30:06 +01:00
Sylvestre Ledru
e3beda08ac
Merge pull request #5762 from cakebaker/cp_link_same_file
cp: show no "same file" error for `--link a a`
2024-01-14 23:29:33 +01:00
Sylvestre Ledru
ef03a4625f
Merge pull request #5806 from cakebaker/nl_is_a_directory
nl: don't exit if input is directory
2024-01-14 23:29:05 +01:00
Sylvestre Ledru
3d356d47b3 expand: avoid an infinite loop 2024-01-14 23:27:00 +01:00
Sylvestre Ledru
8d24036f5c basenc: handle '--base32 .' arg 2024-01-14 23:27:00 +01:00
Sylvestre Ledru
4f33a375cd factor: handle the '< .' arg 2024-01-14 23:26:57 +01:00
Sylvestre Ledru
e01d5f75f7
ls: if acl are used, show the + in the perms (#5816)
* ls: if acl are used, show the + in the perms

Tested by tests/mkdir/p-acl.sh

* CICD.yml: fix small formatting issue

---------

Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
2024-01-14 15:57:22 +01:00
Daniel Hofstetter
ac27b6c4b0
Merge pull request #5833 from sylvestre/cut-multiple
cut: allow the same option to be passed multiple times
2024-01-13 16:58:04 +01:00
Sylvestre Ledru
bc51b8d216 cut: allow the same option to be passed multiple times 2024-01-13 15:09:16 +01:00
Atomei Alexandru
563df4b79d
Made cksum return an error if used on a directory. (#5822)
* Made cksum to return an error if it is used on a directory regardless of the algorithm

* Added one more test for cksum on folders and deleted an old one that expected it to succeed instead of fail

* Made cksum work on more than one item if it fails and added a test for this case
2024-01-13 14:43:36 +01:00
Sudhakar Verma
cd4568f5d9 printf: simplify loop 2024-01-12 17:12:30 +05:30
Sudhakar Verma
4e5a65ee41 printf: fix clippy warnings 2024-01-12 16:23:38 +05:30
Sudhakar Verma
2aa8a3502f printf : no infinite loop 2024-01-12 16:08:47 +05:30
Sylvestre Ledru
edb77b8d59
Merge pull request #5827 from samueltardieu/issue-5826
printf: %c prints the first byte of its argument
2024-01-12 00:25:32 +01:00
Daniel Hofstetter
5b860cb428
Merge pull request #5828 from samueltardieu/printf-double-quote
printf: output of double-quote should not be escaped
2024-01-11 08:52:51 +01:00
Samuel Tardieu
47e908bc6c printf: output of double-quote should not be escaped
This is obtained by escaping the sequence `\"` as `"`.
2024-01-10 19:17:42 +01:00
Sylvestre Ledru
19a9380089
Merge pull request #5803 from D9nni/cksum
cksum: Add --raw argument
2024-01-10 18:36:08 +01:00
Samuel Tardieu
7d32e49fb9 printf: %c prints the first byte of its argument 2024-01-10 18:19:56 +01:00
Marras Antoine
0648321d97 printf: 0x not shown anymore in front of 0 while in alternative mode 2024-01-10 16:55:04 +01:00
Terts Diepraam
0071442cba
Merge pull request #5783 from samueltardieu/printf-compatibility
printf compatibility
2024-01-10 16:33:37 +01:00
D9nni
9a76997b0a cksum: fixed clippy and fmt errors 2024-01-10 16:49:52 +02:00
Samuel Tardieu
a85a792c88 format: use the new number parser and fix the error messages
The error messages are more compliant with GNU coreutils.
Also, floating hexadecimal numbers are now supported in
`printf`.
2024-01-10 14:34:43 +01:00
Samuel Tardieu
00cd6fa347 format: new dedicated number parser
The parser can parse integral and floating point numbers as expected by
the coreutils `printf` command.
2024-01-10 14:34:43 +01:00
D9nni
911df1d76c cksum: code improvements for cksum --raw --algorithm 2024-01-10 15:15:23 +02:00
D9nni
c7b15ddce9 cksum: fixed cksum --raw --algorithm 2024-01-10 15:04:19 +02:00
D9nni
96271ffa3c cksum: added tests for --raw with each algorithm, not working for crc, sysv, bsd 2024-01-09 23:12:40 +02:00
Terts Diepraam
9858fef20e printf: use 0 instead of 0o as octal prefix 2024-01-09 10:34:08 +01:00
Samuel Tardieu
5dfeca9ff2 format: %c prints the first character of a string 2024-01-09 00:13:54 +01:00
Daniel Hofstetter
1c6bf6991c nl: don't exit if input is directory 2024-01-08 11:01:07 +01:00
Sylvestre Ledru
d72343bc64
Merge branch 'main' into cksum 2024-01-08 09:02:11 +01:00
D9nni
f03ef79bc8 cksum: added tests for --raw and fixed fmt whitespace error 2024-01-08 08:51:06 +02:00
Atomei Alexandru Constantin
288ad97878 Made cksum to return an error if the algorithm blake2b is used on a directory 2024-01-07 23:39:33 +02:00
D9nni
8c1fc8b287 Added --raw argument, with error for multiple files 2024-01-07 21:43:31 +02:00
Sylvestre Ledru
b309d64e78
Merge branch 'main' into issue-5766 2024-01-06 22:55:54 +01:00
Kostiantyn Hryshchuk
c867d6bfb1
shred: implemented "--remove" arg (#5790) 2024-01-06 22:50:21 +01:00
Sylvestre Ledru
247f2e55bd
seq: adjust some error messages. GNU's are better (#5798)
* seq: adjust some error messages. GNU's are better
tested by tests/seq/seq.pl

* uucore: remove todo

---------

Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
2024-01-06 16:54:29 +01:00
Fabrice Fontaine
9f4330f94c uucore: add support for sparc64
Add support for sparc64 in uucore to avoid the following build failure
with nushell:

error[E0308]: mismatched types
   --> /home/autobuild/autobuild/instance-7/output-1/build/nushell-0.85.0/VENDOR/uucore/src/lib/features/fs.rs:121:16
    |
111 |     pub fn number_of_links(&self) -> u64 {
    |                                      --- expected `u64` because of return type
...
121 |         return self.0.st_nlink;
    |                ^^^^^^^^^^^^^^^ expected `u64`, found `u32`
    |
help: you can convert a `u32` to a `u64`
    |
121 |         return self.0.st_nlink.into();
    |                               +++++++

For more information about this error, try `rustc --explain E0308`.
error: could not compile `uucore` (lib) due to previous error

Fixes:
 - http://autobuild.buildroot.org/results/f9f0287a8e39c65895014ca513ed25071f020add

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
2024-01-06 10:26:54 +01:00
Michel Lind
5de030f119
uuhelp_parser: add links to homepage and repo
When viewing the crate right now, apart from via looking at the dependencies
it's hard to find the associated project and repository.

Add the missing info.

Signed-off-by: Michel Lind <salimma@fedoraproject.org>
2024-01-05 22:21:28 -06:00
Daniel Hofstetter
e13f0d80ee
Merge pull request #5778 from RenjiSann/main
ls: Support QUOTING_STYLE environment variable
2024-01-05 15:55:23 +01:00
Samuel Tardieu
32f0256d7d uucore/num_format: properly display 10ᵖ where p is the precision
`seq --format %.2g 10 10` would display `1` because the precision would
not allow room for the decimal point, and the `0` in `10` would be
trimmed as an insignificant trailing `0`.

This has been fixed by only trimming trailing `0` in the presence of a
decimal point.
2024-01-05 15:40:20 +01:00
Samuel Tardieu
f5179290a6 uucore/num_format: replace saturating_sub by regular subtraction
Using `saturating_sub()` before converting to `usize` gives a wrong
feeling of security as it looks like it ensures that the value will
never go negative. However, since it is applied to `i32`, it can, and
converting it to `usize` would go horribly wrong anyway.

By following the code flow, `exponent` cannot be greater than
`precision`, or the `else` block would not have been taken.  A plain
subtraction will give the same result and will at least panic in debug
mode.
2024-01-05 15:04:12 +01:00
Samuel Tardieu
4c5326ffa3 uucore/num_format: the default precision for %g is 6 2024-01-05 15:00:12 +01:00
Sylvestre Ledru
e64a0b4a26 Various fixes
Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
2024-01-05 12:56:27 +01:00
Sylvestre Ledru
aabf5fa577 cp: manages target with trailing '/' 2024-01-05 12:56:27 +01:00
Sylvestre Ledru
cb27b9c9c3 path_ends_with_terminator: rustdoc + unittest 2024-01-05 12:56:27 +01:00
Sylvestre Ledru
108dc4a0cd Move path_ends_with_terminator from mv into uucore 2024-01-05 12:56:27 +01:00
Sylvestre Ledru
4c698d58e0 mv: support the case mkdir a && mv a e/ 2024-01-05 12:56:24 +01:00
Samuel Tardieu
e56682893f uucore: fix style in tests
- `Path::new()` returns a `&Path` and does not need to be dereferenced
- Some types can be deduced from the context and are well visible
  already (`parse_size_u128()` or `from_bytes()`)
2024-01-05 10:14:27 +01:00
Ikko Eltociear Ashimine
9dca071b69
Fix typo in signals.rs (#5781)
* Fix typo in signals.rs

occured -> occurred

* Remove "occurred" from spell-checker:ignore

---------

Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
2024-01-05 07:30:23 +01:00
cre4ture
9b3cc5437c
head: head_backwards for non-seekable files like /proc/* or fifos (named pipes) (#5732)
* implement head_backwards for non-seekable files like /proc/* or pipes

Signed-off-by: Ulrich Hornung <hornunguli@gmx.de>
2024-01-05 00:25:59 +01:00
Dorian Péron
6760d63539 ls: Fix clippy warning 2024-01-04 16:51:30 +01:00
Dorian Péron
e30f191579 ls: Handle the use of QUOTING_STYLE variable 2024-01-03 18:37:51 +01:00
Daniel Hofstetter
e4fbc31714 du: ignore duplicate names with --files0-from 2024-01-03 09:39:16 +01:00
Sylvestre Ledru
8df064e1fa
Merge pull request #5772 from cakebaker/du_files0_from_zero_length_file_name
du: show error for nul names with `--files0-from`
2024-01-02 19:53:15 +01:00
Daniel Hofstetter
239e5426e6 du: show error for nul names with --files0-from 2024-01-02 16:06:41 +01:00
Daniel Hofstetter
9f257adf59
Merge pull request #5765 from sylvestre/handle-full
handle the error when stdout is full
2024-01-02 08:31:19 +01:00
Sylvestre Ledru
f53f9b6496 handle the error when stdout is full
Avoid panic when using
seq 1 >/dev/full

Should move tests/csplit/csplit-io-err.sh from ERROR to SKIP
2024-01-01 17:00:10 +01:00
Daniel Hofstetter
01e12120c1 mv: simplify condition 2024-01-01 16:48:06 +01:00
Daniel Hofstetter
7ddeba4b98 cp: show no "same file" error for --link a a 2024-01-01 14:30:27 +01:00
Daniel Hofstetter
5673f32c63 cp: show error if source & dest are same file 2023-12-31 16:01:34 +01:00
Daniel Hofstetter
902a128ea8 cp: rename function
is_forbidden_copy_to_same_file -> is_forbidden_to_copy_to_same_file
2023-12-31 14:36:18 +01:00
Daniel Hofstetter
2c42623b6e cp: backup dest symlink linking to source 2023-12-31 14:09:08 +01:00
Sylvestre Ledru
b07ea957d3 rm: improve the code a tiny bit 2023-12-31 12:03:42 +01:00
Sylvestre Ledru
5fc01f718a
Merge pull request #5747 from Ato2207/fix_docs
Fix docs issues.
2023-12-30 19:28:54 +01:00
Vardhan Patil
d990021572 cksum: remove redundant guard 2023-12-30 20:39:09 +05:30
Vardhan Patil
e7cb4e9ff0 cksum: properly handle cases where --lenghth is 0 or >512 2023-12-30 20:28:03 +05:30
Atomei Alexandru
5ade45f8e9
Merge branch 'main' into fix_docs 2023-12-30 15:43:54 +02:00
Vardhan Patil
aec0cfa6e3 cksum: remove commented code 2023-12-30 16:05:20 +05:30
Vardhan Patil
7caa0bcdea cksum: fix formatting in cksum.rs 2023-12-30 16:02:10 +05:30
Vardhan Patil
037073d852 cksum: make the output formatting match GNU 2023-12-30 15:59:29 +05:30
Sylvestre Ledru
138b11efbd
remove extra spaces 2023-12-30 09:53:32 +01:00
Vardhan Patil
231987b109 cksum: create initial implementation of the --length option 2023-12-30 12:48:19 +05:30
Matei Mantu
21d09dd404
ls: unquoted names should be indented with a space if there is a quoted name (#5740)
* ls: change indentation when file names include quotes to match GNU's

* display_grid: Changed order of parameters because it made more sense

* ls -l: Add padding for unquoted filenames

* Fix checking for quoted filenames

* Simplify if
2023-12-29 15:19:26 +01:00
Sylvestre Ledru
448e4c2224
Merge pull request #5745 from cakebaker/cp_adapt_warning
cp: adapt warning if source is used more than once
2023-12-29 15:09:24 +01:00
Alexandru-Constantin Atomei
d15981650a Fixed one typo 2023-12-29 15:08:50 +01:00
Alexandru-Constantin Atomei
1e5244765d Made one more modification to test usage string. 2023-12-29 15:08:50 +01:00
Alexandru-Constantin Atomei
e61318413e Added documentation for the vdir command. 2023-12-29 15:08:50 +01:00
Alexandru-Constantin Atomei
ce28ae5c02 Fixed more and test docs 2023-12-29 15:08:50 +01:00
Sylvestre Ledru
f8f82774c3
Merge pull request #5696 from dvalere/my-conts
src: Fixing typos in signatures for the argument parser
2023-12-29 15:08:39 +01:00
Daniel Hofstetter
7025619325 cp: adapt warning if source is used more than once 2023-12-29 10:24:08 +01:00
Daniel Hofstetter
9bb725cefc clippy: fix warnings introduced by Rust 1.75 2023-12-28 18:17:06 +01:00
Sylvestre Ledru
2c0f15be55 install: if run as root, revert the uid & gid to root 2023-12-28 10:06:13 +01:00
Sylvestre Ledru
0fb3ffb8ad install: document the need_copy function 2023-12-28 10:05:44 +01:00
Sylvestre Ledru
c0206c5ea4 install: document the need_copy function 2023-12-28 10:05:28 +01:00
Sylvestre Ledru
ce18f8a2a1 install: split the need_copy check 2023-12-28 10:03:42 +01:00
Daniel Hofstetter
179f0a7c3c
Merge pull request #5733 from sylvestre/getegid_geteuid
use our getegid & geteuid wrappers function instead of libc calls
2023-12-28 08:49:34 +01:00
Sylvestre Ledru
ad16313c59
head: -c allocate memory as needed (#5704)
* head: -c allocate memory as needed

Improve the execution of tests/head/head-c.sh

* simplify the code

Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>

---------

Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
2023-12-28 07:15:01 +01:00
Sylvestre Ledru
c38a43210c use our getegid & geteuid wrappers function instead of libc calls 2023-12-28 00:35:20 +01:00
Daniel Hofstetter
0701f535ac cp: fix backup of destination symlink 2023-12-27 15:39:54 +01:00
Matei Mantu
bf26eda786
install: remove / from end of path if it exists so as not to mess with .exists() (#5730)
* remove / from end of path if it exists so as not to mess with .exists()

* install: fix / removal from path

* Fix clippy warnings

* Add test for install target ends with /
2023-12-27 13:37:17 +01:00
Darius
edbb7d5b02 join: fixed parameter
basenc: fixed parameter
cut: fixed parameter
mkdir: fixed parameter
nohup: fixed parameter
pr: fixed parameter
printenv: fixed parameter
printf: added parameters
runcon: fixed typo
shuf: fixed typo
sum: fixed typo
uniq: fixed parameter
unlink: fixed parameter
2023-12-26 16:13:18 +01:00
Sylvestre Ledru
167acb5147
Merge pull request #5484 from cakebaker/cp_l_with_dest_hardlink_to_source
cp --link: don't fail if destination is hardlink to source
2023-12-26 16:12:15 +01:00
Sylvestre Ledru
30eb77ac79
du: implement files0-from (#5721)
* du: implement files0-from

Should make tests/du/files0-from-dir pass

* du: prepare tests/du/files0-from.pl

* fix the build on Windows

* add testfile to the ignore list

* remove useless comment

Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>

* mkdir is enough

Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>

* address review comments

---------

Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
2023-12-26 14:40:31 +01:00
Paul Houssel
eb3dd521ee
touch: address cognitive_complexity lint
Signed-off-by: Paul  Houssel <paul.houssel@telecom-sudparis.eu>
2023-12-26 13:02:00 +01:00
Paul Houssel
da43183fc7
cat: address cognitive_complexity lint
Signed-off-by: Paul  Houssel <paul.houssel@telecom-sudparis.eu>
2023-12-26 13:02:00 +01:00
Sylvestre Ledru
db9f4cc315
Merge pull request #5483 from cakebaker/mv_fix_5481
mv: fix subdir detection
2023-12-25 22:02:23 +01:00
Daniel Hofstetter
f10c6f1d56
Merge pull request #5699 from sylvestre/mv-cp-seen
cp/mv/ln: add support for the "will not overwrite just-created"
2023-12-25 14:58:50 +01:00
Daniel Hofstetter
03f1b8aa3a mv: fix subdir detection 2023-12-25 13:12:18 +01:00
Daniel Hofstetter
4946478409 cp: -l don't fail if dest is hardlink to source 2023-12-25 13:03:11 +01:00
Sylvestre Ledru
356023b055
Merge pull request #5431 from cakebaker/cp_remove_destination_shouldnt_fail_hardlink
cp --remove-destination: don't fail if destination is hardlink to source
2023-12-25 13:02:50 +01:00
Sylvestre Ledru
f86e314f46 Fix some obvious comment
Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
2023-12-25 11:17:04 +01:00
Sylvestre Ledru
840a5bf083
Merge pull request #5700 from cakebaker/ls_block_size_with_k
ls: set correct block size when -k is provided
2023-12-25 11:14:09 +01:00
Daniel Hofstetter
6475e6f148
Merge pull request #5660 from sylvestre/stat-free-color
ls: Improve the access to metadata of the files
2023-12-25 08:29:25 +01:00
Daniel Hofstetter
270ac90cc1 ls: set correct block size when -k is provided 2023-12-24 16:35:49 +01:00
Sylvestre Ledru
c5217b3136 ls: remove unused arg check_for_deref 2023-12-24 15:03:34 +01:00
Sylvestre Ledru
18035a5f82 update of the function names in the comment
Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
2023-12-24 14:57:06 +01:00
Sylvestre Ledru
53b3c782ef add a link to d_type doc 2023-12-24 14:57:06 +01:00
Sylvestre Ledru
a3c7359056 ls: refactor the code 2023-12-24 14:57:06 +01:00
Sylvestre Ledru
5120acb27a fix a clippy warning 2023-12-24 14:57:06 +01:00
Sylvestre Ledru
445d0af277 ls: rename get_metadata_with_deref_opt 2023-12-24 14:57:06 +01:00
Sylvestre Ledru
147721c24b ls: Improve the access to metadata of the files Should fix tests/ls/stat-free-color.sh 2023-12-24 14:57:06 +01:00
Sylvestre Ledru
95fa81250e ls/color_name: use the DirEntry if available 2023-12-24 14:57:06 +01:00
Sylvestre Ledru
1bd8ce5ddf ls/color_name: use PathData instead of a Path as we want to check for DirEntry 2023-12-24 14:57:06 +01:00
Sylvestre Ledru
c0c5ec25b6 ls: rename a function for something more explicit 2023-12-24 14:57:06 +01:00
Sylvestre Ledru
28d684b5ac ls: add a comment 2023-12-24 14:57:06 +01:00
Daniel Hofstetter
4d05f208e0
Merge pull request #5701 from sylvestre/debug
cp: debug with --update=none should show 'skipped'
2023-12-24 14:25:57 +01:00
Daniel Hofstetter
8ede675088
Merge pull request #5712 from sylvestre/shred
shred: improve some output to match GNU's
2023-12-24 14:05:35 +01:00
Daniel Hofstetter
0d05a41f46
Merge pull request #5702 from sylvestre/runcon
runcon: remove trailing '.'
2023-12-24 13:54:52 +01:00
Sylvestre Ledru
c5b08f1c4a shred: improve some output to match GNU's 2023-12-24 11:40:15 +01:00
Sylvestre Ledru
9b78016ac5 runcon: remove trailing '.'
Upstream doesn't have in:
https://github.com/coreutils/coreutils/blob/master/tests/runcon/runcon-no-reorder.sh#L22
2023-12-23 23:03:18 +01:00
Sylvestre Ledru
8685e05f4e cp: debug with --update=none should show 'skipped' 2023-12-23 17:58:05 +01:00
Daniel Hofstetter
be822009f0
Merge pull request #5686 from sylvestre/install-basic
install: with -t, check if we aren't passed a file
2023-12-23 15:33:45 +01:00
Sylvestre Ledru
2832694056
install: support when a hyphen is passed (#5697)
* install: support when a hyphen is passed

Should fix: tests/install/strip-program.sh

Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
2023-12-23 15:29:32 +01:00
Sylvestre Ledru
ceecac110c ln: manages the 'seen' file list before linking
Should help with tests/mv/childproof.sh
2023-12-23 13:53:26 +01:00
Sylvestre Ledru
c94773f522 mv: make sure it continues when hiting an error 2023-12-23 13:27:00 +01:00
Sylvestre Ledru
9c7fd5e8cb mv: rename the variable to match the name in cp 2023-12-23 13:07:54 +01:00
Sylvestre Ledru
3af8ad0fe6 mv: manages the 'seen' file list before moving
Should help with tests/mv/childproof.sh
2023-12-23 13:07:39 +01:00
Sylvestre Ledru
06c98fbdd3 cp: don't fail when --backup=numbered is passed 2023-12-23 12:48:38 +01:00
Sylvestre Ledru
837640bc02 cp: manages the 'seen' file list before copying
Should help with tests/mv/childproof.sh
2023-12-23 12:11:35 +01:00
Sylvestre Ledru
6b1f51385f
Merge pull request #5693 from cakebaker/ls_second_blocksize
ls: introduce 2nd blocksize & fix todos in tests
2023-12-23 09:57:08 +01:00
Sylvestre Ledru
9ca7c3e107 install: with -t, check if we aren't passed a file
Should pass tests/install/basic-1
2023-12-22 18:16:23 +01:00
Daniel Hofstetter
1c6317af76 mv: allow dest with slash when using --update 2023-12-22 17:03:59 +01:00
Daniel Hofstetter
a8a5931cae ls: introduce 2nd blocksize & fix todos in tests 2023-12-22 11:42:01 +01:00
Daniel Hofstetter
6510115d9e
Merge pull request #5680 from tertsdiepraam/fsext-refactor
Fsext refactor
2023-12-21 15:55:30 +01:00
Sylvestre Ledru
e071fd3042
Merge pull request #5684 from allaboutevemirolive/v10_expand
expand: fix duplicate flags
2023-12-21 11:03:09 +01:00
Sylvestre Ledru
95852dbaa5
Merge pull request #5687 from cakebaker/ls_remove_condition
ls: remove condition with unreachable "else" block
2023-12-21 10:44:58 +01:00
Daniel Hofstetter
f16a4ae9c9 ls: remove condition with unreachable "else" block 2023-12-21 09:37:36 +01:00
allaboutevemirolive
3e6187269e fix duplicate flags 2023-12-20 23:30:46 +02:00
Justin !
a6ba81db20
sort: allow -f to be pass multiple time
Fix #5667
2023-12-20 12:42:57 -05:00
Sylvestre Ledru
c20f009da4
Merge pull request #5676 from lcheylus/openbsd-fix
uucore: remove useless conversion for features/fs on OpenBSD
2023-12-20 15:44:34 +01:00
Terts Diepraam
f90713278f uucore/fsext: do not use dangerous macro for nul terminated UTF16 strings 2023-12-20 15:27:51 +01:00
Terts Diepraam
cc15876bb7 uucore/fsext: merge some windows imports 2023-12-20 15:27:51 +01:00
Terts Diepraam
d4a9d63ea2 uucore/fsext: refactor MountInfo construction 2023-12-20 15:27:51 +01:00
Daniel Hofstetter
d8709d2839 ls: recognize BLOCKSIZE env var 2023-12-19 15:00:06 +01:00
Sylvestre Ledru
6bcf4e2cec
tr: add 'boop' to the ignore spell check 2023-12-19 13:26:39 +01:00
Laurent Cheylus
b9d4f97e6d
uucore: remove useless conversion for features/fs on OpenBSD
- src/uucore/src/lib/features/fs.rs: in inode function, remove useless
    conversion for target_OS = OpenBSD

Signed-off-by: Laurent Cheylus <foxy@free.fr>
2023-12-19 12:13:20 +01:00
Sylvestre Ledru
9920f13a34
Merge pull request #5640 from tertsdiepraam/tr-no-output
`tr`: operate on bytes instead of chars
2023-12-19 11:42:44 +01:00
Sylvestre Ledru
3d42619027
Merge pull request #5674 from cakebaker/ls_ignore_invalid_block_size_from_env_vars
ls: ignore invalid block size from env vars
2023-12-19 11:11:11 +01:00
Daniel Hofstetter
d8f299eb48 ls: mention config.hyperlink in comment 2023-12-19 10:50:36 +01:00
Daniel Hofstetter
ebfbd8b1fe ls: rename display_file_name -> display_item_name 2023-12-19 10:50:36 +01:00
Daniel Hofstetter
a5606613bd ls: ignore invalid block size from env vars 2023-12-19 10:02:34 +01:00
Sylvestre Ledru
52af36d80b
Merge pull request #5673 from tertsdiepraam/expr-fix-comparison
`expr`: coerce to string before comparing values
2023-12-18 22:50:42 +01:00
Terts Diepraam
00b9cbe09e expr: coerce to string before comparing values 2023-12-18 22:24:31 +01:00
Sylvestre Ledru
b32c93ee5e
Merge pull request #5672 from cakebaker/ls_hyperlink_dirs
ls: support hyperlinks for dir names
2023-12-18 18:24:27 +01:00
Sylvestre Ledru
ece9e91593
Merge pull request #5671 from Yykz/wc_args_override
wc: fix arguments not overriding
2023-12-18 15:56:10 +01:00
Daniel Hofstetter
917c6a4743 ls: support hyperlinks for dir names 2023-12-18 15:26:09 +01:00
Daniel Hofstetter
8c6463c525 ls: extract "create_hyperlink" function 2023-12-18 14:25:13 +01:00
Sylvestre Ledru
0fa074fcba
Merge pull request #5629 from cakebaker/ls_hyperlink_encode
ls: encode path when using --hyperlink
2023-12-18 13:38:08 +01:00
Yykz
bd22aba03b make args of wc overriding 2023-12-18 12:47:37 +01:00
Daniel Hofstetter
e79eb097af
Merge pull request #5656 from sylvestre/ls-var
ls: manages the COLOR and COLORTERM variables
2023-12-18 07:16:38 +01:00
Sylvestre Ledru
5b45159996
Improve the comment 2023-12-17 17:40:44 +01:00
Sylvestre Ledru
af2625c8ce
fix order
Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
2023-12-17 17:39:02 +01:00
Akmal
052f38f14d
unexpand: remove crash! macro (#5588)
* unexpand_macro_fixed

* unexpand

* Remove crash

* Passed local test case

* Small changes

* unexpand: remove #[allow(clippy::cognitive_complexity)]

---------

Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
2023-12-17 16:43:00 +01:00
Sylvestre Ledru
35ae43e71f
Merge pull request #5620 from lcheylus/openbsd-utmpx
Support unix feature on OpenBSD (utmpx not supported)
2023-12-16 18:15:11 +01:00
Daniel Hofstetter
9167a84358 ls: enable "colors" feature 2023-12-16 17:17:44 +01:00
Sylvestre Ledru
afc6ac8114
Apply change from c32e730a1f 2023-12-16 10:30:47 +01:00
Sylvestre Ledru
6621a1d6d6
Apply the change from c32e730a1f too 2023-12-16 10:30:17 +01:00
Sylvestre Ledru
1bfac9b25a
Merge branch 'main' into openbsd-utmpx 2023-12-16 10:29:16 +01:00
Sylvestre Ledru
f6d3f9afbf ls: manages the COLOR and COLORTERM variables
Should fix GNU tests/ls/color-term.sh
2023-12-16 09:50:37 +01:00
Sylvestre Ledru
01000a37a3 fix two minor clippy warnings 2023-12-16 09:40:38 +01:00
Daniel Hofstetter
f5b228d876
Merge pull request #5651 from tertsdiepraam/remove-parsemode
`mknod`: remove `parsemode.rs`
2023-12-15 16:36:32 +01:00
Daniel Hofstetter
88428cf5d7
Merge pull request #5649 from tertsdiepraam/remove-collect-lossy-and-ignore
all: remove `collect_{lossy,ignore}` calls where possible
2023-12-15 16:30:08 +01:00
Terts Diepraam
30c27c143c mknod: remove parsemode.rs
This file was entirely unused, so it's probably safe to remove it
2023-12-15 15:56:41 +01:00
Terts Diepraam
c32e730a1f all: remove collect_{lossy,ignore} calls where possible 2023-12-15 14:38:27 +01:00
Arpit Bhadauria
3a7a3bf639
fmt: remove crash! macro (#5589)
* fmt: remove crash! macro

* Fix styling in fmt

* Revert "Fix styling in fmt"

This reverts commit 002e02f50c.

* Revert "fmt: remove crash! macro"

This reverts commit d65a3f85a1.

* Replace crash! with unreachable! macro

* Remove crash! import

* Remove unreachable! from fmt

* keep the helpful comment

* Fix lint and format issues

* review fixes
2023-12-15 12:14:31 +01:00
Sylvestre Ledru
f248cc641c
Merge pull request #5614 from Arp-1/feat-refactor-expr
expr: Optimizing for integer values
2023-12-14 18:50:50 +01:00
Terts Diepraam
7f23faf899 expr: clean up conversion from bigint to usize 2023-12-14 16:35:56 +01:00
Daniel Hofstetter
42558344f1 ls: enable "args override self" 2023-12-12 14:23:51 +01:00
Daniel Hofstetter
89cb4acb99 ls: encode path when using --hyperlink 2023-12-12 10:03:55 +01:00