Commit graph

8688 commits

Author SHA1 Message Date
Jeffrey Finkelstein
b89e8e54c4 cp: continue directory walk if file inaccessible
Stop `cp` from terminating prematurely if a file in a directory is
inaccesible due to insufficient permissions.
2022-10-09 17:31:41 -04:00
Jeffrey Finkelstein
2450493302 cp: preserve permissions when copying directory
Make cp preserve the permissions of a directory when copying
it. Before this commit,

    cp -pR src/ dest/

failed to copy the permissions of `src/` to `dest/`. After this
commit, the permissions are correctly copied.
2022-10-09 17:29:29 -04:00
Jeffrey Finkelstein
c370b678b1 cp: refactor copy_attributes() function
Create a `copy_attributes()` function to contain the loop that copies
each of a specified set of attributes in turn.
2022-10-09 17:28:43 -04:00
Jeffrey Finkelstein
2f88ba8628 tests: add AtPath.set_mode() method
Add the `AtPath.set_mode()` method that sets the permissions for a
given path in the test directory.
2022-10-09 17:28:43 -04:00
Jeffrey Finkelstein
fba8d495d2 tests: create assert_metadata_eq!() macro
Create `assert_metadata_eq!()` macro to contain a series of assertions
that check whether two `Metadata` objects are equal.
2022-10-09 17:28:43 -04:00
jfinkels
349320ae61
Merge branch 'main' into cp-symbolic-link-loop 2022-10-09 17:28:30 -04:00
Terts Diepraam
7febaf8b68 GNuComment: clear comment log before appending the messages 2022-10-09 23:03:12 +02:00
Terts Diepraam
8c504edfca
Merge pull request #4016 from tertsdiepraam/ci-post-gnu-comment
GnuComment: convert loaded text into string
2022-10-09 17:16:39 +02:00
Terts Diepraam
562b7e7de8 GnuComment: convert loaded text into string 2022-10-09 17:14:22 +02:00
Sylvestre Ledru
e578502e99
Merge pull request #4015 from tertsdiepraam/ci-post-gnu-comment
CI: run GnuComment also if pipeline fails
2022-10-09 15:20:34 +02:00
Terts Diepraam
f749a129aa ci: upload comparison log regardless of previous result 2022-10-09 12:35:00 +02:00
Terts Diepraam
0f1638545c CI: Fix up JS syntax in GnuComment 2022-10-09 11:23:54 +02:00
Terts Diepraam
4f5407d22b CI: run gnucomment also if pipeline fails 2022-10-09 11:16:57 +02:00
Terts Diepraam
7d8917bb35
Merge pull request #4003 from sylvestre/sync2
sync: various compatibility improvement
2022-10-09 11:07:44 +02:00
Sylvestre Ledru
f41fac3f2b
Merge pull request #3803 from ackerleytng/main
ls: align --ignore behavior with that of GNU ls
2022-10-09 10:55:46 +02:00
Ackerley Tng
d84803b72f ls: align --ignore behavior with that of GNU ls 2022-10-08 16:54:07 -07:00
Sylvestre Ledru
0f98bd01e1
Merge pull request #4010 from tertsdiepraam/ci-post-gnu-comment
CI: post gnu comment
2022-10-08 19:56:21 +02:00
Terts Diepraam
ca820bf674 env: reraise signal from child process 2022-10-08 19:38:00 +02:00
Terts Diepraam
b9ce759a4b gnutests: also store PR number in comment artifact 2022-10-08 17:24:30 +02:00
Terts Diepraam
f5b5dfa1a2 gnutests: save comparison in a comment log 2022-10-08 14:57:09 +02:00
Sylvestre Ledru
d78089ea53
Replace pull_request by pull_request_target
See https://github.com/uutils/coreutils/pull/4006#issuecomment-1272290250
2022-10-08 12:46:12 +02:00
Sylvestre Ledru
b4de65b4d7
Add pull-requests: write for GNU CI 2022-10-08 12:21:26 +02:00
Sylvestre Ledru
97dd4824e5
Merge pull request #3976 from andrewbaptist/implement_suffix_start
Add support for starting suffix numbers
2022-10-07 21:07:07 +02:00
Sylvestre Ledru
f255dcbf6d
Merge pull request #3979 from jfinkels/cp-cow-module
cp: move copy_on_write funcs to platform module
2022-10-07 14:58:45 +02:00
Sylvestre Ledru
a61230828e
Update the GNU CI permissions to allow messages for results 2022-10-06 17:10:18 +02:00
Sylvestre Ledru
97f3dfad54
Merge pull request #3965 from Joining7943/fix-windows-pipe
`tests/tail`: Fix tests to reflect changes from the refactoring #3905
2022-10-06 11:17:25 +02:00
Sylvestre Ledru
88fb43c8e4
Merge branch 'main' into cp-symbolic-link-loop 2022-10-06 09:53:02 +02:00
Sylvestre Ledru
32112d627a
Add fiemap to the spelling 2022-10-06 09:34:48 +02:00
Sylvestre Ledru
6b36a266e4
Merge pull request #3981 from jfinkels/cp-directory-into-itself
cp: correct error message on copying dir to itself
2022-10-06 09:33:41 +02:00
Jeffrey Finkelstein
8bfd96fb59 cp: correct error message on copying dir to itself
Correct the error message produced when attempting to copy a directory
into itself with `cp`. Before this commit, the error message was

    $ cp -R d d
    cp: cannot copy a directory, 'd', into itself, 'd'

After this commit, the error message is

    $ cp -R d d
    cp: cannot copy a directory, 'd', into itself, 'd/d'
2022-10-05 21:37:30 -04:00
Jeffrey Finkelstein
2d0f59c51d cp: move copy_on_write funcs to platform module
Move the copy-on-write functions for `cp` to their own module. This
provides a layer of indirection so that the `cp.rs` module need only
use `platform::copy_on_write()`, and the `platform` module is
responsible for providing the appropriate implementation for the
current platform. This commit does not change the behavior of the
code, just its organization.
2022-10-05 21:35:55 -04:00
Sylvestre Ledru
490aa75553
Merge pull request #4001 from tertsdiepraam/tests-not-via-build-rs
tests: do not generate module structure in `build.rs`
2022-10-05 21:04:43 +02:00
Sylvestre Ledru
ae7c45d27a
Merge pull request #3988 from dmatos2012/add-date-format-ls
ls: add support for +FORMAT in timestyle
2022-10-05 18:41:15 +02:00
Andrew Baptist
49e1cc6c71 Add support for starting suffix numbers
This commit now allows split to pass split/numeric.sh
2022-10-05 09:52:20 -04:00
Pat Laster
493a2628d2
rm: Added descend messages for interactive mode Fixes #3817 (#3931)
Co-authored-by: Terts Diepraam <terts.diepraam@gmail.com>
2022-10-05 13:35:31 +02:00
Joining7943
1725151ef8 tests/tail: Fix tests to reflect changes from the refactoring #3905 2022-10-05 13:32:35 +02:00
Jeffrey Finkelstein
24630db45e cp: allow removing symbolic link loop destination
Allow `cp --remove-destination` to remove a symbolic link loop (or a
symbolic link that initiates a chain of too many symbolic
links). Before this commit, if `loop` were a symbolic link to itself,
then

    cp --remove-destination file loop

would fail with an error message. After this commit, it succeeds. This
matches the behaviotr of GNU cp.
2022-10-05 13:32:21 +02:00
Terts Diepraam
adf4bab03c tests: do not generate module structure in build.rs
Generating the tests to run in build.rs created problems for tooling. For example, cargo fmt, was ignoring the test_*.rs files and needed to be passed these files manually to be formatted. Now we simply use the feature mechanism to decide which tests to run.
2022-10-05 13:30:22 +02:00
Sylvestre Ledru
6edf8ebf41 sync: Verify that the files can be opened 2022-10-05 13:30:19 +02:00
Sylvestre Ledru
fc1c7755b9 sync: make fail like GNU - tests/misc/sync.sh 2022-10-05 13:30:19 +02:00
David Matos
b8a5588b81 ls: add support for +FORMAT in timestyle 2022-10-05 13:29:19 +02:00
Terts Diepraam
e523a56dab
Merge pull request #4005 from sylvestre/disable-expensive-test
Disable test_when_piped_input_then_no_broken_pipe by default
2022-10-04 21:51:59 +02:00
Sylvestre Ledru
858b2a5b99 disable the new tests 2022-10-04 17:24:06 +02:00
Sylvestre Ledru
3cda177d34 Disable test_preference_of_userspec on android 2022-10-04 17:17:01 +02:00
Sylvestre Ledru
8478570c04 Disable test_when_piped_input_then_no_broken_pipe by default
It is blocking the executions of the tests and I suspect it is breaking android
2022-10-04 17:17:01 +02:00
Terts Diepraam
25db814671
Merge pull request #4002 from sylvestre/cmd-test
test: add a bunch of operations
2022-10-04 12:00:00 +02:00
Sylvestre Ledru
45a7e52ed9
Merge pull request #3982 from jfinkels/cp-sparse-copy
cp: make copy_on_write_linux() func more readable
2022-10-03 23:19:01 -10:00
Terts Diepraam
2b495daa16
Merge pull request #3999 from sylvestre/travis
remove an old travis CI script
2022-10-04 10:55:28 +02:00
Sylvestre Ledru
436b7006f2
Merge pull request #3998 from sylvestre/wc-doc
wc: document the long match
2022-10-03 20:37:21 -10:00
Sylvestre Ledru
33de6c89db test: allow parsing of bigger numbers
Fixes: tests/misc/test.pl
2022-10-03 20:25:45 +02:00