Merge pull request #2557 from miDeb/chgrp/no-err

chgrp: don't output an empty error
This commit is contained in:
Sylvestre Ledru 2021-08-13 09:02:54 +02:00 committed by GitHub
commit db7773eddc
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 19 additions and 1 deletions

View file

@ -363,7 +363,9 @@ impl Chgrper {
self.verbosity.clone(),
) {
Ok(n) => {
show_error!("{}", n);
if !n.is_empty() {
show_error!("{}", n);
}
0
}
Err(e) => {

View file

@ -229,6 +229,22 @@ fn test_big_h() {
}
}
#[test]
#[cfg(target_os = "linux")]
fn basic_succeeds() {
let (at, mut ucmd) = at_and_ucmd!();
let one_group = nix::unistd::getgroups().unwrap();
// if there are no groups we can't run this test.
if let Some(group) = one_group.first() {
at.touch("f1");
ucmd.arg(group.as_raw().to_string())
.arg("f1")
.succeeds()
.no_stdout()
.no_stderr();
}
}
#[test]
fn test_no_change() {
let (at, mut ucmd) = at_and_ucmd!();