mirror of
https://github.com/uutils/coreutils
synced 2024-12-14 15:22:38 +00:00
ls -l: show an error when symlink not readable
switching to match and handle the error Will help with tests/ls/stat-failed.sh
This commit is contained in:
parent
97aa8ae5db
commit
37ee889003
2 changed files with 71 additions and 43 deletions
|
@ -2908,55 +2908,64 @@ fn display_file_name(
|
|||
&& path.file_type(out).unwrap().is_symlink()
|
||||
&& !path.must_dereference
|
||||
{
|
||||
if let Ok(target) = path.p_buf.read_link() {
|
||||
name.push_str(" -> ");
|
||||
match path.p_buf.read_link() {
|
||||
Ok(target) => {
|
||||
name.push_str(" -> ");
|
||||
|
||||
// We might as well color the symlink output after the arrow.
|
||||
// This makes extra system calls, but provides important information that
|
||||
// people run `ls -l --color` are very interested in.
|
||||
if let Some(ls_colors) = &config.color {
|
||||
// We get the absolute path to be able to construct PathData with valid Metadata.
|
||||
// This is because relative symlinks will fail to get_metadata.
|
||||
let mut absolute_target = target.clone();
|
||||
if target.is_relative() {
|
||||
if let Some(parent) = path.p_buf.parent() {
|
||||
absolute_target = parent.join(absolute_target);
|
||||
// We might as well color the symlink output after the arrow.
|
||||
// This makes extra system calls, but provides important information that
|
||||
// people run `ls -l --color` are very interested in.
|
||||
if let Some(ls_colors) = &config.color {
|
||||
// We get the absolute path to be able to construct PathData with valid Metadata.
|
||||
// This is because relative symlinks will fail to get_metadata.
|
||||
let mut absolute_target = target.clone();
|
||||
if target.is_relative() {
|
||||
if let Some(parent) = path.p_buf.parent() {
|
||||
absolute_target = parent.join(absolute_target);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
let target_data = PathData::new(absolute_target, None, None, config, false);
|
||||
let target_data = PathData::new(absolute_target, None, None, config, false);
|
||||
|
||||
// If we have a symlink to a valid file, we use the metadata of said file.
|
||||
// Because we use an absolute path, we can assume this is guaranteed to exist.
|
||||
// Otherwise, we use path.md(), which will guarantee we color to the same
|
||||
// color of non-existent symlinks according to style_for_path_with_metadata.
|
||||
if path.md(out).is_none()
|
||||
&& get_metadata(target_data.p_buf.as_path(), target_data.must_dereference)
|
||||
.is_err()
|
||||
{
|
||||
name.push_str(&path.p_buf.read_link().unwrap().to_string_lossy());
|
||||
// If we have a symlink to a valid file, we use the metadata of said file.
|
||||
// Because we use an absolute path, we can assume this is guaranteed to exist.
|
||||
// Otherwise, we use path.md(), which will guarantee we color to the same
|
||||
// color of non-existent symlinks according to style_for_path_with_metadata.
|
||||
if path.md(out).is_none()
|
||||
&& get_metadata(target_data.p_buf.as_path(), target_data.must_dereference)
|
||||
.is_err()
|
||||
{
|
||||
name.push_str(&path.p_buf.read_link().unwrap().to_string_lossy());
|
||||
} else {
|
||||
// Use fn get_metadata instead of md() here and above because ls
|
||||
// should not exit with an err, if we are unable to obtain the target_metadata
|
||||
let target_metadata = match get_metadata(
|
||||
target_data.p_buf.as_path(),
|
||||
target_data.must_dereference,
|
||||
) {
|
||||
Ok(md) => md,
|
||||
Err(_) => path.md(out).unwrap().to_owned(),
|
||||
};
|
||||
|
||||
name.push_str(&color_name(
|
||||
escape_name(target.as_os_str(), &config.quoting_style),
|
||||
&target_data.p_buf,
|
||||
Some(&target_metadata),
|
||||
ls_colors,
|
||||
));
|
||||
}
|
||||
} else {
|
||||
// Use fn get_metadata instead of md() here and above because ls
|
||||
// should not exit with an err, if we are unable to obtain the target_metadata
|
||||
let target_metadata = match get_metadata(
|
||||
target_data.p_buf.as_path(),
|
||||
target_data.must_dereference,
|
||||
) {
|
||||
Ok(md) => md,
|
||||
Err(_) => path.md(out).unwrap().to_owned(),
|
||||
};
|
||||
|
||||
name.push_str(&color_name(
|
||||
escape_name(target.as_os_str(), &config.quoting_style),
|
||||
&target_data.p_buf,
|
||||
Some(&target_metadata),
|
||||
ls_colors,
|
||||
));
|
||||
// If no coloring is required, we just use target as is.
|
||||
// Apply the right quoting
|
||||
name.push_str(&escape_name(target.as_os_str(), &config.quoting_style));
|
||||
}
|
||||
} else {
|
||||
// If no coloring is required, we just use target as is.
|
||||
// Apply the right quoting
|
||||
name.push_str(&escape_name(target.as_os_str(), &config.quoting_style));
|
||||
}
|
||||
Err(err) => {
|
||||
show!(LsError::IOErrorContext(
|
||||
err,
|
||||
path.p_buf.to_path_buf(),
|
||||
false
|
||||
));
|
||||
}
|
||||
}
|
||||
}
|
||||
|
|
|
@ -3503,3 +3503,22 @@ fn test_invalid_utf8() {
|
|||
at.touch(filename);
|
||||
ucmd.succeeds();
|
||||
}
|
||||
|
||||
#[cfg(all(unix, feature = "chmod"))]
|
||||
#[test]
|
||||
fn test_ls_perm_io_errors() {
|
||||
let scene = TestScenario::new(util_name!());
|
||||
let at = &scene.fixtures;
|
||||
at.mkdir("d");
|
||||
at.symlink_file("/", "d/s");
|
||||
|
||||
scene.ccmd("chmod").arg("600").arg("d").succeeds();
|
||||
|
||||
scene
|
||||
.ucmd()
|
||||
.arg("-l")
|
||||
.arg("d")
|
||||
.fails()
|
||||
.code_is(1)
|
||||
.stderr_contains("Permission denied");
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue