3.9 KiB
How to Contribute
Contributions are always welcome! And there is a multitude of ways in which you can help depending on what you like to do, or are good at. Anything from documentation, code cleanup, issue completion, new features, you name it, even filing issues is contributing and greatly appreciated!
Another really great way to help is if you find an interesting, or helpful way in which to use clap_derive
. You can either add it to the examples/ directory, or file an issue and tell me. I'm all about giving credit where credit is due :)
Testing Code
To test with all features both enabled and disabled, you can run these commands:
$ cargo test
Alternatively, if you have just
installed you can run the prebuilt recipes. Not using just
is perfectly fine as well, it simply bundles commands automatically.
For example, to test the code, as above simply run:
$ just run-tests
From here on, I will list the appropriate cargo
command as well as the just
command.
Sometimes it's helpful to only run a subset of the tests, which can be done via:
$ cargo test --test <test_name>
# Or
$ just run-test <test_name>
Linting Code
During the CI process clap_derive
runs against many different lints using clippy
. In order to check if these lints pass on your own computer prior to submitting a PR you'll need a nightly compiler.
In order to check the code for lints run either:
$ cargo +nightly build --features lints
# Or
$ just lint
Commit Messages
I use a conventional changelog format so I can update my changelog automatically using clog
- Please format your commit subject line using the following format:
TYPE(COMPONENT): MESSAGE
whereTYPE
is one of the following:api
- An addition to the APIsetting
- A newAppSettings
variantfeat
- A new feature of an existing APIimp
- An improvement to an existing feature/APIperf
- A performance improvementdocs
- Changes to documentation onlytests
- Changes to the testing framework or tests onlyfix
- A bug fixrefactor
- Code functionality doesn't change, but underlying structure maystyle
- Stylistic changes only, no functionality changeswip
- A work in progress commit (Should typically begit rebase
'ed away)chore
- Catch all or things that have to do with the build system, etcexamples
- Changes to existing example, or a new example
- The
COMPONENT
is optional, and may be a single file, directory, or logical component. Parenthesis can be omitted if you are opting not to use theCOMPONENT
.
Tests and Documentation
- Create tests for your changes
- Ensure the tests are passing. Run the tests (
cargo test
), alternativelyjust run-tests
if you havejust
installed. - Optional Run the lints (
cargo +nightly build --features lints
) (requires a nightly compiler), alternativelyjust lint
- Ensure your changes contain documentation if adding new APIs or features.
Preparing the PR
git rebase
into concise commits and remove--fixup
s orwip
commits (git rebase -i HEAD~NUM
whereNUM
is number of commits back to start the rebase)- Push your changes back to your fork (
git push origin $your-branch
) - Create a pull request against
master
! (You can also create the pull request first, and we'll merge when ready. This a good way to discuss proposed changes.)
Other ways to contribute
Another really great way to help is if you find an interesting, or helpful way in which to use clap_derive
. You can either add it to the examples/ directory, or file an issue and tell me. I'm all about giving credit where credit is due :)