mirror of
https://github.com/clap-rs/clap
synced 2024-11-14 00:27:13 +00:00
50b9e65d39
This addresses a bug that causes duplicate flags reported in user-facing error messages when two flags require one-another but also are required under other conditions. The fix involves removing duplicates in unrolled requirements, which addresses the user-facing aspect of this bug.
89 lines
2.1 KiB
Rust
89 lines
2.1 KiB
Rust
use clap::{App, Arg, ErrorKind};
|
|
|
|
static HELP: &str = "prog
|
|
|
|
USAGE:
|
|
prog [FLAGS]
|
|
|
|
FLAGS:
|
|
-a
|
|
-b
|
|
-c
|
|
-h, --help Print help information
|
|
-V, --version Print version information
|
|
";
|
|
|
|
static ONLY_B_ERROR: &str = "error: The following required arguments were not provided:
|
|
-c
|
|
|
|
USAGE:
|
|
prog [FLAGS] -c -b
|
|
|
|
For more information try --help
|
|
";
|
|
|
|
static ONLY_C_ERROR: &str = "error: The following required arguments were not provided:
|
|
-b
|
|
|
|
USAGE:
|
|
prog [FLAGS] -b -c
|
|
|
|
For more information try --help
|
|
";
|
|
|
|
fn app() -> App<'static> {
|
|
App::new("prog")
|
|
.arg(
|
|
Arg::new("a")
|
|
.short('a')
|
|
.required_unless_present_any(&["b", "c"])
|
|
.conflicts_with_all(&["b", "c"]),
|
|
)
|
|
.arg(
|
|
Arg::new("b")
|
|
.short('b')
|
|
.required_unless_present("a")
|
|
.requires("c"),
|
|
)
|
|
.arg(
|
|
Arg::new("c")
|
|
.short('c')
|
|
.required_unless_present("a")
|
|
.requires("b"),
|
|
)
|
|
}
|
|
|
|
#[test]
|
|
fn valid_cases() {
|
|
let res = app().try_get_matches_from(vec!["", "-a"]);
|
|
assert!(res.is_ok());
|
|
let res = app().clone().try_get_matches_from(vec!["", "-b", "-c"]);
|
|
assert!(res.is_ok());
|
|
let res = app().try_get_matches_from(vec!["", "-c", "-b"]);
|
|
assert!(res.is_ok());
|
|
}
|
|
|
|
#[test]
|
|
fn help_text() {
|
|
let res = app().try_get_matches_from(vec!["prog", "--help"]);
|
|
assert!(res.is_err());
|
|
let err = res.unwrap_err();
|
|
assert_eq!(err.kind, ErrorKind::DisplayHelp);
|
|
println!("{}", err.to_string());
|
|
assert_eq!(err.to_string(), HELP);
|
|
}
|
|
|
|
#[test]
|
|
fn no_duplicate_error() {
|
|
let res = app().try_get_matches_from(vec!["", "-b"]);
|
|
assert!(res.is_err());
|
|
let err = res.unwrap_err();
|
|
assert_eq!(err.kind, ErrorKind::MissingRequiredArgument);
|
|
assert_eq!(err.to_string(), ONLY_B_ERROR);
|
|
|
|
let res = app().try_get_matches_from(vec!["", "-c"]);
|
|
assert!(res.is_err());
|
|
let err = res.unwrap_err();
|
|
assert_eq!(err.kind, ErrorKind::MissingRequiredArgument);
|
|
assert_eq!(err.to_string(), ONLY_C_ERROR);
|
|
}
|