Commit graph

3062 commits

Author SHA1 Message Date
Bence Kalmar
4bf3f97d28 fix(arg_enum!): Invalid expansions of some trailing-comma patterns
In particular, fix macros that take an enum of one of the the following forms:

 - `#[...] enum { ... , }`
 - `pub enum { ... , }`
 - `enum { ... , }`

Previously, these expansions would result in an error message like "error: no
rules expected the token `:`".

Add extensive tests for each pattern.  Only two of the patterns had tests
before, so these errors did not surface automatically.
2020-04-10 09:35:20 +02:00
Ivan Veselov
0f3bdc439e Fix ArgMatcher consuming extra arguments when max_values is set 2020-04-10 09:35:20 +02:00
bors[bot]
f4f5200eff
Merge #1797
1797: debug_assertion validations r=CreepySkeleton a=pksunkara



Co-authored-by: Pavan Kumar Sunkara <pavan.sss1991@gmail.com>
2020-04-10 01:35:44 +00:00
Pavan Kumar Sunkara
15edb69a0d Address review comments 2020-04-10 00:33:16 +02:00
Pavan Kumar Sunkara
f0a216036b Fix some issues 2020-04-09 19:41:33 +02:00
Pavan Kumar Sunkara
92449a4777 Assert arg groups 2020-04-09 16:51:32 +02:00
Pavan Kumar Sunkara
00a0b9660a Assert for require* on args 2020-04-09 16:51:32 +02:00
Pavan Kumar Sunkara
f632aedc72 Started on arg asserts 2020-04-09 16:51:32 +02:00
Pavan Kumar Sunkara
1c16f73c10 Start cleaning up debug_assertion validations 2020-04-09 16:51:32 +02:00
bors[bot]
89a47640c6
Merge #1795
1795: Remove extern crate from README r=pksunkara a=pickfire



Co-authored-by: Ivan Tham <pickfire@riseup.net>
2020-04-08 20:27:32 +00:00
Ivan Tham
54f58e180e Remove extern crate from README 2020-04-08 21:26:32 +08:00
bors[bot]
20daf00d51
Merge #1785
1785: Update the documentation regarding which features are enabled by default r=pksunkara a=stepchowfun



Co-authored-by: Stephan Boyer <stephan.boyer@airbnb.com>
2020-04-05 10:43:12 +00:00
Stephan Boyer
606d120d18 Update the documentation regarding which features are enabled by default 2020-04-04 13:16:30 -07:00
bors[bot]
2dffb93fe6
Merge #1779
1779: Fix value_t documentation r=pksunkara a=AimainaHito



Co-authored-by: AimainaHito <AimainaHito@users.noreply.github.com>
2020-04-04 15:31:24 +00:00
AimainaHito
06b9b32d66 Added full-stop 2020-04-04 11:30:30 +02:00
AimainaHito
f472393b14 Updated value_t documentation 2020-04-03 20:32:36 +02:00
bors[bot]
4b5d7722bf
Merge #1778
1778: set the default disp_ord of App to 999.  r=pksunkara a=pmarks



Co-authored-by: Patrick Marks <pmarks@gmail.com>
2020-04-02 14:16:12 +00:00
Patrick Marks
84214887b9 fix formatting 2020-04-02 06:48:01 -07:00
Patrick Marks
bbdbcbf8e1 add unit tests 2020-04-01 21:35:48 -07:00
bors[bot]
b63c4ea03f
Merge #1774
1774: Moved to github discussions r=CreepySkeleton a=pksunkara



Co-authored-by: Pavan Kumar Sunkara <pavan.sss1991@gmail.com>
2020-04-01 21:45:32 +00:00
Pavan Kumar Sunkara
b77f159315 Moved to github discussions 2020-04-01 22:32:51 +02:00
Patrick Marks
4321cba5ba set the default disp_ord of App to 999. Required for display_order and DeriveDisplay to work properly 2020-04-01 12:49:40 -07:00
bors[bot]
633ce74ba9
Merge #1773
1773: style: fix comma placement for valid values when using arg_enum r=pksunkara a=mmatyas



Co-authored-by: Mátyás Mustoha <matyas.mustoha@gmail.com>
2020-04-01 12:30:31 +00:00
Mátyás Mustoha
8687794986 style: fix comma placement for valid values when using arg_enum 2020-04-01 00:01:51 +02:00
bors[bot]
37889c6611
Merge #1769
1769: Advertise gitter chat r=pksunkara a=CreepySkeleton



Co-authored-by: CreepySkeleton <creepy-skeleton@yandex.ru>
2020-03-28 14:39:57 +00:00
CreepySkeleton
77a8271907
Note abot the closed isues 2020-03-28 10:14:05 +03:00
CreepySkeleton
16ffaea58d Advertise gitter chat 2020-03-27 18:00:47 +03:00
bors[bot]
d8434ec925
Merge #1760
1760: remove redundant imports and clone (found by clippy) r=pksunkara a=matthiaskrgr



Co-authored-by: Matthias Krüger <matthias.krueger@famsik.de>
2020-03-25 13:07:40 +00:00
Matthias Krüger
428a075e41 remove redundant imports and clone (found by clippy) 2020-03-25 13:43:01 +01:00
bors[bot]
7a652054dc
Merge #1758
1758: Update README.md r=CreepySkeleton a=justinwalz



Co-authored-by: Justin Walz <justin.walz10@gmail.com>
2020-03-23 08:08:53 +00:00
Justin Walz
dd14f0da74
Update README.md 2020-03-21 17:24:34 -07:00
bors[bot]
d25c988e35
Merge #1742
1742: Fixed link for Gitter chat r=CreepySkeleton a=humancalico



Co-authored-by: Akshat Agarwal <humancalico@disroot.org>
2020-03-21 23:38:43 +00:00
Akshat Agarwal
848ebb4e44 gitter fix 2020-03-22 02:11:51 +05:30
bors[bot]
6ebc913169
Merge #1754
1754: Select a single docs.rs build target r=pksunkara a=CreepySkeleton



Co-authored-by: CreepySkeleton <creepy-skeleton@yandex.ru>
2020-03-20 08:20:19 +00:00
CreepySkeleton
ee7ee9ba9f Select a single docs.rs build target 2020-03-20 03:02:39 +03:00
bors[bot]
2aa38e81a9
Merge #1739
1739: Remove _some_ of pubs r=pksunkara a=CreepySkeleton



Co-authored-by: CreepySkeleton <creepy-skeleton@yandex.ru>
2020-03-19 23:53:18 +00:00
CreepySkeleton
76689d030f Empty commit 2020-03-19 17:38:16 +03:00
CreepySkeleton
a46ab1639a Turn some integration tests into unit tests 2020-03-19 10:49:49 +03:00
CreepySkeleton
4fc4a00b8f Remove _some_ of pubs 2020-03-19 10:17:52 +03:00
bors[bot]
c2f079cd74
Merge #1753
1753: Fix benchmarks to not use fork anymore r=CreepySkeleton a=pksunkara



Co-authored-by: Pavan Kumar Sunkara <pavan.sss1991@gmail.com>
2020-03-19 03:26:30 +00:00
Pavan Kumar Sunkara
b8e1a1aa77 Fix benchmarks to not use fork anymore 2020-03-18 13:17:31 +01:00
bors[bot]
9c8f9e20b9
Merge #1745
1745: Fix CI r=pksunkara a=CreepySkeleton



Co-authored-by: CreepySkeleton <creepy-skeleton@yandex.ru>
2020-03-13 20:28:29 +00:00
CreepySkeleton
b61a807728 Fix clippy and bump MSRV 2020-03-13 22:41:40 +03:00
CreepySkeleton
1cff11109e Fix CI 2020-03-13 20:51:41 +03:00
bors[bot]
bc738e12c2
Merge #1735
1735: Get rid of extra scopes r=pksunkara a=CreepySkeleton



Co-authored-by: CreepySkeleton <creepy-skeleton@yandex.ru>
2020-03-09 21:03:59 +00:00
CreepySkeleton
3e1f6ed514 Use proper cfg 2020-03-09 23:42:14 +03:00
CreepySkeleton
329bfa9895 Get rid of extra scopes 2020-03-09 21:08:15 +03:00
bors[bot]
23706657fc
Merge #1732
1732: Fixed #1622 r=pksunkara a=sphinxc0re



Co-authored-by: Julian Laubstein <contact@julianlaubstein.de>
2020-03-08 19:52:12 +00:00
Julian Laubstein
c34a0fdae9 Added tests and fixed display of conflicted flags 2020-03-08 17:11:12 +01:00
Julian Laubstein
444bce2471
Fixed #1622 2020-03-08 16:39:14 +01:00