Commit graph

4065 commits

Author SHA1 Message Date
liudingming
963aa1977d Remove ValidArgFound from app settings 2021-08-08 03:41:23 +08:00
liudingming
e851a82080 Move pos_counter before parsing flags.
Then checking if AllowHyphenValues is set when parsing flag is possible.
2021-08-08 03:38:41 +08:00
liudingming
b88d933d96 Extract erroring from parsing.
Rename needs_valueof to parse_result

Use ParseResult more

Less predicting, more fallback

Remove non-sense ParsingResult::NotFound

Merge FlagSubCommand and FlagSubCommandShort

Merge NoMatchingLongArg and NoMatchingShortArg

Better documentation for pos_counter bumping

Denoise of pos_counter

Split ParseState from ParseResult

Remove ParseResult::Flag

small cleanup
2021-08-08 03:38:40 +08:00
liudingming
82d25401a0 Move logic out 2021-08-08 03:34:10 +08:00
liudingming
ca8623c774 Remove duplicate empty value checker 2021-08-08 03:34:10 +08:00
Pavan Kumar Sunkara
10c7228b3f
Merge pull request #2667 from ldm0/tweak1
fmt::write -> push_str
2021-08-07 19:06:40 +01:00
liudingming
d2fec9128f fmt::write -> push_str 2021-08-08 00:25:51 +08:00
Pavan Kumar Sunkara
8b6034e668
Merge pull request #2663 from rami3l/docs-example
docs(example): clarify `stop_parsing_with_--`
2021-08-03 17:32:58 +01:00
rami3l
44ae55fa4e docs(example): clarify stop_parsing_with_-- 2021-08-03 13:41:54 +02:00
Pavan Kumar Sunkara
9e4ea7db17
Merge pull request #2660 from rami3l/fix-clippy
fix(style): eliminate several `clippy` warnings
2021-08-03 03:39:57 +01:00
rami3l
ac12c30352 fix(style): allow bool_assert_comparison in default_missing_value_flag_value 2021-08-02 23:10:51 +02:00
rami3l
d7c984896d fix(style): remove unnecessary usages of 'static and ref 2021-08-02 23:05:21 +02:00
rami3l
adc34a2680 fix(style): eliminate several clippy warnings 2021-08-02 22:31:59 +02:00
Pavan Kumar Sunkara
286fda0b4a
Merge pull request #2653 from patrick-gu/master
Make `multiple_values` `false` with derived `Option<Option<...>>`
2021-08-02 09:19:20 +01:00
patrick-gu
eca8ba6098 Make multiple_values false with Option<Option<...>> 2021-08-01 14:50:31 -07:00
Pavan Kumar Sunkara
4bec66dd03
Merge pull request #2619 from rami3l/flag-literal
fix(parser): Ban long flags with literals
2021-08-01 12:31:29 +01:00
rami3l
d848c88773 fix(test): fix typo in flag_using_long_with_literals 2021-08-01 12:19:00 +02:00
rami3l
97999c2d96 docs(example): remove pseudo-flag example 2021-08-01 11:59:59 +02:00
rami3l
2b3fc4d0b6 test: simplify flag_using_long_with_literals 2021-08-01 11:57:44 +02:00
rami3l
cf94a5bffa docs(example): update pseudo-flag example 2021-08-01 11:49:37 +02:00
rami3l
7f8f5ccc9a Revert "fix(style): fix code format warning"
This reverts commit a4a4d4c307.
2021-08-01 11:41:29 +02:00
Pavan Kumar Sunkara
e649e1b731
Merge pull request #2650 from ldm0/coverage
Use llvm-cov for more accurate coverage report
2021-08-01 09:00:01 +01:00
Pavan Kumar Sunkara
25f6958c16
Merge pull request #2651 from AbyssAbuse/master
Make colorizer respect `AppSettings::ColorAlways` / `ColorChoice::Always`
2021-08-01 08:59:34 +01:00
liudingming
a711fc3cf2 Use llvm-cov for more accurate coverage report 2021-08-01 15:11:27 +08:00
Abyss
faa25f9e67 Make colorizer respect ColorChoice::Always 2021-07-31 18:12:54 -04:00
Pavan Kumar Sunkara
4abf5fefca
Merge pull request #2649 from ldm0/master
Fix `value_of` returns `None` when the first value group is empty
2021-07-31 22:57:22 +01:00
liudingming
ab119b342a Fix value_of returns None when the first value group is empty 2021-08-01 03:56:23 +08:00
patrick-gu
88dec14775
Fix order of arguments in help message with AllowMissingPositional (#2648)
* Fix small formatting error

I accidentally introduced this in #2642

* Fix order of arguments in help message with AllowMissingPositional
2021-07-31 07:39:23 +01:00
Pavan Kumar Sunkara
ff95eb2f5b
Merge pull request #2647 from clap-rs/msrv
Bump msrv to 1.54.0
2021-07-31 05:45:02 +01:00
Pavan Kumar Sunkara
619f4c153c Fix format 2021-07-30 23:01:05 +01:00
Pavan Kumar Sunkara
6994be4f15 Remove doc feature 2021-07-30 22:49:11 +01:00
rami3l
9eaae979e4 docs: fix typo in example 2021-07-30 22:51:55 +02:00
rami3l
38649cc0b5 docs: update example, mentioning the pseudo-flag pattern 2021-07-30 22:44:52 +02:00
rami3l
a4a4d4c307 fix(style): fix code format warning 2021-07-30 22:33:56 +02:00
rami3l
29e3dc2c47 fix(parser): run check_for_help_and_version_str only if no literal is found with flag 2021-07-30 22:33:56 +02:00
rami3l
87479dfb8c fix: ban all uses of literals with flags 2021-07-30 22:33:56 +02:00
rami3l
2d2db652ef fix: fix #1649, take 1 2021-07-30 22:33:56 +02:00
Pavan Kumar Sunkara
75445b974e
Merge pull request #2633 from epage/value_name
fix(derive): Don't mix implicit and explicit `value_name`s
2021-07-30 10:40:33 +01:00
Pavan Kumar Sunkara
0cde7760dd
Merge pull request #2643 from ldm0/master
Fix attached_value abandoned even if it's not used.
2021-07-30 10:37:41 +01:00
Ed Page
52d3942ba6 fix(derive): Reduce compiler error noise
It looks like CI hasn't been running on this and we've introduced some
problems.  It looks like we had an off-by-one error in the check for
MSRV for deciding to run ui tests.
2021-07-30 10:19:21 +01:00
Ed Page
758e5f337f fix(docs): Ensure examples link works from rustdoc 2021-07-30 10:19:21 +01:00
Ed Page
241d183b9c Bump MSRV to 1.54.0
- This makes it so `doc` compiles on stable

Fixes #2618
2021-07-30 10:19:21 +01:00
liudingming
a419f25fdb Fix issue, add tests 2021-07-30 15:39:34 +08:00
liudingming
3791f7e5ad Fix long_arg 2021-07-30 15:39:34 +08:00
liudingming
5ab16f7199 Improve parse_long_arg 2021-07-30 15:39:34 +08:00
liudingming
e8838e1794 fix clippy 2021-07-30 15:39:34 +08:00
liudingming
9509372f12 Improve parse_opt 2021-07-30 15:39:34 +08:00
Pavan Kumar Sunkara
6ea223bc6e
Merge pull request #2644 from ldm0/clippy
Fix clippy
2021-07-30 08:38:34 +01:00
Pavan Kumar Sunkara
ebc28c096f
Merge pull request #2642 from patrick-gu/master
Replace "Prints" with "Print" for default help and version commands
2021-07-30 08:35:49 +01:00
liudingming
44b7eee404 Fix clippy 2021-07-30 13:36:38 +08:00