Ed Page
d001952ac4
refactor(usage): Clarify required gathering
2022-07-29 19:23:29 -05:00
Ed Page
e2a6bbfa95
refactor(parser): Simplify calculation for more values
2022-07-29 15:04:03 -05:00
Ed Page
39e5a86391
fix: Update positional for new num_vals
2022-07-29 15:02:08 -05:00
Ed Page
b47464955c
refactor: Switch to getter for number_of_values
2022-07-29 14:51:02 -05:00
Ed Page
edc7ac359f
Merge pull request #4003 from epage/count
...
fix(help): Show when a flag 'ArgAction::Count's
2022-07-29 10:13:53 -05:00
Ed Page
7b8da03014
Merge pull request #4002 from epage/usage
...
fix(help): Remove '...' for optional values
2022-07-29 09:58:04 -05:00
Ed Page
81bc351cfc
fix(help): Show when a flag 'ArgAction::Count's
2022-07-29 09:56:26 -05:00
Ed Page
7cf25008d5
refactor(test): Put expected values by tests
2022-07-29 09:51:28 -05:00
Ed Page
ac32c831fc
fix(help): Remove '...' for optional values
2022-07-29 09:44:29 -05:00
Ed Page
ddef1cbf10
Merge pull request #4001 from epage/num_vals
...
fix!: Simplify min_values/max_values into number_of_values (per occurrence)
2022-07-29 07:04:20 -05:00
Ed Page
eee31e2e31
docs: Provide best practice by example
2022-07-28 21:50:32 -05:00
Ed Page
30f5b11d06
fix!: Replaced min_values
(tota) with number_of_values
(per occurrence)
2022-07-28 21:40:40 -05:00
Ed Page
ccf35ff70c
fix!: Replace min_values
(total) with number_of_values
(per occurrence)
2022-07-28 17:13:41 -05:00
Ed Page
cf8e1fc319
fix(derive): Make Option<Option<T>>
work per occurrence
2022-07-28 16:52:30 -05:00
Ed Page
ab8ef46663
fix: arg!(--long [value]) to per occurrence values
...
Before we did 0..=1 across all occurrences when what we really wanted
was 0..=1 per occurrence. This makes it compatible with
`ArgAction::Append`.
2022-07-28 16:52:30 -05:00
Ed Page
41535d5c46
feat: Extend number_of_values
to support min/max per occurrence
2022-07-28 16:52:25 -05:00
Ed Page
b4dfdcea15
fix!: Change number_of_values to be per occurrence
2022-07-28 16:52:16 -05:00
Ed Page
ae803e1410
test: Port macro/derive test to builder
...
Making sure we cover the expected experience from multiple perspectives
2022-07-28 16:52:06 -05:00
Ed Page
4f756c483f
fix(derive): Make consistent with arg!
...
This has the downside of a regression in `--help`. We expect to fix
that soon-ish.
2022-07-28 16:52:06 -05:00
Ed Page
5444b60361
test: Verify max_values cases for 0 values
2022-07-28 16:51:41 -05:00
Ed Page
630a4894b3
fix(error): Ensure empty possible values isn't shown
2022-07-28 16:48:47 -05:00
Ed Page
81faa8b34b
Merge pull request #4000 from epage/missing
...
fix(parser): Rely on default_missing_value for flag actions
2022-07-28 15:56:05 -05:00
Ed Page
8e20782bfd
fix(parser): Rely on default_missing_value
for flag actions
...
In the short term, this just provides a back door to custom actions.
Longer term, we can explore a `SetConst` action that relies on this
behavior. Really, `SetTrue` and `SetFalse` are shortcuts for such an
action but shortcuts can be helpful for usability.
Apparently, this also reduced `.text` size by 1k
2022-07-28 15:43:08 -05:00
Ed Page
f76a867e3f
fix: Simplify flag parsing
...
Multiple values can only happen from env variables when configured by
the user, so let's not go out of our way to deal with it.
2022-07-28 15:31:40 -05:00
Ed Page
4887695aca
Merge pull request #3999 from epage/usage
...
fix: Misc clean up in prep for #2688
2022-07-28 15:25:45 -05:00
Ed Page
8aa960c984
style: Make clippy happy
2022-07-28 15:11:28 -05:00
Ed Page
c2f5d8d7b7
perf: Reduce amount of code for rendering args
...
Rendering of usage is not in a critical path, so should be more worried
about binary size than performance. That only leaves avoiding coloring
spaces. That shouldn't be a problem, so let's make the binary smaller.
2022-07-28 14:56:33 -05:00
Ed Page
a7a96e02fa
refactor(help): Simplify rendering of arg values
2022-07-28 14:46:19 -05:00
Ed Page
355a8ff90c
fix!: number_of_values
doesn't always imply multiple_values(true)
...
With `number_of_values` being per-occurrence now, its doesn't make sense
for `number_of_values(0)` to set `takes_value(true)` or for
`number_of_values(1)` to set `multiple_values(true)`.
In addition, an assert is made if the user works around this
2022-07-28 14:40:58 -05:00
Ed Page
2be2924f91
test(help): Veriy rendering of min_values
2022-07-28 13:33:42 -05:00
Ed Page
ef9d582464
refactor(test): Consolidate number_of_values tests
2022-07-28 13:28:39 -05:00
Ed Page
15d7f51e88
test(macros): Port optional-value test from derive to arg
2022-07-28 13:27:28 -05:00
Ed Page
5eedb03e45
fix(help): Mark positionals as optional
2022-07-28 13:12:26 -05:00
Ed Page
43aa695ad7
refactor: Abstract access to min_vals
2022-07-28 13:12:18 -05:00
Ed Page
6e9250d4ab
chore: Remove dead test file
2022-07-28 12:17:22 -05:00
Ed Page
11883b6fbc
fix: Remove unused schema
2022-07-28 12:11:35 -05:00
Ed Page
586b49a43c
Merge pull request #3998 from epage/missing
...
fix(parser)!: Apply default_missing_value per occurrence
2022-07-27 20:58:56 -05:00
Ed Page
67adc4acf9
fix(parser)!: Apply default_missing_value per occurrence
...
This both simplifies the code and the model we present to the user,
making more sense.
There is room for further exploration of tying flag actions into this.
2022-07-27 20:23:58 -05:00
Ed Page
ee06707c90
Merge pull request #3992 from epage/action
...
docs: Shift focus from takes_value to actions
2022-07-26 15:45:18 -05:00
Ed Page
5f20fe1930
docs: Shift focus from takes_value to actions
2022-07-26 14:50:51 -05:00
Ed Page
8e9c4c6c64
fix: Be explicit on help/version action
2022-07-26 09:34:23 -05:00
Ed Page
55f2bb6979
Merge pull request #3991 from epage/warn
...
chore: Fix warnings
2022-07-25 14:58:54 -05:00
Ed Page
62c75a001b
Merge pull request #3990 from epage/external
...
fix!: Use value parsers for external subcommands
2022-07-25 14:46:27 -05:00
Ed Page
095d7db33e
chore: Fix warnings
2022-07-25 14:35:23 -05:00
Ed Page
8ea1e2d4d3
fix!: Use value parsers for external subcommands
...
This changes the default type as well to encourage preserving the full
information for shelling out. If people need UTF-8, then they can
change the value parser.
Fixes #3733
2022-07-25 14:31:56 -05:00
Ed Page
2d469511f9
Merge pull request #3989 from epage/dupe
...
fix(assert)!: Prevent repeated subcommand names
2022-07-25 14:18:10 -05:00
Ed Page
475a0fc0a2
fix!: Remove PartialEq from Command
...
This gives us more implementation flexibility
2022-07-25 13:52:13 -05:00
Ed Page
13e672fb90
fix(assert)!: Prevent repeated subcommand names
...
Fixes #3888
2022-07-25 13:46:18 -05:00
Ed Page
3610a14e9e
Merge pull request #3988 from epage/occur
...
fix!: Remove multiple occurrences in favor of Append/Count
2022-07-25 13:45:47 -05:00
Ed Page
76c47f66e2
chore: Allow releasing from release branches
2022-07-25 13:31:25 -05:00