Ed Page
b654130b14
docs: Update changelog
2022-09-30 14:08:49 -05:00
Ed Page
2ea94555f1
Merge pull request #4310 from epage/skip
...
fix(derive): Support 'group' attribute with Parser
2022-09-30 14:05:47 -05:00
Ed Page
5f145a23e9
fix(derive): Support 'group' attribute with Parser
2022-09-30 13:44:10 -05:00
Ed Page
106d8f5e90
Merge pull request #4309 from epage/docs
...
docs: Fix a few items
2022-09-30 13:41:35 -05:00
Ed Page
16e5599b71
docs: Note that author doesn't show up by default
2022-09-30 13:27:46 -05:00
Ed Page
49186a5930
docs: Note the move in ErrorKind
...
This was supposed to be captured by a deprecation but
- We missed the deprecation on that line
- I think I've run into issues with deprecations not applying to `use`
2022-09-30 13:24:46 -05:00
Ed Page
4eb3da20f7
docs(help): Include example with old template
2022-09-30 13:21:13 -05:00
Ed Page
db31881be5
docs: Remove references to global settings
...
These were copied over from the original `AppSettings` and never updated
despite never being relevant in this context.
2022-09-30 13:17:46 -05:00
Ed Page
973f30fb22
refactor(docs): Use intra-doc links to avoid breakages
2022-09-30 13:16:13 -05:00
Ed Page
e53447835c
docs: Fix link to crate_authors macro
2022-09-30 13:15:58 -05:00
Ed Page
6328c14c0c
Merge pull request #4307 from epage/assert
...
feat(assert): Help people know about implicit ArgGroups
2022-09-30 13:09:13 -05:00
Ed Page
e9c7ee4f5f
docs: Add missing short help entry to changelog
2022-09-30 13:08:10 -05:00
Ed Page
1065d6c36b
feat(assert): Help people know about implicit ArgGroups
2022-09-30 12:56:43 -05:00
Ed Page
59562f0b97
Merge pull request #4305 from epage/id
...
feat(derive): Report the group id
2022-09-30 12:43:57 -05:00
Ed Page
c16fdbedc1
docs: Clarify term_width requires wrap_help
2022-09-30 12:30:14 -05:00
Ed Page
42122787d7
feat(derive): Report the group id
...
This will be needed when we support flattening for #3165
2022-09-30 12:24:21 -05:00
Ed Page
1877e31c21
Merge pull request #4303 from epage/group
...
feat(derive): Implicitly populate groups from some structs
2022-09-30 12:17:18 -05:00
Ed Page
8f8558a32d
Merge pull request #4302 from epage/group4
...
fix(error): Improve errors when groups are involved
2022-09-30 11:42:50 -05:00
Ed Page
50ad905b6a
feat(derive): Implicitly populate groups from some structs
...
This implements the basics for #3165 , just missing
- `flatten` support (waiting on improved group support)
- `group` attributes
2022-09-30 11:42:06 -05:00
Ed Page
5017f0d720
fxi(error): Don't report unrelated groups in requries errors
2022-09-30 11:18:47 -05:00
Ed Page
e1b02a11cc
test: Demonstrate bad requires error
2022-09-30 11:02:44 -05:00
Ed Page
cb04c71105
fix(error): Don't report unrelated groups in conflict errors
...
Ideally, a conflict caused by a group itself would show the relevant
group but that is less important than showing a valid, non-garbage,
usage
2022-09-30 10:38:27 -05:00
Ed Page
76b7579341
test: Demonstrate bad group error
2022-09-30 10:00:24 -05:00
Ed Page
993b0a88d7
test: Expand group test
2022-09-30 09:53:09 -05:00
Ed Page
470140f41e
chore: Release
2022-09-30 09:31:51 -05:00
Ed Page
2780a875f0
docs: Update changelog
2022-09-30 09:31:38 -05:00
Ed Page
9ed78ae793
Merge pull request #4301 from epage/group4
...
feat(derive): Allow skipping the implicit ArgGroup
2022-09-30 09:30:45 -05:00
Ed Page
2498147138
feat(derive): Allow skipping the implicit ArgGroup
...
This was prioritized to allow users to workaround problems when the
implicit `ArgGroup` is getting in the way.
Fixes #4279
2022-09-30 09:15:38 -05:00
Ed Page
35eeba0b63
test(derive): Show failure in #4279
2022-09-30 09:05:48 -05:00
Ed Page
6ca0569baa
fix(derive): Pipe group attribute through
...
Still doesn't support any attributes within it yet.
2022-09-30 08:56:35 -05:00
Ed Page
72469e7e54
Merge pull request #4298 from shellcodesniper/patch-1
...
doc(fix typo): no close bracket in example
2022-09-30 08:23:37 -05:00
Ed Page
2912a6436f
chore: Release
2022-09-30 08:16:12 -05:00
Ed Page
b814c785ef
docs(derive): Correct reference
2022-09-30 08:15:48 -05:00
KuuWang
71be5463e5
doc(fix typo): no close bracket in example
...
Tutorials (derive, builder > Tutorials (derive, builder)
2022-09-30 17:43:23 +09:00
Ed Page
5885cc7f0c
Merge pull request #4294 from epage/req
...
feat: Add ArgGroup::is_required_set
2022-09-29 16:49:13 -05:00
Ed Page
8fc8b5f273
feat: Add ArgGroup::is_required_set
...
This is a part of #4228
I thought I needed this for another change but it turned out I didn't.
2022-09-29 16:29:08 -05:00
Ed Page
eeafb2574b
docs(complete): Don't use deprecated API
2022-09-29 16:11:03 -05:00
Ed Page
1e2b791049
Merge pull request #4292 from epage/func
...
refactor: Use getters internally
2022-09-29 15:50:51 -05:00
Ed Page
4634812e3d
refactor: Use getters internally
...
This originally stemmed from wrapping `Arg` in a `Box`, but we had to
smash it with a hammer as it didn't improve things enough.
- This dropped binary size by 3-7 KiB
- Parsing slowed by 20%.
- Incremental rebuilds slowed down by 1%
2022-09-29 15:26:24 -05:00
Ed Page
84055f41e4
docs: Provide more nuance on allow_hyphen_values
...
This matches what we hope is the right behavior, see #4283
2022-09-29 14:41:39 -05:00
Ed Page
668c021419
chore: Release
2022-09-29 13:09:30 -05:00
Ed Page
9069755919
docs: Update changelog
2022-09-29 13:09:14 -05:00
Ed Page
d24e723bb4
Merge pull request #4255 from anshulrgoyal/master
...
[clap_mangen]fix: use proper sub-command name in manpages
2022-09-29 13:07:18 -05:00
Anshul Goyal
47790e62bf
chore: Remove .vscode folder
2022-09-29 23:15:05 +05:30
Anshul Goyal
cdcf9aad34
fix: Add test for subcommand
2022-09-29 23:07:28 +05:30
Ed Page
80fb67edaa
chore: Release
2022-09-29 12:08:47 -05:00
Ed Page
83db04c0c3
docs: Update changelog
2022-09-29 12:08:40 -05:00
Ed Page
cdaa8a18a5
Merge pull request #4289 from martinvonz/generate-subcommand-alias
...
Generate subcommand alias
2022-09-29 12:07:25 -05:00
Martin von Zweigbergk
33fa7c4c19
fix(complete): Fix command alias and Bash
...
With the previous fixes for #4273 and #4280 in place, it's now easy to
add support for subcommand aliases, which this commit does. This
addresses #4265 for Bash.
2022-09-29 08:58:32 -07:00
Martin von Zweigbergk
9ee45f7f3d
fix(complete): Fix git diff log <TAB>
for Bash
...
This continues the work started with the fix for #4273 . There was
another bug caused by using the subcommand names without considering
their position in the argument list. If the user enters `git diff log
<TAB>`, we build up a string that identifies the subcommand. We ended
up making the string `git__diff__log` in this case because we appended
`__log` without considering the current state. Since `git__diff__log`
does not correspond to an actual command, we wouldn't provide any
suggestions.
This commit restructures the code so we walk subcommands and
subsubcommands in `bash.rs`. While walking those, we build up a list
containing triples of the parent `$cmd` name (e.g. `git__diff`), the
current command's name (e.g. `log`), and the `$cmd` for the current
command. We then build the shell script's case arms based on that
information.
We could instead have fixed #4280 by using the second element in the
pair returned from `utils::all_subcommands()` (a stringified list of
the subcommand path) instead of the first one. However, that would not
have helped us solve #4265 .
Closes #4280
2022-09-29 08:58:32 -07:00