Mirrors/clap
2
0
Fork 0
mirror of https://github.com/clap-rs/clap synced 2024-12-14 14:52:33 +00:00
Code Issues Projects Releases Packages Wiki Activity
7645 commits 13 branches 549 tags 31 MiB
Commit graph

209 commits

Author SHA1 Message Date
Ed Page
36afe99bfa fix(help): Skip [OPTIONS] if help/version action 
Our code for detecting when to skip this in the usage was never updated
for actions.
 2023-07-17 10:40:42 -05:00
Ed Page
22b545b98b feat(help): Explicit control over short/long help 
Fixes #4687
 2023-07-17 10:37:26 -05:00
Ed Page
c2191674b0 chore: Release 2023-07-17 10:26:48 -05:00
Ed Page
bc000aa4b0 fix(help): Defaulting max_term_width instead of max_term_width 
Fixes #4295
 2023-07-17 09:40:49 -05:00
Ed Page
d741e9519c docs(builder): Correct max_term_width docs 2023-07-17 09:25:21 -05:00
Ed Page
f8d86dc165 refactor(help): Break term width calculation out 2023-07-17 09:17:52 -05:00
Ed Page
fcda411e5e chore: Release 2023-07-14 12:01:56 -05:00
Ed Page
6541df2c4b docs: Note user-values subject to value_delimiter 
Inspired by #4999
 2023-07-07 09:07:55 -05:00
Ed Page
cafdf58e02 chore: Release 2023-07-05 10:33:25 -05:00
Ed Page
99bcdfc6c7 style(builder): Be consistent in order 2023-07-05 10:10:34 -05:00
Ed Page
a50e32c135 feat(derive): Accept Boxed Str/OsStr/Path 2023-07-05 10:03:52 -05:00
Ed Page
916c8d93e1 feat(derive): Accept num::Wrapping wrapped types 2023-07-05 09:55:31 -05:00
Ed Page
f043f57559 feat(derive): Accept Box/Arc wrapped types 2023-07-05 09:53:41 -05:00
Ed Page
7353b2be34 chore: Release 2023-06-29 20:45:17 -05:00
Ed Page
27431a43a1 refactor(builder): Remove bitflags dependency 
This saved 1.3 KiB

When color support is enabled, this likely won't save on build times
*until* `is-terminal` is removed.  At that point, `bitflags` will no
longer be in our dependency tree.

I did not (yet) reproduce the `Debug` impl.
 2023-06-29 20:24:34 -05:00
Ed Page
6bfd7852ac chore: Update bitflags 
Fixes #4861
 2023-06-29 19:46:59 -05:00
Ed Page
18f0ad4676 chore: Release 2023-06-28 08:39:55 -05:00
Sebastian Toh
8103e9760a fix(ignore_errors): Allow help and version command 2023-06-28 08:58:40 +08:00
Ed Page
1f71fd9e99 chore: Release 2023-06-23 16:36:03 -05:00
Ed Page
8596fe6523
Merge pull request #4971 from SUPERCILEX/long-arg-inference 
fix: Broken long arg inference on conflicts
 2023-06-23 16:34:19 -05:00
Ed Page
cf7f3a7ba0 chore: Release 2023-06-20 11:15:10 -05:00
Pavan Kumar Sunkara
cfd1d22e26 Improve colorchoice enum 2023-06-20 08:55:04 +01:00
Ed Page
3ad2bf6061 docs(builder): Describe current sort semantics 
I must have been moving too fast with 6e1e754 as it changed the wrong
part of the text when really the whole thing needed an overhaul.

So this correctly fixed #4728
 2023-06-19 09:33:27 -05:00
Alex Saveau
f9994bff47
fix: Broken long arg inference on conflicts 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
 2023-06-17 13:30:05 -07:00
Ed Page
dcccf61099 chore: Release 2023-06-14 08:55:02 -05:00
Sebastian Pipping
36329896e7 feat: Extract/add public method Error.exit_code 
Simplifies method Error.exit as a side effect.
 2023-06-14 01:39:59 +02:00
Ed Page
a87fba2bb6 chore: Release 2023-06-09 09:34:30 -05:00
Ed Page
d10938dd33 feat: Allow deferred initialization of subcommands 
This is mostly targeted at reducing startup time for no-op commands
within *very* large applications, like deno (see #4774).

This comes at the cost of 1.1 KiB of binary size
 2023-06-09 08:29:38 -05:00
Ed Page
5661b6b508 style: Remove unused mut 2023-06-05 12:49:26 -05:00
Ed Page
50f0e6bffb chore: Release 2023-06-01 21:10:46 -05:00
renovate[bot]
534be345d8
chore(deps): update compatible (dev) 2023-06-01 00:38:25 +00:00
Ed Page
9c3dc187cb chore: Release 2023-05-19 11:55:42 -05:00
Ed Page
5047bb40bd chore: Release 2023-05-19 11:48:29 -05:00
Ed Page
e1db168d69 fix(parser): Ensure terminated positionals are assigned correctly 2023-05-19 10:41:44 -05:00
Ed Page
1ee2e95e96 fix(builder): Allow value terminated multiple positional values 2023-05-19 10:39:05 -05:00
Ed Page
c3fe7ff0a9 fix(help): Don't use next-line-help on long-help for subcommands 
Subcommands don't switch their behavior on `--help`, so let's not switch
to next-line-help based on `--help`.

Fixes #4897
 2023-05-12 10:41:05 +02:00
Ed Page
21d911db10 style: Make clippy happy 2023-05-19 09:10:20 -05:00
Ed Page
8edf8c7676
Merge pull request #4922 from epage/docs 
docs(builder): Remove stale docs references (set is default)
 2023-05-19 09:02:18 -05:00
Ed Page
ac5d893091 docs(builder): Remove stale docs references (set is default) 2023-05-18 13:11:14 -05:00
Wim Looman
c41f4beaaa
fix(docs): Add note about Command::disable_help_subcommand applying to children 2023-05-18 14:11:22 +02:00
Ed Page
1d42caa0b6
Merge pull request #4912 from epage/assert 
fix(assert): Clarify last assertion
 2023-05-17 17:10:08 -05:00
Ed Page
67cc5ea3a2 fix(assert): Clarify last assertion 
An incremental improvement for #4911.
 2023-05-17 16:33:36 -05:00
Daniel Hofstetter
3458adc6ae fix: Typo in value_parser.rs 2023-05-15 15:35:25 +02:00
Yuri Astrakhan
d0302c5556 chore: Inline simple non-mixed format args 2023-05-04 15:58:04 -04:00
Ed Page
ba9cad6ca2
Merge pull request #4885 from epage/possible 
refactor(help): Clean up long possible value handling
 2023-05-03 21:17:45 -05:00
Ed Page
5fb1b25799
Merge pull request #4883 from nyurik/happy-clippy 
chore: Make Clippy happy
 2023-05-03 21:13:47 -05:00
Yuri Astrakhan
ebbdce4820 chore: Make Clippy happy 2023-05-03 21:56:07 -04:00
Yuri Astrakhan
797c23c415 chore: Inline format args using clippy fix 
This command cleaned up all the format args,
making code significantly shorter and more readable.

```
cargo clippy --workspace --fix -- -A clippy::all -W clippy::uninlined_format_args
```
 2023-05-03 21:49:11 -04:00
Ed Page
1351c56289 fix(help): Consistently calculate PV name length 2023-05-03 20:15:31 -05:00
Ed Page
3963d73e18 perf(help): Remove next-help possible values 
Next-line help for possible values does not feel like its pulling its
weight.  If anything we should do next-line help for the entire
argument.

This dropped about 0.5 KiB but more importantly is prep for other
changes.
 2023-05-03 20:09:36 -05:00
Ed Page
ec52b74d68 refactor(help): Better call out long-pv policy 2023-05-03 19:48:48 -05:00
Ed Page
9227ab1c7c refactor(help): Be consistent in join style 2023-05-03 19:25:44 -05:00
Yuri Astrakhan
d810235d07 chore: Minor code dedup for writing possible vals 
* writing possible values and subcommands used nearly identical code
* writing elements used duplicate code once for items and once for last item
 2023-05-03 18:40:44 -04:00
Ed Page
baaf5c64c1 chore: Release 2023-05-02 14:07:29 -05:00
Ed Page
937f1ed9c9 fix(parser): Update iterator sizes as we go 
Maybe it was just me, but I didn't realize that the length had to be
updated as we went but it can cause panics with a bad message.

Fixes #4870
 2023-05-02 13:53:42 -05:00
Ed Page
a7214540f6 chore: Release 2023-05-02 13:24:34 -05:00
Dillon Shaffer
37507741c4
impl Eq<std::any::TypeId> for clap_builder::util::AnyValueId 2023-05-01 08:40:00 -06:00
Ed Page
fa57ed3123 chore: Release 2023-04-27 04:29:47 -05:00
Ed Page
9eaf8996a4
Merge pull request #4867 from epage/panic 
fix(builder): Assert earlier on bad requires/conflicts
 2023-04-27 18:57:19 -05:00
Ed Page
185729a7dc fix(builder): Assert earlier on bad requires/conflicts 
Fixes #4865
 2023-04-27 04:16:14 -05:00
Ed Page
e02644b9c2 fix(usage): Provide more context in panic 2023-04-27 04:12:22 -05:00
mattmadeofpasta
296fec9186
test(help): Remove redundant test 2023-04-27 09:04:35 +00:00
Clement Tsang
89bf732353
docs: Update mut_arg docs on help + version flags 2023-04-20 22:18:27 -04:00
Ed Page
950a495753 fix(help): Preserve block indent when wrapping 2023-04-19 11:55:53 -05:00
Ed Page
4f0666d437 refactor(help): Clarify word splitter 2023-04-19 11:37:03 -05:00
Ed Page
60c8c3fc31 chore: Release 2023-04-19 11:11:47 -05:00
Ed Page
1ca073f212 docs(help): Fill in styles docs 2023-04-19 11:00:00 -05:00
Ed Page
6d5aaae5a9 feat(help): Allow access to current Styles 2023-04-19 10:57:00 -05:00
Ed Page
b99c50f7e9 chore: Release 2023-04-18 15:52:35 -05:00
Ed Page
cbea23e3fc style: Make clippy happy 2023-04-18 15:36:02 -05:00
Ed Page
5ca3b2fc5f refactor(help): Shrink binary size 2023-04-18 15:28:20 -05:00
Ed Page
ec7040e8ba style: Make clippy happy 2023-04-18 15:22:42 -05:00
Ed Page
57974bed7b refactor(help): Future proof styling 
We can add a new style and default it to what it was split out of
without a breaking change.
 2023-04-18 15:22:42 -05:00
Ed Page
e10e2ad249 refactor(help): Split out separate usage style 
Because this doesn't have a full section after it, people might want to
style it differently than other headers.
 2023-04-18 15:22:42 -05:00
Ed Page
8fd0a93bdc refactor(help): Clarify style meaning 2023-04-18 15:22:42 -05:00
Ed Page
7cf08e63cd refactor(help): Remove unused hint 2023-04-18 15:22:42 -05:00
Ed Page
015f88b21a feat(help): Allow customizing terminal styling 
For now, this is behind the `unstable-styles` feature as we verify this
is what we want for #3224
 2023-04-18 15:22:42 -05:00
Ed Page
3cb90b0b22 refactor(help): Use a stylesheet 2023-04-18 15:22:42 -05:00
Ed Page
72515d14b1 refactor(help): Style in the caller 
Random fixes along the way
- In one case the space after `tip:` was "colored" (won't matter until
  themeing is available)
- One error case didn't color invalid values
- Changed the args associated with invalid values to be `literal` rather
  than `warning`
- Changed the required value count to be `good`
- Changed the arg for invalid value counts to be `literal` (the actual
  count is `warning`)
 2023-04-18 15:22:42 -05:00
Ed Page
9416f3a347 refactor(help): Use anstyle in the caller 2023-04-18 15:22:42 -05:00
Ed Page
ab61cd6aaf refactor(help): Push color knowledge out a layer 2023-04-18 15:22:42 -05:00
Ed Page
c8f5afe9b5 refactor: Make anstyle always available 2023-04-18 15:22:42 -05:00
Ed Page
690ae13f57 refactor: Track term widths as plugins 2023-04-13 02:23:18 -05:00
Ed Page
1924f45289 refactor: Design plugin system 2023-04-13 01:18:44 -05:00
Ed Page
fe70ddcb20 refactor(builder): Move Any out of parser 2023-04-13 00:28:00 -05:00
Ed Page
6f409544ec chore: Release 2023-04-12 21:41:50 -05:00
Ed Page
9c85e1b295 chore: Update anstyle/anstream 2023-04-12 21:25:42 -05:00
Ed Page
feddd124b0 style: Move away from banned fns 2023-03-30 02:18:00 -05:00
Lorenzo
13d79b7677
Fix typo 2023-04-02 20:01:51 +09:00
Ed Page
3ef784b516 chore: Release 2023-03-28 13:30:03 -05:00
Ed Page
58615a1306 fix(error): Don't highlight 'similar' 2023-03-28 10:00:30 -05:00
Ed Page
8fc65e28b6 chore: Release 2023-03-28 02:19:08 -05:00
Ed Page
56fe5e0ec0 fix!: Remove unstable-replace feature flag 
This has been implemented for 3 years without much traction for
finishing it up.

The subcommand use case can be worked around by creating `Command`s that
just include the relevant logic, very similar to the default subcommand
examples in `git` / `git-derive`.

Using this for flags is covered by #4793.

Without `unstable-replace` being enabled, this still cut 5 KiB from
`cargo bloat --release --example git`.

Closes #2836
Closes #2011
 2023-03-28 00:26:45 -05:00
Ed Page
d5089b2672 fix!: Remove stablized unstable-grouped feature 2023-03-28 00:22:40 -05:00
Ed Page
fa60e723fc fix(error): Give more idea why we are suggesting an arg 
One challenge with this is finding something that generally works.
Making this work perfectly for one setting will make it inconsistent
with other settings and take up more binary size / compile time.

So in the end, I felt like just mirroring rustc (with a bit more
brevity) seemed like a decent experiment.  This will be evaluated by the
feedback on release.

This is a small part of #4638
 2023-03-27 20:45:27 -05:00
Ed Page
234d5f91d1 fix(error): Change from neutral 'note' to helpful 'tip' 
This also has the advantage of aligning with `error:`

This is a small part of #4638
 2023-03-27 20:45:11 -05:00
Ed Page
b6432c8ead docs(help): Show how to style text 
Fixes #3108
Fixes #1433
 2023-03-27 19:47:16 -05:00
Ed Page
5ebcb4c3bf feat(builder): Allow write! on StyledStr 2023-03-27 19:46:23 -05:00
Ed Page
f19e33eb27 perf(help): Reduce binary size 2023-03-27 19:46:22 -05:00
Ed Page
9516fd928f refactor(version): Directly convert rendered to styled 2023-03-27 19:45:41 -05:00
Ed Page
6255229a9c refactor: Remove extra layer of AnsiDisplay 2023-03-27 19:45:41 -05:00
Ed Page
1773884715 refactor(help): Simplify writing 2023-03-27 19:45:41 -05:00
Ed Page
bdbfe6470f refactor(help): Track style via ANSI codes 2023-03-27 19:45:41 -05:00
Ed Page
1040114162 feat(help): Respect CLICOLOR, CLICOLOR_FORCE 
We might have respected `NO_COLOR` before via `termcolor`.

See #4722
 2023-03-27 19:45:39 -05:00
Ed Page
2852653656 chore: Release 2023-03-27 19:41:39 -05:00
Ed Page
2bb4146374 chore: Release 2023-03-25 03:56:28 -05:00
Ed Page
ea4dada1e4 fix(lex): Allow reporting errors for non-UTF8 longs 2023-03-25 03:42:04 -05:00
Ed Page
6419a0d937 perf!(lex): Build faster by removing os_str_bytes 
We are doing direct transmutes between `OsStr` and `[u8]`.
https://github.com/rust-lang/rust/pull/95290 would make this natively
supported but I got tired of waitin for it.

This only saves about 1/4s off of `cargo build`.

This took 2.9 KiB off of `cargo bloat --release --example git`
 2023-03-25 01:59:24 -05:00
Ed Page
4e1a565b8a refactor: Split out clap_builder for faster derive builds 
For now, we are still treating `clap` as the user facing API for both
builder and derive, making this an internal change as we don't expect
this to negatively impact builder build times all that much.  We can
re-evaluate at a later time and consider having distinct top-level
crates for builder and derive.

Looking at `--timings` on my machine
- `clap` only took 0.04s to build and it happened in
  parallel to `clap_builder` codegen
- this saved 1.7s for derive build times, with `clap_builder` building
  in parallel to `syn` and `clap_builder` and `clap_derive` finishing
  around the same time.

This was discussed some at https://rust-lang.zulipchat.com/#narrow/stream/220302-wg-cli/topic/clap.20build.20times.20and.20.60clap_derive.60.3A.20a.20crazy.20idea
 2023-03-24 21:50:02 -05:00