From bfc8e8d367c0d711b7e99ce90bbe8ad92940816f Mon Sep 17 00:00:00 2001 From: Jan Verbeek Date: Tue, 1 Feb 2022 01:14:44 +0100 Subject: [PATCH] perf: Do not instantiate Id::from(&&str) Saves 0.3K. --- src/build/arg/mod.rs | 2 +- src/build/arg_group.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/build/arg/mod.rs b/src/build/arg/mod.rs index 75e326be..fcd664b3 100644 --- a/src/build/arg/mod.rs +++ b/src/build/arg/mod.rs @@ -4335,7 +4335,7 @@ impl<'help> Arg<'help> { /// [`Arg::exclusive(true)`]: Arg::exclusive() #[must_use] pub fn conflicts_with_all(mut self, names: &[&str]) -> Self { - self.blacklist.extend(names.iter().map(Id::from)); + self.blacklist.extend(names.iter().copied().map(Id::from)); self } diff --git a/src/build/arg_group.rs b/src/build/arg_group.rs index 2824e2b9..e2335a99 100644 --- a/src/build/arg_group.rs +++ b/src/build/arg_group.rs @@ -124,7 +124,7 @@ impl<'help> ArgGroup<'help> { #[must_use] pub fn name>(mut self, n: S) -> Self { self.name = n.into(); - self.id = Id::from(&self.name); + self.id = Id::from(self.name); self }