From 4f13f3155ca39b0fc22db4dea1de34ed25d15d98 Mon Sep 17 00:00:00 2001 From: CreepySkeleton Date: Fri, 21 Feb 2020 01:55:19 +0300 Subject: [PATCH] Fix warnings on nightly --- clap_generate/src/lib.rs | 4 +--- src/build/app/mod.rs | 2 +- src/parse/parser.rs | 4 ++-- src/parse/validator.rs | 2 +- 4 files changed, 5 insertions(+), 7 deletions(-) diff --git a/clap_generate/src/lib.rs b/clap_generate/src/lib.rs index dfa625bf..3f532404 100644 --- a/clap_generate/src/lib.rs +++ b/clap_generate/src/lib.rs @@ -127,13 +127,11 @@ where S: Into, T: Into, { - use std::error::Error; - let out_dir = PathBuf::from(out_dir.into()); let file_name = G::file_name(app.get_bin_name().unwrap()); let mut file = match File::create(out_dir.join(file_name)) { - Err(why) => panic!("couldn't create completion file: {}", why.description()), + Err(why) => panic!("couldn't create completion file: {}", why), Ok(file) => file, }; diff --git a/src/build/app/mod.rs b/src/build/app/mod.rs index dc835e5d..23db0613 100644 --- a/src/build/app/mod.rs +++ b/src/build/app/mod.rs @@ -1465,7 +1465,7 @@ impl<'b> App<'b> { } #[cfg(not(debug_assertions))] - fn _panic_on_missing_help(app: &App, help_required_globally: bool) {} + fn _panic_on_missing_help(_app: &App, _help_required_globally: bool) {} #[cfg(debug_assertions)] fn _panic_on_missing_help(app: &App, help_required_globally: bool) { diff --git a/src/parse/parser.rs b/src/parse/parser.rs index df786802..8c323678 100644 --- a/src/parse/parser.rs +++ b/src/parse/parser.rs @@ -830,11 +830,11 @@ where let arg_allows_tac = match needs_val_of { ParseResult::Opt(name) => { let o = self.app.find(name).expect(INTERNAL_ERROR_MSG); - (o.is_set(ArgSettings::AllowHyphenValues) || app_wide_settings) + o.is_set(ArgSettings::AllowHyphenValues) || app_wide_settings } ParseResult::Pos(name) => { let p = self.app.find(name).expect(INTERNAL_ERROR_MSG); - (p.is_set(ArgSettings::AllowHyphenValues) || app_wide_settings) + p.is_set(ArgSettings::AllowHyphenValues) || app_wide_settings } ParseResult::ValuesDone => return true, _ => false, diff --git a/src/parse/validator.rs b/src/parse/validator.rs index d0ab44ac..5fd61d78 100644 --- a/src/parse/validator.rs +++ b/src/parse/validator.rs @@ -427,7 +427,7 @@ impl<'b, 'c, 'z> Validator<'b, 'c, 'z> { a, num, if a.is_set(ArgSettings::MultipleValues) { - (ma.vals.len() % num as usize) + ma.vals.len() % num as usize } else { ma.vals.len() },