Mirrors/clap
2
0
Fork 0
mirror of https://github.com/clap-rs/clap synced 2024-12-14 06:42:33 +00:00
Code Issues Projects Releases Packages Wiki Activity

starting path using several small methods, looks promising

Browse source
This commit is contained in:
Will Murphy 2017-10-14 10:15:40 -04:00
parent aafcf88354
commit 97e978e7b0
2 changed files with 11 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/app/mod.rs
View file

@ -16,6 +16,7 @@ use std::path::Path;
use std::process;
use std::rc::Rc;
use std::result::Result as StdResult;
use std::collections::HashMap;
// Third Party
#[cfg(feature = "yaml")]
@ -1620,14 +1621,13 @@ impl<'a, 'b> App<'a, 'b> {
}
if self.p.is_set(AppSettings::PropagateGlobalValuesDown) {
// hypothesis: self.p.global_args only has the arg I care about
// if it was passed early
for a in &self.p.global_args {
// DOES propagate(a.b.name) propagate the value?
// what globals are available here?
debugln!("grepforme the arg was {}", a.b.name);
matcher.propagate(a.b.name);
}
// TODO: get a list of all the argument names, create a vector
// from it, and passing that to propagate.
let mut global_arg_vec : Vec<&str> = (&self).p.global_args.iter().map(|ga| ga.b.name).collect();
let mut global_arg_to_value_map = HashMap::new();
matcher.get_global_values(&global_arg_vec, &mut global_arg_to_value_map);
matcher.recursive_populate_global_arg_vec(&mut global_arg_vec);
//matcher.propagate_globals(global_arg_vec);
}
Ok(matcher.into())

6
src/app/parser.rs
View file

@ -1073,9 +1073,9 @@ impl<'a, 'b> Parser<'a, 'b>
});
}
// FIXME: this makes the globals exist more than once
if self.settings.is_set(AS::PropagateGlobalValuesDown) {
self.propogate_globals();
}
// if self.settings.is_set(AS::PropagateGlobalValuesDown) {
// self.propogate_globals();
// }
Validator::new(self).validate(needs_val_of, subcmd_name, matcher)
}