Mirrors/clap
2
0
Fork 0
mirror of https://github.com/clap-rs/clap synced 2024-12-14 23:02:31 +00:00
Code Issues Projects Releases Packages Wiki Activity

fix: Provide context for panics

Browse source 
One of the challenges with #2255 is for the user to discover whats going
wrong.  This helps by at least telling people how they got into a bad
state and we can search for the code within the derive.
This commit is contained in:
Ed Page 2021-07-21 16:53:01 -05:00
parent 8ff68080e6
commit 8087811136
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
clap_derive/src/derives/args.rs
View file

@ -361,7 +361,7 @@ pub fn gen_constructor(fields: &Punctuated<Field, Comma>, parent_attribute: &Att
}; };
let unwrapper = match **ty { let unwrapper = match **ty {
Ty::Option => quote!(), Ty::Option => quote!(),
_ => quote_spanned!( ty.span()=> .unwrap() ), _ => quote_spanned!( ty.span()=> .expect("app should verify subcommand is required") ),
}; };
quote_spanned! { kind.span()=> quote_spanned! { kind.span()=>
#field_name: { #field_name: {
@ -594,7 +594,7 @@ fn gen_parsers(
quote_spanned! { ty.span()=> quote_spanned! { ty.span()=>
#arg_matches.#value_of(#name) #arg_matches.#value_of(#name)
.map(#parse) .map(#parse)
.unwrap() .expect("app should verify arg is required")
} }
} }
}; };
@ -615,6 +615,6 @@ fn gen_arg_enum_parse(ty: &Type, attrs: &Attrs) -> TokenStream {
let ci = attrs.case_insensitive(); let ci = attrs.case_insensitive();
quote_spanned! { ty.span()=> quote_spanned! { ty.span()=>
|s| <#ty as clap::ArgEnum>::from_str(s, #ci).unwrap() |s| <#ty as clap::ArgEnum>::from_str(s, #ci).expect("app should verify the choice was valid")
} }
} }