Mirrors/clap
2
0
Fork 0
mirror of https://github.com/clap-rs/clap synced 2024-12-13 06:12:40 +00:00
Code Issues Projects Releases Packages Wiki Activity

perf(derive): Reduce the amount of generated code

Browse source 
Its a small win, dropping the number of copies and reducing the
overhead from `quote` but enough of these could make a difference
This commit is contained in:
Ed Page 2023-03-18 14:51:13 -05:00
parent 240e237b5f
commit 7e7a45ac19
1 changed files with 9 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
clap_derive/src/item.rs
View file

@ -277,6 +277,10 @@ impl Item {
}
fn push_method(&mut self, kind: AttrKind, name: Ident, arg: impl ToTokens) {
self.push_method_(kind, name, arg.to_token_stream());
}
fn push_method_(&mut self, kind: AttrKind, name: Ident, arg: TokenStream) {
if name == "id" {
match kind {
AttrKind::Command | AttrKind::Value => {
@ -293,7 +297,7 @@ impl Item {
}
AttrKind::Group | AttrKind::Arg | AttrKind::Clap | AttrKind::StructOpt => {}
}
self.name = Name::Assigned(quote!(#arg));
self.name = Name::Assigned(arg);
} else if name == "name" {
match kind {
AttrKind::Arg => {
@ -315,16 +319,16 @@ impl Item {
| AttrKind::Clap
| AttrKind::StructOpt => {}
}
self.name = Name::Assigned(quote!(#arg));
self.name = Name::Assigned(arg);
} else if name == "value_parser" {
self.value_parser = Some(ValueParser::Explicit(Method::new(name, quote!(#arg))));
self.value_parser = Some(ValueParser::Explicit(Method::new(name, arg)));
} else if name == "action" {
self.action = Some(Action::Explicit(Method::new(name, quote!(#arg))));
self.action = Some(Action::Explicit(Method::new(name, arg)));
} else {
if name == "short" || name == "long" {
self.is_positional = false;
}
self.methods.push(Method::new(name, quote!(#arg)));
self.methods.push(Method::new(name, arg));
}
}