Mirrors/clap
2
0
Fork 0
mirror of https://github.com/clap-rs/clap synced 2024-12-13 14:22:34 +00:00
Code Issues Projects Releases Packages Wiki Activity

perf(derive): Reuse allocations for external subcommands

Browse source 
In case the `ArgMatches` is cloned, this forces a constraint that the
underlying type impls `Clone` but that should be safe as we only support
`String` and `OsString`.
This commit is contained in:
Ed Page 2022-05-20 12:02:29 -05:00
parent d61552a8b8
commit 0628d04174
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
clap_derive/src/derives/subcommand.rs
View file

@ -527,9 +527,10 @@ fn gen_from_arg_matches(
::std::iter::once(#str_ty::from(#subcommand_name_var))
.chain(
#sub_arg_matches_var
.get_many::<#str_ty>("")
.remove_many::<#str_ty>("")
.expect("unexpected type")
.into_iter().flatten() // `""` isn't present, bug in `unstable-v4`
.map(|f| ::std::sync::Arc::try_unwrap(f).unwrap_or_else(|arc| (*arc).clone()))
.map(#str_ty::from)
)
.collect::<::std::vec::Vec<_>>()