Mirrors/bottom
2
0
Fork 0
mirror of https://github.com/ClementTsang/bottom synced 2024-11-23 20:53:07 +00:00
Code Issues Projects Releases Packages Wiki Activity
bottom/docs/content/contribution/issues-and-pull-requests.md
Clement Tsang f41e7cd66d
ci: unify cache keys in actions (#890) 
* ci: unify cache keys in actions

* some docs

* because empty strings are false in JS

* update comment

* fix build cache naming
2022-11-11 23:45:27 -05:00

1.9 KiB
Raw Blame History

Issues, Pull Requests, and Discussions

Discussions

Discussions are open in the repo. As for the difference between discussions and issues:

  • Open an issue if what you have enough information to properly fill out any details needed for a report or request.
  • Open a discussion otherwise (e.g. asking a question).

Opening an issue

Bug reports

When filing a bug report, please use the bug report template and fill in as much as you can. It is incredibly difficult for a maintainer to fix a bug when it cannot be reproduced, and giving as much detail as possible generally helps to make it easier to reproduce the problem!

Feature requests

Please use the feature request template and fill it out. Remember to give details about what the feature is along with why you think this suggestion will be useful.

Also please check whether or not an existing issue has covered your specific feature request!

Pull requests

The expected workflow for a pull request is:

  1. Fork the project.
  2. Make your changes.
  3. Make any documentation changes if necessary - if you add a new feature, it'll probably need documentation changes. See here for tips on documentation.
  4. Commit and create a pull request to merge into the master branch. Please follow the pull request template.
  5. Ask/wait for a maintainer to review your pull request.
    • Check if the CI workflow passes. These consist of clippy lints, rustfmt checks, and basic tests.
    • If changes are suggested or any comments are made, they should probably be addressed.
  6. Once it looks good, it'll be merged! Note that generally, PRs are squashed, though feel free to ask otherwise if that isn't preferable.