Mirrors/bottom
2
0
Fork 0
mirror of https://github.com/ClementTsang/bottom synced 2025-02-16 13:18:28 +00:00
Code Issues Projects Releases Packages Wiki Activity

some notes

Browse source
This commit is contained in:
ClementTsang 2024-09-22 02:11:24 -04:00
parent 2ba435f22e
commit 30bb37bf5d
No known key found for this signature in database
GPG key ID: DC3B7867D8D97095
4 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/data_collection/disks/unix/macos/counters.rs
View file

@ -6,7 +6,7 @@ use crate::data_collection::disks::IoCounters;
fn get_device_io(device: io_kit::IoObject) -> anyhow::Result<IoCounters> { fn get_device_io(device: io_kit::IoObject) -> anyhow::Result<IoCounters> {
let parent = device.service_parent()?; let parent = device.service_parent()?;
// XXX: Re: Conform check being disabled. // NB: Regarding the conform check being disabled.
// //
// Okay, so this is weird. // Okay, so this is weird.
// //

1
src/new_data_collection/sources/sysinfo/disk.rs
View file

@ -0,0 +1 @@

2
src/new_data_collection/sources/sysinfo/mod.rs
View file

@ -1,4 +1,4 @@
pub mod temperature;
pub mod cpu; pub mod cpu;
pub mod disk; pub mod disk;
pub mod memory; pub mod memory;
pub mod temperature;

2
src/utils/logging.rs
View file

@ -18,7 +18,7 @@ pub fn init_logger(
// logging at all in a debug context which is generally fine, // logging at all in a debug context which is generally fine,
// release builds should have this logging disabled entirely for now. // release builds should have this logging disabled entirely for now.
unsafe { unsafe {
// XXX: If we ever DO add general logging as a release feature, evaluate this // NB: If we ever DO add general logging as a release feature, evaluate this
// again and whether this is something we want enabled in // again and whether this is something we want enabled in
// release builds! What might be safe is falling back to the non-set-soundness // release builds! What might be safe is falling back to the non-set-soundness
// mode when specifically using certain feature flags (e.g. dev-logging feature // mode when specifically using certain feature flags (e.g. dev-logging feature