mirror of
https://github.com/bevyengine/bevy
synced 2024-11-14 00:47:32 +00:00
01aedc8431
# Objective Now that we can consolidate Bundles and Components under a single insert (thanks to #2975 and #6039), almost 100% of world spawns now look like `world.spawn().insert((Some, Tuple, Here))`. Spawning an entity without any components is an extremely uncommon pattern, so it makes sense to give spawn the "first class" ergonomic api. This consolidated api should be made consistent across all spawn apis (such as World and Commands). ## Solution All `spawn` apis (`World::spawn`, `Commands:;spawn`, `ChildBuilder::spawn`, and `WorldChildBuilder::spawn`) now accept a bundle as input: ```rust // before: commands .spawn() .insert((A, B, C)); world .spawn() .insert((A, B, C); // after commands.spawn((A, B, C)); world.spawn((A, B, C)); ``` All existing instances of `spawn_bundle` have been deprecated in favor of the new `spawn` api. A new `spawn_empty` has been added, replacing the old `spawn` api. By allowing `world.spawn(some_bundle)` to replace `world.spawn().insert(some_bundle)`, this opened the door to removing the initial entity allocation in the "empty" archetype / table done in `spawn()` (and subsequent move to the actual archetype in `.insert(some_bundle)`). This improves spawn performance by over 10%:  To take this measurement, I added a new `world_spawn` benchmark. Unfortunately, optimizing `Commands::spawn` is slightly less trivial, as Commands expose the Entity id of spawned entities prior to actually spawning. Doing the optimization would (naively) require assurances that the `spawn(some_bundle)` command is applied before all other commands involving the entity (which would not necessarily be true, if memory serves). Optimizing `Commands::spawn` this way does feel possible, but it will require careful thought (and maybe some additional checks), which deserves its own PR. For now, it has the same performance characteristics of the current `Commands::spawn_bundle` on main. **Note that 99% of this PR is simple renames and refactors. The only code that needs careful scrutiny is the new `World::spawn()` impl, which is relatively straightforward, but it has some new unsafe code (which re-uses battle tested BundlerSpawner code path).** --- ## Changelog - All `spawn` apis (`World::spawn`, `Commands:;spawn`, `ChildBuilder::spawn`, and `WorldChildBuilder::spawn`) now accept a bundle as input - All instances of `spawn_bundle` have been deprecated in favor of the new `spawn` api - World and Commands now have `spawn_empty()`, which is equivalent to the old `spawn()` behavior. ## Migration Guide ```rust // Old (0.8): commands .spawn() .insert_bundle((A, B, C)); // New (0.9) commands.spawn((A, B, C)); // Old (0.8): commands.spawn_bundle((A, B, C)); // New (0.9) commands.spawn((A, B, C)); // Old (0.8): let entity = commands.spawn().id(); // New (0.9) let entity = commands.spawn_empty().id(); // Old (0.8) let entity = world.spawn().id(); // New (0.9) let entity = world.spawn_empty(); ```
113 lines
3.3 KiB
Rust
113 lines
3.3 KiB
Rust
use bevy::{
|
|
diagnostic::{FrameTimeDiagnosticsPlugin, LogDiagnosticsPlugin},
|
|
prelude::*,
|
|
window::PresentMode,
|
|
};
|
|
|
|
// For a total of 110 * 110 = 12100 buttons with text
|
|
const ROW_COLUMN_COUNT: usize = 110;
|
|
const FONT_SIZE: f32 = 7.0;
|
|
|
|
/// This example shows what happens when there is a lot of buttons on screen.
|
|
fn main() {
|
|
App::new()
|
|
.insert_resource(WindowDescriptor {
|
|
present_mode: PresentMode::Immediate,
|
|
..default()
|
|
})
|
|
.add_plugins(DefaultPlugins)
|
|
.add_plugin(FrameTimeDiagnosticsPlugin::default())
|
|
.add_plugin(LogDiagnosticsPlugin::default())
|
|
.init_resource::<UiFont>()
|
|
.add_startup_system(setup)
|
|
.add_system(button_system)
|
|
.run();
|
|
}
|
|
|
|
#[derive(Component)]
|
|
struct IdleColor(UiColor);
|
|
|
|
fn button_system(
|
|
mut interaction_query: Query<(&Interaction, &mut UiColor, &IdleColor), Changed<Interaction>>,
|
|
) {
|
|
for (interaction, mut material, IdleColor(idle_color)) in interaction_query.iter_mut() {
|
|
if matches!(interaction, Interaction::Hovered) {
|
|
*material = Color::ORANGE_RED.into();
|
|
} else {
|
|
*material = *idle_color;
|
|
}
|
|
}
|
|
}
|
|
|
|
#[derive(Resource)]
|
|
struct UiFont(Handle<Font>);
|
|
|
|
impl FromWorld for UiFont {
|
|
fn from_world(world: &mut World) -> Self {
|
|
let asset_server = world.get_resource::<AssetServer>().unwrap();
|
|
UiFont(asset_server.load("fonts/FiraSans-Bold.ttf"))
|
|
}
|
|
}
|
|
|
|
fn setup(mut commands: Commands, font: Res<UiFont>) {
|
|
let count = ROW_COLUMN_COUNT;
|
|
let count_f = count as f32;
|
|
let as_rainbow = |i: usize| Color::hsl((i as f32 / count_f) * 360.0, 0.9, 0.8);
|
|
commands.spawn(Camera2dBundle::default());
|
|
commands
|
|
.spawn(NodeBundle {
|
|
style: Style {
|
|
size: Size::new(Val::Percent(100.0), Val::Percent(100.0)),
|
|
..default()
|
|
},
|
|
..default()
|
|
})
|
|
.with_children(|commands| {
|
|
for i in 0..count {
|
|
for j in 0..count {
|
|
let color = as_rainbow(j % i.max(1)).into();
|
|
spawn_button(commands, font.0.clone_weak(), color, count_f, i, j);
|
|
}
|
|
}
|
|
});
|
|
}
|
|
fn spawn_button(
|
|
commands: &mut ChildBuilder,
|
|
font: Handle<Font>,
|
|
color: UiColor,
|
|
total: f32,
|
|
i: usize,
|
|
j: usize,
|
|
) {
|
|
let width = 90.0 / total;
|
|
commands
|
|
.spawn((
|
|
ButtonBundle {
|
|
style: Style {
|
|
size: Size::new(Val::Percent(width), Val::Percent(width)),
|
|
|
|
position: UiRect {
|
|
bottom: Val::Percent(100.0 / total * i as f32),
|
|
left: Val::Percent(100.0 / total * j as f32),
|
|
..default()
|
|
},
|
|
align_items: AlignItems::Center,
|
|
position_type: PositionType::Absolute,
|
|
..default()
|
|
},
|
|
color,
|
|
..default()
|
|
},
|
|
IdleColor(color),
|
|
))
|
|
.with_children(|commands| {
|
|
commands.spawn(TextBundle::from_section(
|
|
format!("{i}, {j}"),
|
|
TextStyle {
|
|
font,
|
|
font_size: FONT_SIZE,
|
|
color: Color::rgb(0.2, 0.2, 0.2),
|
|
},
|
|
));
|
|
});
|
|
}
|