mirror of
https://github.com/bevyengine/bevy
synced 2025-01-04 09:18:54 +00:00
d8974e7c3d
What is says on the tin. This has got more to do with making `clippy` slightly more *quiet* than it does with changing anything that might greatly impact readability or performance. that said, deriving `Default` for a couple of structs is a nice easy win
295 lines
8.8 KiB
Rust
295 lines
8.8 KiB
Rust
use crate::storage::SparseSetIndex;
|
|
use fixedbitset::FixedBitSet;
|
|
use std::marker::PhantomData;
|
|
|
|
/// `Access` keeps track of read and write accesses to values within a collection.
|
|
///
|
|
/// This is used for ensuring systems are executed soundly.
|
|
#[derive(Debug, Eq, PartialEq, Clone)]
|
|
pub struct Access<T: SparseSetIndex> {
|
|
reads_all: bool,
|
|
/// A combined set of T read and write accesses.
|
|
reads_and_writes: FixedBitSet,
|
|
writes: FixedBitSet,
|
|
marker: PhantomData<T>,
|
|
}
|
|
|
|
impl<T: SparseSetIndex> Default for Access<T> {
|
|
fn default() -> Self {
|
|
Self {
|
|
reads_all: false,
|
|
reads_and_writes: Default::default(),
|
|
writes: Default::default(),
|
|
marker: PhantomData,
|
|
}
|
|
}
|
|
}
|
|
|
|
impl<T: SparseSetIndex> Access<T> {
|
|
pub fn grow(&mut self, bits: usize) {
|
|
self.reads_and_writes.grow(bits);
|
|
self.writes.grow(bits);
|
|
}
|
|
|
|
/// Adds a read access for the given index.
|
|
pub fn add_read(&mut self, index: T) {
|
|
self.reads_and_writes.grow(index.sparse_set_index() + 1);
|
|
self.reads_and_writes.insert(index.sparse_set_index());
|
|
}
|
|
|
|
/// Adds a write access for the given index.
|
|
pub fn add_write(&mut self, index: T) {
|
|
self.reads_and_writes.grow(index.sparse_set_index() + 1);
|
|
self.writes.grow(index.sparse_set_index() + 1);
|
|
self.reads_and_writes.insert(index.sparse_set_index());
|
|
self.writes.insert(index.sparse_set_index());
|
|
}
|
|
|
|
/// Returns true if this `Access` contains a read access for the given index.
|
|
pub fn has_read(&self, index: T) -> bool {
|
|
if self.reads_all {
|
|
true
|
|
} else {
|
|
self.reads_and_writes.contains(index.sparse_set_index())
|
|
}
|
|
}
|
|
|
|
/// Returns true if this `Access` contains a write access for the given index.
|
|
pub fn has_write(&self, index: T) -> bool {
|
|
self.writes.contains(index.sparse_set_index())
|
|
}
|
|
|
|
/// Sets this `Access` to having read access for all indices.
|
|
pub fn read_all(&mut self) {
|
|
self.reads_all = true;
|
|
}
|
|
|
|
/// Returns true if this `Access` has read access to all indices.
|
|
pub fn reads_all(&self) -> bool {
|
|
self.reads_all
|
|
}
|
|
|
|
/// Clears all recorded accesses.
|
|
pub fn clear(&mut self) {
|
|
self.reads_all = false;
|
|
self.reads_and_writes.clear();
|
|
self.writes.clear();
|
|
}
|
|
|
|
/// Extends this `Access` with another, copying all accesses of `other` into this.
|
|
pub fn extend(&mut self, other: &Access<T>) {
|
|
self.reads_all = self.reads_all || other.reads_all;
|
|
self.reads_and_writes.union_with(&other.reads_and_writes);
|
|
self.writes.union_with(&other.writes);
|
|
}
|
|
|
|
/// Returns true if this `Access` is compatible with `other`.
|
|
///
|
|
/// Two `Access` instances are incompatible with each other if one `Access` has a write for
|
|
/// which the other also has a write or a read.
|
|
pub fn is_compatible(&self, other: &Access<T>) -> bool {
|
|
if self.reads_all {
|
|
0 == other.writes.count_ones(..)
|
|
} else if other.reads_all {
|
|
0 == self.writes.count_ones(..)
|
|
} else {
|
|
self.writes.is_disjoint(&other.reads_and_writes)
|
|
&& self.reads_and_writes.is_disjoint(&other.writes)
|
|
}
|
|
}
|
|
|
|
/// Calculates conflicting accesses between this `Access` and `other`.
|
|
pub fn get_conflicts(&self, other: &Access<T>) -> Vec<T> {
|
|
let mut conflicts = FixedBitSet::default();
|
|
if self.reads_all {
|
|
conflicts.extend(other.writes.ones());
|
|
}
|
|
|
|
if other.reads_all {
|
|
conflicts.extend(self.writes.ones());
|
|
}
|
|
conflicts.extend(self.writes.intersection(&other.reads_and_writes));
|
|
conflicts.extend(self.reads_and_writes.intersection(&other.writes));
|
|
conflicts
|
|
.ones()
|
|
.map(SparseSetIndex::get_sparse_set_index)
|
|
.collect()
|
|
}
|
|
|
|
/// Returns all read accesses.
|
|
pub fn reads(&self) -> impl Iterator<Item = T> + '_ {
|
|
self.reads_and_writes
|
|
.difference(&self.writes)
|
|
.map(T::get_sparse_set_index)
|
|
}
|
|
|
|
/// Returns all write accesses.
|
|
pub fn writes(&self) -> impl Iterator<Item = T> + '_ {
|
|
self.writes.ones().map(T::get_sparse_set_index)
|
|
}
|
|
}
|
|
|
|
#[derive(Clone, Eq, PartialEq)]
|
|
pub struct FilteredAccess<T: SparseSetIndex> {
|
|
access: Access<T>,
|
|
with: FixedBitSet,
|
|
without: FixedBitSet,
|
|
}
|
|
|
|
impl<T: SparseSetIndex> Default for FilteredAccess<T> {
|
|
fn default() -> Self {
|
|
Self {
|
|
access: Access::default(),
|
|
with: Default::default(),
|
|
without: Default::default(),
|
|
}
|
|
}
|
|
}
|
|
|
|
impl<T: SparseSetIndex> FilteredAccess<T> {
|
|
#[inline]
|
|
pub fn access(&self) -> &Access<T> {
|
|
&self.access
|
|
}
|
|
|
|
pub fn add_read(&mut self, index: T) {
|
|
self.access.add_read(index.clone());
|
|
self.add_with(index);
|
|
}
|
|
|
|
pub fn add_write(&mut self, index: T) {
|
|
self.access.add_write(index.clone());
|
|
self.add_with(index);
|
|
}
|
|
|
|
pub fn add_with(&mut self, index: T) {
|
|
self.with.grow(index.sparse_set_index() + 1);
|
|
self.with.insert(index.sparse_set_index());
|
|
}
|
|
|
|
pub fn add_without(&mut self, index: T) {
|
|
self.without.grow(index.sparse_set_index() + 1);
|
|
self.without.insert(index.sparse_set_index());
|
|
}
|
|
|
|
pub fn is_compatible(&self, other: &FilteredAccess<T>) -> bool {
|
|
if self.access.is_compatible(&other.access) {
|
|
true
|
|
} else {
|
|
self.with.intersection(&other.without).next().is_some()
|
|
|| self.without.intersection(&other.with).next().is_some()
|
|
}
|
|
}
|
|
|
|
pub fn extend(&mut self, access: &FilteredAccess<T>) {
|
|
self.access.extend(&access.access);
|
|
self.with.union_with(&access.with);
|
|
self.without.union_with(&access.without);
|
|
}
|
|
|
|
pub fn read_all(&mut self) {
|
|
self.access.read_all();
|
|
}
|
|
}
|
|
|
|
pub struct FilteredAccessSet<T: SparseSetIndex> {
|
|
combined_access: Access<T>,
|
|
filtered_accesses: Vec<FilteredAccess<T>>,
|
|
}
|
|
|
|
impl<T: SparseSetIndex> FilteredAccessSet<T> {
|
|
#[inline]
|
|
pub fn combined_access(&self) -> &Access<T> {
|
|
&self.combined_access
|
|
}
|
|
|
|
#[inline]
|
|
pub fn combined_access_mut(&mut self) -> &mut Access<T> {
|
|
&mut self.combined_access
|
|
}
|
|
|
|
pub fn get_conflicts(&self, filtered_access: &FilteredAccess<T>) -> Vec<T> {
|
|
// if combined unfiltered access is incompatible, check each filtered access for
|
|
// compatibility
|
|
if !filtered_access.access.is_compatible(&self.combined_access) {
|
|
for current_filtered_access in &self.filtered_accesses {
|
|
if !current_filtered_access.is_compatible(filtered_access) {
|
|
return current_filtered_access
|
|
.access
|
|
.get_conflicts(&filtered_access.access);
|
|
}
|
|
}
|
|
}
|
|
Vec::new()
|
|
}
|
|
|
|
pub fn add(&mut self, filtered_access: FilteredAccess<T>) {
|
|
self.combined_access.extend(&filtered_access.access);
|
|
self.filtered_accesses.push(filtered_access);
|
|
}
|
|
}
|
|
|
|
impl<T: SparseSetIndex> Default for FilteredAccessSet<T> {
|
|
fn default() -> Self {
|
|
Self {
|
|
combined_access: Default::default(),
|
|
filtered_accesses: Vec::new(),
|
|
}
|
|
}
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod tests {
|
|
use crate::query::{Access, FilteredAccess};
|
|
|
|
#[test]
|
|
fn access_get_conflicts() {
|
|
let mut access_a = Access::<usize>::default();
|
|
access_a.add_read(0);
|
|
access_a.add_read(1);
|
|
|
|
let mut access_b = Access::<usize>::default();
|
|
access_b.add_read(0);
|
|
access_b.add_write(1);
|
|
|
|
assert_eq!(access_a.get_conflicts(&access_b), vec![1]);
|
|
|
|
let mut access_c = Access::<usize>::default();
|
|
access_c.add_write(0);
|
|
access_c.add_write(1);
|
|
|
|
assert_eq!(access_a.get_conflicts(&access_c), vec![0, 1]);
|
|
assert_eq!(access_b.get_conflicts(&access_c), vec![0, 1]);
|
|
|
|
let mut access_d = Access::<usize>::default();
|
|
access_d.add_read(0);
|
|
|
|
assert_eq!(access_d.get_conflicts(&access_a), vec![]);
|
|
assert_eq!(access_d.get_conflicts(&access_b), vec![]);
|
|
assert_eq!(access_d.get_conflicts(&access_c), vec![0]);
|
|
}
|
|
|
|
#[test]
|
|
fn filtered_access_extend() {
|
|
let mut access_a = FilteredAccess::<usize>::default();
|
|
access_a.add_read(0);
|
|
access_a.add_read(1);
|
|
access_a.add_with(2);
|
|
|
|
let mut access_b = FilteredAccess::<usize>::default();
|
|
access_b.add_read(0);
|
|
access_b.add_write(3);
|
|
access_b.add_without(4);
|
|
|
|
access_a.extend(&access_b);
|
|
|
|
let mut expected = FilteredAccess::<usize>::default();
|
|
expected.add_read(0);
|
|
expected.add_read(1);
|
|
expected.add_with(2);
|
|
expected.add_write(3);
|
|
expected.add_without(4);
|
|
|
|
assert!(access_a.eq(&expected));
|
|
}
|
|
}
|