mirror of
https://github.com/bevyengine/bevy
synced 2025-02-16 14:08:32 +00:00
d7ea5b6aa9
# Objective - Intended to resolve https://github.com/bevyengine/bevy/issues/15290. - Fix four duplicate `DragEnd` firing when drag finished. - Fix redundant `DragStart` firing when dragging across pick-able entities. - Fix `Click` coming after `Drop` and obliterating finished drag interactions. Big thanks to B. Reinhart for testing picking in their codebase and identifying these issues early. ## Solution - Fix press & drag state being cleared after the first entity is read from the hover map on pointer release, rather than after all entities are read. This caused only the first hovered entity to receive `Up` and `Click` events. - Fixes `Down` being determined using the `previous_hover_map` rather than `hover_map`, a regression compared to `bevy_mod_picking`. I think this is what was messing up drag events. - Fixes and issue where `PointerEnd` would fire multiple times and `PointerStart` would fire when dragging onto a new entity. - Re-orders events to make them easier to handle. `Out` now fired before `DragLeave` and `Click/Up` now fire before `DragDrop`. - Generally refactors the picking event code to be more clean and sane. ## Testing These changes are currently sporadically tested. |
||
|---|---|---|
| .. | ||
| bevy_a11y | ||
| bevy_animation | ||
| bevy_app | ||
| bevy_asset | ||
| bevy_audio | ||
| bevy_color | ||
| bevy_core | ||
| bevy_core_pipeline | ||
| bevy_derive | ||
| bevy_dev_tools | ||
| bevy_diagnostic | ||
| bevy_dylib | ||
| bevy_ecs | ||
| bevy_encase_derive | ||
| bevy_gilrs | ||
| bevy_gizmos | ||
| bevy_gltf | ||
| bevy_hierarchy | ||
| bevy_input | ||
| bevy_internal | ||
| bevy_log | ||
| bevy_macro_utils | ||
| bevy_math | ||
| bevy_mikktspace | ||
| bevy_pbr | ||
| bevy_picking | ||
| bevy_ptr | ||
| bevy_reflect | ||
| bevy_render | ||
| bevy_scene | ||
| bevy_sprite | ||
| bevy_state | ||
| bevy_tasks | ||
| bevy_text | ||
| bevy_time | ||
| bevy_transform | ||
| bevy_ui | ||
| bevy_utils | ||
| bevy_window | ||
| bevy_winit | ||