mirror of
https://github.com/bevyengine/bevy
synced 2025-01-06 10:18:59 +00:00
027f8e21ec
Changes: - Track whether an output texture has been written to yet and only clear it on the first write. - Use `ClearColorConfig` on `CameraOutputMode` instead of a raw `LoadOp`. - Track whether a output texture has been seen when specializing the upscaling pipeline and use alpha blending for extra cameras rendering to that texture that do not specify an explicit blend mode. Fixes #6754 ## Testing Tested against provided test case in issue: ![image](https://github.com/bevyengine/bevy/assets/10366310/d066f069-87fb-4249-a4d9-b6cb1751971b) --- ## Changelog - Allow cameras rendering to the same output texture with mixed hdr to work correctly. ## Migration Guide - - Change `CameraOutputMode` to use `ClearColorConfig` instead of `LoadOp`.
160 lines
5.7 KiB
Rust
160 lines
5.7 KiB
Rust
use super::CachedTexture;
|
|
use crate::render_resource::{TextureFormat, TextureView};
|
|
use bevy_color::LinearRgba;
|
|
use std::sync::{
|
|
atomic::{AtomicBool, Ordering},
|
|
Arc,
|
|
};
|
|
use wgpu::{
|
|
LoadOp, Operations, RenderPassColorAttachment, RenderPassDepthStencilAttachment, StoreOp,
|
|
};
|
|
|
|
/// A wrapper for a [`CachedTexture`] that is used as a [`RenderPassColorAttachment`].
|
|
#[derive(Clone)]
|
|
pub struct ColorAttachment {
|
|
pub texture: CachedTexture,
|
|
pub resolve_target: Option<CachedTexture>,
|
|
clear_color: Option<LinearRgba>,
|
|
is_first_call: Arc<AtomicBool>,
|
|
}
|
|
|
|
impl ColorAttachment {
|
|
pub fn new(
|
|
texture: CachedTexture,
|
|
resolve_target: Option<CachedTexture>,
|
|
clear_color: Option<LinearRgba>,
|
|
) -> Self {
|
|
Self {
|
|
texture,
|
|
resolve_target,
|
|
clear_color,
|
|
is_first_call: Arc::new(AtomicBool::new(true)),
|
|
}
|
|
}
|
|
|
|
/// Get this texture view as an attachment. The attachment will be cleared with a value of
|
|
/// `clear_color` if this is the first time calling this function, otherwise it will be loaded.
|
|
///
|
|
/// The returned attachment will always have writing enabled (`store: StoreOp::Load`).
|
|
pub fn get_attachment(&self) -> RenderPassColorAttachment {
|
|
if let Some(resolve_target) = self.resolve_target.as_ref() {
|
|
let first_call = self.is_first_call.fetch_and(false, Ordering::SeqCst);
|
|
|
|
RenderPassColorAttachment {
|
|
view: &resolve_target.default_view,
|
|
resolve_target: Some(&self.texture.default_view),
|
|
ops: Operations {
|
|
load: match (self.clear_color, first_call) {
|
|
(Some(clear_color), true) => LoadOp::Clear(clear_color.into()),
|
|
(None, _) | (Some(_), false) => LoadOp::Load,
|
|
},
|
|
store: StoreOp::Store,
|
|
},
|
|
}
|
|
} else {
|
|
self.get_unsampled_attachment()
|
|
}
|
|
}
|
|
|
|
/// Get this texture view as an attachment, without the resolve target. The attachment will be cleared with
|
|
/// a value of `clear_color` if this is the first time calling this function, otherwise it will be loaded.
|
|
///
|
|
/// The returned attachment will always have writing enabled (`store: StoreOp::Load`).
|
|
pub fn get_unsampled_attachment(&self) -> RenderPassColorAttachment {
|
|
let first_call = self.is_first_call.fetch_and(false, Ordering::SeqCst);
|
|
|
|
RenderPassColorAttachment {
|
|
view: &self.texture.default_view,
|
|
resolve_target: None,
|
|
ops: Operations {
|
|
load: match (self.clear_color, first_call) {
|
|
(Some(clear_color), true) => LoadOp::Clear(clear_color.into()),
|
|
(None, _) | (Some(_), false) => LoadOp::Load,
|
|
},
|
|
store: StoreOp::Store,
|
|
},
|
|
}
|
|
}
|
|
|
|
pub(crate) fn mark_as_cleared(&self) {
|
|
self.is_first_call.store(false, Ordering::SeqCst);
|
|
}
|
|
}
|
|
|
|
/// A wrapper for a [`TextureView`] that is used as a depth-only [`RenderPassDepthStencilAttachment`].
|
|
pub struct DepthAttachment {
|
|
pub view: TextureView,
|
|
clear_value: Option<f32>,
|
|
is_first_call: Arc<AtomicBool>,
|
|
}
|
|
|
|
impl DepthAttachment {
|
|
pub fn new(view: TextureView, clear_value: Option<f32>) -> Self {
|
|
Self {
|
|
view,
|
|
clear_value,
|
|
is_first_call: Arc::new(AtomicBool::new(clear_value.is_some())),
|
|
}
|
|
}
|
|
|
|
/// Get this texture view as an attachment. The attachment will be cleared with a value of
|
|
/// `clear_value` if this is the first time calling this function with `store` == [`StoreOp::Store`],
|
|
/// and a clear value was provided, otherwise it will be loaded.
|
|
pub fn get_attachment(&self, store: StoreOp) -> RenderPassDepthStencilAttachment {
|
|
let first_call = self
|
|
.is_first_call
|
|
.fetch_and(store != StoreOp::Store, Ordering::SeqCst);
|
|
|
|
RenderPassDepthStencilAttachment {
|
|
view: &self.view,
|
|
depth_ops: Some(Operations {
|
|
load: if first_call {
|
|
// If first_call is true, then a clear value will always have been provided in the constructor
|
|
LoadOp::Clear(self.clear_value.unwrap())
|
|
} else {
|
|
LoadOp::Load
|
|
},
|
|
store,
|
|
}),
|
|
stencil_ops: None,
|
|
}
|
|
}
|
|
}
|
|
|
|
/// A wrapper for a [`TextureView`] that is used as a [`RenderPassColorAttachment`] for a view
|
|
/// target's final output texture.
|
|
#[derive(Clone)]
|
|
pub struct OutputColorAttachment {
|
|
pub view: TextureView,
|
|
pub format: TextureFormat,
|
|
is_first_call: Arc<AtomicBool>,
|
|
}
|
|
|
|
impl OutputColorAttachment {
|
|
pub fn new(view: TextureView, format: TextureFormat) -> Self {
|
|
Self {
|
|
view,
|
|
format,
|
|
is_first_call: Arc::new(AtomicBool::new(true)),
|
|
}
|
|
}
|
|
|
|
/// Get this texture view as an attachment. The attachment will be cleared with a value of
|
|
/// the provided `clear_color` if this is the first time calling this function, otherwise it
|
|
/// will be loaded.
|
|
pub fn get_attachment(&self, clear_color: Option<LinearRgba>) -> RenderPassColorAttachment {
|
|
let first_call = self.is_first_call.fetch_and(false, Ordering::SeqCst);
|
|
|
|
RenderPassColorAttachment {
|
|
view: &self.view,
|
|
resolve_target: None,
|
|
ops: Operations {
|
|
load: match (clear_color, first_call) {
|
|
(Some(clear_color), true) => LoadOp::Clear(clear_color.into()),
|
|
(None, _) | (Some(_), false) => LoadOp::Load,
|
|
},
|
|
store: StoreOp::Store,
|
|
},
|
|
}
|
|
}
|
|
}
|