mirror of
https://github.com/bevyengine/bevy
synced 2025-01-02 16:28:59 +00:00
d70595b667
# Objective - Fixes #6370 - Closes #6581 ## Solution - Added the following lints to the workspace: - `std_instead_of_core` - `std_instead_of_alloc` - `alloc_instead_of_core` - Used `cargo +nightly fmt` with [item level use formatting](https://rust-lang.github.io/rustfmt/?version=v1.6.0&search=#Item%5C%3A) to split all `use` statements into single items. - Used `cargo clippy --workspace --all-targets --all-features --fix --allow-dirty` to _attempt_ to resolve the new linting issues, and intervened where the lint was unable to resolve the issue automatically (usually due to needing an `extern crate alloc;` statement in a crate root). - Manually removed certain uses of `std` where negative feature gating prevented `--all-features` from finding the offending uses. - Used `cargo +nightly fmt` with [crate level use formatting](https://rust-lang.github.io/rustfmt/?version=v1.6.0&search=#Crate%5C%3A) to re-merge all `use` statements matching Bevy's previous styling. - Manually fixed cases where the `fmt` tool could not re-merge `use` statements due to conditional compilation attributes. ## Testing - Ran CI locally ## Migration Guide The MSRV is now 1.81. Please update to this version or higher. ## Notes - This is a _massive_ change to try and push through, which is why I've outlined the semi-automatic steps I used to create this PR, in case this fails and someone else tries again in the future. - Making this change has no impact on user code, but does mean Bevy contributors will be warned to use `core` and `alloc` instead of `std` where possible. - This lint is a critical first step towards investigating `no_std` options for Bevy. --------- Co-authored-by: François Mockers <francois.mockers@vleue.com>
109 lines
3.3 KiB
Rust
109 lines
3.3 KiB
Rust
use core::marker::PhantomData;
|
|
|
|
use bevy_app::{App, SubApp};
|
|
use bevy_ecs::{
|
|
event::{Event, EventReader, Events},
|
|
system::{Commands, Resource},
|
|
world::World,
|
|
};
|
|
use bevy_utils::HashMap;
|
|
|
|
use crate::state::{FreelyMutableState, OnExit, StateTransitionEvent};
|
|
|
|
fn clear_event_queue<E: Event>(w: &mut World) {
|
|
if let Some(mut queue) = w.get_resource_mut::<Events<E>>() {
|
|
queue.clear();
|
|
}
|
|
}
|
|
|
|
#[derive(Resource)]
|
|
struct StateScopedEvents<S: FreelyMutableState> {
|
|
cleanup_fns: HashMap<S, Vec<fn(&mut World)>>,
|
|
}
|
|
|
|
impl<S: FreelyMutableState> StateScopedEvents<S> {
|
|
fn add_event<E: Event>(&mut self, state: S) {
|
|
self.cleanup_fns
|
|
.entry(state)
|
|
.or_default()
|
|
.push(clear_event_queue::<E>);
|
|
}
|
|
|
|
fn cleanup(&self, w: &mut World, state: S) {
|
|
let Some(fns) = self.cleanup_fns.get(&state) else {
|
|
return;
|
|
};
|
|
for callback in fns {
|
|
(*callback)(w);
|
|
}
|
|
}
|
|
}
|
|
|
|
impl<S: FreelyMutableState> Default for StateScopedEvents<S> {
|
|
fn default() -> Self {
|
|
Self {
|
|
cleanup_fns: HashMap::default(),
|
|
}
|
|
}
|
|
}
|
|
|
|
fn cleanup_state_scoped_event<S: FreelyMutableState>(
|
|
mut c: Commands,
|
|
mut transitions: EventReader<StateTransitionEvent<S>>,
|
|
) {
|
|
let Some(transition) = transitions.read().last() else {
|
|
return;
|
|
};
|
|
if transition.entered == transition.exited {
|
|
return;
|
|
}
|
|
let Some(exited) = transition.exited.clone() else {
|
|
return;
|
|
};
|
|
|
|
c.queue(move |w: &mut World| {
|
|
w.resource_scope::<StateScopedEvents<S>, ()>(|w, events| {
|
|
events.cleanup(w, exited);
|
|
});
|
|
});
|
|
}
|
|
|
|
fn add_state_scoped_event_impl<E: Event, S: FreelyMutableState>(
|
|
app: &mut SubApp,
|
|
_p: PhantomData<E>,
|
|
state: S,
|
|
) {
|
|
if !app.world().contains_resource::<StateScopedEvents<S>>() {
|
|
app.init_resource::<StateScopedEvents<S>>();
|
|
}
|
|
app.add_event::<E>();
|
|
app.world_mut()
|
|
.resource_mut::<StateScopedEvents<S>>()
|
|
.add_event::<E>(state.clone());
|
|
app.add_systems(OnExit(state), cleanup_state_scoped_event::<S>);
|
|
}
|
|
|
|
/// Extension trait for [`App`] adding methods for registering state scoped events.
|
|
pub trait StateScopedEventsAppExt {
|
|
/// Adds an [`Event`] that is automatically cleaned up when leaving the specified `state`.
|
|
///
|
|
/// Note that event cleanup is ordered ambiguously relative to [`StateScoped`](crate::prelude::StateScoped) entity
|
|
/// cleanup and the [`OnExit`] schedule for the target state. All of these (state scoped
|
|
/// entities and events cleanup, and `OnExit`) occur within schedule [`StateTransition`](crate::prelude::StateTransition)
|
|
/// and system set `StateTransitionSteps::ExitSchedules`.
|
|
fn add_state_scoped_event<E: Event>(&mut self, state: impl FreelyMutableState) -> &mut Self;
|
|
}
|
|
|
|
impl StateScopedEventsAppExt for App {
|
|
fn add_state_scoped_event<E: Event>(&mut self, state: impl FreelyMutableState) -> &mut Self {
|
|
add_state_scoped_event_impl(self.main_mut(), PhantomData::<E>, state);
|
|
self
|
|
}
|
|
}
|
|
|
|
impl StateScopedEventsAppExt for SubApp {
|
|
fn add_state_scoped_event<E: Event>(&mut self, state: impl FreelyMutableState) -> &mut Self {
|
|
add_state_scoped_event_impl(self, PhantomData::<E>, state);
|
|
self
|
|
}
|
|
}
|