mirror of
https://github.com/bevyengine/bevy
synced 2024-11-26 22:50:19 +00:00
218b0fd3b6
builds on top of #4780 # Objective `Reflect` and `Serialize` are currently very tied together because `Reflect` has a `fn serialize(&self) -> Option<Serializable<'_>>` method. Because of that, we can either implement `Reflect` for types like `Option<T>` with `T: Serialize` and have `fn serialize` be implemented, or without the bound but having `fn serialize` return `None`. By separating `ReflectSerialize` into a separate type (like how it already is for `ReflectDeserialize`, `ReflectDefault`), we could separately `.register::<Option<T>>()` and `.register_data::<Option<T>, ReflectSerialize>()` only if the type `T: Serialize`. This PR does not change the registration but allows it to be changed in a future PR. ## Solution - add the type ```rust struct ReflectSerialize { .. } impl<T: Reflect + Serialize> FromType<T> for ReflectSerialize { .. } ``` - remove `#[reflect(Serialize)]` special casing. - when serializing reflect value types, look for `ReflectSerialize` in the `TypeRegistry` instead of calling `value.serialize()` |
||
|---|---|---|
| .. | ||
| container_attributes.rs | ||
| derive_data.rs | ||
| field_attributes.rs | ||
| from_reflect.rs | ||
| impls.rs | ||
| lib.rs | ||
| reflect_value.rs | ||
| registration.rs | ||
| trait_reflection.rs | ||
| type_uuid.rs | ||
| utility.rs | ||