Jakob Hellermann d38a8dfdd7 add more SAFETY comments and lint for missing ones in bevy_ecs (#4835) ... # Objective `SAFETY` comments are meant to be placed before `unsafe` blocks and should contain the reasoning of why in this case the usage of unsafe is okay. This is useful when reading the code because it makes it clear which assumptions are required for safety, and makes it easier to spot possible unsoundness holes. It also forces the code writer to think of something to write and maybe look at the safety contracts of any called unsafe methods again to double-check their correct usage. There's a clippy lint called `undocumented_unsafe_blocks` which warns when using a block without such a comment. ## Solution - since clippy expects `SAFETY` instead of `SAFE`, rename those - add `SAFETY` comments in more places - for the last remaining 3 places, add an `#[allow()]` and `// TODO` since I wasn't comfortable enough with the code to justify their safety - add ` #![warn(clippy::undocumented_unsafe_blocks)]` to `bevy_ecs` ### Note for reviewers The first commit only renames `SAFETY` to `SAFE` so it doesn't need a thorough review. cb042a416e..55cef2d6fa is the diff for all other changes. ### Safety comments where I'm not too familiar with the code 774012ece5/crates/bevy_ecs/src/entity/mod.rs (L540-L546) 774012ece5/crates/bevy_ecs/src/world/entity_ref.rs (L249-L252) ### Locations left undocumented with a `TODO` comment 5dde944a30/crates/bevy_ecs/src/schedule/executor_parallel.rs (L196-L199) 5dde944a30/crates/bevy_ecs/src/world/entity_ref.rs (L287-L289) 5dde944a30/crates/bevy_ecs/src/world/entity_ref.rs (L413-L415) Co-authored-by: Jakob Hellermann <hellermann@sipgate.de>		2022-07-04 14:44:24 +00:00
..
src	add more SAFETY comments and lint for missing ones in bevy_ecs (#4835)	2022-07-04 14:44:24 +00:00
Cargo.toml	Allow closing windows at runtime (#3575)	2022-05-05 13:35:43 +00:00