mirror of
https://github.com/bevyengine/bevy
synced 2024-12-22 11:03:06 +00:00
01aedc8431
# Objective Now that we can consolidate Bundles and Components under a single insert (thanks to #2975 and #6039), almost 100% of world spawns now look like `world.spawn().insert((Some, Tuple, Here))`. Spawning an entity without any components is an extremely uncommon pattern, so it makes sense to give spawn the "first class" ergonomic api. This consolidated api should be made consistent across all spawn apis (such as World and Commands). ## Solution All `spawn` apis (`World::spawn`, `Commands:;spawn`, `ChildBuilder::spawn`, and `WorldChildBuilder::spawn`) now accept a bundle as input: ```rust // before: commands .spawn() .insert((A, B, C)); world .spawn() .insert((A, B, C); // after commands.spawn((A, B, C)); world.spawn((A, B, C)); ``` All existing instances of `spawn_bundle` have been deprecated in favor of the new `spawn` api. A new `spawn_empty` has been added, replacing the old `spawn` api. By allowing `world.spawn(some_bundle)` to replace `world.spawn().insert(some_bundle)`, this opened the door to removing the initial entity allocation in the "empty" archetype / table done in `spawn()` (and subsequent move to the actual archetype in `.insert(some_bundle)`). This improves spawn performance by over 10%: ![image](https://user-images.githubusercontent.com/2694663/191627587-4ab2f949-4ccd-4231-80eb-80dd4d9ad6b9.png) To take this measurement, I added a new `world_spawn` benchmark. Unfortunately, optimizing `Commands::spawn` is slightly less trivial, as Commands expose the Entity id of spawned entities prior to actually spawning. Doing the optimization would (naively) require assurances that the `spawn(some_bundle)` command is applied before all other commands involving the entity (which would not necessarily be true, if memory serves). Optimizing `Commands::spawn` this way does feel possible, but it will require careful thought (and maybe some additional checks), which deserves its own PR. For now, it has the same performance characteristics of the current `Commands::spawn_bundle` on main. **Note that 99% of this PR is simple renames and refactors. The only code that needs careful scrutiny is the new `World::spawn()` impl, which is relatively straightforward, but it has some new unsafe code (which re-uses battle tested BundlerSpawner code path).** --- ## Changelog - All `spawn` apis (`World::spawn`, `Commands:;spawn`, `ChildBuilder::spawn`, and `WorldChildBuilder::spawn`) now accept a bundle as input - All instances of `spawn_bundle` have been deprecated in favor of the new `spawn` api - World and Commands now have `spawn_empty()`, which is equivalent to the old `spawn()` behavior. ## Migration Guide ```rust // Old (0.8): commands .spawn() .insert_bundle((A, B, C)); // New (0.9) commands.spawn((A, B, C)); // Old (0.8): commands.spawn_bundle((A, B, C)); // New (0.9) commands.spawn((A, B, C)); // Old (0.8): let entity = commands.spawn().id(); // New (0.9) let entity = commands.spawn_empty().id(); // Old (0.8) let entity = world.spawn().id(); // New (0.9) let entity = world.spawn_empty(); ```
118 lines
4.5 KiB
Rust
118 lines
4.5 KiB
Rust
use bevy_ecs::prelude::*;
|
|
use rand::Rng;
|
|
use std::ops::Deref;
|
|
|
|
// In this example we will simulate a population of entities. In every tick we will:
|
|
// 1. spawn a new entity with a certain possibility
|
|
// 2. age all entities
|
|
// 3. despawn entities with age > 2
|
|
//
|
|
// To demonstrate change detection, there are some console outputs based on changes in
|
|
// the EntityCounter resource and updated Age components
|
|
fn main() {
|
|
// Create a new empty World to hold our Entities, Components and Resources
|
|
let mut world = World::new();
|
|
|
|
// Add the counter resource to remember how many entities where spawned
|
|
world.insert_resource(EntityCounter { value: 0 });
|
|
|
|
// Create a new Schedule, which defines an execution strategy for Systems
|
|
let mut schedule = Schedule::default();
|
|
// Create a Stage to add to our Schedule. Each Stage in a schedule runs all of its systems
|
|
// before moving on to the next Stage
|
|
let mut update = SystemStage::parallel();
|
|
|
|
// Add systems to the Stage to execute our app logic
|
|
// We can label our systems to force a specific run-order between some of them
|
|
update.add_system(spawn_entities.label(SimulationSystem::Spawn));
|
|
update.add_system(print_counter_when_changed.after(SimulationSystem::Spawn));
|
|
update.add_system(age_all_entities.label(SimulationSystem::Age));
|
|
update.add_system(remove_old_entities.after(SimulationSystem::Age));
|
|
update.add_system(print_changed_entities.after(SimulationSystem::Age));
|
|
// Add the Stage with our systems to the Schedule
|
|
#[derive(StageLabel)]
|
|
struct Update;
|
|
schedule.add_stage(Update, update);
|
|
|
|
// Simulate 10 frames in our world
|
|
for iteration in 1..=10 {
|
|
println!("Simulating frame {}/10", iteration);
|
|
schedule.run(&mut world);
|
|
}
|
|
}
|
|
|
|
// This struct will be used as a Resource keeping track of the total amount of spawned entities
|
|
#[derive(Debug, Resource)]
|
|
struct EntityCounter {
|
|
pub value: i32,
|
|
}
|
|
|
|
// This struct represents a Component and holds the age in frames of the entity it gets assigned to
|
|
#[derive(Component, Default, Debug)]
|
|
struct Age {
|
|
frames: i32,
|
|
}
|
|
|
|
// System labels to enforce a run order of our systems
|
|
#[derive(SystemLabel, Debug, Clone, PartialEq, Eq, Hash)]
|
|
enum SimulationSystem {
|
|
Spawn,
|
|
Age,
|
|
}
|
|
|
|
// This system randomly spawns a new entity in 60% of all frames
|
|
// The entity will start with an age of 0 frames
|
|
// If an entity gets spawned, we increase the counter in the EntityCounter resource
|
|
fn spawn_entities(mut commands: Commands, mut entity_counter: ResMut<EntityCounter>) {
|
|
if rand::thread_rng().gen_bool(0.6) {
|
|
let entity_id = commands.spawn(Age::default()).id();
|
|
println!(" spawning {:?}", entity_id);
|
|
entity_counter.value += 1;
|
|
}
|
|
}
|
|
|
|
// This system prints out changes in our entity collection
|
|
// For every entity that just got the Age component added we will print that it's the
|
|
// entities first birthday. These entities where spawned in the previous frame.
|
|
// For every entity with a changed Age component we will print the new value.
|
|
// In this example the Age component is changed in every frame, so we don't actually
|
|
// need the `Changed` here, but it is still used for the purpose of demonstration.
|
|
fn print_changed_entities(
|
|
entity_with_added_component: Query<Entity, Added<Age>>,
|
|
entity_with_mutated_component: Query<(Entity, &Age), Changed<Age>>,
|
|
) {
|
|
for entity in &entity_with_added_component {
|
|
println!(" {:?} has it's first birthday!", entity);
|
|
}
|
|
for (entity, value) in &entity_with_mutated_component {
|
|
println!(" {:?} is now {:?} frames old", entity, value);
|
|
}
|
|
}
|
|
|
|
// This system iterates over all entities and increases their age in every frame
|
|
fn age_all_entities(mut entities: Query<&mut Age>) {
|
|
for mut age in &mut entities {
|
|
age.frames += 1;
|
|
}
|
|
}
|
|
|
|
// This system iterates over all entities in every frame and despawns entities older than 2 frames
|
|
fn remove_old_entities(mut commands: Commands, entities: Query<(Entity, &Age)>) {
|
|
for (entity, age) in &entities {
|
|
if age.frames > 2 {
|
|
println!(" despawning {:?} due to age > 2", entity);
|
|
commands.entity(entity).despawn();
|
|
}
|
|
}
|
|
}
|
|
|
|
// This system will print the new counter value everytime it was changed since
|
|
// the last execution of the system.
|
|
fn print_counter_when_changed(entity_counter: Res<EntityCounter>) {
|
|
if entity_counter.is_changed() {
|
|
println!(
|
|
" total number of entities spawned: {}",
|
|
entity_counter.deref().value
|
|
);
|
|
}
|
|
}
|